Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
On Mon, 2005-07-11 at 22:38 +0400, Alexey Dobriyan wrote: > $ make allmodconfig >/dev/null > $ make C=2 CHECK="sparse -Wbitwise" drivers/infiniband/ 2>&1 | tee > ../W_infiniband > [snip] > $ grep -c "warning: " ../W_infiniband > 430 These seem to be mostly coming from cpu_to_be*() and be*_to_cpu(). Is there a good rule of thumb for fixing these warnings? Thanks, -tduffy signature.asc Description: This is a digitally signed message part
Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
On Mon, 2005-07-11 at 22:38 +0400, Alexey Dobriyan wrote: $ make allmodconfig /dev/null $ make C=2 CHECK=sparse -Wbitwise drivers/infiniband/ 21 | tee ../W_infiniband [snip] $ grep -c warning: ../W_infiniband 430 These seem to be mostly coming from cpu_to_be*() and be*_to_cpu(). Is there a good rule of thumb for fixing these warnings? Thanks, -tduffy signature.asc Description: This is a digitally signed message part
Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
On Monday 11 July 2005 21:52, Tom Duffy wrote: > Alexey Dobriyan wrote: > > >unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings > >is not a reason to add more. > > > > > Can you please elaborate on the sparse warnings that you are seeing > throughout the rest of infiniband? $ make allmodconfig >/dev/null $ make C=2 CHECK="sparse -Wbitwise" drivers/infiniband/ 2>&1 | tee ../W_infiniband [snip] $ grep -c "warning: " ../W_infiniband 430 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
Alexey Dobriyan wrote: unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings is not a reason to add more. Can you please elaborate on the sparse warnings that you are seeing throughout the rest of infiniband? Thanks, -tduffy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
On Mon, 2005-07-11 at 12:05, Nishanth Aravamudan wrote: > On 11.07.2005 [11:30:23 -0400], Hal Rosenstock wrote: > > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > > > -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c > > > > +++ linux-2.6.13-rc2-mm1/drivers/infiniband3/core/mad.c > > > ^^^ > > > Ick. You'd better have linux-2.6.13-rc2-mm1-[0123...]. > > > > Shall I resubmit with linux-2.6.13-rc2-mm1-[0123...] ? > > Do these patches even apply with -p1 with these odd directories? I think > it will try to find the addition context in a file which doesn't exist > (because the directory, e.g. infiniband3, does not). I notice that every > patch increments these values. I think you only want to differentiate > between the kernels, not between particular directories in the kernel. I will resubmit. Sorry. -- Hal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
On 11.07.2005 [11:30:23 -0400], Hal Rosenstock wrote: > On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: > > On Monday 11 July 2005 17:48, Hal Rosenstock wrote: > > > Add new helper routines for allocating MADs for sending and formatting > > > a send WR. > > > > > -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c > > > +++ linux-2.6.13-rc2-mm1/drivers/infiniband3/core/mad.c > >^^^ > > Ick. You'd better have linux-2.6.13-rc2-mm1-[0123...]. > > Shall I resubmit with linux-2.6.13-rc2-mm1-[0123...] ? Do these patches even apply with -p1 with these odd directories? I think it will try to find the addition context in a file which doesn't exist (because the directory, e.g. infiniband3, does not). I notice that every patch increments these values. I think you only want to differentiate between the kernels, not between particular directories in the kernel. Thanks, Nish - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
On 11.07.2005 [11:30:23 -0400], Hal Rosenstock wrote: On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: On Monday 11 July 2005 17:48, Hal Rosenstock wrote: Add new helper routines for allocating MADs for sending and formatting a send WR. -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c +++ linux-2.6.13-rc2-mm1/drivers/infiniband3/core/mad.c ^^^ Ick. You'd better have linux-2.6.13-rc2-mm1-[0123...]. Shall I resubmit with linux-2.6.13-rc2-mm1-[0123...] ? Do these patches even apply with -p1 with these odd directories? I think it will try to find the addition context in a file which doesn't exist (because the directory, e.g. infiniband3, does not). I notice that every patch increments these values. I think you only want to differentiate between the kernels, not between particular directories in the kernel. Thanks, Nish - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
On Mon, 2005-07-11 at 12:05, Nishanth Aravamudan wrote: On 11.07.2005 [11:30:23 -0400], Hal Rosenstock wrote: On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: On Monday 11 July 2005 17:48, Hal Rosenstock wrote: -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c +++ linux-2.6.13-rc2-mm1/drivers/infiniband3/core/mad.c ^^^ Ick. You'd better have linux-2.6.13-rc2-mm1-[0123...]. Shall I resubmit with linux-2.6.13-rc2-mm1-[0123...] ? Do these patches even apply with -p1 with these odd directories? I think it will try to find the addition context in a file which doesn't exist (because the directory, e.g. infiniband3, does not). I notice that every patch increments these values. I think you only want to differentiate between the kernels, not between particular directories in the kernel. I will resubmit. Sorry. -- Hal - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
Alexey Dobriyan wrote: unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings is not a reason to add more. Can you please elaborate on the sparse warnings that you are seeing throughout the rest of infiniband? Thanks, -tduffy - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions
On Monday 11 July 2005 21:52, Tom Duffy wrote: Alexey Dobriyan wrote: unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings is not a reason to add more. Can you please elaborate on the sparse warnings that you are seeing throughout the rest of infiniband? $ make allmodconfig /dev/null $ make C=2 CHECK=sparse -Wbitwise drivers/infiniband/ 21 | tee ../W_infiniband [snip] $ grep -c warning: ../W_infiniband 430 - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
