Re: [patch] bnx2x: NULL dereference on error in debug code
From: Dan Carpenter Date: Tue, 8 Jan 2013 16:42:14 +0300 > "vfop" is NULL here. I've changed the debugging to not use it. > > Signed-off-by: Dan Carpenter Applied, thanks Dan. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] bnx2x: NULL dereference on error in debug code
From: Dan Carpenter dan.carpen...@oracle.com Date: Tue, 8 Jan 2013 16:42:14 +0300 vfop is NULL here. I've changed the debugging to not use it. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Applied, thanks Dan. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [patch] bnx2x: NULL dereference on error in debug code
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Tuesday, January 08, 2013 3:42 PM > To: Eilon Greenstein > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- > janit...@vger.kernel.org > Subject: [patch] bnx2x: NULL dereference on error in debug code > > "vfop" is NULL here. I've changed the debugging to not use it. > > Signed-off-by: Dan Carpenter > --- > Only needed in linux-next. > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > index 71fcef0..3eef972 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, > return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, >cmd->block); > } > - DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n", > -vf->abs_vfid, vfop->rc); > + DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid); > return -ENOMEM; > } > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Ariel Elior -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] bnx2x: NULL dereference on error in debug code
From: "Ariel Elior" Date: Tue, 8 Jan 2013 14:50:50 + >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev- >> ow...@vger.kernel.org] On Behalf Of Dan Carpenter >> Sent: Tuesday, January 08, 2013 3:42 PM >> To: Eilon Greenstein >> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- >> janit...@vger.kernel.org >> Subject: [patch] bnx2x: NULL dereference on error in debug code >> >> "vfop" is NULL here. I've changed the debugging to not use it. >> >> Signed-off-by: Dan Carpenter >> --- >> Only needed in linux-next. >> >> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c >> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c >> index 71fcef0..3eef972 100644 >> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c >> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c >> @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, >> return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, >> cmd->block); >> } >> -DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n", >> - vf->abs_vfid, vfop->rc); >> +DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid); >> return -ENOMEM; >> } >> > Right you are. Ack. This is not the correct way to ack a patch, this is: Acked-by: Ariel Elior -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [patch] bnx2x: NULL dereference on error in debug code
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Tuesday, January 08, 2013 3:42 PM > To: Eilon Greenstein > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- > janit...@vger.kernel.org > Subject: [patch] bnx2x: NULL dereference on error in debug code > > "vfop" is NULL here. I've changed the debugging to not use it. > > Signed-off-by: Dan Carpenter > --- > Only needed in linux-next. > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > index 71fcef0..3eef972 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, > return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, >cmd->block); > } > - DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n", > -vf->abs_vfid, vfop->rc); > + DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid); > return -ENOMEM; > } > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html And now acking it properly. Acked-by Ariel Elior -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [patch] bnx2x: NULL dereference on error in debug code
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Tuesday, January 08, 2013 3:42 PM > To: Eilon Greenstein > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- > janit...@vger.kernel.org > Subject: [patch] bnx2x: NULL dereference on error in debug code > > "vfop" is NULL here. I've changed the debugging to not use it. > > Signed-off-by: Dan Carpenter > --- > Only needed in linux-next. > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > index 71fcef0..3eef972 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c > @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, > return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, >cmd->block); > } > - DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n", > -vf->abs_vfid, vfop->rc); > + DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid); > return -ENOMEM; > } > Right you are. Ack. Thanks Dan, Ariel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] bnx2x: NULL dereference on error in debug code
"vfop" is NULL here. I've changed the debugging to not use it. Signed-off-by: Dan Carpenter --- Only needed in linux-next. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 71fcef0..3eef972 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, cmd->block); } - DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n", - vf->abs_vfid, vfop->rc); + DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid); return -ENOMEM; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] bnx2x: NULL dereference on error in debug code
vfop is NULL here. I've changed the debugging to not use it. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Only needed in linux-next. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 71fcef0..3eef972 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, cmd-block); } - DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop. rc %d\n, - vf-abs_vfid, vfop-rc); + DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop.\n, vf-abs_vfid); return -ENOMEM; } -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [patch] bnx2x: NULL dereference on error in debug code
-Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev- ow...@vger.kernel.org] On Behalf Of Dan Carpenter Sent: Tuesday, January 08, 2013 3:42 PM To: Eilon Greenstein Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- janit...@vger.kernel.org Subject: [patch] bnx2x: NULL dereference on error in debug code vfop is NULL here. I've changed the debugging to not use it. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Only needed in linux-next. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 71fcef0..3eef972 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, cmd-block); } - DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop. rc %d\n, -vf-abs_vfid, vfop-rc); + DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop.\n, vf-abs_vfid); return -ENOMEM; } Right you are. Ack. Thanks Dan, Ariel -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [patch] bnx2x: NULL dereference on error in debug code
-Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev- ow...@vger.kernel.org] On Behalf Of Dan Carpenter Sent: Tuesday, January 08, 2013 3:42 PM To: Eilon Greenstein Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- janit...@vger.kernel.org Subject: [patch] bnx2x: NULL dereference on error in debug code vfop is NULL here. I've changed the debugging to not use it. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Only needed in linux-next. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 71fcef0..3eef972 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, cmd-block); } - DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop. rc %d\n, -vf-abs_vfid, vfop-rc); + DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop.\n, vf-abs_vfid); return -ENOMEM; } -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html And now acking it properly. Acked-by Ariel Elior ari...@broadcom.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] bnx2x: NULL dereference on error in debug code
From: Ariel Elior ari...@broadcom.com Date: Tue, 8 Jan 2013 14:50:50 + -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev- ow...@vger.kernel.org] On Behalf Of Dan Carpenter Sent: Tuesday, January 08, 2013 3:42 PM To: Eilon Greenstein Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- janit...@vger.kernel.org Subject: [patch] bnx2x: NULL dereference on error in debug code vfop is NULL here. I've changed the debugging to not use it. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Only needed in linux-next. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 71fcef0..3eef972 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, cmd-block); } -DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop. rc %d\n, - vf-abs_vfid, vfop-rc); +DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop.\n, vf-abs_vfid); return -ENOMEM; } Right you are. Ack. This is not the correct way to ack a patch, this is: Acked-by: Ariel Elior ari...@broadcom.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [patch] bnx2x: NULL dereference on error in debug code
-Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev- ow...@vger.kernel.org] On Behalf Of Dan Carpenter Sent: Tuesday, January 08, 2013 3:42 PM To: Eilon Greenstein Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- janit...@vger.kernel.org Subject: [patch] bnx2x: NULL dereference on error in debug code vfop is NULL here. I've changed the debugging to not use it. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Only needed in linux-next. diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 71fcef0..3eef972 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp, return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor, cmd-block); } - DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop. rc %d\n, -vf-abs_vfid, vfop-rc); + DP(BNX2X_MSG_IOV, VF[%d] failed to add a vfop.\n, vf-abs_vfid); return -ENOMEM; } -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Ariel Elior ari...@broadcom.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
