Re: [patch] mm: memcontrol: remove stale page_cgroup_lock comment
On Sat 01-11-14 23:14:20, Johannes Weiner wrote: > There is no cgroup-specific page lock anymore. > > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko > --- > mm/memcontrol.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 38f0647a2f12..d20928597a07 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2467,10 +2467,6 @@ static void commit_charge(struct page *page, struct > mem_cgroup *memcg, > int isolated; > > VM_BUG_ON_PAGE(pc->mem_cgroup, page); > - /* > - * we don't need page_cgroup_lock about tail pages, becase they are not > - * accessed by any other context at this point. > - */ > > /* >* In some cases, SwapCache and FUSE(splice_buf->radixtree), the page > -- > 2.1.3 > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] mm: memcontrol: remove stale page_cgroup_lock comment
On Sat 01-11-14 23:14:20, Johannes Weiner wrote: There is no cgroup-specific page lock anymore. Signed-off-by: Johannes Weiner han...@cmpxchg.org Acked-by: Michal Hocko mho...@suse.cz --- mm/memcontrol.c | 4 1 file changed, 4 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 38f0647a2f12..d20928597a07 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2467,10 +2467,6 @@ static void commit_charge(struct page *page, struct mem_cgroup *memcg, int isolated; VM_BUG_ON_PAGE(pc-mem_cgroup, page); - /* - * we don't need page_cgroup_lock about tail pages, becase they are not - * accessed by any other context at this point. - */ /* * In some cases, SwapCache and FUSE(splice_buf-radixtree), the page -- 2.1.3 -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] mm: memcontrol: remove stale page_cgroup_lock comment
There is no cgroup-specific page lock anymore. Signed-off-by: Johannes Weiner --- mm/memcontrol.c | 4 1 file changed, 4 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 38f0647a2f12..d20928597a07 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2467,10 +2467,6 @@ static void commit_charge(struct page *page, struct mem_cgroup *memcg, int isolated; VM_BUG_ON_PAGE(pc->mem_cgroup, page); - /* -* we don't need page_cgroup_lock about tail pages, becase they are not -* accessed by any other context at this point. -*/ /* * In some cases, SwapCache and FUSE(splice_buf->radixtree), the page -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] mm: memcontrol: remove stale page_cgroup_lock comment
There is no cgroup-specific page lock anymore. Signed-off-by: Johannes Weiner han...@cmpxchg.org --- mm/memcontrol.c | 4 1 file changed, 4 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 38f0647a2f12..d20928597a07 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2467,10 +2467,6 @@ static void commit_charge(struct page *page, struct mem_cgroup *memcg, int isolated; VM_BUG_ON_PAGE(pc-mem_cgroup, page); - /* -* we don't need page_cgroup_lock about tail pages, becase they are not -* accessed by any other context at this point. -*/ /* * In some cases, SwapCache and FUSE(splice_buf-radixtree), the page -- 2.1.3 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
