Fwd: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
for 2.6.22
-- Forwarded message --
From: Oliver Pinter <[EMAIL PROTECTED]>
Date: Thu, 7 Feb 2008 00:11:58 +0100
Subject: Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are
remaining in quicklist 0
To: Greg KH <[EMAIL PROTECTED]>
Cc: Christoph Lameter <[EMAIL PROTECTED]>, "Justin M. Forbes"
<[EMAIL PROTECTED]>, Greg KH <[EMAIL PROTECTED]>,
linux-kernel@vger.kernel.org, [EMAIL PROTECTED],
[EMAIL PROTECTED], Zwane Mwaikambo
<[EMAIL PROTECTED]>, Theodore Ts'o <[EMAIL PROTECTED]>, Randy Dunlap
<[EMAIL PROTECTED]>, Dave Jones <[EMAIL PROTECTED]>, Chuck Wolber
<[EMAIL PROTECTED]>, Chris Wedgwood <[EMAIL PROTECTED]>,
Michael Krufky <[EMAIL PROTECTED]>, Chuck Ebbert
<[EMAIL PROTECTED]>, Domenico Andreoli <[EMAIL PROTECTED]>,
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED]
Greg, the patch in queue-2.6.23 is good for it
but the git id.: 96990a4ae979df9e235d01097d6175759331e88c
---
>From [EMAIL PROTECTED] Tue Jan 15 10:52:21 2008
From: Christoph Lameter <[EMAIL PROTECTED]>
Date: Wed, 16 Jan 2008 00:21:19 +0530
Subject: quicklists: Only consider memory that can be used with GFP_KERNEL
To: [EMAIL PROTECTED]
Cc: Andrew Morton <[EMAIL PROTECTED]>, [EMAIL PROTECTED],
[EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
Content-Disposition: inline
From: Christoph Lameter <[EMAIL PROTECTED]>
patch 96990a4ae979df9e235d01097d6175759331e88c in mainline.
Quicklists calculates the size of the quicklists based on the number of
free pages. This must be the number of free pages that can be allocated
with GFP_KERNEL. node_page_state() includes the pages in ZONE_HIGHMEM and
ZONE_MOVABLE which may lead the quicklists to become too large causing OOM.
Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
Tested-by: Dhaval Giani <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
mm/quicklist.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
--- a/mm/quicklist.c
+++ b/mm/quicklist.c
@@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist, quickli
static unsigned long max_pages(unsigned long min_pages)
{
unsigned long node_free_pages, max;
+ struct zone *zones = NODE_DATA(numa_node_id())->node_zones;
+
+ node_free_pages =
+#ifdef CONFIG_ZONE_DMA
+ zone_page_state([ZONE_DMA], NR_FREE_PAGES) +
+#endif
+#ifdef CONFIG_ZONE_DMA32
+ zone_page_state([ZONE_DMA32], NR_FREE_PAGES) +
+#endif
+ zone_page_state([ZONE_NORMAL], NR_FREE_PAGES);
- node_free_pages = node_page_state(numa_node_id(),
- NR_FREE_PAGES);
max = node_free_pages / FRACTION_OF_NODE_MEM;
return max(max, min_pages);
}
On 2/6/08, Greg KH <[EMAIL PROTECTED]> wrote:
> On Fri, Feb 01, 2008 at 05:30:14PM -0800, Christoph Lameter wrote:
> > On Fri, 1 Feb 2008, Justin M. Forbes wrote:
> >
> > >
> > > On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote:
> > > > NO! Wrong fix. Was dropped from mainline.
> > >
> > > What is the right fix for the OOM issues with 2.6.22? Perhaps
> > > http://marc.info/?l=linux-mm=119973653803451=2 should be added to
> > > the queue in its place? The OOM issue in 2.6.22 is real, and should be
> > > addressed.
> >
> > Indeed that is the right fix.
>
> Can someone send it to me, in patch form so that I can apply it? Along
> with the git id of the same patch in mainline please, I can't seem to
> find it.
>
> thanks,
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Thanks,
Oliver
--
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Fwd: [patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
for 2.6.22
-- Forwarded message --
From: Oliver Pinter [EMAIL PROTECTED]
Date: Thu, 7 Feb 2008 00:11:58 +0100
Subject: Re: [patch 22/27] quicklist: Set tlb-need_flush if pages are
remaining in quicklist 0
To: Greg KH [EMAIL PROTECTED]
Cc: Christoph Lameter [EMAIL PROTECTED], Justin M. Forbes
[EMAIL PROTECTED], Greg KH [EMAIL PROTECTED],
linux-kernel@vger.kernel.org, [EMAIL PROTECTED],
[EMAIL PROTECTED], Zwane Mwaikambo
[EMAIL PROTECTED], Theodore Ts'o [EMAIL PROTECTED], Randy Dunlap
[EMAIL PROTECTED], Dave Jones [EMAIL PROTECTED], Chuck Wolber
[EMAIL PROTECTED], Chris Wedgwood [EMAIL PROTECTED],
Michael Krufky [EMAIL PROTECTED], Chuck Ebbert
[EMAIL PROTECTED], Domenico Andreoli [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED]
Greg, the patch in queue-2.6.23 is good for it
but the git id.: 96990a4ae979df9e235d01097d6175759331e88c
---
From [EMAIL PROTECTED] Tue Jan 15 10:52:21 2008
From: Christoph Lameter [EMAIL PROTECTED]
Date: Wed, 16 Jan 2008 00:21:19 +0530
Subject: quicklists: Only consider memory that can be used with GFP_KERNEL
To: [EMAIL PROTECTED]
Cc: Andrew Morton [EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED]
Message-ID: [EMAIL PROTECTED]
Content-Disposition: inline
From: Christoph Lameter [EMAIL PROTECTED]
patch 96990a4ae979df9e235d01097d6175759331e88c in mainline.
Quicklists calculates the size of the quicklists based on the number of
free pages. This must be the number of free pages that can be allocated
with GFP_KERNEL. node_page_state() includes the pages in ZONE_HIGHMEM and
ZONE_MOVABLE which may lead the quicklists to become too large causing OOM.
Signed-off-by: Christoph Lameter [EMAIL PROTECTED]
Tested-by: Dhaval Giani [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]
---
mm/quicklist.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
--- a/mm/quicklist.c
+++ b/mm/quicklist.c
@@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist, quickli
static unsigned long max_pages(unsigned long min_pages)
{
unsigned long node_free_pages, max;
+ struct zone *zones = NODE_DATA(numa_node_id())-node_zones;
+
+ node_free_pages =
+#ifdef CONFIG_ZONE_DMA
+ zone_page_state(zones[ZONE_DMA], NR_FREE_PAGES) +
+#endif
+#ifdef CONFIG_ZONE_DMA32
+ zone_page_state(zones[ZONE_DMA32], NR_FREE_PAGES) +
+#endif
+ zone_page_state(zones[ZONE_NORMAL], NR_FREE_PAGES);
- node_free_pages = node_page_state(numa_node_id(),
- NR_FREE_PAGES);
max = node_free_pages / FRACTION_OF_NODE_MEM;
return max(max, min_pages);
}
On 2/6/08, Greg KH [EMAIL PROTECTED] wrote:
On Fri, Feb 01, 2008 at 05:30:14PM -0800, Christoph Lameter wrote:
On Fri, 1 Feb 2008, Justin M. Forbes wrote:
On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote:
NO! Wrong fix. Was dropped from mainline.
What is the right fix for the OOM issues with 2.6.22? Perhaps
http://marc.info/?l=linux-mmm=119973653803451w=2 should be added to
the queue in its place? The OOM issue in 2.6.22 is real, and should be
addressed.
Indeed that is the right fix.
Can someone send it to me, in patch form so that I can apply it? Along
with the git id of the same patch in mainline please, I can't seem to
find it.
thanks,
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
Thanks,
Oliver
--
Thanks,
Oliver
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
Correct -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
Greg, the patch in queue-2.6.23 is good for it
but the git id.: 96990a4ae979df9e235d01097d6175759331e88c
---
>From [EMAIL PROTECTED] Tue Jan 15 10:52:21 2008
From: Christoph Lameter <[EMAIL PROTECTED]>
Date: Wed, 16 Jan 2008 00:21:19 +0530
Subject: quicklists: Only consider memory that can be used with GFP_KERNEL
To: [EMAIL PROTECTED]
Cc: Andrew Morton <[EMAIL PROTECTED]>, [EMAIL PROTECTED],
[EMAIL PROTECTED]
Message-ID: <[EMAIL PROTECTED]>
Content-Disposition: inline
From: Christoph Lameter <[EMAIL PROTECTED]>
patch 96990a4ae979df9e235d01097d6175759331e88c in mainline.
Quicklists calculates the size of the quicklists based on the number of
free pages. This must be the number of free pages that can be allocated
with GFP_KERNEL. node_page_state() includes the pages in ZONE_HIGHMEM and
ZONE_MOVABLE which may lead the quicklists to become too large causing OOM.
Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
Tested-by: Dhaval Giani <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
mm/quicklist.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
--- a/mm/quicklist.c
+++ b/mm/quicklist.c
@@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist, quickli
static unsigned long max_pages(unsigned long min_pages)
{
unsigned long node_free_pages, max;
+ struct zone *zones = NODE_DATA(numa_node_id())->node_zones;
+
+ node_free_pages =
+#ifdef CONFIG_ZONE_DMA
+ zone_page_state([ZONE_DMA], NR_FREE_PAGES) +
+#endif
+#ifdef CONFIG_ZONE_DMA32
+ zone_page_state([ZONE_DMA32], NR_FREE_PAGES) +
+#endif
+ zone_page_state([ZONE_NORMAL], NR_FREE_PAGES);
- node_free_pages = node_page_state(numa_node_id(),
- NR_FREE_PAGES);
max = node_free_pages / FRACTION_OF_NODE_MEM;
return max(max, min_pages);
}
On 2/6/08, Greg KH <[EMAIL PROTECTED]> wrote:
> On Fri, Feb 01, 2008 at 05:30:14PM -0800, Christoph Lameter wrote:
> > On Fri, 1 Feb 2008, Justin M. Forbes wrote:
> >
> > >
> > > On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote:
> > > > NO! Wrong fix. Was dropped from mainline.
> > >
> > > What is the right fix for the OOM issues with 2.6.22? Perhaps
> > > http://marc.info/?l=linux-mm=119973653803451=2 should be added to
> > > the queue in its place? The OOM issue in 2.6.22 is real, and should be
> > > addressed.
> >
> > Indeed that is the right fix.
>
> Can someone send it to me, in patch form so that I can apply it? Along
> with the git id of the same patch in mainline please, I can't seem to
> find it.
>
> thanks,
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
On Fri, Feb 01, 2008 at 05:30:14PM -0800, Christoph Lameter wrote: > On Fri, 1 Feb 2008, Justin M. Forbes wrote: > > > > > On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote: > > > NO! Wrong fix. Was dropped from mainline. > > > > What is the right fix for the OOM issues with 2.6.22? Perhaps > > http://marc.info/?l=linux-mm=119973653803451=2 should be added to > > the queue in its place? The OOM issue in 2.6.22 is real, and should be > > addressed. > > Indeed that is the right fix. Can someone send it to me, in patch form so that I can apply it? Along with the git id of the same patch in mainline please, I can't seem to find it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
On Fri, Feb 01, 2008 at 05:30:14PM -0800, Christoph Lameter wrote: On Fri, 1 Feb 2008, Justin M. Forbes wrote: On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote: NO! Wrong fix. Was dropped from mainline. What is the right fix for the OOM issues with 2.6.22? Perhaps http://marc.info/?l=linux-mmm=119973653803451w=2 should be added to the queue in its place? The OOM issue in 2.6.22 is real, and should be addressed. Indeed that is the right fix. Can someone send it to me, in patch form so that I can apply it? Along with the git id of the same patch in mainline please, I can't seem to find it. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
Greg, the patch in queue-2.6.23 is good for it
but the git id.: 96990a4ae979df9e235d01097d6175759331e88c
---
From [EMAIL PROTECTED] Tue Jan 15 10:52:21 2008
From: Christoph Lameter [EMAIL PROTECTED]
Date: Wed, 16 Jan 2008 00:21:19 +0530
Subject: quicklists: Only consider memory that can be used with GFP_KERNEL
To: [EMAIL PROTECTED]
Cc: Andrew Morton [EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED]
Message-ID: [EMAIL PROTECTED]
Content-Disposition: inline
From: Christoph Lameter [EMAIL PROTECTED]
patch 96990a4ae979df9e235d01097d6175759331e88c in mainline.
Quicklists calculates the size of the quicklists based on the number of
free pages. This must be the number of free pages that can be allocated
with GFP_KERNEL. node_page_state() includes the pages in ZONE_HIGHMEM and
ZONE_MOVABLE which may lead the quicklists to become too large causing OOM.
Signed-off-by: Christoph Lameter [EMAIL PROTECTED]
Tested-by: Dhaval Giani [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]
---
mm/quicklist.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
--- a/mm/quicklist.c
+++ b/mm/quicklist.c
@@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist, quickli
static unsigned long max_pages(unsigned long min_pages)
{
unsigned long node_free_pages, max;
+ struct zone *zones = NODE_DATA(numa_node_id())-node_zones;
+
+ node_free_pages =
+#ifdef CONFIG_ZONE_DMA
+ zone_page_state(zones[ZONE_DMA], NR_FREE_PAGES) +
+#endif
+#ifdef CONFIG_ZONE_DMA32
+ zone_page_state(zones[ZONE_DMA32], NR_FREE_PAGES) +
+#endif
+ zone_page_state(zones[ZONE_NORMAL], NR_FREE_PAGES);
- node_free_pages = node_page_state(numa_node_id(),
- NR_FREE_PAGES);
max = node_free_pages / FRACTION_OF_NODE_MEM;
return max(max, min_pages);
}
On 2/6/08, Greg KH [EMAIL PROTECTED] wrote:
On Fri, Feb 01, 2008 at 05:30:14PM -0800, Christoph Lameter wrote:
On Fri, 1 Feb 2008, Justin M. Forbes wrote:
On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote:
NO! Wrong fix. Was dropped from mainline.
What is the right fix for the OOM issues with 2.6.22? Perhaps
http://marc.info/?l=linux-mmm=119973653803451w=2 should be added to
the queue in its place? The OOM issue in 2.6.22 is real, and should be
addressed.
Indeed that is the right fix.
Can someone send it to me, in patch form so that I can apply it? Along
with the git id of the same patch in mainline please, I can't seem to
find it.
thanks,
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
Thanks,
Oliver
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
Correct -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
On Fri, 2008-02-01 at 17:30 -0800, Christoph Lameter wrote: > On Fri, 1 Feb 2008, Justin M. Forbes wrote: > > > > > On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote: > > > NO! Wrong fix. Was dropped from mainline. > > > > What is the right fix for the OOM issues with 2.6.22? Perhaps > > http://marc.info/?l=linux-mm=119973653803451=2 should be added to > > the queue in its place? The OOM issue in 2.6.22 is real, and should be > > addressed. > > Indeed that is the right fix. Greg, could we get that one added? We are already shipping it as our users have run into the OOM problem with 2.6.22.16 without this patch. Justin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote: > NO! Wrong fix. Was dropped from mainline. What is the right fix for the OOM issues with 2.6.22? Perhaps http://marc.info/?l=linux-mm=119973653803451=2 should be added to the queue in its place? The OOM issue in 2.6.22 is real, and should be addressed. Justin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
On Fri, 1 Feb 2008, Justin M. Forbes wrote: > > On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote: > > NO! Wrong fix. Was dropped from mainline. > > What is the right fix for the OOM issues with 2.6.22? Perhaps > http://marc.info/?l=linux-mm=119973653803451=2 should be added to > the queue in its place? The OOM issue in 2.6.22 is real, and should be > addressed. Indeed that is the right fix. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
On Fri, Feb 01, 2008 at 04:39:08PM -0800, Christoph Lameter wrote: > NO! Wrong fix. Was dropped from mainline. Thanks for letting us know, now dropped. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
NO! Wrong fix. Was dropped from mainline. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0
2.6.22-stable review patch. If anyone has any objections, please let us
know.
--
From: Christoph Lameter <[EMAIL PROTECTED]>
patch 421d99193537a6522aac2148286f08792167d5fd in mainline.
This ensures that the quicklists are drained. Otherwise draining may only
occur when the processor reaches an idle state.
Fixes fatal leakage of pgd_t's on 2.6.22 and later.
Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>
Reported-by: Dhaval Giani <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
include/asm-generic/tlb.h |4
1 file changed, 4 insertions(+)
--- a/include/asm-generic/tlb.h
+++ b/include/asm-generic/tlb.h
@@ -14,6 +14,7 @@
#define _ASM_GENERIC__TLB_H
#include
+#include
#include
#include
@@ -85,6 +86,9 @@ tlb_flush_mmu(struct mmu_gather *tlb, un
static inline void
tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
{
+#ifdef CONFIG_QUICKLIST
+ tlb->need_flush += &__get_cpu_var(quicklist)[0].nr_pages != 0;
+#endif
tlb_flush_mmu(tlb, start, end);
/* keep the page table cache within bounds */
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
NO! Wrong fix. Was dropped from mainline. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
On Fri, Feb 01, 2008 at 04:39:08PM -0800, Christoph Lameter wrote: NO! Wrong fix. Was dropped from mainline. Thanks for letting us know, now dropped. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
2.6.22-stable review patch. If anyone has any objections, please let us
know.
--
From: Christoph Lameter [EMAIL PROTECTED]
patch 421d99193537a6522aac2148286f08792167d5fd in mainline.
This ensures that the quicklists are drained. Otherwise draining may only
occur when the processor reaches an idle state.
Fixes fatal leakage of pgd_t's on 2.6.22 and later.
Signed-off-by: Christoph Lameter [EMAIL PROTECTED]
Reported-by: Dhaval Giani [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
Signed-off-by: Linus Torvalds [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]
---
include/asm-generic/tlb.h |4
1 file changed, 4 insertions(+)
--- a/include/asm-generic/tlb.h
+++ b/include/asm-generic/tlb.h
@@ -14,6 +14,7 @@
#define _ASM_GENERIC__TLB_H
#include linux/swap.h
+#include linux/quicklist.h
#include asm/pgalloc.h
#include asm/tlbflush.h
@@ -85,6 +86,9 @@ tlb_flush_mmu(struct mmu_gather *tlb, un
static inline void
tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
{
+#ifdef CONFIG_QUICKLIST
+ tlb-need_flush += __get_cpu_var(quicklist)[0].nr_pages != 0;
+#endif
tlb_flush_mmu(tlb, start, end);
/* keep the page table cache within bounds */
--
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
On Fri, 1 Feb 2008, Justin M. Forbes wrote: On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote: NO! Wrong fix. Was dropped from mainline. What is the right fix for the OOM issues with 2.6.22? Perhaps http://marc.info/?l=linux-mmm=119973653803451w=2 should be added to the queue in its place? The OOM issue in 2.6.22 is real, and should be addressed. Indeed that is the right fix. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote: NO! Wrong fix. Was dropped from mainline. What is the right fix for the OOM issues with 2.6.22? Perhaps http://marc.info/?l=linux-mmm=119973653803451w=2 should be added to the queue in its place? The OOM issue in 2.6.22 is real, and should be addressed. Justin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 22/27] quicklist: Set tlb-need_flush if pages are remaining in quicklist 0
On Fri, 2008-02-01 at 17:30 -0800, Christoph Lameter wrote: On Fri, 1 Feb 2008, Justin M. Forbes wrote: On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote: NO! Wrong fix. Was dropped from mainline. What is the right fix for the OOM issues with 2.6.22? Perhaps http://marc.info/?l=linux-mmm=119973653803451w=2 should be added to the queue in its place? The OOM issue in 2.6.22 is real, and should be addressed. Indeed that is the right fix. Greg, could we get that one added? We are already shipping it as our users have run into the OOM problem with 2.6.22.16 without this patch. Justin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
