Re: [patch V4 part 3 19/29] x86/entry: Convert Coprocessor segment overrun exception to IDTENTRY

2020-05-13 Thread Andy Lutomirski
On Tue, May 5, 2020 at 7:15 AM Thomas Gleixner  wrote:
>
> From: Thomas Gleixner 
>
> Convert #OLD_MF to IDTENTRY:
>   - Implement the C entry point with DEFINE_IDTENTRY
>   - Emit the ASM stub with DECLARE_IDTENTRY
>   - Remove the ASM idtentry in 64bit
>   - Remove the open coded ASM entry code in 32bit
>   - Fixup the XEN/PV code
>   - Remove the old prototyoes
>
> No functional change.


Acked-by: Andy Lutomirski 


[patch V4 part 3 19/29] x86/entry: Convert Coprocessor segment overrun exception to IDTENTRY

2020-05-05 Thread Thomas Gleixner
From: Thomas Gleixner 

Convert #OLD_MF to IDTENTRY:
  - Implement the C entry point with DEFINE_IDTENTRY
  - Emit the ASM stub with DECLARE_IDTENTRY
  - Remove the ASM idtentry in 64bit
  - Remove the open coded ASM entry code in 32bit
  - Fixup the XEN/PV code
  - Remove the old prototyoes

No functional change.

Signed-off-by: Thomas Gleixner 

---
 arch/x86/entry/entry_32.S   |7 ---
 arch/x86/entry/entry_64.S   |1 -
 arch/x86/include/asm/idtentry.h |1 +
 arch/x86/include/asm/traps.h|3 ---
 arch/x86/kernel/idt.c   |2 +-
 arch/x86/kernel/traps.c |7 ++-
 arch/x86/xen/enlighten_pv.c |2 +-
 arch/x86/xen/xen-asm_64.S   |2 +-
 8 files changed, 10 insertions(+), 15 deletions(-)

--- a/arch/x86/entry/entry_32.S
+++ b/arch/x86/entry/entry_32.S
@@ -1318,13 +1318,6 @@ SYM_CODE_START(native_iret)
 SYM_CODE_END(native_iret)
 #endif
 
-SYM_CODE_START(coprocessor_segment_overrun)
-   ASM_CLAC
-   pushl   $0
-   pushl   $do_coprocessor_segment_overrun
-   jmp common_exception
-SYM_CODE_END(coprocessor_segment_overrun)
-
 SYM_CODE_START(invalid_TSS)
ASM_CLAC
pushl   $do_invalid_TSS
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -1074,7 +1074,6 @@ apicinterrupt IRQ_WORK_VECTOR irq_work
  */
 
 idtentry   X86_TRAP_BP int3do_int3 
has_error_code=0
-idtentry   X86_TRAP_OLD_MF coprocessor_segment_overrun 
do_coprocessor_segment_overrun  has_error_code=0
 idtentry   X86_TRAP_TS invalid_TSS do_invalid_TSS  
has_error_code=1
 idtentry   X86_TRAP_NP segment_not_present 
do_segment_not_present  has_error_code=1
 idtentry   X86_TRAP_SS stack_segment   
do_stack_segmenthas_error_code=1
--- a/arch/x86/include/asm/idtentry.h
+++ b/arch/x86/include/asm/idtentry.h
@@ -82,5 +82,6 @@ DECLARE_IDTENTRY(X86_TRAP_OF, exc_overf
 DECLARE_IDTENTRY(X86_TRAP_BR,  exc_bounds);
 DECLARE_IDTENTRY(X86_TRAP_UD,  exc_invalid_op);
 DECLARE_IDTENTRY(X86_TRAP_NM,  exc_device_not_available);
+DECLARE_IDTENTRY(X86_TRAP_OLD_MF,  exc_coproc_segment_overrun);
 
 #endif
--- a/arch/x86/include/asm/traps.h
+++ b/arch/x86/include/asm/traps.h
@@ -17,7 +17,6 @@ asmlinkage void int3(void);
 #ifdef CONFIG_X86_64
 asmlinkage void double_fault(void);
 #endif
-asmlinkage void coprocessor_segment_overrun(void);
 asmlinkage void invalid_TSS(void);
 asmlinkage void segment_not_present(void);
 asmlinkage void stack_segment(void);
@@ -37,7 +36,6 @@ asmlinkage void xen_xennmi(void);
 asmlinkage void xen_xendebug(void);
 asmlinkage void xen_int3(void);
 asmlinkage void xen_double_fault(void);
-asmlinkage void xen_coprocessor_segment_overrun(void);
 asmlinkage void xen_invalid_TSS(void);
 asmlinkage void xen_segment_not_present(void);
 asmlinkage void xen_stack_segment(void);
@@ -58,7 +56,6 @@ dotraplinkage void do_int3(struct pt_reg
 #if defined(CONFIG_X86_64) || defined(CONFIG_DOUBLEFAULT)
 dotraplinkage void do_double_fault(struct pt_regs *regs, long error_code, 
unsigned long cr2);
 #endif
-dotraplinkage void do_coprocessor_segment_overrun(struct pt_regs *regs, long 
error_code);
 dotraplinkage void do_invalid_TSS(struct pt_regs *regs, long error_code);
 dotraplinkage void do_segment_not_present(struct pt_regs *regs, long 
error_code);
 dotraplinkage void do_stack_segment(struct pt_regs *regs, long error_code);
--- a/arch/x86/kernel/idt.c
+++ b/arch/x86/kernel/idt.c
@@ -75,7 +75,7 @@ static const __initconst struct idt_data
INTG(X86_TRAP_BR,   asm_exc_bounds),
INTG(X86_TRAP_UD,   asm_exc_invalid_op),
INTG(X86_TRAP_NM,   asm_exc_device_not_available),
-   INTG(X86_TRAP_OLD_MF,   coprocessor_segment_overrun),
+   INTG(X86_TRAP_OLD_MF,   asm_exc_coproc_segment_overrun),
INTG(X86_TRAP_TS,   invalid_TSS),
INTG(X86_TRAP_NP,   segment_not_present),
INTG(X86_TRAP_SS,   stack_segment),
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -236,6 +236,12 @@ DEFINE_IDTENTRY(exc_invalid_op)
handle_invalid_op(regs);
 }
 
+DEFINE_IDTENTRY(exc_coproc_segment_overrun)
+{
+   do_error_trap(regs, 0, "coprocessor segment overrun",
+ X86_TRAP_OLD_MF, SIGFPE, 0, NULL);
+}
+
 #define IP ((void __user *)uprobe_get_trap_addr(regs))
 #define DO_ERROR(trapnr, signr, sicode, addr, str, name)  \
 dotraplinkage void do_##name(struct pt_regs *regs, long error_code)   \
@@ -243,7 +249,6 @@ dotraplinkage void do_##name(struct pt_r
do_error_trap(regs, error_code, str, trapnr, signr, sicode, addr); \
 }
 
-DO_ERROR(X86_TRAP_OLD_MF, SIGFPE,   0, NULL, "coprocessor segment 
overrun", coprocessor_segment_overrun)
 DO_ERROR(X8