[tip:irq/urgent] genirq: Dont allow affinity mask to be updated on IPIs

[tip-bot for Matt Redfearn]

Commit-ID:  4589f450fb285ab85f7513b6649e51ec2a820653
Gitweb: http://git.kernel.org/tip/4589f450fb285ab85f7513b6649e51ec2a820653
Author: Matt Redfearn 
AuthorDate: Thu, 21 Apr 2016 10:08:32 +0100
Committer:  Thomas Gleixner 
CommitDate: Thu, 21 Apr 2016 12:05:15 +0200

genirq: Dont allow affinity mask to be updated on IPIs

The IPI domain re-purposes the IRQ affinity to signify the mask of CPUs
that this IPI will deliver to. This must not be modified before the IPI
is destroyed again, so set the IRQ_NO_BALANCING flag to prevent the
affinity being overwritten by setup_affinity().

Without this, if an IPI is reserved for a single target CPU, then
allocated using __setup_irq(), the affinity is overwritten with
cpu_online_mask. When ipi_destroy() is subsequently called on a
multi-cpu system, it will attempt to free cpumask_weight() IRQs
that were never allocated, and crash.

Fixes: d17bf24e6952 ("genirq: Add a new generic IPI reservation code to irq 
core")
Signed-off-by: Matt Redfearn 
Cc: linux-m...@linux-mips.org
Cc: ja...@lakedaemon.net
Cc: marc.zyng...@arm.com
Cc: r...@linux-mips.org
Cc: Qais Yousef 
Cc: lisa.parr...@imgtec.com
Link: 
http://lkml.kernel.org/r/1461229712-13057-1-git-send-email-matt.redfe...@imgtec.com
Signed-off-by: Thomas Gleixner 

---
 kernel/irq/ipi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/ipi.c b/kernel/irq/ipi.c
index c37f34b..14777af 100644
--- a/kernel/irq/ipi.c
+++ b/kernel/irq/ipi.c
@@ -94,6 +94,7 @@ unsigned int irq_reserve_ipi(struct irq_domain *domain,
data = irq_get_irq_data(virq + i);
cpumask_copy(data->common->affinity, dest);
data->common->ipi_offset = offset;
+   irq_set_status_flags(virq + i, IRQ_NO_BALANCING);
}
return virq;
 

[tip:irq/urgent] genirq: Dont allow affinity mask to be updated on IPIs

[tip-bot for Matt Redfearn]

Commit-ID:  4589f450fb285ab85f7513b6649e51ec2a820653
Gitweb: http://git.kernel.org/tip/4589f450fb285ab85f7513b6649e51ec2a820653
Author: Matt Redfearn 
AuthorDate: Thu, 21 Apr 2016 10:08:32 +0100
Committer:  Thomas Gleixner 
CommitDate: Thu, 21 Apr 2016 12:05:15 +0200

genirq: Dont allow affinity mask to be updated on IPIs

The IPI domain re-purposes the IRQ affinity to signify the mask of CPUs
that this IPI will deliver to. This must not be modified before the IPI
is destroyed again, so set the IRQ_NO_BALANCING flag to prevent the
affinity being overwritten by setup_affinity().

Without this, if an IPI is reserved for a single target CPU, then
allocated using __setup_irq(), the affinity is overwritten with
cpu_online_mask. When ipi_destroy() is subsequently called on a
multi-cpu system, it will attempt to free cpumask_weight() IRQs
that were never allocated, and crash.

Fixes: d17bf24e6952 ("genirq: Add a new generic IPI reservation code to irq 
core")
Signed-off-by: Matt Redfearn 
Cc: linux-m...@linux-mips.org
Cc: ja...@lakedaemon.net
Cc: marc.zyng...@arm.com
Cc: r...@linux-mips.org
Cc: Qais Yousef 
Cc: lisa.parr...@imgtec.com
Link: 
http://lkml.kernel.org/r/1461229712-13057-1-git-send-email-matt.redfe...@imgtec.com
Signed-off-by: Thomas Gleixner 

---
 kernel/irq/ipi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/ipi.c b/kernel/irq/ipi.c
index c37f34b..14777af 100644
--- a/kernel/irq/ipi.c
+++ b/kernel/irq/ipi.c
@@ -94,6 +94,7 @@ unsigned int irq_reserve_ipi(struct irq_domain *domain,
data = irq_get_irq_data(virq + i);
cpumask_copy(data->common->affinity, dest);
data->common->ipi_offset = offset;
+   irq_set_status_flags(virq + i, IRQ_NO_BALANCING);
}
return virq;