[tip:perf/core] perf diff: Color the Weighted Diff column

2014-01-14 Thread tip-bot for Ramkumar Ramachandra
Commit-ID:  a5846e215bd47f61133383822422c683600efa7a
Gitweb: http://git.kernel.org/tip/a5846e215bd47f61133383822422c683600efa7a
Author: Ramkumar Ramachandra 
AuthorDate: Mon, 30 Dec 2013 13:32:35 +0530
Committer:  Arnaldo Carvalho de Melo 
CommitDate: Mon, 13 Jan 2014 11:38:25 -0300

perf diff: Color the Weighted Diff column

In

  $ perf diff -c wdiff:M,N

color the numbers in the Weighted Diff column using color_snprintf(),
picking the colors using get_percent_color().

Signed-off-by: Ramkumar Ramachandra 
Acked-by: Jiri Olsa 
Cc: Jiri Olsa 
Link: 
http://lkml.kernel.org/r/1388390555-10808-1-git-send-email-artag...@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo 
---
 tools/perf/builtin-diff.c | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 73d8bff..a77e312 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -778,6 +778,7 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
container_of(fmt, struct diff_hpp_fmt, fmt);
struct hist_entry *pair = get_pair_fmt(he, dfmt);
double diff;
+   s64 wdiff;
char pfmt[20] = " ";
 
if (!pair)
@@ -806,6 +807,18 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
scnprintf(pfmt, 20, "%%%d.6f", dfmt->header_width);
return value_color_snprintf(hpp->buf, hpp->size,
pfmt, diff);
+   case COMPUTE_WEIGHTED_DIFF:
+   if (he->dummy)
+   goto dummy_print;
+   if (pair->diff.computed)
+   wdiff = pair->diff.wdiff;
+   else
+   wdiff = compute_wdiff(he, pair);
+
+   scnprintf(pfmt, 20, "%%14ld", dfmt->header_width);
+   return color_snprintf(hpp->buf, hpp->size,
+   get_percent_color(wdiff),
+   pfmt, wdiff);
default:
BUG_ON(1);
}
@@ -826,6 +839,12 @@ static int hpp__color_ratio(struct perf_hpp_fmt *fmt,
return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO);
 }
 
+static int hpp__color_wdiff(struct perf_hpp_fmt *fmt,
+   struct perf_hpp *hpp, struct hist_entry *he)
+{
+   return __hpp__color_compare(fmt, hpp, he, COMPUTE_WEIGHTED_DIFF);
+}
+
 static void
 hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
 {
@@ -1007,6 +1026,9 @@ static void data__hpp_register(struct data__file *d, int 
idx)
case PERF_HPP_DIFF__RATIO:
fmt->color = hpp__color_ratio;
break;
+   case PERF_HPP_DIFF__WEIGHTED_DIFF:
+   fmt->color = hpp__color_wdiff;
+   break;
default:
break;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[tip:perf/core] perf diff: Color the Weighted Diff column

2014-01-14 Thread tip-bot for Ramkumar Ramachandra
Commit-ID:  a5846e215bd47f61133383822422c683600efa7a
Gitweb: http://git.kernel.org/tip/a5846e215bd47f61133383822422c683600efa7a
Author: Ramkumar Ramachandra artag...@gmail.com
AuthorDate: Mon, 30 Dec 2013 13:32:35 +0530
Committer:  Arnaldo Carvalho de Melo a...@redhat.com
CommitDate: Mon, 13 Jan 2014 11:38:25 -0300

perf diff: Color the Weighted Diff column

In

  $ perf diff -c wdiff:M,N

color the numbers in the Weighted Diff column using color_snprintf(),
picking the colors using get_percent_color().

Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
Acked-by: Jiri Olsa jo...@redhat.com
Cc: Jiri Olsa jo...@redhat.com
Link: 
http://lkml.kernel.org/r/1388390555-10808-1-git-send-email-artag...@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo a...@redhat.com
---
 tools/perf/builtin-diff.c | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 73d8bff..a77e312 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -778,6 +778,7 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
container_of(fmt, struct diff_hpp_fmt, fmt);
struct hist_entry *pair = get_pair_fmt(he, dfmt);
double diff;
+   s64 wdiff;
char pfmt[20] =  ;
 
if (!pair)
@@ -806,6 +807,18 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
scnprintf(pfmt, 20, %%%d.6f, dfmt-header_width);
return value_color_snprintf(hpp-buf, hpp-size,
pfmt, diff);
+   case COMPUTE_WEIGHTED_DIFF:
+   if (he-dummy)
+   goto dummy_print;
+   if (pair-diff.computed)
+   wdiff = pair-diff.wdiff;
+   else
+   wdiff = compute_wdiff(he, pair);
+
+   scnprintf(pfmt, 20, %%14ld, dfmt-header_width);
+   return color_snprintf(hpp-buf, hpp-size,
+   get_percent_color(wdiff),
+   pfmt, wdiff);
default:
BUG_ON(1);
}
@@ -826,6 +839,12 @@ static int hpp__color_ratio(struct perf_hpp_fmt *fmt,
return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO);
 }
 
+static int hpp__color_wdiff(struct perf_hpp_fmt *fmt,
+   struct perf_hpp *hpp, struct hist_entry *he)
+{
+   return __hpp__color_compare(fmt, hpp, he, COMPUTE_WEIGHTED_DIFF);
+}
+
 static void
 hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
 {
@@ -1007,6 +1026,9 @@ static void data__hpp_register(struct data__file *d, int 
idx)
case PERF_HPP_DIFF__RATIO:
fmt-color = hpp__color_ratio;
break;
+   case PERF_HPP_DIFF__WEIGHTED_DIFF:
+   fmt-color = hpp__color_wdiff;
+   break;
default:
break;
}
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/