[tip:perf/core] perf gtk/hists: Display callchain overhead also
Commit-ID: cc60f24e225e50a0b57398f9ba105fd8ffcf4bb3
Gitweb: http://git.kernel.org/tip/cc60f24e225e50a0b57398f9ba105fd8ffcf4bb3
Author: Namhyung Kim
AuthorDate: Tue, 4 Jun 2013 18:22:14 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 12 Jul 2013 13:52:40 -0300
perf gtk/hists: Display callchain overhead also
Display callchain percent value in the overhead column.
Signed-off-by: Namhyung Kim
Reviewed-by: Pekka Enberg
Cc: David Ahern
Cc: Ingo Molnar
Cc: Jiri Olsa
Cc: Paul Mackerras
Cc: Pekka Enberg
Cc: Peter Zijlstra
Link:
http://lkml.kernel.org/r/1370337737-30812-4-git-send-email-namhy...@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo
---
tools/perf/ui/gtk/hists.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c
index 226c7e1..fa9f8a0 100644
--- a/tools/perf/ui/gtk/hists.c
+++ b/tools/perf/ui/gtk/hists.c
@@ -134,7 +134,7 @@ static void callchain_list__sym_name(struct callchain_list
*cl,
}
static void perf_gtk__add_callchain(struct rb_root *root, GtkTreeStore *store,
- GtkTreeIter *parent, int col)
+ GtkTreeIter *parent, int col, u64 total)
{
struct rb_node *nd;
bool has_single_node = (rb_first(root) == rb_last(root));
@@ -144,9 +144,14 @@ static void perf_gtk__add_callchain(struct rb_root *root,
GtkTreeStore *store,
struct callchain_list *chain;
GtkTreeIter iter, new_parent;
bool need_new_parent;
+ double percent;
+ u64 hits, child_total;
node = rb_entry(nd, struct callchain_node, rb_node);
+ hits = callchain_cumul_hits(node);
+ percent = 100.0 * hits / total;
+
new_parent = *parent;
need_new_parent = !has_single_node && (node->val_nr > 1);
@@ -155,6 +160,9 @@ static void perf_gtk__add_callchain(struct rb_root *root,
GtkTreeStore *store,
gtk_tree_store_append(store, , _parent);
+ scnprintf(buf, sizeof(buf), "%5.2f%%", percent);
+ gtk_tree_store_set(store, , 0, buf, -1);
+
callchain_list__sym_name(chain, buf, sizeof(buf));
gtk_tree_store_set(store, , col, buf, -1);
@@ -168,8 +176,14 @@ static void perf_gtk__add_callchain(struct rb_root *root,
GtkTreeStore *store,
}
}
+ if (callchain_param.mode == CHAIN_GRAPH_REL)
+ child_total = node->children_hit;
+ else
+ child_total = total;
+
/* Now 'iter' contains info of the last callchain_list */
- perf_gtk__add_callchain(>rb_root, store, , col);
+ perf_gtk__add_callchain(>rb_root, store, , col,
+ child_total);
}
}
@@ -283,8 +297,15 @@ static void perf_gtk__show_hists(GtkWidget *window, struct
hists *hists,
}
if (symbol_conf.use_callchain && sort__has_sym) {
+ u64 total;
+
+ if (callchain_param.mode == CHAIN_GRAPH_REL)
+ total = h->stat.period;
+ else
+ total = hists->stats.total_period;
+
perf_gtk__add_callchain(>sorted_chain, store, ,
- sym_col);
+ sym_col, total);
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[tip:perf/core] perf gtk/hists: Display callchain overhead also
Commit-ID: cc60f24e225e50a0b57398f9ba105fd8ffcf4bb3
Gitweb: http://git.kernel.org/tip/cc60f24e225e50a0b57398f9ba105fd8ffcf4bb3
Author: Namhyung Kim namhyung@lge.com
AuthorDate: Tue, 4 Jun 2013 18:22:14 +0900
Committer: Arnaldo Carvalho de Melo a...@redhat.com
CommitDate: Fri, 12 Jul 2013 13:52:40 -0300
perf gtk/hists: Display callchain overhead also
Display callchain percent value in the overhead column.
Signed-off-by: Namhyung Kim namhy...@kernel.org
Reviewed-by: Pekka Enberg penb...@kernel.org
Cc: David Ahern dsah...@gmail.com
Cc: Ingo Molnar mi...@kernel.org
Cc: Jiri Olsa jo...@redhat.com
Cc: Paul Mackerras pau...@samba.org
Cc: Pekka Enberg penb...@kernel.org
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Link:
http://lkml.kernel.org/r/1370337737-30812-4-git-send-email-namhy...@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo a...@redhat.com
---
tools/perf/ui/gtk/hists.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c
index 226c7e1..fa9f8a0 100644
--- a/tools/perf/ui/gtk/hists.c
+++ b/tools/perf/ui/gtk/hists.c
@@ -134,7 +134,7 @@ static void callchain_list__sym_name(struct callchain_list
*cl,
}
static void perf_gtk__add_callchain(struct rb_root *root, GtkTreeStore *store,
- GtkTreeIter *parent, int col)
+ GtkTreeIter *parent, int col, u64 total)
{
struct rb_node *nd;
bool has_single_node = (rb_first(root) == rb_last(root));
@@ -144,9 +144,14 @@ static void perf_gtk__add_callchain(struct rb_root *root,
GtkTreeStore *store,
struct callchain_list *chain;
GtkTreeIter iter, new_parent;
bool need_new_parent;
+ double percent;
+ u64 hits, child_total;
node = rb_entry(nd, struct callchain_node, rb_node);
+ hits = callchain_cumul_hits(node);
+ percent = 100.0 * hits / total;
+
new_parent = *parent;
need_new_parent = !has_single_node (node-val_nr 1);
@@ -155,6 +160,9 @@ static void perf_gtk__add_callchain(struct rb_root *root,
GtkTreeStore *store,
gtk_tree_store_append(store, iter, new_parent);
+ scnprintf(buf, sizeof(buf), %5.2f%%, percent);
+ gtk_tree_store_set(store, iter, 0, buf, -1);
+
callchain_list__sym_name(chain, buf, sizeof(buf));
gtk_tree_store_set(store, iter, col, buf, -1);
@@ -168,8 +176,14 @@ static void perf_gtk__add_callchain(struct rb_root *root,
GtkTreeStore *store,
}
}
+ if (callchain_param.mode == CHAIN_GRAPH_REL)
+ child_total = node-children_hit;
+ else
+ child_total = total;
+
/* Now 'iter' contains info of the last callchain_list */
- perf_gtk__add_callchain(node-rb_root, store, iter, col);
+ perf_gtk__add_callchain(node-rb_root, store, iter, col,
+ child_total);
}
}
@@ -283,8 +297,15 @@ static void perf_gtk__show_hists(GtkWidget *window, struct
hists *hists,
}
if (symbol_conf.use_callchain sort__has_sym) {
+ u64 total;
+
+ if (callchain_param.mode == CHAIN_GRAPH_REL)
+ total = h-stat.period;
+ else
+ total = hists-stats.total_period;
+
perf_gtk__add_callchain(h-sorted_chain, store, iter,
- sym_col);
+ sym_col, total);
}
}
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
