[tip:perf/core] perf top: Make -g refer to callchains
Commit-ID: bf80669e4f689f181f23a54dfe2a0f264147ad67
Gitweb: http://git.kernel.org/tip/bf80669e4f689f181f23a54dfe2a0f264147ad67
Author: David Ahern
AuthorDate: Thu, 14 Nov 2013 20:51:30 -0700
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 27 Nov 2013 14:58:35 -0300
perf top: Make -g refer to callchains
In most commands -g is used for callchains. Make perf-top follow suit.
Move group to just --group with no short cut making it similar to
perf-record.
Signed-off-by: David Ahern
Acked-by: Ingo Molnar
Cc: Frederic Weisbecker
Cc: Ingo Molnar
Cc: Jiri Olsa
Cc: Namhyung Kim
Link:
http://lkml.kernel.org/r/1384487490-6865-1-git-send-email-dsah...@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo
---
tools/perf/Documentation/perf-top.txt | 5 ++---
tools/perf/builtin-top.c | 4 ++--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools/perf/Documentation/perf-top.txt
b/tools/perf/Documentation/perf-top.txt
index 7de01dd..cdd8d49 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -50,7 +50,6 @@ Default is to monitor all CPUS.
--count-filter=::
Only display functions with more events than this.
--g::
--group::
Put the counters into a counter group.
@@ -143,12 +142,12 @@ Default is to monitor all CPUS.
--asm-raw::
Show raw instruction encoding of assembly instructions.
--G::
+-g::
Enables call-graph (stack chain/backtrace) recording.
--call-graph::
Setup and enable call-graph (stack chain/backtrace) recording,
- implies -G.
+ implies -g.
--max-stack::
Set the stack depth limit when parsing the callchain, anything
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 71e6402..531522d 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1084,7 +1084,7 @@ int cmd_top(int argc, const char **argv, const char
*prefix __maybe_unused)
"dump the symbol table used for profiling"),
OPT_INTEGER('f', "count-filter", _filter,
"only display functions with more events than this"),
- OPT_BOOLEAN('g', "group", >group,
+ OPT_BOOLEAN(0, "group", >group,
"put the counters into a counter group"),
OPT_BOOLEAN('i', "no-inherit", >no_inherit,
"child tasks do not inherit counters"),
@@ -1105,7 +1105,7 @@ int cmd_top(int argc, const char **argv, const char
*prefix __maybe_unused)
" abort, in_tx, transaction"),
OPT_BOOLEAN('n', "show-nr-samples", _conf.show_nr_samples,
"Show a column with the number of samples"),
- OPT_CALLBACK_NOOPT('G', NULL, _opts,
+ OPT_CALLBACK_NOOPT('g', NULL, _opts,
NULL, "enables call-graph recording",
_opt),
OPT_CALLBACK(0, "call-graph", _opts,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[tip:perf/core] perf top: Make -g refer to callchains
Commit-ID: bf80669e4f689f181f23a54dfe2a0f264147ad67
Gitweb: http://git.kernel.org/tip/bf80669e4f689f181f23a54dfe2a0f264147ad67
Author: David Ahern dsah...@gmail.com
AuthorDate: Thu, 14 Nov 2013 20:51:30 -0700
Committer: Arnaldo Carvalho de Melo a...@redhat.com
CommitDate: Wed, 27 Nov 2013 14:58:35 -0300
perf top: Make -g refer to callchains
In most commands -g is used for callchains. Make perf-top follow suit.
Move group to just --group with no short cut making it similar to
perf-record.
Signed-off-by: David Ahern dsah...@gmail.com
Acked-by: Ingo Molnar mi...@kernel.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Ingo Molnar mi...@kernel.org
Cc: Jiri Olsa jo...@redhat.com
Cc: Namhyung Kim namhy...@kernel.org
Link:
http://lkml.kernel.org/r/1384487490-6865-1-git-send-email-dsah...@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo a...@redhat.com
---
tools/perf/Documentation/perf-top.txt | 5 ++---
tools/perf/builtin-top.c | 4 ++--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools/perf/Documentation/perf-top.txt
b/tools/perf/Documentation/perf-top.txt
index 7de01dd..cdd8d49 100644
--- a/tools/perf/Documentation/perf-top.txt
+++ b/tools/perf/Documentation/perf-top.txt
@@ -50,7 +50,6 @@ Default is to monitor all CPUS.
--count-filter=count::
Only display functions with more events than this.
--g::
--group::
Put the counters into a counter group.
@@ -143,12 +142,12 @@ Default is to monitor all CPUS.
--asm-raw::
Show raw instruction encoding of assembly instructions.
--G::
+-g::
Enables call-graph (stack chain/backtrace) recording.
--call-graph::
Setup and enable call-graph (stack chain/backtrace) recording,
- implies -G.
+ implies -g.
--max-stack::
Set the stack depth limit when parsing the callchain, anything
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 71e6402..531522d 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1084,7 +1084,7 @@ int cmd_top(int argc, const char **argv, const char
*prefix __maybe_unused)
dump the symbol table used for profiling),
OPT_INTEGER('f', count-filter, top.count_filter,
only display functions with more events than this),
- OPT_BOOLEAN('g', group, opts-group,
+ OPT_BOOLEAN(0, group, opts-group,
put the counters into a counter group),
OPT_BOOLEAN('i', no-inherit, opts-no_inherit,
child tasks do not inherit counters),
@@ -1105,7 +1105,7 @@ int cmd_top(int argc, const char **argv, const char
*prefix __maybe_unused)
abort, in_tx, transaction),
OPT_BOOLEAN('n', show-nr-samples, symbol_conf.show_nr_samples,
Show a column with the number of samples),
- OPT_CALLBACK_NOOPT('G', NULL, top.record_opts,
+ OPT_CALLBACK_NOOPT('g', NULL, top.record_opts,
NULL, enables call-graph recording,
callchain_opt),
OPT_CALLBACK(0, call-graph, top.record_opts,
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
