[tip:ras/core] kexec/crash: Say which char is the unrecognized

[tip-bot for Borislav Petkov]

Commit-ID:  53b90c0c56b502056da83d768047dcf765bac9fb
Gitweb: http://git.kernel.org/tip/53b90c0c56b502056da83d768047dcf765bac9fb
Author: Borislav Petkov 
AuthorDate: Mon, 19 Oct 2015 11:17:47 +0200
Committer:  Ingo Molnar 
CommitDate: Wed, 21 Oct 2015 11:10:57 +0200

kexec/crash: Say which char is the unrecognized

It is helpful when the crashkernel cmdline parsing routines
actually say which character is the unrecognized one. Make them
do so.

Signed-off-by: Borislav Petkov 
Reviewed-by: Dave Young 
Reviewed-by: Joerg Roedel 
Cc: Andrew Morton 
Cc: Andy Lutomirski 
Cc: Baoquan He 
Cc: H. Peter Anvin 
Cc: Jiri Kosina 
Cc: Juergen Gross 
Cc: Linus Torvalds 
Cc: Mark Salter 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: Vivek Goyal 
Cc: WANG Chao 
Cc: jerry_hoem...@hp.com
Link: http://lkml.kernel.org/r/1445246268-26285-8-git-send-email...@alien8.de
Signed-off-by: Ingo Molnar 
---
 kernel/kexec_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 201b453..bd9f8a0 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -1149,7 +1149,7 @@ static int __init parse_crashkernel_simple(char *cmdline,
if (*cur == '@')
*crash_base = memparse(cur+1, );
else if (*cur != ' ' && *cur != '\0') {
-   pr_warn("crashkernel: unrecognized char\n");
+   pr_warn("crashkernel: unrecognized char: %c\n", *cur);
return -EINVAL;
}
 
@@ -1186,12 +1186,12 @@ static int __init parse_crashkernel_suffix(char 
*cmdline,
 
/* check with suffix */
if (strncmp(cur, suffix, strlen(suffix))) {
-   pr_warn("crashkernel: unrecognized char\n");
+   pr_warn("crashkernel: unrecognized char: %c\n", *cur);
return -EINVAL;
}
cur += strlen(suffix);
if (*cur != ' ' && *cur != '\0') {
-   pr_warn("crashkernel: unrecognized char\n");
+   pr_warn("crashkernel: unrecognized char: %c\n", *cur);
return -EINVAL;
}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[tip:ras/core] kexec/crash: Say which char is the unrecognized

[tip-bot for Borislav Petkov]

Commit-ID:  53b90c0c56b502056da83d768047dcf765bac9fb
Gitweb: http://git.kernel.org/tip/53b90c0c56b502056da83d768047dcf765bac9fb
Author: Borislav Petkov 
AuthorDate: Mon, 19 Oct 2015 11:17:47 +0200
Committer:  Ingo Molnar 
CommitDate: Wed, 21 Oct 2015 11:10:57 +0200

kexec/crash: Say which char is the unrecognized

It is helpful when the crashkernel cmdline parsing routines
actually say which character is the unrecognized one. Make them
do so.

Signed-off-by: Borislav Petkov 
Reviewed-by: Dave Young 
Reviewed-by: Joerg Roedel 
Cc: Andrew Morton 
Cc: Andy Lutomirski 
Cc: Baoquan He 
Cc: H. Peter Anvin 
Cc: Jiri Kosina 
Cc: Juergen Gross 
Cc: Linus Torvalds 
Cc: Mark Salter 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: Vivek Goyal 
Cc: WANG Chao 
Cc: jerry_hoem...@hp.com
Link: http://lkml.kernel.org/r/1445246268-26285-8-git-send-email...@alien8.de
Signed-off-by: Ingo Molnar 
---
 kernel/kexec_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 201b453..bd9f8a0 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -1149,7 +1149,7 @@ static int __init parse_crashkernel_simple(char *cmdline,
if (*cur == '@')
*crash_base = memparse(cur+1, );
else if (*cur != ' ' && *cur != '\0') {
-   pr_warn("crashkernel: unrecognized char\n");
+   pr_warn("crashkernel: unrecognized char: %c\n", *cur);
return -EINVAL;
}
 
@@ -1186,12 +1186,12 @@ static int __init parse_crashkernel_suffix(char 
*cmdline,
 
/* check with suffix */
if (strncmp(cur, suffix, strlen(suffix))) {
-   pr_warn("crashkernel: unrecognized char\n");
+   pr_warn("crashkernel: unrecognized char: %c\n", *cur);
return -EINVAL;
}
cur += strlen(suffix);
if (*cur != ' ' && *cur != '\0') {
-   pr_warn("crashkernel: unrecognized char\n");
+   pr_warn("crashkernel: unrecognized char: %c\n", *cur);
return -EINVAL;
}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/