Re: [uml-devel] [PATCH 3/6] UML - Userspace files should call libc directly
On venerdì 17 agosto 2007, Jeff Dike wrote: > A number of files that were changed in the recent removal of tt mode > are userspace files which call the os_* wrappers instead of calling > libc directly. A few other files were affected by this, through > os_print_error has no remaining callers, so it is deleted. Actually, os_print_error() (or some other interface to perror()) should be reintroduced and used more for error messages (and also strsignal() should be, for "Kernel mode signal N"). Problem debugging is hard, but there is no reason make it harder (or rather, not to simplify it for users). Btw, the inlined abs() call is not very nice; on the other hand, it's a simple solution to make it robust, and we do not to be extra-optimal on these debug code paths. Bye -- "Doh!" (cit.), I've made another mistake! Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 http://www.user-mode-linux.org/~blaisorblade signature.asc Description: This is a digitally signed message part.
Re: [uml-devel] [PATCH 3/6] UML - Userspace files should call libc directly
On venerdì 17 agosto 2007, Jeff Dike wrote: A number of files that were changed in the recent removal of tt mode are userspace files which call the os_* wrappers instead of calling libc directly. A few other files were affected by this, through os_print_error has no remaining callers, so it is deleted. Actually, os_print_error() (or some other interface to perror()) should be reintroduced and used more for error messages (and also strsignal() should be, for Kernel mode signal N). Problem debugging is hard, but there is no reason make it harder (or rather, not to simplify it for users). Btw, the inlined abs() call is not very nice; on the other hand, it's a simple solution to make it robust, and we do not to be extra-optimal on these debug code paths. Bye -- Doh! (cit.), I've made another mistake! Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 http://www.user-mode-linux.org/~blaisorblade signature.asc Description: This is a digitally signed message part.