Re: ACPI EC warnings

2006-12-24 Thread Ismail Dönmez
24 Ara 2006 Paz 23:19 tarihinde, Guillaume Chazarain şunları yazmıştı: 
> > Patch looks nice,
>
> But LKML didn't like gmail's HTML so here is it again. Hopefully this
> one will pass.

I think this one didn't pass either :-/

> > btw do you notice any skippy behaviour? i.e sound skips when
> > I get this warning
>
> No, in my case I just get the message: ACPI: EC: evaluating _Q20
>
> > or something else is broken and I blame ACPI because its
> > flooding dmesg =)
>
> I happen to have at the moment some other debugging printk, flooding
> my logs, and sound doesn't skip either :-) Asus V6VA - Pentium-M 2GHz here.

Yeah the warning seems unrelated to skips.

Regards,
ismail

-- 
2 + 2 = 5 for very large values of 2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: ACPI EC warnings

2006-12-24 Thread Guillaume Chazarain



Patch looks nice,
But LKML didn't like gmail's HTML so here is it again. Hopefully this 
one will pass.


btw do you notice any skippy behaviour? i.e sound skips when 
I get this warning


No, in my case I just get the message: ACPI: EC: evaluating _Q20
or something else is broken and I blame ACPI because its 
flooding dmesg =)
  

I happen to have at the moment some other debugging printk, flooding
my logs, and sound doesn't skip either :-) Asus V6VA - Pentium-M 2GHz here.

--
Guillaume

diff -r ef50bfb54157 drivers/acpi/ec.c
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -424,7 +424,7 @@ static void acpi_ec_gpe_query(void *ec_c
 
 	snprintf(object_name, 8, "_Q%2.2X", value);
 
-	printk(KERN_INFO PREFIX "evaluating %s\n", object_name);
+	ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Evaluating %s", object_name));
 
 	acpi_evaluate_object(ec->handle, object_name, NULL, NULL);
 }



Re: ACPI EC warnings

2006-12-24 Thread Ismail Dönmez
24 Ara 2006 Paz 23:02 tarihinde, Guillaume Chazarain şunları yazmıştı: 
> 2006/12/24, Ismail Donmez <[EMAIL PROTECTED]>:
> > ACPI: EC: evaluating _Q60
>
> Same thing here, I think it is caused by
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=comm
>it;h=af3fd1404fd4f0f58ebbb52b22be4f1ca0794cda
>
> The attached patch restores the previous behaviour.

Patch looks nice, btw do you notice any skippy behaviour? i.e sound skips when 
I get this warning or something else is broken and I blame ACPI because its 
flooding dmesg =)

Regards,
ismail

-- 
2 + 2 = 5 for very large values of 2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: ACPI EC warnings

2006-12-24 Thread Ismail Dönmez
24 Ara 2006 Paz 23:02 tarihinde, Guillaume Chazarain şunları yazmıştı: 
 2006/12/24, Ismail Donmez [EMAIL PROTECTED]:
  ACPI: EC: evaluating _Q60

 Same thing here, I think it is caused by
 http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=comm
it;h=af3fd1404fd4f0f58ebbb52b22be4f1ca0794cda

 The attached patch restores the previous behaviour.

Patch looks nice, btw do you notice any skippy behaviour? i.e sound skips when 
I get this warning or something else is broken and I blame ACPI because its 
flooding dmesg =)

Regards,
ismail

-- 
2 + 2 = 5 for very large values of 2
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: ACPI EC warnings

2006-12-24 Thread Guillaume Chazarain



Patch looks nice,
But LKML didn't like gmail's HTML so here is it again. Hopefully this 
one will pass.


btw do you notice any skippy behaviour? i.e sound skips when 
I get this warning


No, in my case I just get the message: ACPI: EC: evaluating _Q20
or something else is broken and I blame ACPI because its 
flooding dmesg =)
  

I happen to have at the moment some other debugging printk, flooding
my logs, and sound doesn't skip either :-) Asus V6VA - Pentium-M 2GHz here.

--
Guillaume

diff -r ef50bfb54157 drivers/acpi/ec.c
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -424,7 +424,7 @@ static void acpi_ec_gpe_query(void *ec_c
 
 	snprintf(object_name, 8, _Q%2.2X, value);
 
-	printk(KERN_INFO PREFIX evaluating %s\n, object_name);
+	ACPI_DEBUG_PRINT((ACPI_DB_INFO, Evaluating %s, object_name));
 
 	acpi_evaluate_object(ec-handle, object_name, NULL, NULL);
 }



Re: ACPI EC warnings

2006-12-24 Thread Ismail Dönmez
24 Ara 2006 Paz 23:19 tarihinde, Guillaume Chazarain şunları yazmıştı: 
  Patch looks nice,

 But LKML didn't like gmail's HTML so here is it again. Hopefully this
 one will pass.

I think this one didn't pass either :-/

  btw do you notice any skippy behaviour? i.e sound skips when
  I get this warning

 No, in my case I just get the message: ACPI: EC: evaluating _Q20

  or something else is broken and I blame ACPI because its
  flooding dmesg =)

 I happen to have at the moment some other debugging printk, flooding
 my logs, and sound doesn't skip either :-) Asus V6VA - Pentium-M 2GHz here.

Yeah the warning seems unrelated to skips.

Regards,
ismail

-- 
2 + 2 = 5 for very large values of 2
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/