Re: FIX Me in pgtable.h
On 14-09-23 11:21 PM, Laura Abbott wrote: > On 9/23/2014 6:04 AM, nick wrote: >> Greetings Arm Maintainers, >> I am wondering about the fix me in pgtable.h for define kern_addr_valid and >> how to set it to a correct >> value as you state that this needs to be fixed as the defined macro is still >> 1. This is probably incorrect >> and should be changed. >> Thanks, >> Nick >> > > It's not clear to me how valuable fixing kern_addr_valid would actually > be for arm. It seems to be used in exactly one place, fs/proc/kcore.c > and the associated Kconfig is explicitly marked if !ARM. Nearly all > other archs minus x86, arm64 and sparc are in the same boat as well. > > Thanks, > Laura > Laura, Can we remove it then as it seems that it's not needed at all. Cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: FIX Me in pgtable.h
On 14-09-23 11:21 PM, Laura Abbott wrote: On 9/23/2014 6:04 AM, nick wrote: Greetings Arm Maintainers, I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed. Thanks, Nick It's not clear to me how valuable fixing kern_addr_valid would actually be for arm. It seems to be used in exactly one place, fs/proc/kcore.c and the associated Kconfig is explicitly marked if !ARM. Nearly all other archs minus x86, arm64 and sparc are in the same boat as well. Thanks, Laura Laura, Can we remove it then as it seems that it's not needed at all. Cheers Nick -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: FIX Me in pgtable.h
On 9/23/2014 6:04 AM, nick wrote: Greetings Arm Maintainers, I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed. Thanks, Nick It's not clear to me how valuable fixing kern_addr_valid would actually be for arm. It seems to be used in exactly one place, fs/proc/kcore.c and the associated Kconfig is explicitly marked if !ARM. Nearly all other archs minus x86, arm64 and sparc are in the same boat as well. Thanks, Laura -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: FIX Me in pgtable.h
I don't have any hardware to test this over, however I can emulate a arm system over qemu if needed. I was just trying to help out if we need hardware I can't test and again I am sorry for the terrible patches. It was never my goal to be a nuisance. Nick On Tue, Sep 23, 2014 at 9:46 AM, Krzysztof Kozłowski wrote: > On 23.09.2014 15:04, nick wrote: >> >> Greetings Arm Maintainers, >> I am wondering about the fix me in pgtable.h for define kern_addr_valid >> and how to set it to a correct >> value as you state that this needs to be fixed as the defined macro is >> still 1. This is probably incorrect >> and should be changed. > > > Dear Nick Krause, > > Before you start coding - do you have necessary ARM-based hardware to test > your changes? > > Changing email won't remove LKML archives... > > Best regards, > Krzysztof > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: FIX Me in pgtable.h
On 23.09.2014 15:04, nick wrote: Greetings Arm Maintainers, I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed. Dear Nick Krause, Before you start coding - do you have necessary ARM-based hardware to test your changes? Changing email won't remove LKML archives... Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
FIX Me in pgtable.h
Greetings Arm Maintainers, I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed. Thanks, Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
FIX Me in pgtable.h
Greetings Arm Maintainers, I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed. Thanks, Nick -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: FIX Me in pgtable.h
On 23.09.2014 15:04, nick wrote: Greetings Arm Maintainers, I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed. Dear Nick Krause, Before you start coding - do you have necessary ARM-based hardware to test your changes? Changing email won't remove LKML archives... Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: FIX Me in pgtable.h
I don't have any hardware to test this over, however I can emulate a arm system over qemu if needed. I was just trying to help out if we need hardware I can't test and again I am sorry for the terrible patches. It was never my goal to be a nuisance. Nick On Tue, Sep 23, 2014 at 9:46 AM, Krzysztof Kozłowski k.kozlow...@samsung.com wrote: On 23.09.2014 15:04, nick wrote: Greetings Arm Maintainers, I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed. Dear Nick Krause, Before you start coding - do you have necessary ARM-based hardware to test your changes? Changing email won't remove LKML archives... Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: FIX Me in pgtable.h
On 9/23/2014 6:04 AM, nick wrote: Greetings Arm Maintainers, I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect and should be changed. Thanks, Nick It's not clear to me how valuable fixing kern_addr_valid would actually be for arm. It seems to be used in exactly one place, fs/proc/kcore.c and the associated Kconfig is explicitly marked if !ARM. Nearly all other archs minus x86, arm64 and sparc are in the same boat as well. Thanks, Laura -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
FIX ME in pgtable.h
There is a fix me message I am hitting with cscope on line 317 of this file about #define kern_addr_valid(addr) (1) not being correct. I am wondering what value this should be set to. Thanks for the advice so I can remove this fix me from the kernel. Cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
FIX ME in pgtable.h
There is a fix me message I am hitting with cscope on line 317 of this file about #define kern_addr_valid(addr) (1) not being correct. I am wondering what value this should be set to. Thanks for the advice so I can remove this fix me from the kernel. Cheers Nick -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
