FireWire/ nosy compile error (was gre...@linuxfoundation.org linux-kernel@vger.kernel.org)

2016-11-14 Thread Stefan Richter
On Nov 14 Karatas Ozgur wrote:
> Hi,
> 
> I fixed compile error, not include to FIREWIRE variable and only PCI return 
> an error.
> 
> 
> diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
> 
> index 145974f..60e5a8c 100644
> --- a/drivers/firewire/Kconfig
> +++ b/drivers/firewire/Kconfig
> @@ -57,7 +57,7 @@ config FIREWIRE_NET
> 
> config FIREWIRE_NOSY
> tristate "Nosy - a FireWire traffic sniffer for PCILynx cards"
> -   depends on PCI
> +   depends on FIREWIRE && PCI
> help
>   Nosy is an IEEE 1394 packet sniffer that is used for protocol
>   analysis and in development of IEEE 1394 drivers, applications,

This is wrong.  The variable FIREWIRE enables the firewire-core driver.
But nosy is a stand-alone driver which does not depend on firewire-core.

Please tell us what your compile error was (and on what platform), so that
we can find out which dependency was really missing, if any.
-- 
Stefan Richter
-==- =-== -===-
http://arcgraph.de/sr/


FireWire/ nosy compile error (was gre...@linuxfoundation.org linux-kernel@vger.kernel.org)

2016-11-14 Thread Stefan Richter
On Nov 14 Karatas Ozgur wrote:
> Hi,
> 
> I fixed compile error, not include to FIREWIRE variable and only PCI return 
> an error.
> 
> 
> diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
> 
> index 145974f..60e5a8c 100644
> --- a/drivers/firewire/Kconfig
> +++ b/drivers/firewire/Kconfig
> @@ -57,7 +57,7 @@ config FIREWIRE_NET
> 
> config FIREWIRE_NOSY
> tristate "Nosy - a FireWire traffic sniffer for PCILynx cards"
> -   depends on PCI
> +   depends on FIREWIRE && PCI
> help
>   Nosy is an IEEE 1394 packet sniffer that is used for protocol
>   analysis and in development of IEEE 1394 drivers, applications,

This is wrong.  The variable FIREWIRE enables the firewire-core driver.
But nosy is a stand-alone driver which does not depend on firewire-core.

Please tell us what your compile error was (and on what platform), so that
we can find out which dependency was really missing, if any.
-- 
Stefan Richter
-==- =-== -===-
http://arcgraph.de/sr/