[PATCH] Fix Irq Subsystem menu
Hi; In menuconfig, General setup -> Irq subsystem contains two possible menu-items. Sometimes, neither menu-item exists. This patch prevents the Irq susystem menu from appearing at all unless it will contain at least one menu-item, preventing a confusing, empty menu. --- linux-3.7-rc8/kernel/irq/Kconfig.orig 2012-12-05 20:59:00.963707538 -0500 +++ linux-3.7-rc8/kernel/irq/Kconfig2012-12-05 21:00:18.454788693 -0500 @@ -3,7 +3,6 @@ config HAVE_GENERIC_HARDIRQS bool if HAVE_GENERIC_HARDIRQS -menu "IRQ subsystem" # # Interrupt subsystem related configuration options # @@ -56,6 +55,13 @@ config GENERIC_IRQ_CHIP config IRQ_DOMAIN bool +# Support forced irq threading +config IRQ_FORCED_THREADING + bool + +menu "IRQ subsystem" + depends on ( IRQ_DOMAIN && DEBUG_FS ) || MAY_HAVE_SPARSE_IRQ + config IRQ_DOMAIN_DEBUG bool "Expose hardware/virtual IRQ mapping via debugfs" depends on IRQ_DOMAIN && DEBUG_FS @@ -66,10 +72,6 @@ config IRQ_DOMAIN_DEBUG If you don't know what this means you don't need it. -# Support forced irq threading -config IRQ_FORCED_THREADING - bool - config SPARSE_IRQ bool "Support sparse irq numbering" if MAY_HAVE_SPARSE_IRQ ---help--- Signed-off-by: Paul Thompson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: IRQ subsystem menu
On Wed, 5 Dec 2012 21:16:20 -0500, Paul Thompson wrote: > Grant Likely , on Thu 2012.11.29 said: > > On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek wrote: > > > (Adding lkml and Thomas as IRQ subsystem maintainer to CC) > > > > > > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: > > > > Hi; > > > > > > > > In menuconfig, General setup -> IRQ subsystem, there are two > > > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other > > > > on MAY_HAVE_SPARSE_IRQ. > > > > > [...] > > > > > > > > Ideally, the "IRQ subsystem" menu would not even show up > > > > if it would contain no menu-items, but I do not know enough to > > > > formulate that constraint. > > > > First, move the 'menu "IRQ subsystem"' line does to right before the > > IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you > > can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right > > below the menu item. > > > > You'll also need to move the IRQ_FORCED_THREADING line out from inside > > the menu block. > > > > Try it out and let me know how it goes. > > > > g. > > Hi; > > The logic makes sense to me, and makes the menus appearance > dependent on if either option setting can exist. So, on my system, > the IRQ subsystem menu does not appear. > > Paul Looks right to me. Please repost with a proper commit log and "Signed-off-by" line and I'll apply this patch. (See Documentation/SubmittingPatches) g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: IRQ subsystem menu
On Wed, 5 Dec 2012 21:16:20 -0500, Paul Thompson set48...@gmail.com wrote: Grant Likely grant.lik...@secretlab.ca, on Thu 2012.11.29 said: On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek mma...@suse.cz wrote: (Adding lkml and Thomas as IRQ subsystem maintainer to CC) On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: Hi; In menuconfig, General setup - IRQ subsystem, there are two possible menu-items. One depends partly on IRQ_DOMAIN, and the other on MAY_HAVE_SPARSE_IRQ. [...] Ideally, the IRQ subsystem menu would not even show up if it would contain no menu-items, but I do not know enough to formulate that constraint. First, move the 'menu IRQ subsystem' line does to right before the IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you can add a depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN line right below the menu item. You'll also need to move the IRQ_FORCED_THREADING line out from inside the menu block. Try it out and let me know how it goes. g. Hi; The logic makes sense to me, and makes the menus appearance dependent on if either option setting can exist. So, on my system, the IRQ subsystem menu does not appear. Paul Looks right to me. Please repost with a proper commit log and Signed-off-by line and I'll apply this patch. (See Documentation/SubmittingPatches) g. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Fix Irq Subsystem menu
Hi; In menuconfig, General setup - Irq subsystem contains two possible menu-items. Sometimes, neither menu-item exists. This patch prevents the Irq susystem menu from appearing at all unless it will contain at least one menu-item, preventing a confusing, empty menu. --- linux-3.7-rc8/kernel/irq/Kconfig.orig 2012-12-05 20:59:00.963707538 -0500 +++ linux-3.7-rc8/kernel/irq/Kconfig2012-12-05 21:00:18.454788693 -0500 @@ -3,7 +3,6 @@ config HAVE_GENERIC_HARDIRQS bool if HAVE_GENERIC_HARDIRQS -menu IRQ subsystem # # Interrupt subsystem related configuration options # @@ -56,6 +55,13 @@ config GENERIC_IRQ_CHIP config IRQ_DOMAIN bool +# Support forced irq threading +config IRQ_FORCED_THREADING + bool + +menu IRQ subsystem + depends on ( IRQ_DOMAIN DEBUG_FS ) || MAY_HAVE_SPARSE_IRQ + config IRQ_DOMAIN_DEBUG bool Expose hardware/virtual IRQ mapping via debugfs depends on IRQ_DOMAIN DEBUG_FS @@ -66,10 +72,6 @@ config IRQ_DOMAIN_DEBUG If you don't know what this means you don't need it. -# Support forced irq threading -config IRQ_FORCED_THREADING - bool - config SPARSE_IRQ bool Support sparse irq numbering if MAY_HAVE_SPARSE_IRQ ---help--- Signed-off-by: Paul Thompson set.mailingl...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: IRQ subsystem menu
Grant Likely , on Thu 2012.11.29 said: > On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek wrote: > > (Adding lkml and Thomas as IRQ subsystem maintainer to CC) > > > > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: > > > Hi; > > > > > > In menuconfig, General setup -> IRQ subsystem, there are two > > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other > > > on MAY_HAVE_SPARSE_IRQ. > > > [...] > > > > > > Ideally, the "IRQ subsystem" menu would not even show up > > > if it would contain no menu-items, but I do not know enough to > > > formulate that constraint. > > First, move the 'menu "IRQ subsystem"' line does to right before the > IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you > can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right > below the menu item. > > You'll also need to move the IRQ_FORCED_THREADING line out from inside > the menu block. > > Try it out and let me know how it goes. > > g. Hi; The logic makes sense to me, and makes the menus appearance dependent on if either option setting can exist. So, on my system, the IRQ subsystem menu does not appear. Paul See if this attached patch looks right: --- linux-3.7-rc8/kernel/irq/Kconfig.orig 2012-12-05 20:59:00.963707538 -0500 +++ linux-3.7-rc8/kernel/irq/Kconfig2012-12-05 21:00:18.454788693 -0500 @@ -3,7 +3,6 @@ config HAVE_GENERIC_HARDIRQS bool if HAVE_GENERIC_HARDIRQS -menu "IRQ subsystem" # # Interrupt subsystem related configuration options # @@ -56,6 +55,13 @@ config GENERIC_IRQ_CHIP config IRQ_DOMAIN bool +# Support forced irq threading +config IRQ_FORCED_THREADING + bool + +menu "IRQ subsystem" + depends on ( IRQ_DOMAIN && DEBUG_FS ) || MAY_HAVE_SPARSE_IRQ + config IRQ_DOMAIN_DEBUG bool "Expose hardware/virtual IRQ mapping via debugfs" depends on IRQ_DOMAIN && DEBUG_FS @@ -66,10 +72,6 @@ config IRQ_DOMAIN_DEBUG If you don't know what this means you don't need it. -# Support forced irq threading -config IRQ_FORCED_THREADING - bool - config SPARSE_IRQ bool "Support sparse irq numbering" if MAY_HAVE_SPARSE_IRQ ---help---
Re: IRQ subsystem menu
Grant Likely grant.lik...@secretlab.ca, on Thu 2012.11.29 said: On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek mma...@suse.cz wrote: (Adding lkml and Thomas as IRQ subsystem maintainer to CC) On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: Hi; In menuconfig, General setup - IRQ subsystem, there are two possible menu-items. One depends partly on IRQ_DOMAIN, and the other on MAY_HAVE_SPARSE_IRQ. [...] Ideally, the IRQ subsystem menu would not even show up if it would contain no menu-items, but I do not know enough to formulate that constraint. First, move the 'menu IRQ subsystem' line does to right before the IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you can add a depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN line right below the menu item. You'll also need to move the IRQ_FORCED_THREADING line out from inside the menu block. Try it out and let me know how it goes. g. Hi; The logic makes sense to me, and makes the menus appearance dependent on if either option setting can exist. So, on my system, the IRQ subsystem menu does not appear. Paul See if this attached patch looks right: --- linux-3.7-rc8/kernel/irq/Kconfig.orig 2012-12-05 20:59:00.963707538 -0500 +++ linux-3.7-rc8/kernel/irq/Kconfig2012-12-05 21:00:18.454788693 -0500 @@ -3,7 +3,6 @@ config HAVE_GENERIC_HARDIRQS bool if HAVE_GENERIC_HARDIRQS -menu IRQ subsystem # # Interrupt subsystem related configuration options # @@ -56,6 +55,13 @@ config GENERIC_IRQ_CHIP config IRQ_DOMAIN bool +# Support forced irq threading +config IRQ_FORCED_THREADING + bool + +menu IRQ subsystem + depends on ( IRQ_DOMAIN DEBUG_FS ) || MAY_HAVE_SPARSE_IRQ + config IRQ_DOMAIN_DEBUG bool Expose hardware/virtual IRQ mapping via debugfs depends on IRQ_DOMAIN DEBUG_FS @@ -66,10 +72,6 @@ config IRQ_DOMAIN_DEBUG If you don't know what this means you don't need it. -# Support forced irq threading -config IRQ_FORCED_THREADING - bool - config SPARSE_IRQ bool Support sparse irq numbering if MAY_HAVE_SPARSE_IRQ ---help---
Re: IRQ subsystem menu
On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek wrote: > (Adding lkml and Thomas as IRQ subsystem maintainer to CC) > > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: > > Hi; > > > > In menuconfig, General setup -> IRQ subsystem, there are two > > possible menu-items. One depends partly on IRQ_DOMAIN, and the other > > on MAY_HAVE_SPARSE_IRQ. > > > > On the x86-64 arch, neither of these seems to be set, so the > > menu entry is blank if entered (displaying an odd ^@ if you try to > > navigate up or down. And sometimes some screen garbage on the sides.) > > > > Previously (in the 3.2 kernel at least) this menu used to be > > populated by the "Support sparse IRQ numbering" menu-item, which > > at that time depended on HAVE_SPARSE_IRQ, and was forced to YES. > > > > I do not know if the current behaviour is intended, but it > > is ugly and confusing to be confronted with a blank menu page. > > > > Ideally, the "IRQ subsystem" menu would not even show up > > if it would contain no menu-items, but I do not know enough to > > formulate that constraint. First, move the 'menu "IRQ subsystem"' line does to right before the IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you can add a "depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN" line right below the menu item. You'll also need to move the IRQ_FORCED_THREADING line out from inside the menu block. Try it out and let me know how it goes. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: IRQ subsystem menu
On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek mma...@suse.cz wrote: (Adding lkml and Thomas as IRQ subsystem maintainer to CC) On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: Hi; In menuconfig, General setup - IRQ subsystem, there are two possible menu-items. One depends partly on IRQ_DOMAIN, and the other on MAY_HAVE_SPARSE_IRQ. On the x86-64 arch, neither of these seems to be set, so the menu entry is blank if entered (displaying an odd ^@ if you try to navigate up or down. And sometimes some screen garbage on the sides.) Previously (in the 3.2 kernel at least) this menu used to be populated by the Support sparse IRQ numbering menu-item, which at that time depended on HAVE_SPARSE_IRQ, and was forced to YES. I do not know if the current behaviour is intended, but it is ugly and confusing to be confronted with a blank menu page. Ideally, the IRQ subsystem menu would not even show up if it would contain no menu-items, but I do not know enough to formulate that constraint. First, move the 'menu IRQ subsystem' line does to right before the IRQ_DOMAIN_DEBUG line so that it wraps the options that matter, then you can add a depends on MAY_HAVE_SPARSE_IRQ || IRQ_DOMAIN line right below the menu item. You'll also need to move the IRQ_FORCED_THREADING line out from inside the menu block. Try it out and let me know how it goes. g. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: IRQ subsystem menu
(Adding lkml and Thomas as IRQ subsystem maintainer to CC) On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: > Hi; > > In menuconfig, General setup -> IRQ subsystem, there are two > possible menu-items. One depends partly on IRQ_DOMAIN, and the other > on MAY_HAVE_SPARSE_IRQ. > > On the x86-64 arch, neither of these seems to be set, so the > menu entry is blank if entered (displaying an odd ^@ if you try to > navigate up or down. And sometimes some screen garbage on the sides.) > > Previously (in the 3.2 kernel at least) this menu used to be > populated by the "Support sparse IRQ numbering" menu-item, which > at that time depended on HAVE_SPARSE_IRQ, and was forced to YES. > > I do not know if the current behaviour is intended, but it > is ugly and confusing to be confronted with a blank menu page. > > Ideally, the "IRQ subsystem" menu would not even show up > if it would contain no menu-items, but I do not know enough to > formulate that constraint. > > A simple alternative is a comment section to reasure babes in > the wood of kernel configuration that something is not amiss. I include > a sample patch. > > Paul > set.mailingl...@gmail.com > --- linux-3.7-rc2/kernel/irq/Kconfig.orig 2012-10-20 15:11:32.0 > -0400 > +++ linux-3.7-rc2/kernel/irq/Kconfig 2012-10-21 03:14:56.272952813 -0400 > @@ -4,6 +4,9 @@ config HAVE_GENERIC_HARDIRQS > > if HAVE_GENERIC_HARDIRQS > menu "IRQ subsystem" > + > +comment "Some configurations may have no available options here" > + > # > # Interrupt subsystem related configuration options > # -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: IRQ subsystem menu
(Adding lkml and Thomas as IRQ subsystem maintainer to CC) On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: Hi; In menuconfig, General setup - IRQ subsystem, there are two possible menu-items. One depends partly on IRQ_DOMAIN, and the other on MAY_HAVE_SPARSE_IRQ. On the x86-64 arch, neither of these seems to be set, so the menu entry is blank if entered (displaying an odd ^@ if you try to navigate up or down. And sometimes some screen garbage on the sides.) Previously (in the 3.2 kernel at least) this menu used to be populated by the Support sparse IRQ numbering menu-item, which at that time depended on HAVE_SPARSE_IRQ, and was forced to YES. I do not know if the current behaviour is intended, but it is ugly and confusing to be confronted with a blank menu page. Ideally, the IRQ subsystem menu would not even show up if it would contain no menu-items, but I do not know enough to formulate that constraint. A simple alternative is a comment section to reasure babes in the wood of kernel configuration that something is not amiss. I include a sample patch. Paul set.mailingl...@gmail.com --- linux-3.7-rc2/kernel/irq/Kconfig.orig 2012-10-20 15:11:32.0 -0400 +++ linux-3.7-rc2/kernel/irq/Kconfig 2012-10-21 03:14:56.272952813 -0400 @@ -4,6 +4,9 @@ config HAVE_GENERIC_HARDIRQS if HAVE_GENERIC_HARDIRQS menu IRQ subsystem + +comment Some configurations may have no available options here + # # Interrupt subsystem related configuration options # -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
