Re: Linux 2.6.11-rc4 (compile stats)
Linux 2.6 Compile Statistics (gcc 3.4.1) Web page with links to complete details: http://developer.osdl.org/cherry/compile/ Kernel bzImagebzImage bzImage modules bzImage modules (defconfig) (allno) (allyes) (allyes) (allmod) (allmod) --- --- - 2.6.11-rc314w/0e 0w/0e 353w/0e6w/0e 18w/0e431w/0e 2.6.11-rc313w/0e 0w/0e 356w/0e6w/0e 18w/0e435w/0e 2.6.11-rc218w/0e 0w/0e 365w/0e6w/0e 22w/0e440w/0e 2.6.11-rc120w/0e 0w/0e 497w/0e6w/0e 22w/0e577w/0e 2.6.1013w/0e 0w/0e 778w/0e6w/0e 15w/0e861w/0e 2.6.9-rc3 13w/0e 0w/0e 774w/0e6w/0e 15w/0e857w/0e 2.6.9-rc2 14w/0e 0w/0e 1815w/11e 65w/0e 19w/0e 2157w/0e (Compiles with gcc 3.2.2) 2.6.9-rc1 5w/0e 1w/0e 1069w/15e 6w/0e 4w/0e 1062w/1e 2.6.9 0w/0e 0w/0e 1930w/0e 41w/0e 11w/0e 1950w/0e 2.6.9-final0w/0e 0w/0e 1930w/0e 41w/0e 11w/0e 1950w/0e 2.6.9-rc4 0w/0e 0w/0e 1930w/0e 41w/0e 11w/0e 1950w/0e 2.6.9-rc3 0w/0e 0w/0e 2752w/17e 41w/0e 11w/0e 2782w/5e 2.6.9-rc2 0w/0e 0w/0e 3036w/0e 41w/0e 11w/0e 3655w/0e 2.6.9-rc1 0w/0e 0w/0e77w/10e 4w/0e 3w/0e 68w/0e 2.6.8.10w/0e 0w/0e78w/ 0e 4w/0e 1w/0e 72w/0e 2.6.8 0w/0e 0w/0e78w/ 0e 4w/0e 1w/0e 72w/0e 2.6.8-rc4 0w/0e 0w/0e78w/ 0e 4w/0e 1w/0e 72w/0e 2.6.8-rc3 0w/0e 0w/0e78w/ 0e 4w/0e 1w/0e 72w/0e 2.6.8-rc2 0w/0e 0w/0e85w/ 0e 5w/0e 1w/0e 79w/0e 2.6.8-rc1 0w/0e 0w/0e87w/ 0e 5w/0e 1w/0e 82w/0e 2.6.7 0w/0e 0w/0e 108w/ 0e 5w/0e 2w/0e102w/0e 2.6.7-rc3 0w/0e 0w/0e 108w/ 0e 5w/0e 2w/0e104w/0e 2.6.7-rc2 0w/0e 0w/0e 110w/ 0e 5w/0e 2w/0e106w/0e 2.6.7-rc1 0w/0e 0w/0e 111w/ 0e 6w/0e 2w/0e107w/0e 2.6.6 0w/0e 0w/0e 123w/ 0e 7w/0e 4w/0e121w/0e 2.6.6-rc3 0w/0e 0w/0e 124w/ 0e 7w/0e 5w/0e121w/0e 2.6.6-rc2 0w/0e 0w/0e 122w/ 0e 7w/0e 4w/0e121w/0e 2.6.6-rc1 0w/0e 0w/0e 125w/ 0e 7w/0e 4w/0e123w/0e 2.6.5 0w/0e 0w/0e 134w/ 0e 8w/0e 4w/0e132w/0e 2.6.5-rc3 0w/0e 0w/0e 135w/ 0e 8w/0e 4w/0e132w/0e 2.6.5-rc2 0w/0e 0w/0e 135w/ 0e 8w/0e 3w/0e132w/0e 2.6.5-rc1 0w/0e 0w/0e 138w/ 0e 8w/0e 3w/0e135w/0e 2.6.4 1w/0e 0w/0e 145w/ 0e 7w/0e 3w/0e142w/0e 2.6.4-rc2 1w/0e 0w/0e 148w/ 0e 7w/0e 3w/0e145w/0e 2.6.4-rc1 1w/0e 0w/0e 148w/ 0e 7w/0e 3w/0e145w/0e 2.6.3 1w/0e 0w/0e 142w/ 0e 9w/0e 3w/0e142w/0e 2.6.3-rc4 1w/0e 0w/0e 142w/ 0e 9w/0e 3w/0e142w/0e 2.6.3-rc3 1w/0e 0w/0e 145w/ 7e 9w/0e 3w/0e148w/0e 2.6.3-rc2 1w/0e 0w/0e 141w/ 0e 9w/0e 3w/0e144w/0e 2.6.3-rc1 1w/0e 0w/0e 145w/ 0e 9w/0e 3w/0e177w/0e 2.6.2 1w/0e 0w/0e 152w/ 0e 12w/0e 3w/0e187w/0e 2.6.2-rc3 0w/0e 0w/0e 152w/ 0e 12w/0e 3w/0e187w/0e 2.6.2-rc2 0w/0e 0w/0e 153w/ 8e 12w/0e 3w/0e188w/0e 2.6.2-rc1 0w/0e 0w/0e 152w/ 0e 12w/0e 3w/0e187w/0e 2.6.1 0w/0e 0w/0e 158w/ 0e 12w/0e 3w/0e197w/0e 2.6.1-rc3 0w/0e 0w/0e 158w/ 0e 12w/0e 3w/0e197w/0e 2.6.1-rc2 0w/0e 0w/0e 166w/ 0e 12w/0e 3w/0e205w/0e 2.6.1-rc1 0w/0e 0w/0e 167w/ 0e 12w/0e 3w/0e206w/0e 2.6.0 0w/0e 0w/0e 170w/ 0e 12w/0e 3w/0e209w/0e Daily compiles (ia32): http://developer.osdl.org/cherry/compile/2.6/linus-tree/running.txt Latest changes in Linus' bitkeeper tree: http://linux.bkbits.net:8080/linux-2.5 John - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.11-rc4 (compile stats)
Linux 2.6 Compile Statistics (gcc 3.4.1) Web page with links to complete details: http://developer.osdl.org/cherry/compile/ Kernel bzImagebzImage bzImage modules bzImage modules (defconfig) (allno) (allyes) (allyes) (allmod) (allmod) --- --- - 2.6.11-rc314w/0e 0w/0e 353w/0e6w/0e 18w/0e431w/0e 2.6.11-rc313w/0e 0w/0e 356w/0e6w/0e 18w/0e435w/0e 2.6.11-rc218w/0e 0w/0e 365w/0e6w/0e 22w/0e440w/0e 2.6.11-rc120w/0e 0w/0e 497w/0e6w/0e 22w/0e577w/0e 2.6.1013w/0e 0w/0e 778w/0e6w/0e 15w/0e861w/0e 2.6.9-rc3 13w/0e 0w/0e 774w/0e6w/0e 15w/0e857w/0e 2.6.9-rc2 14w/0e 0w/0e 1815w/11e 65w/0e 19w/0e 2157w/0e (Compiles with gcc 3.2.2) 2.6.9-rc1 5w/0e 1w/0e 1069w/15e 6w/0e 4w/0e 1062w/1e 2.6.9 0w/0e 0w/0e 1930w/0e 41w/0e 11w/0e 1950w/0e 2.6.9-final0w/0e 0w/0e 1930w/0e 41w/0e 11w/0e 1950w/0e 2.6.9-rc4 0w/0e 0w/0e 1930w/0e 41w/0e 11w/0e 1950w/0e 2.6.9-rc3 0w/0e 0w/0e 2752w/17e 41w/0e 11w/0e 2782w/5e 2.6.9-rc2 0w/0e 0w/0e 3036w/0e 41w/0e 11w/0e 3655w/0e 2.6.9-rc1 0w/0e 0w/0e77w/10e 4w/0e 3w/0e 68w/0e 2.6.8.10w/0e 0w/0e78w/ 0e 4w/0e 1w/0e 72w/0e 2.6.8 0w/0e 0w/0e78w/ 0e 4w/0e 1w/0e 72w/0e 2.6.8-rc4 0w/0e 0w/0e78w/ 0e 4w/0e 1w/0e 72w/0e 2.6.8-rc3 0w/0e 0w/0e78w/ 0e 4w/0e 1w/0e 72w/0e 2.6.8-rc2 0w/0e 0w/0e85w/ 0e 5w/0e 1w/0e 79w/0e 2.6.8-rc1 0w/0e 0w/0e87w/ 0e 5w/0e 1w/0e 82w/0e 2.6.7 0w/0e 0w/0e 108w/ 0e 5w/0e 2w/0e102w/0e 2.6.7-rc3 0w/0e 0w/0e 108w/ 0e 5w/0e 2w/0e104w/0e 2.6.7-rc2 0w/0e 0w/0e 110w/ 0e 5w/0e 2w/0e106w/0e 2.6.7-rc1 0w/0e 0w/0e 111w/ 0e 6w/0e 2w/0e107w/0e 2.6.6 0w/0e 0w/0e 123w/ 0e 7w/0e 4w/0e121w/0e 2.6.6-rc3 0w/0e 0w/0e 124w/ 0e 7w/0e 5w/0e121w/0e 2.6.6-rc2 0w/0e 0w/0e 122w/ 0e 7w/0e 4w/0e121w/0e 2.6.6-rc1 0w/0e 0w/0e 125w/ 0e 7w/0e 4w/0e123w/0e 2.6.5 0w/0e 0w/0e 134w/ 0e 8w/0e 4w/0e132w/0e 2.6.5-rc3 0w/0e 0w/0e 135w/ 0e 8w/0e 4w/0e132w/0e 2.6.5-rc2 0w/0e 0w/0e 135w/ 0e 8w/0e 3w/0e132w/0e 2.6.5-rc1 0w/0e 0w/0e 138w/ 0e 8w/0e 3w/0e135w/0e 2.6.4 1w/0e 0w/0e 145w/ 0e 7w/0e 3w/0e142w/0e 2.6.4-rc2 1w/0e 0w/0e 148w/ 0e 7w/0e 3w/0e145w/0e 2.6.4-rc1 1w/0e 0w/0e 148w/ 0e 7w/0e 3w/0e145w/0e 2.6.3 1w/0e 0w/0e 142w/ 0e 9w/0e 3w/0e142w/0e 2.6.3-rc4 1w/0e 0w/0e 142w/ 0e 9w/0e 3w/0e142w/0e 2.6.3-rc3 1w/0e 0w/0e 145w/ 7e 9w/0e 3w/0e148w/0e 2.6.3-rc2 1w/0e 0w/0e 141w/ 0e 9w/0e 3w/0e144w/0e 2.6.3-rc1 1w/0e 0w/0e 145w/ 0e 9w/0e 3w/0e177w/0e 2.6.2 1w/0e 0w/0e 152w/ 0e 12w/0e 3w/0e187w/0e 2.6.2-rc3 0w/0e 0w/0e 152w/ 0e 12w/0e 3w/0e187w/0e 2.6.2-rc2 0w/0e 0w/0e 153w/ 8e 12w/0e 3w/0e188w/0e 2.6.2-rc1 0w/0e 0w/0e 152w/ 0e 12w/0e 3w/0e187w/0e 2.6.1 0w/0e 0w/0e 158w/ 0e 12w/0e 3w/0e197w/0e 2.6.1-rc3 0w/0e 0w/0e 158w/ 0e 12w/0e 3w/0e197w/0e 2.6.1-rc2 0w/0e 0w/0e 166w/ 0e 12w/0e 3w/0e205w/0e 2.6.1-rc1 0w/0e 0w/0e 167w/ 0e 12w/0e 3w/0e206w/0e 2.6.0 0w/0e 0w/0e 170w/ 0e 12w/0e 3w/0e209w/0e Daily compiles (ia32): http://developer.osdl.org/cherry/compile/2.6/linus-tree/running.txt Latest changes in Linus' bitkeeper tree: http://linux.bkbits.net:8080/linux-2.5 John - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6] Check return value of copy_to_user in fs/cifs/file.c [Re: Linux 2.6.11-rc4]
Il Sun, Feb 13, 2005 at 06:28:38PM +0100, Marcel Sebek ha scritto:
> > @@ -1164,13 +1164,22 @@
> > current_read_size, *poffset,
> > _read, _read_data);
> >
> > + if (rc == -EAGAIN)
> > + continue;
> > + else
> > + break;
> > +
> > pSMBr = (struct smb_com_read_rsp *)smb_read_data;
> ^
> Perhaps this line and the following lines are never executed with your
> patch, am I right?
Yes, you are. Let's try again:
The following patch against 2.6.11-rc4 fixes this compile time
warning:
CC [M] fs/cifs/file.o
fs/cifs/file.c: In function `cifs_user_read':
fs/cifs/file.c:1168: warning: ignoring return value of
`copy_to_user', declared with attribute warn_unused_result
I also added an explicit check for errors other than -EAGAIN, since
CIFSSMBRead may return -ENOMEM if it's unable to allocate
smb_com_read_rsp; in that case we don't want to call copy_to_user with a
NULL pointer.
Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]>
--- a/fs/cifs/file.c2005-02-03 17:58:07.0 +0100
+++ b/fs/cifs/file.c2005-02-13 21:18:01.0 +0100
@@ -1151,7 +1151,7 @@
current_read_size = min_t(const int,read_size -
total_read,cifs_sb->rsize);
rc = -EAGAIN;
smb_read_data = NULL;
- while(rc == -EAGAIN) {
+ while(1) {
if ((open_file->invalidHandle) &&
(!open_file->closePend)) {
rc = cifs_reopen_file(file->f_dentry->d_inode,
file,TRUE);
@@ -1164,13 +1164,22 @@
current_read_size, *poffset,
_read, _read_data);
+ if (rc == -EAGAIN)
+ continue;
+ if (rc)
+ break;
+
pSMBr = (struct smb_com_read_rsp *)smb_read_data;
- copy_to_user(current_offset,smb_read_data + 4/* RFC1001
hdr*/
+ rc = copy_to_user(current_offset,smb_read_data + 4/*
RFC1001 hdr*/
+ le16_to_cpu(pSMBr->DataOffset), bytes_read);
if(smb_read_data) {
cifs_buf_release(smb_read_data);
smb_read_data = NULL;
}
+ if (rc) {
+ FreeXid(xid);
+ return -EFAULT;
+ }
}
if (rc || (bytes_read == 0)) {
if (total_read) {
Luca
--
Home: http://kronoz.cjb.net
"La teoria e` quando sappiamo come funzionano le cose ma non funzionano.
La pratica e` quando le cose funzionano ma non sappiamo perche`.
Abbiamo unito la teoria e la pratica: le cose non funzionano piu` e non
sappiamo il perche`." -- A. Einstein
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6] Check return value of copy_to_user in fs/cifs/file.c [Re: Linux 2.6.11-rc4]
On Sun, Feb 13, 2005 at 04:44:16PM +0100, Luca wrote:
> Linus Torvalds <[EMAIL PROTECTED]> ha scritto:
> > this is hopefully the last -rc kernel before the real 2.6.11, so please
> > give it a whirl, and complain loudly about anything broken.
>
> The following patch against 2.6.11-rc4 fixes this compile time warning:
>
> CC [M] fs/cifs/file.o
> fs/cifs/file.c: In function `cifs_user_read':
> fs/cifs/file.c:1168: warning: ignoring return value of
> `copy_to_user', declared with attribute warn_unused_result
>
> I also added an explicit check for errors other than -EAGAIN, since
> CIFSSMBRead may return -ENOMEM if it's unable to allocate smb_com_read_rsp;
> in that case we don't want to call copy_to_user with a NULL pointer.
>
> Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]>
>
> --- a/fs/cifs/file.c 2005-02-03 17:58:07.0 +0100
> +++ b/fs/cifs/file.c 2005-02-03 18:17:37.0 +0100
> @@ -1151,7 +1151,7 @@
> current_read_size = min_t(const int,read_size -
> total_read,cifs_sb->rsize);
> rc = -EAGAIN;
> smb_read_data = NULL;
> - while(rc == -EAGAIN) {
> + while(1) {
> if ((open_file->invalidHandle) &&
> (!open_file->closePend)) {
> rc = cifs_reopen_file(file->f_dentry->d_inode,
> file,TRUE);
> @@ -1164,13 +1164,22 @@
>current_read_size, *poffset,
>_read, _read_data);
>
> + if (rc == -EAGAIN)
> + continue;
> + else
> + break;
> +
> pSMBr = (struct smb_com_read_rsp *)smb_read_data;
^
Perhaps this line and the following lines are never executed with your
patch, am I right?
> - copy_to_user(current_offset,smb_read_data + 4/* RFC1001
> hdr*/
> + rc = copy_to_user(current_offset,smb_read_data + 4/*
> RFC1001 hdr*/
> + le16_to_cpu(pSMBr->DataOffset), bytes_read);
> if(smb_read_data) {
> cifs_buf_release(smb_read_data);
> smb_read_data = NULL;
> }
> + if (rc) {
> + FreeXid(xid);
> + return -EFAULT;
> + }
> }
> if (rc || (bytes_read == 0)) {
> if (total_read) {
>
>
--
Marcel Sebek
jabber: [EMAIL PROTECTED] ICQ: 279852819
linux user number: 307850 GPG ID: 5F88735E
GPG FP: 0F01 BAB8 3148 94DB B95D 1FCA 8B63 CA06 5F88 735E
signature.asc
Description: Digital signature
Re: Linux 2.6.11-rc4
Hi Enrico, > It is possible to include the SIS5595 chip driver to the final > release? No, sorry. It's not even in -mm yet (in fact it's even not in Greg's bk-i2c tree yet). It needs to spend some time (and get some testing) in -mm before it can go to Linus. You are still welcome to get the patch [1] and apply it manually to your tree if you want support right now. And of course, report to the Aurélien and the sensors mailing-list if you hit a problem. [1] http://lkml.org/lkml/diff/2005/2/6/192/1 Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6] Check return value of copy_to_user in fs/cifs/file.c [Re: Linux 2.6.11-rc4]
Linus Torvalds <[EMAIL PROTECTED]> ha scritto:
> this is hopefully the last -rc kernel before the real 2.6.11, so please
> give it a whirl, and complain loudly about anything broken.
The following patch against 2.6.11-rc4 fixes this compile time warning:
CC [M] fs/cifs/file.o
fs/cifs/file.c: In function `cifs_user_read':
fs/cifs/file.c:1168: warning: ignoring return value of
`copy_to_user', declared with attribute warn_unused_result
I also added an explicit check for errors other than -EAGAIN, since
CIFSSMBRead may return -ENOMEM if it's unable to allocate smb_com_read_rsp;
in that case we don't want to call copy_to_user with a NULL pointer.
Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]>
--- a/fs/cifs/file.c2005-02-03 17:58:07.0 +0100
+++ b/fs/cifs/file.c2005-02-03 18:17:37.0 +0100
@@ -1151,7 +1151,7 @@
current_read_size = min_t(const int,read_size -
total_read,cifs_sb->rsize);
rc = -EAGAIN;
smb_read_data = NULL;
- while(rc == -EAGAIN) {
+ while(1) {
if ((open_file->invalidHandle) &&
(!open_file->closePend)) {
rc = cifs_reopen_file(file->f_dentry->d_inode,
file,TRUE);
@@ -1164,13 +1164,22 @@
current_read_size, *poffset,
_read, _read_data);
+ if (rc == -EAGAIN)
+ continue;
+ else
+ break;
+
pSMBr = (struct smb_com_read_rsp *)smb_read_data;
- copy_to_user(current_offset,smb_read_data + 4/* RFC1001
hdr*/
+ rc = copy_to_user(current_offset,smb_read_data + 4/*
RFC1001 hdr*/
+ le16_to_cpu(pSMBr->DataOffset), bytes_read);
if(smb_read_data) {
cifs_buf_release(smb_read_data);
smb_read_data = NULL;
}
+ if (rc) {
+ FreeXid(xid);
+ return -EFAULT;
+ }
}
if (rc || (bytes_read == 0)) {
if (total_read) {
Luca
--
Home: http://kronoz.cjb.net
Se non sei parte della soluzione, allora sei parte del problema.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6] Check return of copy_from_user value in cifssmb.c [Re: Linux 2.6.11-rc4]
Linus Torvalds <[EMAIL PROTECTED]> ha scritto:
> this is hopefully the last -rc kernel before the real 2.6.11, so please
> give it a whirl, and complain loudly about anything broken.
The following patch against 2.6.11-rc4 fixes this compile time warning:
fs/cifs/cifssmb.c: In function `CIFSSMBWrite':
fs/cifs/cifssmb.c:902: warning: ignoring return value of
`copy_from_user', declared with attribute warn_unused_result
It also fixes the strange indentation of the code in that point. Also
note that pSMB cannot be NULL, since the return value of smb_init (which
initiliaze pSMB) is checked (see line 874).
Signed-off-by: Luca Tettamanti <[EMAIL PROTECTED]>
--- a/fs/cifs/cifssmb.c 2005-02-03 17:43:18.0 +0100
+++ b/fs/cifs/cifssmb.c 2005-02-03 17:47:29.0 +0100
@@ -896,14 +896,17 @@
pSMB->DataLengthHigh = 0;
pSMB->DataOffset =
cpu_to_le16(offsetof(struct smb_com_write_req,Data) - 4);
-if(buf)
- memcpy(pSMB->Data,buf,bytes_sent);
- else if(ubuf)
- copy_from_user(pSMB->Data,ubuf,bytes_sent);
-else {
- /* No buffer */
- if(pSMB)
+
+ if(buf)
+ memcpy(pSMB->Data, buf, bytes_sent);
+ else if(ubuf) {
+ if (copy_from_user(pSMB->Data, ubuf, bytes_sent)) {
cifs_buf_release(pSMB);
+ return -EFAULT;
+ }
+ } else {
+ /* No buffer */
+ cifs_buf_release(pSMB);
return -EINVAL;
}
Luca
--
Home: http://kronoz.cjb.net
Il dottore mi ha detto di smettere di fare cene intime per quattro.
A meno che non ci siamo altre tre persone.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.11-rc4
Linus Torvalds <[EMAIL PROTECTED]> : [...] > this is hopefully the last -rc kernel before the real 2.6.11, so please > give it a whirl, and complain loudly about anything broken. - dscc4 (patch in Jeff's -netdev) Apart the fact that the driver crashes on module insertion and is unusable, users do not complain so this is a minor annoyance from a maintainer's pov :o) - r8169 (patches available on netdev, sent to Jeff and Andrew) rtl8169_open() after rtl8169_close() sucks. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.11-rc4
Hello, It is possible to include the SIS5595 chip driver to the final release? EnricoB - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.11-rc4
Hello, It is possible to include the SIS5595 chip driver to the final release? EnricoB - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.11-rc4
Linus Torvalds [EMAIL PROTECTED] : [...] this is hopefully the last -rc kernel before the real 2.6.11, so please give it a whirl, and complain loudly about anything broken. - dscc4 (patch in Jeff's -netdev) Apart the fact that the driver crashes on module insertion and is unusable, users do not complain so this is a minor annoyance from a maintainer's pov :o) - r8169 (patches available on netdev, sent to Jeff and Andrew) rtl8169_open() after rtl8169_close() sucks. -- Ueimor - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6] Check return of copy_from_user value in cifssmb.c [Re: Linux 2.6.11-rc4]
Linus Torvalds [EMAIL PROTECTED] ha scritto:
this is hopefully the last -rc kernel before the real 2.6.11, so please
give it a whirl, and complain loudly about anything broken.
The following patch against 2.6.11-rc4 fixes this compile time warning:
fs/cifs/cifssmb.c: In function `CIFSSMBWrite':
fs/cifs/cifssmb.c:902: warning: ignoring return value of
`copy_from_user', declared with attribute warn_unused_result
It also fixes the strange indentation of the code in that point. Also
note that pSMB cannot be NULL, since the return value of smb_init (which
initiliaze pSMB) is checked (see line 874).
Signed-off-by: Luca Tettamanti [EMAIL PROTECTED]
--- a/fs/cifs/cifssmb.c 2005-02-03 17:43:18.0 +0100
+++ b/fs/cifs/cifssmb.c 2005-02-03 17:47:29.0 +0100
@@ -896,14 +896,17 @@
pSMB-DataLengthHigh = 0;
pSMB-DataOffset =
cpu_to_le16(offsetof(struct smb_com_write_req,Data) - 4);
-if(buf)
- memcpy(pSMB-Data,buf,bytes_sent);
- else if(ubuf)
- copy_from_user(pSMB-Data,ubuf,bytes_sent);
-else {
- /* No buffer */
- if(pSMB)
+
+ if(buf)
+ memcpy(pSMB-Data, buf, bytes_sent);
+ else if(ubuf) {
+ if (copy_from_user(pSMB-Data, ubuf, bytes_sent)) {
cifs_buf_release(pSMB);
+ return -EFAULT;
+ }
+ } else {
+ /* No buffer */
+ cifs_buf_release(pSMB);
return -EINVAL;
}
Luca
--
Home: http://kronoz.cjb.net
Il dottore mi ha detto di smettere di fare cene intime per quattro.
A meno che non ci siamo altre tre persone.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6] Check return value of copy_to_user in fs/cifs/file.c [Re: Linux 2.6.11-rc4]
Linus Torvalds [EMAIL PROTECTED] ha scritto:
this is hopefully the last -rc kernel before the real 2.6.11, so please
give it a whirl, and complain loudly about anything broken.
The following patch against 2.6.11-rc4 fixes this compile time warning:
CC [M] fs/cifs/file.o
fs/cifs/file.c: In function `cifs_user_read':
fs/cifs/file.c:1168: warning: ignoring return value of
`copy_to_user', declared with attribute warn_unused_result
I also added an explicit check for errors other than -EAGAIN, since
CIFSSMBRead may return -ENOMEM if it's unable to allocate smb_com_read_rsp;
in that case we don't want to call copy_to_user with a NULL pointer.
Signed-off-by: Luca Tettamanti [EMAIL PROTECTED]
--- a/fs/cifs/file.c2005-02-03 17:58:07.0 +0100
+++ b/fs/cifs/file.c2005-02-03 18:17:37.0 +0100
@@ -1151,7 +1151,7 @@
current_read_size = min_t(const int,read_size -
total_read,cifs_sb-rsize);
rc = -EAGAIN;
smb_read_data = NULL;
- while(rc == -EAGAIN) {
+ while(1) {
if ((open_file-invalidHandle)
(!open_file-closePend)) {
rc = cifs_reopen_file(file-f_dentry-d_inode,
file,TRUE);
@@ -1164,13 +1164,22 @@
current_read_size, *poffset,
bytes_read, smb_read_data);
+ if (rc == -EAGAIN)
+ continue;
+ else
+ break;
+
pSMBr = (struct smb_com_read_rsp *)smb_read_data;
- copy_to_user(current_offset,smb_read_data + 4/* RFC1001
hdr*/
+ rc = copy_to_user(current_offset,smb_read_data + 4/*
RFC1001 hdr*/
+ le16_to_cpu(pSMBr-DataOffset), bytes_read);
if(smb_read_data) {
cifs_buf_release(smb_read_data);
smb_read_data = NULL;
}
+ if (rc) {
+ FreeXid(xid);
+ return -EFAULT;
+ }
}
if (rc || (bytes_read == 0)) {
if (total_read) {
Luca
--
Home: http://kronoz.cjb.net
Se non sei parte della soluzione, allora sei parte del problema.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.11-rc4
Hi Enrico, It is possible to include the SIS5595 chip driver to the final release? No, sorry. It's not even in -mm yet (in fact it's even not in Greg's bk-i2c tree yet). It needs to spend some time (and get some testing) in -mm before it can go to Linus. You are still welcome to get the patch [1] and apply it manually to your tree if you want support right now. And of course, report to the Aurélien and the sensors mailing-list if you hit a problem. [1] http://lkml.org/lkml/diff/2005/2/6/192/1 Thanks, -- Jean Delvare - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6] Check return value of copy_to_user in fs/cifs/file.c [Re: Linux 2.6.11-rc4]
On Sun, Feb 13, 2005 at 04:44:16PM +0100, Luca wrote:
Linus Torvalds [EMAIL PROTECTED] ha scritto:
this is hopefully the last -rc kernel before the real 2.6.11, so please
give it a whirl, and complain loudly about anything broken.
The following patch against 2.6.11-rc4 fixes this compile time warning:
CC [M] fs/cifs/file.o
fs/cifs/file.c: In function `cifs_user_read':
fs/cifs/file.c:1168: warning: ignoring return value of
`copy_to_user', declared with attribute warn_unused_result
I also added an explicit check for errors other than -EAGAIN, since
CIFSSMBRead may return -ENOMEM if it's unable to allocate smb_com_read_rsp;
in that case we don't want to call copy_to_user with a NULL pointer.
Signed-off-by: Luca Tettamanti [EMAIL PROTECTED]
--- a/fs/cifs/file.c 2005-02-03 17:58:07.0 +0100
+++ b/fs/cifs/file.c 2005-02-03 18:17:37.0 +0100
@@ -1151,7 +1151,7 @@
current_read_size = min_t(const int,read_size -
total_read,cifs_sb-rsize);
rc = -EAGAIN;
smb_read_data = NULL;
- while(rc == -EAGAIN) {
+ while(1) {
if ((open_file-invalidHandle)
(!open_file-closePend)) {
rc = cifs_reopen_file(file-f_dentry-d_inode,
file,TRUE);
@@ -1164,13 +1164,22 @@
current_read_size, *poffset,
bytes_read, smb_read_data);
+ if (rc == -EAGAIN)
+ continue;
+ else
+ break;
+
pSMBr = (struct smb_com_read_rsp *)smb_read_data;
^
Perhaps this line and the following lines are never executed with your
patch, am I right?
- copy_to_user(current_offset,smb_read_data + 4/* RFC1001
hdr*/
+ rc = copy_to_user(current_offset,smb_read_data + 4/*
RFC1001 hdr*/
+ le16_to_cpu(pSMBr-DataOffset), bytes_read);
if(smb_read_data) {
cifs_buf_release(smb_read_data);
smb_read_data = NULL;
}
+ if (rc) {
+ FreeXid(xid);
+ return -EFAULT;
+ }
}
if (rc || (bytes_read == 0)) {
if (total_read) {
--
Marcel Sebek
jabber: [EMAIL PROTECTED] ICQ: 279852819
linux user number: 307850 GPG ID: 5F88735E
GPG FP: 0F01 BAB8 3148 94DB B95D 1FCA 8B63 CA06 5F88 735E
signature.asc
Description: Digital signature
Re: [PATCH 2.6] Check return value of copy_to_user in fs/cifs/file.c [Re: Linux 2.6.11-rc4]
Il Sun, Feb 13, 2005 at 06:28:38PM +0100, Marcel Sebek ha scritto:
@@ -1164,13 +1164,22 @@
current_read_size, *poffset,
bytes_read, smb_read_data);
+ if (rc == -EAGAIN)
+ continue;
+ else
+ break;
+
pSMBr = (struct smb_com_read_rsp *)smb_read_data;
^
Perhaps this line and the following lines are never executed with your
patch, am I right?
Yes, you are. Let's try again:
The following patch against 2.6.11-rc4 fixes this compile time
warning:
CC [M] fs/cifs/file.o
fs/cifs/file.c: In function `cifs_user_read':
fs/cifs/file.c:1168: warning: ignoring return value of
`copy_to_user', declared with attribute warn_unused_result
I also added an explicit check for errors other than -EAGAIN, since
CIFSSMBRead may return -ENOMEM if it's unable to allocate
smb_com_read_rsp; in that case we don't want to call copy_to_user with a
NULL pointer.
Signed-off-by: Luca Tettamanti [EMAIL PROTECTED]
--- a/fs/cifs/file.c2005-02-03 17:58:07.0 +0100
+++ b/fs/cifs/file.c2005-02-13 21:18:01.0 +0100
@@ -1151,7 +1151,7 @@
current_read_size = min_t(const int,read_size -
total_read,cifs_sb-rsize);
rc = -EAGAIN;
smb_read_data = NULL;
- while(rc == -EAGAIN) {
+ while(1) {
if ((open_file-invalidHandle)
(!open_file-closePend)) {
rc = cifs_reopen_file(file-f_dentry-d_inode,
file,TRUE);
@@ -1164,13 +1164,22 @@
current_read_size, *poffset,
bytes_read, smb_read_data);
+ if (rc == -EAGAIN)
+ continue;
+ if (rc)
+ break;
+
pSMBr = (struct smb_com_read_rsp *)smb_read_data;
- copy_to_user(current_offset,smb_read_data + 4/* RFC1001
hdr*/
+ rc = copy_to_user(current_offset,smb_read_data + 4/*
RFC1001 hdr*/
+ le16_to_cpu(pSMBr-DataOffset), bytes_read);
if(smb_read_data) {
cifs_buf_release(smb_read_data);
smb_read_data = NULL;
}
+ if (rc) {
+ FreeXid(xid);
+ return -EFAULT;
+ }
}
if (rc || (bytes_read == 0)) {
if (total_read) {
Luca
--
Home: http://kronoz.cjb.net
La teoria e` quando sappiamo come funzionano le cose ma non funzionano.
La pratica e` quando le cose funzionano ma non sappiamo perche`.
Abbiamo unito la teoria e la pratica: le cose non funzionano piu` e non
sappiamo il perche`. -- A. Einstein
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Linux 2.6.11-rc4
iver
John Rose:
o PCI Hotplug: remove incorrect rpaphp firmware dependency
o PCI Hotplug: fix rpaphp firmware dependency
Josh Green:
o pcmcia: ds.c initialisation fix
Kay Sievers:
o PCI: memset rom attribute before using it
Keith Owens:
o [IA64] mca_asm.S: Correctly dereference ia64_mca_data
Kenneth W. Chen:
o [IA64] Ensure that r9 can't be a NaT on return from sys_pipe()
o [IA64] entry.S: another syscall exit path optimization
Kumar Gala:
o ppc32: Fix PCI2 support on MPC8555/41 CDS systems
Lennert Buytenhek:
o [ARM PATCH] 2457/1: fix two typos in arch/arm/mm/tlb*.S
o [ARM PATCH] 2473/1: fix alignment trap handler for big-endian
Libor Michalek:
o InfiniBand: add missing break between cases
Linus Torvalds:
o Make read/write always do the full "access_ok()" tests
o Make generic rw_verify_area check against file offset overflows
o Add extra debugging help for bad user accesses
o FRV: "len" is size_t
o Undo recent tty_io.c "fix"
o Fix ATM copy-to-user usage
o Linux 2.6.11-rc4
Marcel Holtmann:
o [Bluetooth] Support Broadcom BCM92035 USB dongles
o [Bluetooth] Support for Digianswer BPA 100/105 sniffers
Mark A. Greer:
o ppc32: include/asm-ppc/rwsem.h RWSEM_DEBUG usage
o ppc32: fix locking bugs in mv64x60 code
Martin Kögler:
o serial: fix low-latency mode deadlock
Martin Schwidefsky:
o Fix shmget for ppc64, s390-64 & sparc64
Martins Krikis:
o libata: fix ata_piix on ICH6R in RAID mode
Matt Porter:
o ppc32: PPC4xx DMA fixes, burst, and sg improvements
o ppc32: add PPC440SP and Luan ref board support
Matthew Wilcox:
o [IPV4]: ipconfig should use memmove() instead of strcpy()
Matthias-Christian Ott:
o speedstep-lib.c: fix frequency multiplier for Pentium4 models 0&1
Meelis Roos:
o [SPARC32]: Fix syntax errors from smp_{mb,rmb,wmb} on sparc32
Michael Chan:
o [TG3]: 5704 serdes fixes
o [TG3]: capacitive coupling detection fix
Michael Ellerman:
o Fix oops in alloc_zeroed_user_highpage() when page is NULL
Michael S. Tsirkin:
o InfiniBand: remove unbalance refcnt decrement
Michal Ludvig:
o Update Michal Ludvig details
Mikkel Krautz:
o TIGLUSB Cleanups 1/3
o TIGLUSB Cleanups 2/3
o TIGLUSB Cleanups 3/3
Narayanan R S:
o sonypi: add fan and temperature status/control
Nathan Lynch:
o ppc64: show -1 for physical_id of non-present cpus
Neil Brown:
o md: fix problems with verion-1 superblock code
o md: prevent oops when drive set faulty in inactive md array
o md: make md work a bit better with devfs
o md: fix endless loop when syncing an array that doesn't need any
resync
o md: remove extra loop from copy_data
o raid5 overlapping read hack
o nfsd: Don't try to cache reply to nfsv2 readdir
o nfsd: Allow read access over NFS to files with APPEND bit set
Nick Piggin:
o Fix kswapd spinning
o fix wait_task_inactive race
Nico Huber:
o USB: Logitech Cordeless Desktop Keyboard fails to report class
descriptor
Nicolas Bouliane:
o [NETFILTER]: Fix ip_conntrack_ftp crash with debugging enabled
Nicolas Pitre:
o [ARM PATCH] 2456/1: fix futex syscall argument passing
o [ARM PATCH] 2458/1: prevent PXA2xx defines from clashing with
SA's
o L18 flash corruption fix
Nishanth Aravamudan:
o include/jiffies: fix usecs_to_jiffies()/jiffies_to_usecs() math
o [NET]: Replace schedule_timeout() with msleep() in
netdev_wait_allrefs()
o [IPVS]: Replace schedule_timeout() with ssleep()
o [IPV4]: ipconfig: Replace schedule_timeout() with msleep()
Olaf Hering:
o PCI: typo in pci_scan_bus_parented
o ppc64: typo in arch/ppc64/kernel/prom_init.c prom_debug
Oliver Neukum:
o USB: fix for open/disconnect race in acm
Oskar Senft:
o Fix ISDN4Linux bug in isdnhdlc.c
Pablo Neira:
o [NETFILTER]: fix iptables userspace build
Paolo 'Blaisorblade' Giarrusso:
o uml: makefile fix
o uml: fix compilation for missing headers
o uml: kconfig fixes
o uml: kbuild: add further cleaning
o uml: hostfs: (security) fix chmod +s permission check
Patrick McHardy:
o [PKT_SCHED]: ipt action: add back pskb_expand_head() call
o [NETFILTER]: Clean NAT status bits on module unload
o [PKT_SCHED]: Fix u32 double listing
Paul Mackerras:
o ppc64: correct return code in syscall auditing
o Fix PPC rwlock code on SMP
Pavel Machek:
o binfmt_elf: clearing bss may fail
Pete Zaitcev:
o [libata] fix probe object allocation bugs
Peter Osterlund:
o Make mousedev.c report all events to user space immediately
Phil Oester:
o [NETFILTER]: Improve TCP window tracking retransmission detection
Prarit Bhargava:
o [ide] fix error handling in probe_hwif_init() and sgiioc4 driver
Ralf Bächle:
o mips: SGI IP22 updates
Randy Dunlap:
o USB: hid-core: possible buffer overflow in hid-core.c
Robert Olsson:
o [IPV4]: Add gc_min_interval_ms sysctl
Rogier Wolff:
o Re: Bug when using custom baud rates
Russ Anderson:
o [IA64] r23 was used without being set
Russ
Linux 2.6.11-rc4
: remove incorrect rpaphp firmware dependency
o PCI Hotplug: fix rpaphp firmware dependency
Josh Green:
o pcmcia: ds.c initialisation fix
Kay Sievers:
o PCI: memset rom attribute before using it
Keith Owens:
o [IA64] mca_asm.S: Correctly dereference ia64_mca_data
Kenneth W. Chen:
o [IA64] Ensure that r9 can't be a NaT on return from sys_pipe()
o [IA64] entry.S: another syscall exit path optimization
Kumar Gala:
o ppc32: Fix PCI2 support on MPC8555/41 CDS systems
Lennert Buytenhek:
o [ARM PATCH] 2457/1: fix two typos in arch/arm/mm/tlb*.S
o [ARM PATCH] 2473/1: fix alignment trap handler for big-endian
Libor Michalek:
o InfiniBand: add missing break between cases
Linus Torvalds:
o Make read/write always do the full access_ok() tests
o Make generic rw_verify_area check against file offset overflows
o Add extra debugging help for bad user accesses
o FRV: len is size_t
o Undo recent tty_io.c fix
o Fix ATM copy-to-user usage
o Linux 2.6.11-rc4
Marcel Holtmann:
o [Bluetooth] Support Broadcom BCM92035 USB dongles
o [Bluetooth] Support for Digianswer BPA 100/105 sniffers
Mark A. Greer:
o ppc32: include/asm-ppc/rwsem.h RWSEM_DEBUG usage
o ppc32: fix locking bugs in mv64x60 code
Martin Kögler:
o serial: fix low-latency mode deadlock
Martin Schwidefsky:
o Fix shmget for ppc64, s390-64 sparc64
Martins Krikis:
o libata: fix ata_piix on ICH6R in RAID mode
Matt Porter:
o ppc32: PPC4xx DMA fixes, burst, and sg improvements
o ppc32: add PPC440SP and Luan ref board support
Matthew Wilcox:
o [IPV4]: ipconfig should use memmove() instead of strcpy()
Matthias-Christian Ott:
o speedstep-lib.c: fix frequency multiplier for Pentium4 models 01
Meelis Roos:
o [SPARC32]: Fix syntax errors from smp_{mb,rmb,wmb} on sparc32
Michael Chan:
o [TG3]: 5704 serdes fixes
o [TG3]: capacitive coupling detection fix
Michael Ellerman:
o Fix oops in alloc_zeroed_user_highpage() when page is NULL
Michael S. Tsirkin:
o InfiniBand: remove unbalance refcnt decrement
Michal Ludvig:
o Update Michal Ludvig details
Mikkel Krautz:
o TIGLUSB Cleanups 1/3
o TIGLUSB Cleanups 2/3
o TIGLUSB Cleanups 3/3
Narayanan R S:
o sonypi: add fan and temperature status/control
Nathan Lynch:
o ppc64: show -1 for physical_id of non-present cpus
Neil Brown:
o md: fix problems with verion-1 superblock code
o md: prevent oops when drive set faulty in inactive md array
o md: make md work a bit better with devfs
o md: fix endless loop when syncing an array that doesn't need any
resync
o md: remove extra loop from copy_data
o raid5 overlapping read hack
o nfsd: Don't try to cache reply to nfsv2 readdir
o nfsd: Allow read access over NFS to files with APPEND bit set
Nick Piggin:
o Fix kswapd spinning
o fix wait_task_inactive race
Nico Huber:
o USB: Logitech Cordeless Desktop Keyboard fails to report class
descriptor
Nicolas Bouliane:
o [NETFILTER]: Fix ip_conntrack_ftp crash with debugging enabled
Nicolas Pitre:
o [ARM PATCH] 2456/1: fix futex syscall argument passing
o [ARM PATCH] 2458/1: prevent PXA2xx defines from clashing with
SA's
o L18 flash corruption fix
Nishanth Aravamudan:
o include/jiffies: fix usecs_to_jiffies()/jiffies_to_usecs() math
o [NET]: Replace schedule_timeout() with msleep() in
netdev_wait_allrefs()
o [IPVS]: Replace schedule_timeout() with ssleep()
o [IPV4]: ipconfig: Replace schedule_timeout() with msleep()
Olaf Hering:
o PCI: typo in pci_scan_bus_parented
o ppc64: typo in arch/ppc64/kernel/prom_init.c prom_debug
Oliver Neukum:
o USB: fix for open/disconnect race in acm
Oskar Senft:
o Fix ISDN4Linux bug in isdnhdlc.c
Pablo Neira:
o [NETFILTER]: fix iptables userspace build
Paolo 'Blaisorblade' Giarrusso:
o uml: makefile fix
o uml: fix compilation for missing headers
o uml: kconfig fixes
o uml: kbuild: add further cleaning
o uml: hostfs: (security) fix chmod +s permission check
Patrick McHardy:
o [PKT_SCHED]: ipt action: add back pskb_expand_head() call
o [NETFILTER]: Clean NAT status bits on module unload
o [PKT_SCHED]: Fix u32 double listing
Paul Mackerras:
o ppc64: correct return code in syscall auditing
o Fix PPC rwlock code on SMP
Pavel Machek:
o binfmt_elf: clearing bss may fail
Pete Zaitcev:
o [libata] fix probe object allocation bugs
Peter Osterlund:
o Make mousedev.c report all events to user space immediately
Phil Oester:
o [NETFILTER]: Improve TCP window tracking retransmission detection
Prarit Bhargava:
o [ide] fix error handling in probe_hwif_init() and sgiioc4 driver
Ralf Bächle:
o mips: SGI IP22 updates
Randy Dunlap:
o USB: hid-core: possible buffer overflow in hid-core.c
Robert Olsson:
o [IPV4]: Add gc_min_interval_ms sysctl
Rogier Wolff:
o Re: Bug when using custom baud rates
Russ Anderson:
o [IA64] r23 was used without being set
Russell King:
o [ARM] Fix sys_syscall
o [ARM] Re-order lubbock includes
o [ARM
