Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-23 Thread Dmitry Torokhov
On 4/22/05, Stefan Seyfried <[EMAIL PROTECTED]> wrote:
> --- linux/kernel/power/swsusp.c~2005-04-22 17:07:56.0 +0200
> +++ linux/kernel/power/swsusp.c 2005-04-22 17:09:22.0 +0200
> @@ -1239,7 +1239,7 @@ static int check_sig(void)
> */
>error = bio_write_page(0, _header);
>} else {
> -   printk(KERN_ERR "swsusp: Suspend partition has wrong 
> signature?\n");
> +   printk(KERN_ERR "swsusp: Suspend partition is no suspend 
> image.\n");

Hrm, I don't think it is a good message... What about "Suspend
partition has no suspend image" or, better yet, "Suspend partition
does not contain valid suspend image"?

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-23 Thread Stefan Seyfried
Pavel Machek wrote:
>> 1. Is it necessary to print the following message during regular boot?
>>swsusp: Suspend partition has wrong signature?

> Hmm, feel free to provide a patch. (I need something to try git on :-).

Attached (sorry, Thunderbird...). One may argue over KERN_ERR, but i
don't mind.
-- 
Stefan Seyfried, QA / R Team Mobile Devices, SUSE LINUX Nürnberg.

"Any ideas, John?"
"Well, surrounding them's out."
--- linux/kernel/power/swsusp.c~2005-04-22 17:07:56.0 +0200
+++ linux/kernel/power/swsusp.c 2005-04-22 17:09:22.0 +0200
@@ -1239,7 +1239,7 @@ static int check_sig(void)
 */
error = bio_write_page(0, _header);
} else { 
-   printk(KERN_ERR "swsusp: Suspend partition has wrong 
signature?\n");
+   printk(KERN_ERR "swsusp: Suspend partition is no suspend 
image.\n");
return -EINVAL;
}
if (!error)


Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-23 Thread Dmitry Torokhov
On 4/22/05, Stefan Seyfried [EMAIL PROTECTED] wrote:
 --- linux/kernel/power/swsusp.c~2005-04-22 17:07:56.0 +0200
 +++ linux/kernel/power/swsusp.c 2005-04-22 17:09:22.0 +0200
 @@ -1239,7 +1239,7 @@ static int check_sig(void)
 */
error = bio_write_page(0, swsusp_header);
} else {
 -   printk(KERN_ERR swsusp: Suspend partition has wrong 
 signature?\n);
 +   printk(KERN_ERR swsusp: Suspend partition is no suspend 
 image.\n);

Hrm, I don't think it is a good message... What about Suspend
partition has no suspend image or, better yet, Suspend partition
does not contain valid suspend image?

-- 
Dmitry
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-23 Thread Stefan Seyfried
Pavel Machek wrote:
 1. Is it necessary to print the following message during regular boot?
swsusp: Suspend partition has wrong signature?

 Hmm, feel free to provide a patch. (I need something to try git on :-).

Attached (sorry, Thunderbird...). One may argue over KERN_ERR, but i
don't mind.
-- 
Stefan Seyfried, QA / RD Team Mobile Devices, SUSE LINUX Nürnberg.

Any ideas, John?
Well, surrounding them's out.
--- linux/kernel/power/swsusp.c~2005-04-22 17:07:56.0 +0200
+++ linux/kernel/power/swsusp.c 2005-04-22 17:09:22.0 +0200
@@ -1239,7 +1239,7 @@ static int check_sig(void)
 */
error = bio_write_page(0, swsusp_header);
} else { 
-   printk(KERN_ERR swsusp: Suspend partition has wrong 
signature?\n);
+   printk(KERN_ERR swsusp: Suspend partition is no suspend 
image.\n);
return -EINVAL;
}
if (!error)


Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-21 Thread Andreas Steinmetz
Pavel Machek wrote:
> Hi!
> Are they new or were they in -rc2, too?

Some further backtracking:

The nic problem is already present in 2.6.12-rc1.
The pcmcia hang problem is not present in 2.6.12-rc1.
-- 
Andreas Steinmetz   SPAMmers use [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-21 Thread Andreas Steinmetz
Pavel Machek wrote:
> Hi!
> 
> 
>>there's some problems with swsusp in 2.6.12-rc3 (x86_64):
> 
> 
> Are they new or were they in -rc2, too?
> 

Fixed the rc2/rc3 IDE Oops myself today that prevented me to test rc2
earlier. It seems the IDE maintainer is currently not very responsive
and I didn't have sufficient spare time to look into this before today :-(

Yes, all problems are already in rc2.

> 
>>1. Is it necessary to print the following message during regular boot?
>>   swsusp: Suspend partition has wrong signature?
>>   It is a bit annoying and I believe it will confuse some swsusp
>>   users.
> 
> 
> Hmm, feel free to provide a patch. (I need something to try git on :-).

I'll have a look over the weekend.

> 
> 
>>2. PCMCIA related hangs during swsusp.
>>   swsusp hangs after freeing memory when either cardmgr is running
>>   or pcmcia cards are *physically* inserted. It is insufficient
>>   to do a 'cardctl eject' the cards must be removed, too, for
>>   swsusp not to hang. I do suspect some problem with the
>>   'pccardd' kernel threads.
> 
> 
> Did it work with any older kernel? Which driver is it? yenta?

2.6.11.2 works ok and, yes, its yenta. Some excerpt from lspci:

00:0b.0 CardBus bridge: Texas Instruments PCI7420 CardBus Controller
00:0b.1 CardBus bridge: Texas Instruments PCI7420 CardBus Controller

> 
> 
>>3. Sometimes during the search for the suspend hang reason the system
>>   went during suspend into a lightshow of:
>>   eth0: Too much work at interrupt!
>>   and some line that ends in:
>>   release_console_sem+0x13d/0x1c0)
>>   The start of the line is not readable as it just flickers by in
>>   the eth0 message limbo. NIC is a built in RTL-8169 Gigabit Ethernet
>>   (rev 10). Oh, no chance for a serial console capture as there's no
>>   built in serial device in this laptop.
> 
> 
> How repeatable is that? Will NIC work okay if you rmmod/insmod its driver?
>   Pavel

Happens with a probability of about 10% to 20%. I did comment out the
'Too much work...' printk in r8169.c which results in the following
effect: no more message from the network driver (expected), no other
printk related to release_console_sem or anything else unusal, but write
to disk in the case the problem seems to happen is suddenly quite slow
and suspend eventually succeeds.
As the nic driver is built into the kernel insmod/rmmod currently won't
do:-) Nevertheless there doesn't seem to be any strange behaviour after
resume though I didn't really try to use the nic then.
There is, however, definitely no such problem with the nic in 2.6.11.2.
-- 
Andreas Steinmetz   SPAMmers use [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-21 Thread Andreas Steinmetz
Hi Pavel,
there's some problems with swsusp in 2.6.12-rc3 (x86_64):

1. Is it necessary to print the following message during regular boot?
   swsusp: Suspend partition has wrong signature?
   It is a bit annoying and I believe it will confuse some swsusp
   users.

2. PCMCIA related hangs during swsusp.
   swsusp hangs after freeing memory when either cardmgr is running
   or pcmcia cards are *physically* inserted. It is insufficient
   to do a 'cardctl eject' the cards must be removed, too, for
   swsusp not to hang. I do suspect some problem with the
   'pccardd' kernel threads.

3. Sometimes during the search for the suspend hang reason the system
   went during suspend into a lightshow of:
   eth0: Too much work at interrupt!
   and some line that ends in:
   release_console_sem+0x13d/0x1c0)
   The start of the line is not readable as it just flickers by in
   the eth0 message limbo. NIC is a built in RTL-8169 Gigabit Ethernet
   (rev 10). Oh, no chance for a serial console capture as there's no
   built in serial device in this laptop.
-- 
Andreas Steinmetz   SPAMmers use [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-21 Thread Andreas Steinmetz
Hi Pavel,
there's some problems with swsusp in 2.6.12-rc3 (x86_64):

1. Is it necessary to print the following message during regular boot?
   swsusp: Suspend partition has wrong signature?
   It is a bit annoying and I believe it will confuse some swsusp
   users.

2. PCMCIA related hangs during swsusp.
   swsusp hangs after freeing memory when either cardmgr is running
   or pcmcia cards are *physically* inserted. It is insufficient
   to do a 'cardctl eject' the cards must be removed, too, for
   swsusp not to hang. I do suspect some problem with the
   'pccardd' kernel threads.

3. Sometimes during the search for the suspend hang reason the system
   went during suspend into a lightshow of:
   eth0: Too much work at interrupt!
   and some line that ends in:
   release_console_sem+0x13d/0x1c0)
   The start of the line is not readable as it just flickers by in
   the eth0 message limbo. NIC is a built in RTL-8169 Gigabit Ethernet
   (rev 10). Oh, no chance for a serial console capture as there's no
   built in serial device in this laptop.
-- 
Andreas Steinmetz   SPAMmers use [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-21 Thread Andreas Steinmetz
Pavel Machek wrote:
 Hi!
 
 
there's some problems with swsusp in 2.6.12-rc3 (x86_64):
 
 
 Are they new or were they in -rc2, too?
 

Fixed the rc2/rc3 IDE Oops myself today that prevented me to test rc2
earlier. It seems the IDE maintainer is currently not very responsive
and I didn't have sufficient spare time to look into this before today :-(

Yes, all problems are already in rc2.

 
1. Is it necessary to print the following message during regular boot?
   swsusp: Suspend partition has wrong signature?
   It is a bit annoying and I believe it will confuse some swsusp
   users.
 
 
 Hmm, feel free to provide a patch. (I need something to try git on :-).

I'll have a look over the weekend.

 
 
2. PCMCIA related hangs during swsusp.
   swsusp hangs after freeing memory when either cardmgr is running
   or pcmcia cards are *physically* inserted. It is insufficient
   to do a 'cardctl eject' the cards must be removed, too, for
   swsusp not to hang. I do suspect some problem with the
   'pccardd' kernel threads.
 
 
 Did it work with any older kernel? Which driver is it? yenta?

2.6.11.2 works ok and, yes, its yenta. Some excerpt from lspci:

00:0b.0 CardBus bridge: Texas Instruments PCI7420 CardBus Controller
00:0b.1 CardBus bridge: Texas Instruments PCI7420 CardBus Controller

 
 
3. Sometimes during the search for the suspend hang reason the system
   went during suspend into a lightshow of:
   eth0: Too much work at interrupt!
   and some line that ends in:
   release_console_sem+0x13d/0x1c0)
   The start of the line is not readable as it just flickers by in
   the eth0 message limbo. NIC is a built in RTL-8169 Gigabit Ethernet
   (rev 10). Oh, no chance for a serial console capture as there's no
   built in serial device in this laptop.
 
 
 How repeatable is that? Will NIC work okay if you rmmod/insmod its driver?
   Pavel

Happens with a probability of about 10% to 20%. I did comment out the
'Too much work...' printk in r8169.c which results in the following
effect: no more message from the network driver (expected), no other
printk related to release_console_sem or anything else unusal, but write
to disk in the case the problem seems to happen is suddenly quite slow
and suspend eventually succeeds.
As the nic driver is built into the kernel insmod/rmmod currently won't
do:-) Nevertheless there doesn't seem to be any strange behaviour after
resume though I didn't really try to use the nic then.
There is, however, definitely no such problem with the nic in 2.6.11.2.
-- 
Andreas Steinmetz   SPAMmers use [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Linux 2.6.12-rc3: various swsusp problems

2005-04-21 Thread Andreas Steinmetz
Pavel Machek wrote:
 Hi!
 Are they new or were they in -rc2, too?

Some further backtracking:

The nic problem is already present in 2.6.12-rc1.
The pcmcia hang problem is not present in 2.6.12-rc1.
-- 
Andreas Steinmetz   SPAMmers use [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/