Re: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
"Ju, Seokmann" <[EMAIL PROTECTED]> wrote: > > Here, I'm sending another patch that has > fix for this issue. It is still wordwrapped. Please fix you email client, email the patch to yourself, ensure that the result still applies, then resend it with a full description. Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
On Thursday, March 17, 2005 12:28 PM, James wrote:
> This is still rejecting:
>
> patching file drivers/scsi/megaraid/megaraid_mm.c
> Hunk #2 FAILED at 43.
> Hunk #4 FAILED at 68.
> Hunk #5 FAILED at 1217.
> Hunk #6 FAILED at 1225.
> Hunk #7 FAILED at 1245.
> 5 out of 7 hunks FAILED -- saving rejects to file
> drivers/scsi/megaraid/megaraid_mm.c.rej
Thank you for correction again.
At this time, I've download the source from
BK:/linux.bkbits.net:8080/linux-2.6 and found that the source already
includes 'compat_ioctl' support. Here, I'm sending another patch that has
fix for this issue.
I've verified (also, recreated above error with previous patch) this by
applying the patch to the source from BK.
I'm learning from your great comments and I appreciate your time on this.
Please let me know for any comment.
Thank you.
Sign-off-by: Seokmann Ju <[EMAIL PROTECTED]>
---
diff -Naur BK/Documentation/scsi/ChangeLog.megaraid
new/Documentation/scsi/ChangeLog.megaraid
--- BK/Documentation/scsi/ChangeLog.megaraid2005-03-17
18:06:38.115075184 -0500
+++ new/Documentation/scsi/ChangeLog.megaraid 2005-03-17
09:14:03.247953384 -0500
@@ -1,3 +1,69 @@
+Release Date : Mon Mar 07 12:27:22 EST 2005 - Seokmann Ju <[EMAIL PROTECTED]>
+Current Version: 2.20.4.6 (scsi module), 2.20.2.6 (cmm module)
+Older Version : 2.20.4.5 (scsi module), 2.20.2.5 (cmm module)
+
+1. Added IOCTL backward compatibility.
+ Convert megaraid_mm driver to new compat_ioctl entry points.
+ I don't have easy access to hardware, so only compile tested.
+ - Signed-off-by:Andi Kleen <[EMAIL PROTECTED]>
+
+2. megaraid_mbox fix: wrong order of arguments in memset()
+ That, BTW, shows why cross-builds are useful-the only indication of
+ problem had been a new warning showing up in sparse output on alpha
+ build (number of exceeding 256 got truncated).
+ - Signed-off-by: Al Viro
+ <[EMAIL PROTECTED]>
+
+3. Convert pci_module_init to pci_register_driver
+ Convert from pci_module_init to pci_register_driver
+ (from:http://kerneljanitors.org/TODO)
+ - Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
+
+4. Use the pre defined DMA mask constants from dma-mapping.h
+ Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when
calling
+ pci_set_dma_mask() or pci_set_consistend_dma_mask(). See
+ http://marc.theaimsgroup.com/?t=10800199301=1=2 for more
+ details.
+ Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]>
+ Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
+
+5. Remove SSID checking for Dobson, Lindsay, and Verde based products.
+ Checking the SSVID/SSID for controllers which have Dobson, Lindsay,
+ and Verde is unnecessary because device ID has been assigned by LSI
+ and it is unique value. So, all controllers with these IOPs have to
be
+ supported by the driver regardless SSVID/SSID.
+
+6. Date Thu, 27 Jan 2005 04:31:09 +0100
+ From Herbert Poetzl <>
+ Subject RFC: assert_spin_locked() for 2.6
+
+ Greetings!
+
+ overcautious programming will kill your kernel ;)
+ ever thought about checking a spin_lock or even
+ asserting that it must be held (maybe just for
+ spinlock debugging?) ...
+
+ there are several checks present in the kernel
+ where somebody does a variation on the following:
+
+ BUG_ON(!spin_is_locked(_lock));
+
+ so what's wrong about that? nothing, unless you
+ compile the code with CONFIG_DEBUG_SPINLOCK but
+ without CONFIG_SMP ... in which case the BUG()
+ will kill your kernel ...
+
+ maybe it's not advised to make such assertions,
+ but here is a solution which works for me ...
+ (compile tested for sh, x86_64 and x86, boot/run
+ tested for x86 only)
+
+ best,
+ Herbert
+
+ - Herbert Poetzl <[EMAIL PROTECTED]>, Thu, 27 Jan 2005
+
Release Date : Thu Feb 03 12:27:22 EST 2005 - Seokmann Ju <[EMAIL PROTECTED]>
Current Version: 2.20.4.5 (scsi module), 2.20.2.5 (cmm module)
Older Version : 2.20.4.4 (scsi module), 2.20.2.4 (cmm module)
diff -Naur BK/drivers/scsi/megaraid/mega_common.h
new/drivers/scsi/megaraid/mega_common.h
--- BK/drivers/scsi/megaraid/mega_common.h 2005-03-17
20:01:55.774431112 -0500
+++ new/drivers/scsi/megaraid/mega_common.h 2005-03-17
07:16:21.209546408 -0500
@@ -27,6 +27,7 @@
#include
#include
#include
+#include
#include
#include
#include
diff -Naur BK/drivers/scsi/megaraid/megaraid_mbox.c
new/drivers/scsi/megaraid/megaraid_mbox.c
--- BK/drivers/scsi/megaraid/megaraid_mbox.c2005-03-17
20:01:55.782429896 -0500
+++ new/drivers/scsi/megaraid/megaraid_mbox.c 2005-03-17
09:03:41.275507568 -0500
@@ -10,7 +10,7 @@
*2 of the License, or (at your option) any later version.
*
* FILE: megaraid_mbox.c
- * Version
RE: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
On Thu, 2005-03-17 at 11:48 -0500, Ju, Seokmann wrote: > On Thursday, March 17, 2005 1:26 AM, Andrew wrote: > > Some of these things have already been done in Linus's > > post-2.6.11 tree and > > you patch throws lots of rejects. Please always work against the most > > recent kernel - 2.6.11 is very out of date. > Thank you for correction. I've created NEW patch against 2.6.11.4 which is > latest from kernel.org. This is still rejecting: patching file drivers/scsi/megaraid/megaraid_mm.c Hunk #2 FAILED at 43. Hunk #4 FAILED at 68. Hunk #5 FAILED at 1217. Hunk #6 FAILED at 1225. Hunk #7 FAILED at 1245. 5 out of 7 hunks FAILED -- saving rejects to file drivers/scsi/megaraid/megaraid_mm.c.rej Could you rebase this patch to the bk snapshots so we can look at applying it? Thanks, James - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
On Thursday, March 17, 2005 1:26 AM, Andrew wrote:
> Some of these things have already been done in Linus's
> post-2.6.11 tree and
> you patch throws lots of rejects. Please always work against the most
> recent kernel - 2.6.11 is very out of date.
Thank you for correction. I've created NEW patch against 2.6.11.4 which is
latest from kernel.org.
>
> The patch was severely wordwrapped. Please fix your email
> client and send
> a test patch to yourself and ensure that it still applies OK.
Sorry for inconvenience. The patch in here should not have the issue.
Also, I'm including the patch as attachment.
Thank you
Signed-off-by: Seokmann Ju <[EMAIL PROTECTED]>
---
diff -Naur old/Documentation/scsi/ChangeLog.megaraid
new/Documentation/scsi/ChangeLog.megaraid
--- old/Documentation/scsi/ChangeLog.megaraid 2005-03-17
09:54:51.780719824 -0500
+++ new/Documentation/scsi/ChangeLog.megaraid 2005-03-17
09:14:03.247953384 -0500
@@ -1,3 +1,69 @@
+Release Date : Mon Mar 07 12:27:22 EST 2005 - Seokmann Ju <[EMAIL PROTECTED]>
+Current Version: 2.20.4.6 (scsi module), 2.20.2.6 (cmm module)
+Older Version : 2.20.4.5 (scsi module), 2.20.2.5 (cmm module)
+
+1. Added IOCTL backward compatibility.
+ Convert megaraid_mm driver to new compat_ioctl entry points.
+ I don't have easy access to hardware, so only compile tested.
+ - Signed-off-by:Andi Kleen <[EMAIL PROTECTED]>
+
+2. megaraid_mbox fix: wrong order of arguments in memset()
+ That, BTW, shows why cross-builds are useful-the only indication of
+ problem had been a new warning showing up in sparse output on alpha
+ build (number of exceeding 256 got truncated).
+ - Signed-off-by: Al Viro
+ <[EMAIL PROTECTED]>
+
+3. Convert pci_module_init to pci_register_driver
+ Convert from pci_module_init to pci_register_driver
+ (from:http://kerneljanitors.org/TODO)
+ - Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
+
+4. Use the pre defined DMA mask constants from dma-mapping.h
+ Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when
calling
+ pci_set_dma_mask() or pci_set_consistend_dma_mask(). See
+ http://marc.theaimsgroup.com/?t=10800199301=1=2 for more
+ details.
+ Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]>
+ Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
+
+5. Remove SSID checking for Dobson, Lindsay, and Verde based products.
+ Checking the SSVID/SSID for controllers which have Dobson, Lindsay,
+ and Verde is unnecessary because device ID has been assigned by LSI
+ and it is unique value. So, all controllers with these IOPs have to
be
+ supported by the driver regardless SSVID/SSID.
+
+6. Date Thu, 27 Jan 2005 04:31:09 +0100
+ From Herbert Poetzl <>
+ Subject RFC: assert_spin_locked() for 2.6
+
+ Greetings!
+
+ overcautious programming will kill your kernel ;)
+ ever thought about checking a spin_lock or even
+ asserting that it must be held (maybe just for
+ spinlock debugging?) ...
+
+ there are several checks present in the kernel
+ where somebody does a variation on the following:
+
+ BUG_ON(!spin_is_locked(_lock));
+
+ so what's wrong about that? nothing, unless you
+ compile the code with CONFIG_DEBUG_SPINLOCK but
+ without CONFIG_SMP ... in which case the BUG()
+ will kill your kernel ...
+
+ maybe it's not advised to make such assertions,
+ but here is a solution which works for me ...
+ (compile tested for sh, x86_64 and x86, boot/run
+ tested for x86 only)
+
+ best,
+ Herbert
+
+ - Herbert Poetzl <[EMAIL PROTECTED]>, Thu, 27 Jan 2005
+
Release Date : Thu Feb 03 12:27:22 EST 2005 - Seokmann Ju <[EMAIL PROTECTED]>
Current Version: 2.20.4.5 (scsi module), 2.20.2.5 (cmm module)
Older Version : 2.20.4.4 (scsi module), 2.20.2.4 (cmm module)
diff -Naur old/drivers/scsi/megaraid/mega_common.h
new/drivers/scsi/megaraid/mega_common.h
--- old/drivers/scsi/megaraid/mega_common.h 2005-03-17
08:37:00.147915960 -0500
+++ new/drivers/scsi/megaraid/mega_common.h 2005-03-17
07:16:21.209546408 -0500
@@ -27,6 +27,7 @@
#include
#include
#include
+#include
#include
#include
#include
diff -Naur old/drivers/scsi/megaraid/megaraid_mbox.c
new/drivers/scsi/megaraid/megaraid_mbox.c
--- old/drivers/scsi/megaraid/megaraid_mbox.c 2005-03-17
08:37:00.110921584 -0500
+++ new/drivers/scsi/megaraid/megaraid_mbox.c 2005-03-17
09:03:41.275507568 -0500
@@ -10,7 +10,7 @@
*2 of the License, or (at your option) any later version.
*
* FILE: megaraid_mbox.c
- * Version : v2.20.4.5 (Feb 03 2005)
+ * Version : v2.20.4.6 (Mar 07 2005)
*
* Authors:
* Atul Mukker <[EMAIL PROTECTED]>
@@ -202,7 +202,7 @@
* ### global data ###
*/
static
RE: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
On Thursday, March 17, 2005 1:26 AM, Andrew wrote:
Some of these things have already been done in Linus's
post-2.6.11 tree and
you patch throws lots of rejects. Please always work against the most
recent kernel - 2.6.11 is very out of date.
Thank you for correction. I've created NEW patch against 2.6.11.4 which is
latest from kernel.org.
The patch was severely wordwrapped. Please fix your email
client and send
a test patch to yourself and ensure that it still applies OK.
Sorry for inconvenience. The patch in here should not have the issue.
Also, I'm including the patch as attachment.
Thank you
Signed-off-by: Seokmann Ju [EMAIL PROTECTED]
---
diff -Naur old/Documentation/scsi/ChangeLog.megaraid
new/Documentation/scsi/ChangeLog.megaraid
--- old/Documentation/scsi/ChangeLog.megaraid 2005-03-17
09:54:51.780719824 -0500
+++ new/Documentation/scsi/ChangeLog.megaraid 2005-03-17
09:14:03.247953384 -0500
@@ -1,3 +1,69 @@
+Release Date : Mon Mar 07 12:27:22 EST 2005 - Seokmann Ju [EMAIL PROTECTED]
+Current Version: 2.20.4.6 (scsi module), 2.20.2.6 (cmm module)
+Older Version : 2.20.4.5 (scsi module), 2.20.2.5 (cmm module)
+
+1. Added IOCTL backward compatibility.
+ Convert megaraid_mm driver to new compat_ioctl entry points.
+ I don't have easy access to hardware, so only compile tested.
+ - Signed-off-by:Andi Kleen [EMAIL PROTECTED]
+
+2. megaraid_mbox fix: wrong order of arguments in memset()
+ That, BTW, shows why cross-builds are useful-the only indication of
+ problem had been a new warning showing up in sparse output on alpha
+ build (number of exceeding 256 got truncated).
+ - Signed-off-by: Al Viro
+ [EMAIL PROTECTED]
+
+3. Convert pci_module_init to pci_register_driver
+ Convert from pci_module_init to pci_register_driver
+ (from:http://kerneljanitors.org/TODO)
+ - Signed-off-by: Domen Puncer [EMAIL PROTECTED]
+
+4. Use the pre defined DMA mask constants from dma-mapping.h
+ Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when
calling
+ pci_set_dma_mask() or pci_set_consistend_dma_mask(). See
+ http://marc.theaimsgroup.com/?t=10800199301r=1w=2 for more
+ details.
+ Signed-off-by: Tobias Klauser [EMAIL PROTECTED]
+ Signed-off-by: Domen Puncer [EMAIL PROTECTED]
+
+5. Remove SSID checking for Dobson, Lindsay, and Verde based products.
+ Checking the SSVID/SSID for controllers which have Dobson, Lindsay,
+ and Verde is unnecessary because device ID has been assigned by LSI
+ and it is unique value. So, all controllers with these IOPs have to
be
+ supported by the driver regardless SSVID/SSID.
+
+6. Date Thu, 27 Jan 2005 04:31:09 +0100
+ From Herbert Poetzl
+ Subject RFC: assert_spin_locked() for 2.6
+
+ Greetings!
+
+ overcautious programming will kill your kernel ;)
+ ever thought about checking a spin_lock or even
+ asserting that it must be held (maybe just for
+ spinlock debugging?) ...
+
+ there are several checks present in the kernel
+ where somebody does a variation on the following:
+
+ BUG_ON(!spin_is_locked(some_lock));
+
+ so what's wrong about that? nothing, unless you
+ compile the code with CONFIG_DEBUG_SPINLOCK but
+ without CONFIG_SMP ... in which case the BUG()
+ will kill your kernel ...
+
+ maybe it's not advised to make such assertions,
+ but here is a solution which works for me ...
+ (compile tested for sh, x86_64 and x86, boot/run
+ tested for x86 only)
+
+ best,
+ Herbert
+
+ - Herbert Poetzl [EMAIL PROTECTED], Thu, 27 Jan 2005
+
Release Date : Thu Feb 03 12:27:22 EST 2005 - Seokmann Ju [EMAIL PROTECTED]
Current Version: 2.20.4.5 (scsi module), 2.20.2.5 (cmm module)
Older Version : 2.20.4.4 (scsi module), 2.20.2.4 (cmm module)
diff -Naur old/drivers/scsi/megaraid/mega_common.h
new/drivers/scsi/megaraid/mega_common.h
--- old/drivers/scsi/megaraid/mega_common.h 2005-03-17
08:37:00.147915960 -0500
+++ new/drivers/scsi/megaraid/mega_common.h 2005-03-17
07:16:21.209546408 -0500
@@ -27,6 +27,7 @@
#include linux/list.h
#include linux/version.h
#include linux/moduleparam.h
+#include linux/dma-mapping.h
#include asm/semaphore.h
#include scsi/scsi.h
#include scsi/scsi_cmnd.h
diff -Naur old/drivers/scsi/megaraid/megaraid_mbox.c
new/drivers/scsi/megaraid/megaraid_mbox.c
--- old/drivers/scsi/megaraid/megaraid_mbox.c 2005-03-17
08:37:00.110921584 -0500
+++ new/drivers/scsi/megaraid/megaraid_mbox.c 2005-03-17
09:03:41.275507568 -0500
@@ -10,7 +10,7 @@
*2 of the License, or (at your option) any later version.
*
* FILE: megaraid_mbox.c
- * Version : v2.20.4.5 (Feb 03 2005)
+ * Version : v2.20.4.6 (Mar 07 2005)
*
* Authors:
* Atul Mukker
RE: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
On Thu, 2005-03-17 at 11:48 -0500, Ju, Seokmann wrote: On Thursday, March 17, 2005 1:26 AM, Andrew wrote: Some of these things have already been done in Linus's post-2.6.11 tree and you patch throws lots of rejects. Please always work against the most recent kernel - 2.6.11 is very out of date. Thank you for correction. I've created NEW patch against 2.6.11.4 which is latest from kernel.org. This is still rejecting: patching file drivers/scsi/megaraid/megaraid_mm.c Hunk #2 FAILED at 43. Hunk #4 FAILED at 68. Hunk #5 FAILED at 1217. Hunk #6 FAILED at 1225. Hunk #7 FAILED at 1245. 5 out of 7 hunks FAILED -- saving rejects to file drivers/scsi/megaraid/megaraid_mm.c.rej Could you rebase this patch to the bk snapshots so we can look at applying it? Thanks, James - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
On Thursday, March 17, 2005 12:28 PM, James wrote:
This is still rejecting:
patching file drivers/scsi/megaraid/megaraid_mm.c
Hunk #2 FAILED at 43.
Hunk #4 FAILED at 68.
Hunk #5 FAILED at 1217.
Hunk #6 FAILED at 1225.
Hunk #7 FAILED at 1245.
5 out of 7 hunks FAILED -- saving rejects to file
drivers/scsi/megaraid/megaraid_mm.c.rej
Thank you for correction again.
At this time, I've download the source from
BK:/linux.bkbits.net:8080/linux-2.6 and found that the source already
includes 'compat_ioctl' support. Here, I'm sending another patch that has
fix for this issue.
I've verified (also, recreated above error with previous patch) this by
applying the patch to the source from BK.
I'm learning from your great comments and I appreciate your time on this.
Please let me know for any comment.
Thank you.
Sign-off-by: Seokmann Ju [EMAIL PROTECTED]
---
diff -Naur BK/Documentation/scsi/ChangeLog.megaraid
new/Documentation/scsi/ChangeLog.megaraid
--- BK/Documentation/scsi/ChangeLog.megaraid2005-03-17
18:06:38.115075184 -0500
+++ new/Documentation/scsi/ChangeLog.megaraid 2005-03-17
09:14:03.247953384 -0500
@@ -1,3 +1,69 @@
+Release Date : Mon Mar 07 12:27:22 EST 2005 - Seokmann Ju [EMAIL PROTECTED]
+Current Version: 2.20.4.6 (scsi module), 2.20.2.6 (cmm module)
+Older Version : 2.20.4.5 (scsi module), 2.20.2.5 (cmm module)
+
+1. Added IOCTL backward compatibility.
+ Convert megaraid_mm driver to new compat_ioctl entry points.
+ I don't have easy access to hardware, so only compile tested.
+ - Signed-off-by:Andi Kleen [EMAIL PROTECTED]
+
+2. megaraid_mbox fix: wrong order of arguments in memset()
+ That, BTW, shows why cross-builds are useful-the only indication of
+ problem had been a new warning showing up in sparse output on alpha
+ build (number of exceeding 256 got truncated).
+ - Signed-off-by: Al Viro
+ [EMAIL PROTECTED]
+
+3. Convert pci_module_init to pci_register_driver
+ Convert from pci_module_init to pci_register_driver
+ (from:http://kerneljanitors.org/TODO)
+ - Signed-off-by: Domen Puncer [EMAIL PROTECTED]
+
+4. Use the pre defined DMA mask constants from dma-mapping.h
+ Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when
calling
+ pci_set_dma_mask() or pci_set_consistend_dma_mask(). See
+ http://marc.theaimsgroup.com/?t=10800199301r=1w=2 for more
+ details.
+ Signed-off-by: Tobias Klauser [EMAIL PROTECTED]
+ Signed-off-by: Domen Puncer [EMAIL PROTECTED]
+
+5. Remove SSID checking for Dobson, Lindsay, and Verde based products.
+ Checking the SSVID/SSID for controllers which have Dobson, Lindsay,
+ and Verde is unnecessary because device ID has been assigned by LSI
+ and it is unique value. So, all controllers with these IOPs have to
be
+ supported by the driver regardless SSVID/SSID.
+
+6. Date Thu, 27 Jan 2005 04:31:09 +0100
+ From Herbert Poetzl
+ Subject RFC: assert_spin_locked() for 2.6
+
+ Greetings!
+
+ overcautious programming will kill your kernel ;)
+ ever thought about checking a spin_lock or even
+ asserting that it must be held (maybe just for
+ spinlock debugging?) ...
+
+ there are several checks present in the kernel
+ where somebody does a variation on the following:
+
+ BUG_ON(!spin_is_locked(some_lock));
+
+ so what's wrong about that? nothing, unless you
+ compile the code with CONFIG_DEBUG_SPINLOCK but
+ without CONFIG_SMP ... in which case the BUG()
+ will kill your kernel ...
+
+ maybe it's not advised to make such assertions,
+ but here is a solution which works for me ...
+ (compile tested for sh, x86_64 and x86, boot/run
+ tested for x86 only)
+
+ best,
+ Herbert
+
+ - Herbert Poetzl [EMAIL PROTECTED], Thu, 27 Jan 2005
+
Release Date : Thu Feb 03 12:27:22 EST 2005 - Seokmann Ju [EMAIL PROTECTED]
Current Version: 2.20.4.5 (scsi module), 2.20.2.5 (cmm module)
Older Version : 2.20.4.4 (scsi module), 2.20.2.4 (cmm module)
diff -Naur BK/drivers/scsi/megaraid/mega_common.h
new/drivers/scsi/megaraid/mega_common.h
--- BK/drivers/scsi/megaraid/mega_common.h 2005-03-17
20:01:55.774431112 -0500
+++ new/drivers/scsi/megaraid/mega_common.h 2005-03-17
07:16:21.209546408 -0500
@@ -27,6 +27,7 @@
#include linux/list.h
#include linux/version.h
#include linux/moduleparam.h
+#include linux/dma-mapping.h
#include asm/semaphore.h
#include scsi/scsi.h
#include scsi/scsi_cmnd.h
diff -Naur BK/drivers/scsi/megaraid/megaraid_mbox.c
new/drivers/scsi/megaraid/megaraid_mbox.c
--- BK/drivers/scsi/megaraid/megaraid_mbox.c2005-03-17
20:01:55.782429896 -0500
+++ new/drivers/scsi/megaraid/megaraid_mbox.c 2005-03-17
09:03:41.275507568 -0500
@@ -10,7 +10,7 @@
*2 of the License, or (at your
Re: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
Ju, Seokmann [EMAIL PROTECTED] wrote: Here, I'm sending another patch that has fix for this issue. It is still wordwrapped. Please fix you email client, email the patch to yourself, ensure that the result still applies, then resend it with a full description. Thanks. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
"Ju, Seokmann" <[EMAIL PROTECTED]> wrote:
>
> Here is a patch for megaraid_mm/megaraid_mbox driver which makes it
> 2.20.4.6.
> Following is brief on the changes:
> 1. Added compat_ioctl
> 2. Reordered inputs on memset
> 3. Convert pci_module_iit to pci_register_driver
> 4. Added DMA_{32,64}BIT_MASK 5. Modified PCI PnP ID table
Some of these things have already been done in Linus's post-2.6.11 tree and
you patch throws lots of rejects. Please always work against the most
recent kernel - 2.6.11 is very out of date.
The patch was severely wordwrapped. Please fix your email client and send
a test patch to yourself and ensure that it still applies OK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [ANNOUNCE][PATCH] drivers/scsi/megaraid/megaraid_{mm,mbox}
Ju, Seokmann [EMAIL PROTECTED] wrote:
Here is a patch for megaraid_mm/megaraid_mbox driver which makes it
2.20.4.6.
Following is brief on the changes:
1. Added compat_ioctl
2. Reordered inputs on memset
3. Convert pci_module_iit to pci_register_driver
4. Added DMA_{32,64}BIT_MASK 5. Modified PCI PnP ID table
Some of these things have already been done in Linus's post-2.6.11 tree and
you patch throws lots of rejects. Please always work against the most
recent kernel - 2.6.11 is very out of date.
The patch was severely wordwrapped. Please fix your email client and send
a test patch to yourself and ensure that it still applies OK.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
