Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
On Tue, 21 Aug 2018 09:22:07 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Tuesday, August 21, 2018 11:30 AM > > To: Naga Sureshkumar Relli > > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > > computersforpe...@gmail.com; marek.va...@gmail.com; > > kyungmin.p...@samsung.com; > > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > > linux- > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > ; > > nagasureshkumarre...@gmail.com > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device > > tree binding > > documentation > > > > On Tue, 21 Aug 2018 05:47:18 + > > Naga Sureshkumar Relli wrote: > > > > > > > +Required properties: > > > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > > > "arasan,nfc-v3p10" > > > > > > > > In your example it's not an "or" since both are defined. > > > In our previous discussion > > > (https://lore.kernel.org/patchwork/patch/748901/) > > > We decided to have compatible strings like " compatible = > > > ",", > > "arasan,";" > > > So it should be either of these. > > > so I will write something like below > > > "Possible values are "xlnx,zynqmp-nand" > > > "arasan,nfc-v3p10" > > > And in example I will mention any one compatible. > > > Is it ok? > > > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be > > overloaded by a soc specific > > compat? > Actually we put these compatible strings based on the comments on v7 series. > Anyway I will just keep "xlnx,zynqmp-nand" as compatible. If Rob said you should have both, then keep both, but the description should match, because "arasan,nfc-v3p10" cannot be used alone, it has to be placed next to a ",nfc-" string.
Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
On Tue, 21 Aug 2018 09:22:07 + Naga Sureshkumar Relli wrote: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Tuesday, August 21, 2018 11:30 AM > > To: Naga Sureshkumar Relli > > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > > computersforpe...@gmail.com; marek.va...@gmail.com; > > kyungmin.p...@samsung.com; > > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > > linux- > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > ; > > nagasureshkumarre...@gmail.com > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device > > tree binding > > documentation > > > > On Tue, 21 Aug 2018 05:47:18 + > > Naga Sureshkumar Relli wrote: > > > > > > > +Required properties: > > > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > > > "arasan,nfc-v3p10" > > > > > > > > In your example it's not an "or" since both are defined. > > > In our previous discussion > > > (https://lore.kernel.org/patchwork/patch/748901/) > > > We decided to have compatible strings like " compatible = > > > ",", > > "arasan,";" > > > So it should be either of these. > > > so I will write something like below > > > "Possible values are "xlnx,zynqmp-nand" > > > "arasan,nfc-v3p10" > > > And in example I will mention any one compatible. > > > Is it ok? > > > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be > > overloaded by a soc specific > > compat? > Actually we put these compatible strings based on the comments on v7 series. > Anyway I will just keep "xlnx,zynqmp-nand" as compatible. If Rob said you should have both, then keep both, but the description should match, because "arasan,nfc-v3p10" cannot be used alone, it has to be placed next to a ",nfc-" string.
Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
On Tue, 21 Aug 2018 10:44:54 + Naga Sureshkumar Relli wrote: > Hi Miquel, > > > -Original Message- > > From: Miquel Raynal [mailto:miquel.ray...@bootlin.com] > > Sent: Tuesday, August 21, 2018 3:23 PM > > To: Naga Sureshkumar Relli > > Cc: Boris Brezillon ; rich...@nod.at; > > dw...@infradead.org; > > computersforpe...@gmail.com; marek.va...@gmail.com; > > kyungmin.p...@samsung.com; > > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > > linux- > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > ; > > nagasureshkumarre...@gmail.com > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device > > tree binding > > documentation > > > > Hi Naga, > > > > Naga Sureshkumar Relli wrote on Tue, 21 Aug 2018 > > 09:22:07 +: > > > > > Hi Boris, > > > > > > > -Original Message- > > > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > > > Sent: Tuesday, August 21, 2018 11:30 AM > > > > To: Naga Sureshkumar Relli > > > > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > > > > computersforpe...@gmail.com; marek.va...@gmail.com; > > > > kyungmin.p...@samsung.com; abs...@codeaurora.org; > > > > peterpand...@micron.com; frieder.schre...@exceet.de; linux- > > > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > > > ; nagasureshkumarre...@gmail.com > > > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add > > > > device tree binding documentation > > > > > > > > On Tue, 21 Aug 2018 05:47:18 + > > > > Naga Sureshkumar Relli wrote: > > > > > > > > > > > +Required properties: > > > > > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > > > > > "arasan,nfc-v3p10" > > > > > > > > > > > > In your example it's not an "or" since both are defined. > > > > > In our previous discussion > > > > > (https://lore.kernel.org/patchwork/patch/748901/) > > > > > We decided to have compatible strings like " compatible = > > > > > ",", > > > > "arasan,";" > > > > > So it should be either of these. > > > > > so I will write something like below "Possible values are > > > > > "xlnx,zynqmp-nand" > > > > > "arasan,nfc-v3p10" > > > > > And in example I will mention any one compatible. > > > > > Is it ok? > > > > > > > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be > > > > overloaded by a soc specific compat? > > > Actually we put these compatible strings based on the comments on v7 > > > series. > > > Anyway I will just keep "xlnx,zynqmp-nand" as compatible. > > > > > > > > > > > + > > > > > > > +Optional properties: > > > > > > > +- arasan,has-mdma: Enables DMA support > > > > > > > > > > > > Can't you detect that based on the compatible (or thanks to a > > > > > > register). If it's something you choose when configuring the IP > > > > > > and can't detect at > > > > runtime I guess it's fine. > > > > > There is no way to select DMA when configuring the IP. > > > > > But it has internal DMA and there is a register to select PIO or > > > > > DMA while starting a > > > > transfer. > > > > > So if user really don't want DMA, then we will never set DMA in > > > > > the code based on DT > > > > property. > > > > > > > > If it's a purely SW choice, then is shouldn't be described in the DT. > > > > You can use a module param, but I'm not even sure why one would want to > > > > disable DMA. > > > UBIFS doesn't work with DMA, hence we are using a DT property to operate > > > the driver in > > IO. > > > But as you pointed (use virt_is_valid()), with this we can switch our > > > driver to operate in > > PIO or DMA. > > > I will remove this from DT. > > > > I don't get why UBIFS would not work with DMA? This is a significant > > drawback. > UBIFS uses vmalloc'ed buffers whereas for DMA it should be DMA-able, i.e uses > physically contiguous memory. > Hence we used a DT property to make it work in PIO mode. > Some discussion happened in https://patchwork.kernel.org/patch/9675007/. > But whatever I said above, is with older arasan_nand driver, now anyway we > have > virt_addr_valid(). By checking this we can use DMA or PIO. > This is the information I have, but I may be wrong. My recommandation: set the NAND_USE_BOUNCE_BUFFER and always use DMA.
Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
On Tue, 21 Aug 2018 10:44:54 + Naga Sureshkumar Relli wrote: > Hi Miquel, > > > -Original Message- > > From: Miquel Raynal [mailto:miquel.ray...@bootlin.com] > > Sent: Tuesday, August 21, 2018 3:23 PM > > To: Naga Sureshkumar Relli > > Cc: Boris Brezillon ; rich...@nod.at; > > dw...@infradead.org; > > computersforpe...@gmail.com; marek.va...@gmail.com; > > kyungmin.p...@samsung.com; > > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > > linux- > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > ; > > nagasureshkumarre...@gmail.com > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device > > tree binding > > documentation > > > > Hi Naga, > > > > Naga Sureshkumar Relli wrote on Tue, 21 Aug 2018 > > 09:22:07 +: > > > > > Hi Boris, > > > > > > > -Original Message- > > > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > > > Sent: Tuesday, August 21, 2018 11:30 AM > > > > To: Naga Sureshkumar Relli > > > > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > > > > computersforpe...@gmail.com; marek.va...@gmail.com; > > > > kyungmin.p...@samsung.com; abs...@codeaurora.org; > > > > peterpand...@micron.com; frieder.schre...@exceet.de; linux- > > > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > > > ; nagasureshkumarre...@gmail.com > > > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add > > > > device tree binding documentation > > > > > > > > On Tue, 21 Aug 2018 05:47:18 + > > > > Naga Sureshkumar Relli wrote: > > > > > > > > > > > +Required properties: > > > > > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > > > > > "arasan,nfc-v3p10" > > > > > > > > > > > > In your example it's not an "or" since both are defined. > > > > > In our previous discussion > > > > > (https://lore.kernel.org/patchwork/patch/748901/) > > > > > We decided to have compatible strings like " compatible = > > > > > ",", > > > > "arasan,";" > > > > > So it should be either of these. > > > > > so I will write something like below "Possible values are > > > > > "xlnx,zynqmp-nand" > > > > > "arasan,nfc-v3p10" > > > > > And in example I will mention any one compatible. > > > > > Is it ok? > > > > > > > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be > > > > overloaded by a soc specific compat? > > > Actually we put these compatible strings based on the comments on v7 > > > series. > > > Anyway I will just keep "xlnx,zynqmp-nand" as compatible. > > > > > > > > > > > + > > > > > > > +Optional properties: > > > > > > > +- arasan,has-mdma: Enables DMA support > > > > > > > > > > > > Can't you detect that based on the compatible (or thanks to a > > > > > > register). If it's something you choose when configuring the IP > > > > > > and can't detect at > > > > runtime I guess it's fine. > > > > > There is no way to select DMA when configuring the IP. > > > > > But it has internal DMA and there is a register to select PIO or > > > > > DMA while starting a > > > > transfer. > > > > > So if user really don't want DMA, then we will never set DMA in > > > > > the code based on DT > > > > property. > > > > > > > > If it's a purely SW choice, then is shouldn't be described in the DT. > > > > You can use a module param, but I'm not even sure why one would want to > > > > disable DMA. > > > UBIFS doesn't work with DMA, hence we are using a DT property to operate > > > the driver in > > IO. > > > But as you pointed (use virt_is_valid()), with this we can switch our > > > driver to operate in > > PIO or DMA. > > > I will remove this from DT. > > > > I don't get why UBIFS would not work with DMA? This is a significant > > drawback. > UBIFS uses vmalloc'ed buffers whereas for DMA it should be DMA-able, i.e uses > physically contiguous memory. > Hence we used a DT property to make it work in PIO mode. > Some discussion happened in https://patchwork.kernel.org/patch/9675007/. > But whatever I said above, is with older arasan_nand driver, now anyway we > have > virt_addr_valid(). By checking this we can use DMA or PIO. > This is the information I have, but I may be wrong. My recommandation: set the NAND_USE_BOUNCE_BUFFER and always use DMA.
RE: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
Hi Miquel, > -Original Message- > From: Miquel Raynal [mailto:miquel.ray...@bootlin.com] > Sent: Tuesday, August 21, 2018 3:23 PM > To: Naga Sureshkumar Relli > Cc: Boris Brezillon ; rich...@nod.at; > dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com; > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > linux- > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > ; > nagasureshkumarre...@gmail.com > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree > binding > documentation > > Hi Naga, > > Naga Sureshkumar Relli wrote on Tue, 21 Aug 2018 > 09:22:07 +: > > > Hi Boris, > > > > > -Original Message- > > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > > Sent: Tuesday, August 21, 2018 11:30 AM > > > To: Naga Sureshkumar Relli > > > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > > > computersforpe...@gmail.com; marek.va...@gmail.com; > > > kyungmin.p...@samsung.com; abs...@codeaurora.org; > > > peterpand...@micron.com; frieder.schre...@exceet.de; linux- > > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > > ; nagasureshkumarre...@gmail.com > > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add > > > device tree binding documentation > > > > > > On Tue, 21 Aug 2018 05:47:18 + > > > Naga Sureshkumar Relli wrote: > > > > > > > > > +Required properties: > > > > > > +- compatible: Should be "xlnx,zynqmp-nand" or > > > > > > "arasan,nfc-v3p10" > > > > > > > > > > In your example it's not an "or" since both are defined. > > > > In our previous discussion > > > > (https://lore.kernel.org/patchwork/patch/748901/) > > > > We decided to have compatible strings like " compatible = > > > > ",", > > > "arasan,";" > > > > So it should be either of these. > > > > so I will write something like below "Possible values are > > > > "xlnx,zynqmp-nand" > > > > "arasan,nfc-v3p10" > > > > And in example I will mention any one compatible. > > > > Is it ok? > > > > > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be > > > overloaded by a soc specific compat? > > Actually we put these compatible strings based on the comments on v7 series. > > Anyway I will just keep "xlnx,zynqmp-nand" as compatible. > > > > > > > > > + > > > > > > +Optional properties: > > > > > > +- arasan,has-mdma: Enables DMA support > > > > > > > > > > Can't you detect that based on the compatible (or thanks to a > > > > > register). If it's something you choose when configuring the IP > > > > > and can't detect at > > > runtime I guess it's fine. > > > > There is no way to select DMA when configuring the IP. > > > > But it has internal DMA and there is a register to select PIO or > > > > DMA while starting a > > > transfer. > > > > So if user really don't want DMA, then we will never set DMA in > > > > the code based on DT > > > property. > > > > > > If it's a purely SW choice, then is shouldn't be described in the DT. > > > You can use a module param, but I'm not even sure why one would want to > > > disable DMA. > > UBIFS doesn't work with DMA, hence we are using a DT property to operate > > the driver in > IO. > > But as you pointed (use virt_is_valid()), with this we can switch our > > driver to operate in > PIO or DMA. > > I will remove this from DT. > > I don't get why UBIFS would not work with DMA? This is a significant drawback. UBIFS uses vmalloc'ed buffers whereas for DMA it should be DMA-able, i.e uses physically contiguous memory. Hence we used a DT property to make it work in PIO mode. Some discussion happened in https://patchwork.kernel.org/patch/9675007/. But whatever I said above, is with older arasan_nand driver, now anyway we have virt_addr_valid(). By checking this we can use DMA or PIO. This is the information I have, but I may be wrong. Thanks, Naga Sureshkumar Relli. > > Miquèl
RE: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
Hi Miquel, > -Original Message- > From: Miquel Raynal [mailto:miquel.ray...@bootlin.com] > Sent: Tuesday, August 21, 2018 3:23 PM > To: Naga Sureshkumar Relli > Cc: Boris Brezillon ; rich...@nod.at; > dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com; > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > linux- > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > ; > nagasureshkumarre...@gmail.com > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree > binding > documentation > > Hi Naga, > > Naga Sureshkumar Relli wrote on Tue, 21 Aug 2018 > 09:22:07 +: > > > Hi Boris, > > > > > -Original Message- > > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > > Sent: Tuesday, August 21, 2018 11:30 AM > > > To: Naga Sureshkumar Relli > > > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > > > computersforpe...@gmail.com; marek.va...@gmail.com; > > > kyungmin.p...@samsung.com; abs...@codeaurora.org; > > > peterpand...@micron.com; frieder.schre...@exceet.de; linux- > > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > > ; nagasureshkumarre...@gmail.com > > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add > > > device tree binding documentation > > > > > > On Tue, 21 Aug 2018 05:47:18 + > > > Naga Sureshkumar Relli wrote: > > > > > > > > > +Required properties: > > > > > > +- compatible: Should be "xlnx,zynqmp-nand" or > > > > > > "arasan,nfc-v3p10" > > > > > > > > > > In your example it's not an "or" since both are defined. > > > > In our previous discussion > > > > (https://lore.kernel.org/patchwork/patch/748901/) > > > > We decided to have compatible strings like " compatible = > > > > ",", > > > "arasan,";" > > > > So it should be either of these. > > > > so I will write something like below "Possible values are > > > > "xlnx,zynqmp-nand" > > > > "arasan,nfc-v3p10" > > > > And in example I will mention any one compatible. > > > > Is it ok? > > > > > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be > > > overloaded by a soc specific compat? > > Actually we put these compatible strings based on the comments on v7 series. > > Anyway I will just keep "xlnx,zynqmp-nand" as compatible. > > > > > > > > > + > > > > > > +Optional properties: > > > > > > +- arasan,has-mdma: Enables DMA support > > > > > > > > > > Can't you detect that based on the compatible (or thanks to a > > > > > register). If it's something you choose when configuring the IP > > > > > and can't detect at > > > runtime I guess it's fine. > > > > There is no way to select DMA when configuring the IP. > > > > But it has internal DMA and there is a register to select PIO or > > > > DMA while starting a > > > transfer. > > > > So if user really don't want DMA, then we will never set DMA in > > > > the code based on DT > > > property. > > > > > > If it's a purely SW choice, then is shouldn't be described in the DT. > > > You can use a module param, but I'm not even sure why one would want to > > > disable DMA. > > UBIFS doesn't work with DMA, hence we are using a DT property to operate > > the driver in > IO. > > But as you pointed (use virt_is_valid()), with this we can switch our > > driver to operate in > PIO or DMA. > > I will remove this from DT. > > I don't get why UBIFS would not work with DMA? This is a significant drawback. UBIFS uses vmalloc'ed buffers whereas for DMA it should be DMA-able, i.e uses physically contiguous memory. Hence we used a DT property to make it work in PIO mode. Some discussion happened in https://patchwork.kernel.org/patch/9675007/. But whatever I said above, is with older arasan_nand driver, now anyway we have virt_addr_valid(). By checking this we can use DMA or PIO. This is the information I have, but I may be wrong. Thanks, Naga Sureshkumar Relli. > > Miquèl
Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
Hi Naga, Naga Sureshkumar Relli wrote on Tue, 21 Aug 2018 09:22:07 +: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Tuesday, August 21, 2018 11:30 AM > > To: Naga Sureshkumar Relli > > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > > computersforpe...@gmail.com; marek.va...@gmail.com; > > kyungmin.p...@samsung.com; > > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > > linux- > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > ; > > nagasureshkumarre...@gmail.com > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device > > tree binding > > documentation > > > > On Tue, 21 Aug 2018 05:47:18 + > > Naga Sureshkumar Relli wrote: > > > > > > > +Required properties: > > > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > > > "arasan,nfc-v3p10" > > > > > > > > In your example it's not an "or" since both are defined. > > > In our previous discussion > > > (https://lore.kernel.org/patchwork/patch/748901/) > > > We decided to have compatible strings like " compatible = > > > ",", > > "arasan,";" > > > So it should be either of these. > > > so I will write something like below > > > "Possible values are "xlnx,zynqmp-nand" > > > "arasan,nfc-v3p10" > > > And in example I will mention any one compatible. > > > Is it ok? > > > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be > > overloaded by a soc specific > > compat? > Actually we put these compatible strings based on the comments on v7 series. > Anyway I will just keep "xlnx,zynqmp-nand" as compatible. > > > > > > > + > > > > > +Optional properties: > > > > > +- arasan,has-mdma: Enables DMA support > > > > > > > > Can't you detect that based on the compatible (or thanks to a > > > > register). If it's something you choose when configuring the IP and > > > > can't detect at > > runtime I guess it's fine. > > > There is no way to select DMA when configuring the IP. > > > But it has internal DMA and there is a register to select PIO or DMA > > > while starting a > > transfer. > > > So if user really don't want DMA, then we will never set DMA in the code > > > based on DT > > property. > > > > If it's a purely SW choice, then is shouldn't be described in the DT. > > You can use a module param, but I'm not even sure why one would want to > > disable DMA. > UBIFS doesn't work with DMA, hence we are using a DT property to operate the > driver in IO. > But as you pointed (use virt_is_valid()), with this we can switch our driver > to operate in PIO or DMA. > I will remove this from DT. I don't get why UBIFS would not work with DMA? This is a significant drawback. Miquèl
Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
Hi Naga, Naga Sureshkumar Relli wrote on Tue, 21 Aug 2018 09:22:07 +: > Hi Boris, > > > -Original Message- > > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > > Sent: Tuesday, August 21, 2018 11:30 AM > > To: Naga Sureshkumar Relli > > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > > computersforpe...@gmail.com; marek.va...@gmail.com; > > kyungmin.p...@samsung.com; > > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > > linux- > > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > > ; > > nagasureshkumarre...@gmail.com > > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device > > tree binding > > documentation > > > > On Tue, 21 Aug 2018 05:47:18 + > > Naga Sureshkumar Relli wrote: > > > > > > > +Required properties: > > > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > > > "arasan,nfc-v3p10" > > > > > > > > In your example it's not an "or" since both are defined. > > > In our previous discussion > > > (https://lore.kernel.org/patchwork/patch/748901/) > > > We decided to have compatible strings like " compatible = > > > ",", > > "arasan,";" > > > So it should be either of these. > > > so I will write something like below > > > "Possible values are "xlnx,zynqmp-nand" > > > "arasan,nfc-v3p10" > > > And in example I will mention any one compatible. > > > Is it ok? > > > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be > > overloaded by a soc specific > > compat? > Actually we put these compatible strings based on the comments on v7 series. > Anyway I will just keep "xlnx,zynqmp-nand" as compatible. > > > > > > > + > > > > > +Optional properties: > > > > > +- arasan,has-mdma: Enables DMA support > > > > > > > > Can't you detect that based on the compatible (or thanks to a > > > > register). If it's something you choose when configuring the IP and > > > > can't detect at > > runtime I guess it's fine. > > > There is no way to select DMA when configuring the IP. > > > But it has internal DMA and there is a register to select PIO or DMA > > > while starting a > > transfer. > > > So if user really don't want DMA, then we will never set DMA in the code > > > based on DT > > property. > > > > If it's a purely SW choice, then is shouldn't be described in the DT. > > You can use a module param, but I'm not even sure why one would want to > > disable DMA. > UBIFS doesn't work with DMA, hence we are using a DT property to operate the > driver in IO. > But as you pointed (use virt_is_valid()), with this we can switch our driver > to operate in PIO or DMA. > I will remove this from DT. I don't get why UBIFS would not work with DMA? This is a significant drawback. Miquèl
RE: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
Hi Boris, > -Original Message- > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > Sent: Tuesday, August 21, 2018 11:30 AM > To: Naga Sureshkumar Relli > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com; > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > linux- > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > ; > nagasureshkumarre...@gmail.com > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree > binding > documentation > > On Tue, 21 Aug 2018 05:47:18 + > Naga Sureshkumar Relli wrote: > > > > > +Required properties: > > > > +- compatible: Should be "xlnx,zynqmp-nand" or > > > > "arasan,nfc-v3p10" > > > > > > In your example it's not an "or" since both are defined. > > In our previous discussion > > (https://lore.kernel.org/patchwork/patch/748901/) > > We decided to have compatible strings like " compatible = > > ",", > "arasan,";" > > So it should be either of these. > > so I will write something like below > > "Possible values are "xlnx,zynqmp-nand" > > "arasan,nfc-v3p10" > > And in example I will mention any one compatible. > > Is it ok? > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be overloaded > by a soc specific > compat? Actually we put these compatible strings based on the comments on v7 series. Anyway I will just keep "xlnx,zynqmp-nand" as compatible. > > > > > + > > > > +Optional properties: > > > > +- arasan,has-mdma: Enables DMA support > > > > > > Can't you detect that based on the compatible (or thanks to a > > > register). If it's something you choose when configuring the IP and can't > > > detect at > runtime I guess it's fine. > > There is no way to select DMA when configuring the IP. > > But it has internal DMA and there is a register to select PIO or DMA while > > starting a > transfer. > > So if user really don't want DMA, then we will never set DMA in the code > > based on DT > property. > > If it's a purely SW choice, then is shouldn't be described in the DT. > You can use a module param, but I'm not even sure why one would want to > disable DMA. UBIFS doesn't work with DMA, hence we are using a DT property to operate the driver in IO. But as you pointed (use virt_is_valid()), with this we can switch our driver to operate in PIO or DMA. I will remove this from DT. Thanks, Naga Sureshkumar Relli.
RE: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
Hi Boris, > -Original Message- > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > Sent: Tuesday, August 21, 2018 11:30 AM > To: Naga Sureshkumar Relli > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com; > abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de; > linux- > m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek > ; > nagasureshkumarre...@gmail.com > Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree > binding > documentation > > On Tue, 21 Aug 2018 05:47:18 + > Naga Sureshkumar Relli wrote: > > > > > +Required properties: > > > > +- compatible: Should be "xlnx,zynqmp-nand" or > > > > "arasan,nfc-v3p10" > > > > > > In your example it's not an "or" since both are defined. > > In our previous discussion > > (https://lore.kernel.org/patchwork/patch/748901/) > > We decided to have compatible strings like " compatible = > > ",", > "arasan,";" > > So it should be either of these. > > so I will write something like below > > "Possible values are "xlnx,zynqmp-nand" > > "arasan,nfc-v3p10" > > And in example I will mention any one compatible. > > Is it ok? > > Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be overloaded > by a soc specific > compat? Actually we put these compatible strings based on the comments on v7 series. Anyway I will just keep "xlnx,zynqmp-nand" as compatible. > > > > > + > > > > +Optional properties: > > > > +- arasan,has-mdma: Enables DMA support > > > > > > Can't you detect that based on the compatible (or thanks to a > > > register). If it's something you choose when configuring the IP and can't > > > detect at > runtime I guess it's fine. > > There is no way to select DMA when configuring the IP. > > But it has internal DMA and there is a register to select PIO or DMA while > > starting a > transfer. > > So if user really don't want DMA, then we will never set DMA in the code > > based on DT > property. > > If it's a purely SW choice, then is shouldn't be described in the DT. > You can use a module param, but I'm not even sure why one would want to > disable DMA. UBIFS doesn't work with DMA, hence we are using a DT property to operate the driver in IO. But as you pointed (use virt_is_valid()), with this we can switch our driver to operate in PIO or DMA. I will remove this from DT. Thanks, Naga Sureshkumar Relli.
Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
On Tue, 21 Aug 2018 05:47:18 + Naga Sureshkumar Relli wrote: > > > +Required properties: > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > "arasan,nfc-v3p10" > > > > In your example it's not an "or" since both are defined. > In our previous discussion (https://lore.kernel.org/patchwork/patch/748901/) > We decided to have compatible strings like " compatible = > ",", "arasan,";" > So it should be either of these. > so I will write something like below > "Possible values are "xlnx,zynqmp-nand" > "arasan,nfc-v3p10" > And in example I will mention any one compatible. > Is it ok? Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be overloaded by a soc specific compat? > > > + > > > +Optional properties: > > > +- arasan,has-mdma: Enables DMA support > > > > Can't you detect that based on the compatible (or thanks to a register). If > > it's something you > > choose when configuring the IP and can't detect at runtime I guess it's > > fine. > There is no way to select DMA when configuring the IP. > But it has internal DMA and there is a register to select PIO or DMA while > starting a transfer. > So if user really don't want DMA, then we will never set DMA in the code > based on DT property. If it's a purely SW choice, then is shouldn't be described in the DT. You can use a module param, but I'm not even sure why one would want to disable DMA.
Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
On Tue, 21 Aug 2018 05:47:18 + Naga Sureshkumar Relli wrote: > > > +Required properties: > > > +- compatible:Should be "xlnx,zynqmp-nand" or > > > "arasan,nfc-v3p10" > > > > In your example it's not an "or" since both are defined. > In our previous discussion (https://lore.kernel.org/patchwork/patch/748901/) > We decided to have compatible strings like " compatible = > ",", "arasan,";" > So it should be either of these. > so I will write something like below > "Possible values are "xlnx,zynqmp-nand" > "arasan,nfc-v3p10" > And in example I will mention any one compatible. > Is it ok? Hm, why do you need arasan,nfc-v3p10 at all if it's supposed to be overloaded by a soc specific compat? > > > + > > > +Optional properties: > > > +- arasan,has-mdma: Enables DMA support > > > > Can't you detect that based on the compatible (or thanks to a register). If > > it's something you > > choose when configuring the IP and can't detect at runtime I guess it's > > fine. > There is no way to select DMA when configuring the IP. > But it has internal DMA and there is a register to select PIO or DMA while > starting a transfer. > So if user really don't want DMA, then we will never set DMA in the code > based on DT property. If it's a purely SW choice, then is shouldn't be described in the DT. You can use a module param, but I'm not even sure why one would want to disable DMA.
RE: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
Hi Boris,
> -Original Message-
> From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> Sent: Monday, August 20, 2018 6:03 PM
> To: Naga Sureshkumar Relli
> Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org;
> computersforpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com;
> abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de;
> linux-
> m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek
> ;
> nagasureshkumarre...@gmail.com
> Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree
> binding
> documentation
>
> On Fri, 17 Aug 2018 18:49:23 +0530
> Naga Sureshkumar Relli wrote:
>
> > This patch adds the dts binding document for arasan nand flash
> > controller.
> >
> > Signed-off-by: Naga Sureshkumar Relli
> >
> > ---
> > Changes in v10:
> > - None
> > Changes in v9:
> > - None
> > Changes in v8:
> > - Updated compatible and clock-names as per Boris comments Changes in
> > v7:
> > - Corrected the acronyms those should be in caps changes in v6:
> > - Removed num-cs property
> > - Separated nandchip from nand controller changes in v5:
> > - None
> > Changes in v4:
> > - Added num-cs property
> > - Added clock support
> > Changes in v3:
> > - None
> > Changes in v2:
> > - None
> > ---
> > .../devicetree/bindings/mtd/arasan_nand.txt| 38
> > ++
> > 1 file changed, 38 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/mtd/arasan_nand.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> > b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> > new file mode 100644
> > index 000..234d7ca
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> > @@ -0,0 +1,38 @@
> > +Arasan NAND Flash Controller with ONFI 3.1 support
> > +
> > +Required properties:
> > +- compatible: Should be "xlnx,zynqmp-nand" or
> > "arasan,nfc-v3p10"
>
> In your example it's not an "or" since both are defined.
In our previous discussion (https://lore.kernel.org/patchwork/patch/748901/)
We decided to have compatible strings like " compatible =
",", "arasan,";"
So it should be either of these.
so I will write something like below
"Possible values are "xlnx,zynqmp-nand"
"arasan,nfc-v3p10"
And in example I will mention any one compatible.
Is it ok?
>
> > +- reg: Memory map for module access
> > +- interrupt-parent:Interrupt controller the interrupt is routed
> > through
> > +- interrupts: Should contain the interrupt for the device
> > +- clock-name: List of input clocks - "sys", "flash"
>
> clock-names
Ok, will correct it in next version.
>
> > + (See clock bindings for details)
> > +- clocks: Clock phandles (see clock bindings for details)
> > +
> > +Optional properties:
> > +- arasan,has-mdma: Enables DMA support
>
> Can't you detect that based on the compatible (or thanks to a register). If
> it's something you
> choose when configuring the IP and can't detect at runtime I guess it's fine.
There is no way to select DMA when configuring the IP.
But it has internal DMA and there is a register to select PIO or DMA while
starting a transfer.
So if user really don't want DMA, then we will never set DMA in the code based
on DT property.
>
> > +
> > +For NAND partition information please refer the below file
> > +Documentation/devicetree/bindings/mtd/partition.txt
> > +
> > +Example:
> > + nand0: nand@ff10 {
> > + compatible = "xlnx,zynqmp-nand", "arasan,nfc-v3p10"
> > + reg = <0x0 0xff10 0x1000>;
> > + clock-name = "sys", "flash"
> > + clocks = <_clk _clk>;
> > + interrupt-parent = <>;
> > + interrupts = <0 14 4>;
> > + arasan,has-mdma;
> > + #address-cells = <1>;
> > + #size-cells = <0>
> > +
> > + nand@0 {
> > + reg = <0>
> > + partition@0 {
> > + label = "filesystem";
> > + reg = <0x0 0x0 0x100>;
> > + };
>
> Hm, not s
RE: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
Hi Boris,
> -Original Message-
> From: Boris Brezillon [mailto:boris.brezil...@bootlin.com]
> Sent: Monday, August 20, 2018 6:03 PM
> To: Naga Sureshkumar Relli
> Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org;
> computersforpe...@gmail.com; marek.va...@gmail.com; kyungmin.p...@samsung.com;
> abs...@codeaurora.org; peterpand...@micron.com; frieder.schre...@exceet.de;
> linux-
> m...@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek
> ;
> nagasureshkumarre...@gmail.com
> Subject: Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree
> binding
> documentation
>
> On Fri, 17 Aug 2018 18:49:23 +0530
> Naga Sureshkumar Relli wrote:
>
> > This patch adds the dts binding document for arasan nand flash
> > controller.
> >
> > Signed-off-by: Naga Sureshkumar Relli
> >
> > ---
> > Changes in v10:
> > - None
> > Changes in v9:
> > - None
> > Changes in v8:
> > - Updated compatible and clock-names as per Boris comments Changes in
> > v7:
> > - Corrected the acronyms those should be in caps changes in v6:
> > - Removed num-cs property
> > - Separated nandchip from nand controller changes in v5:
> > - None
> > Changes in v4:
> > - Added num-cs property
> > - Added clock support
> > Changes in v3:
> > - None
> > Changes in v2:
> > - None
> > ---
> > .../devicetree/bindings/mtd/arasan_nand.txt| 38
> > ++
> > 1 file changed, 38 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/mtd/arasan_nand.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> > b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> > new file mode 100644
> > index 000..234d7ca
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> > @@ -0,0 +1,38 @@
> > +Arasan NAND Flash Controller with ONFI 3.1 support
> > +
> > +Required properties:
> > +- compatible: Should be "xlnx,zynqmp-nand" or
> > "arasan,nfc-v3p10"
>
> In your example it's not an "or" since both are defined.
In our previous discussion (https://lore.kernel.org/patchwork/patch/748901/)
We decided to have compatible strings like " compatible =
",", "arasan,";"
So it should be either of these.
so I will write something like below
"Possible values are "xlnx,zynqmp-nand"
"arasan,nfc-v3p10"
And in example I will mention any one compatible.
Is it ok?
>
> > +- reg: Memory map for module access
> > +- interrupt-parent:Interrupt controller the interrupt is routed
> > through
> > +- interrupts: Should contain the interrupt for the device
> > +- clock-name: List of input clocks - "sys", "flash"
>
> clock-names
Ok, will correct it in next version.
>
> > + (See clock bindings for details)
> > +- clocks: Clock phandles (see clock bindings for details)
> > +
> > +Optional properties:
> > +- arasan,has-mdma: Enables DMA support
>
> Can't you detect that based on the compatible (or thanks to a register). If
> it's something you
> choose when configuring the IP and can't detect at runtime I guess it's fine.
There is no way to select DMA when configuring the IP.
But it has internal DMA and there is a register to select PIO or DMA while
starting a transfer.
So if user really don't want DMA, then we will never set DMA in the code based
on DT property.
>
> > +
> > +For NAND partition information please refer the below file
> > +Documentation/devicetree/bindings/mtd/partition.txt
> > +
> > +Example:
> > + nand0: nand@ff10 {
> > + compatible = "xlnx,zynqmp-nand", "arasan,nfc-v3p10"
> > + reg = <0x0 0xff10 0x1000>;
> > + clock-name = "sys", "flash"
> > + clocks = <_clk _clk>;
> > + interrupt-parent = <>;
> > + interrupts = <0 14 4>;
> > + arasan,has-mdma;
> > + #address-cells = <1>;
> > + #size-cells = <0>
> > +
> > + nand@0 {
> > + reg = <0>
> > + partition@0 {
> > + label = "filesystem";
> > + reg = <0x0 0x0 0x100>;
> > + };
>
> Hm, not s
Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
On Fri, 17 Aug 2018 18:49:23 +0530
Naga Sureshkumar Relli wrote:
> This patch adds the dts binding document for arasan nand flash
> controller.
>
> Signed-off-by: Naga Sureshkumar Relli
> ---
> Changes in v10:
> - None
> Changes in v9:
> - None
> Changes in v8:
> - Updated compatible and clock-names as per Boris comments
> Changes in v7:
> - Corrected the acronyms those should be in caps
> changes in v6:
> - Removed num-cs property
> - Separated nandchip from nand controller
> changes in v5:
> - None
> Changes in v4:
> - Added num-cs property
> - Added clock support
> Changes in v3:
> - None
> Changes in v2:
> - None
> ---
> .../devicetree/bindings/mtd/arasan_nand.txt| 38
> ++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/arasan_nand.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> new file mode 100644
> index 000..234d7ca
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> @@ -0,0 +1,38 @@
> +Arasan NAND Flash Controller with ONFI 3.1 support
> +
> +Required properties:
> +- compatible:Should be "xlnx,zynqmp-nand" or
> "arasan,nfc-v3p10"
In your example it's not an "or" since both are defined.
> +- reg: Memory map for module access
> +- interrupt-parent: Interrupt controller the interrupt is routed through
> +- interrupts:Should contain the interrupt for the device
> +- clock-name:List of input clocks - "sys", "flash"
clock-names
> + (See clock bindings for details)
> +- clocks:Clock phandles (see clock bindings for details)
> +
> +Optional properties:
> +- arasan,has-mdma: Enables DMA support
Can't you detect that based on the compatible (or thanks to a
register). If it's something you choose when configuring the IP and
can't detect at runtime I guess it's fine.
> +
> +For NAND partition information please refer the below file
> +Documentation/devicetree/bindings/mtd/partition.txt
> +
> +Example:
> + nand0: nand@ff10 {
> + compatible = "xlnx,zynqmp-nand", "arasan,nfc-v3p10"
> + reg = <0x0 0xff10 0x1000>;
> + clock-name = "sys", "flash"
> + clocks = <_clk _clk>;
> + interrupt-parent = <>;
> + interrupts = <0 14 4>;
> + arasan,has-mdma;
> + #address-cells = <1>;
> + #size-cells = <0>
> +
> + nand@0 {
> + reg = <0>
> + partition@0 {
> + label = "filesystem";
> + reg = <0x0 0x0 0x100>;
> + };
Hm, not sure you need to define partitions in this example, but if
you do, please define your partitions in a 'partitions' subnode:
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
partition@0 {
reg = <0x0 0x100>;
...
};
...
};
> + (...)
> + };
> + };
Re: [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation
On Fri, 17 Aug 2018 18:49:23 +0530
Naga Sureshkumar Relli wrote:
> This patch adds the dts binding document for arasan nand flash
> controller.
>
> Signed-off-by: Naga Sureshkumar Relli
> ---
> Changes in v10:
> - None
> Changes in v9:
> - None
> Changes in v8:
> - Updated compatible and clock-names as per Boris comments
> Changes in v7:
> - Corrected the acronyms those should be in caps
> changes in v6:
> - Removed num-cs property
> - Separated nandchip from nand controller
> changes in v5:
> - None
> Changes in v4:
> - Added num-cs property
> - Added clock support
> Changes in v3:
> - None
> Changes in v2:
> - None
> ---
> .../devicetree/bindings/mtd/arasan_nand.txt| 38
> ++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/arasan_nand.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> new file mode 100644
> index 000..234d7ca
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/arasan_nand.txt
> @@ -0,0 +1,38 @@
> +Arasan NAND Flash Controller with ONFI 3.1 support
> +
> +Required properties:
> +- compatible:Should be "xlnx,zynqmp-nand" or
> "arasan,nfc-v3p10"
In your example it's not an "or" since both are defined.
> +- reg: Memory map for module access
> +- interrupt-parent: Interrupt controller the interrupt is routed through
> +- interrupts:Should contain the interrupt for the device
> +- clock-name:List of input clocks - "sys", "flash"
clock-names
> + (See clock bindings for details)
> +- clocks:Clock phandles (see clock bindings for details)
> +
> +Optional properties:
> +- arasan,has-mdma: Enables DMA support
Can't you detect that based on the compatible (or thanks to a
register). If it's something you choose when configuring the IP and
can't detect at runtime I guess it's fine.
> +
> +For NAND partition information please refer the below file
> +Documentation/devicetree/bindings/mtd/partition.txt
> +
> +Example:
> + nand0: nand@ff10 {
> + compatible = "xlnx,zynqmp-nand", "arasan,nfc-v3p10"
> + reg = <0x0 0xff10 0x1000>;
> + clock-name = "sys", "flash"
> + clocks = <_clk _clk>;
> + interrupt-parent = <>;
> + interrupts = <0 14 4>;
> + arasan,has-mdma;
> + #address-cells = <1>;
> + #size-cells = <0>
> +
> + nand@0 {
> + reg = <0>
> + partition@0 {
> + label = "filesystem";
> + reg = <0x0 0x0 0x100>;
> + };
Hm, not sure you need to define partitions in this example, but if
you do, please define your partitions in a 'partitions' subnode:
partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;
partition@0 {
reg = <0x0 0x100>;
...
};
...
};
> + (...)
> + };
> + };
