Re: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"
On Sunday, April 07, 2013 07:00:34 AM Zheng, Lv wrote:
> > > > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> > > > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro
> > > > was removed from that header in v3.8, with commit
> > > > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> > > > acmacros.h divergences."). That commit did not explain why that
> > > > macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can
> > now
> > > > be removed too, as it is unused.
> > >
> > > Lv, can you please comment here?
> >
> > Sorry for the delayed reply.
> >
> > The commit should have done something that already have been done in the
> > ACPICA.
> > I'll take a look at this.
>
> The original commit deleted CONFIG_ACPI_DEBUG_FUNC_TRACE from acmacros.h as
> it is in the __wrong__ place.
> CONFIG_xxx is linux specific codes thus should appear in OSL layer -
> aclinux.h.
> ACPICA specific codes should only use selective definitions in #ifdef
> ACPI_xxx style and such codes should be merged into ACPICA rather than being
> merged into Linux ACPI.
>
> Now we have two choices:
> Re-implement it in the aclinux.h using "ACPI_DEBUG_OUTPUT" defined/undefined
> or delete
> this kernel configuration item temporarily.
OK
I'll apply the Paul's patch then and we'll decide what to do with that config
option later.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"
> > > > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> > > > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro
> > > > was removed from that header in v3.8, with commit
> > > > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> > > > acmacros.h divergences."). That commit did not explain why that
> > > > macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can
> > now
> > > > be removed too, as it is unused.
> > >
> > > Lv, can you please comment here?
> >
> > Sorry for the delayed reply.
> >
> > The commit should have done something that already have been done in
> > the ACPICA.
> > I'll take a look at this.
>
> The original commit deleted CONFIG_ACPI_DEBUG_FUNC_TRACE from
> acmacros.h as it is in the __wrong__ place.
> CONFIG_xxx is linux specific codes thus should appear in OSL layer -
> aclinux.h.
> ACPICA specific codes should only use selective definitions in #ifdef ACPI_xxx
> style and such codes should be merged into ACPICA rather than being merged
> into Linux ACPI.
>
> Now we have two choices:
> Re-implement it in the aclinux.h using "ACPI_DEBUG_OUTPUT"
> defined/undefined or delete this kernel configuration item temporarily.
Sorry, I made a mistake here.
ACPI_DEBUG_OUTPUT is already covered by the CONFIG_ACPI_DEBUG.
The corrected statement should be:
If we want to fine tune the output, then the codes might be implemented in
ACPICA first and then get utilized in Linux using the new ACPICA feature.
Best regards
-Lv
RE: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"
> > > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> > > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro
> > > was removed from that header in v3.8, with commit
> > > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> > > acmacros.h divergences."). That commit did not explain why that
> > > macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can
> now
> > > be removed too, as it is unused.
> >
> > Lv, can you please comment here?
>
> Sorry for the delayed reply.
>
> The commit should have done something that already have been done in the
> ACPICA.
> I'll take a look at this.
The original commit deleted CONFIG_ACPI_DEBUG_FUNC_TRACE from acmacros.h as it
is in the __wrong__ place.
CONFIG_xxx is linux specific codes thus should appear in OSL layer - aclinux.h.
ACPICA specific codes should only use selective definitions in #ifdef ACPI_xxx
style and such codes should be merged into ACPICA rather than being merged into
Linux ACPI.
Now we have two choices:
Re-implement it in the aclinux.h using "ACPI_DEBUG_OUTPUT" defined/undefined or
delete this kernel configuration item temporarily.
Thanks and best regards
-Lv
RE: [PATCH] ACPI: remove config ACPI_DEBUG_FUNC_TRACE
Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was removed from that header in v3.8, with commit 86ff0e508f88eda6e479a897476026055831d2d8 (ACPICA: Fix unmerged acmacros.h divergences.). That commit did not explain why that macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed too, as it is unused. Lv, can you please comment here? Sorry for the delayed reply. The commit should have done something that already have been done in the ACPICA. I'll take a look at this. The original commit deleted CONFIG_ACPI_DEBUG_FUNC_TRACE from acmacros.h as it is in the __wrong__ place. CONFIG_xxx is linux specific codes thus should appear in OSL layer - aclinux.h. ACPICA specific codes should only use selective definitions in #ifdef ACPI_xxx style and such codes should be merged into ACPICA rather than being merged into Linux ACPI. Now we have two choices: Re-implement it in the aclinux.h using ACPI_DEBUG_OUTPUT defined/undefined or delete this kernel configuration item temporarily. Thanks and best regards -Lv
RE: [PATCH] ACPI: remove config ACPI_DEBUG_FUNC_TRACE
Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was removed from that header in v3.8, with commit 86ff0e508f88eda6e479a897476026055831d2d8 (ACPICA: Fix unmerged acmacros.h divergences.). That commit did not explain why that macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed too, as it is unused. Lv, can you please comment here? Sorry for the delayed reply. The commit should have done something that already have been done in the ACPICA. I'll take a look at this. The original commit deleted CONFIG_ACPI_DEBUG_FUNC_TRACE from acmacros.h as it is in the __wrong__ place. CONFIG_xxx is linux specific codes thus should appear in OSL layer - aclinux.h. ACPICA specific codes should only use selective definitions in #ifdef ACPI_xxx style and such codes should be merged into ACPICA rather than being merged into Linux ACPI. Now we have two choices: Re-implement it in the aclinux.h using ACPI_DEBUG_OUTPUT defined/undefined or delete this kernel configuration item temporarily. Sorry, I made a mistake here. ACPI_DEBUG_OUTPUT is already covered by the CONFIG_ACPI_DEBUG. The corrected statement should be: If we want to fine tune the output, then the codes might be implemented in ACPICA first and then get utilized in Linux using the new ACPICA feature. Best regards -Lv
Re: [PATCH] ACPI: remove config ACPI_DEBUG_FUNC_TRACE
On Sunday, April 07, 2013 07:00:34 AM Zheng, Lv wrote: Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was removed from that header in v3.8, with commit 86ff0e508f88eda6e479a897476026055831d2d8 (ACPICA: Fix unmerged acmacros.h divergences.). That commit did not explain why that macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed too, as it is unused. Lv, can you please comment here? Sorry for the delayed reply. The commit should have done something that already have been done in the ACPICA. I'll take a look at this. The original commit deleted CONFIG_ACPI_DEBUG_FUNC_TRACE from acmacros.h as it is in the __wrong__ place. CONFIG_xxx is linux specific codes thus should appear in OSL layer - aclinux.h. ACPICA specific codes should only use selective definitions in #ifdef ACPI_xxx style and such codes should be merged into ACPICA rather than being merged into Linux ACPI. Now we have two choices: Re-implement it in the aclinux.h using ACPI_DEBUG_OUTPUT defined/undefined or delete this kernel configuration item temporarily. OK I'll apply the Paul's patch then and we'll decide what to do with that config option later. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"
> > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was
> > removed from that header in v3.8, with commit
> > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> > acmacros.h divergences."). That commit did not explain why that macro
> > was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be
> > removed too, as it is unused.
>
> Lv, can you please comment here?
Sorry for the delayed reply.
The commit should have done something that already have been done in the ACPICA.
I'll take a look at this.
Thanks and best regards
-Lv
RE: [PATCH] ACPI: remove config ACPI_DEBUG_FUNC_TRACE
Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was removed from that header in v3.8, with commit 86ff0e508f88eda6e479a897476026055831d2d8 (ACPICA: Fix unmerged acmacros.h divergences.). That commit did not explain why that macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed too, as it is unused. Lv, can you please comment here? Sorry for the delayed reply. The commit should have done something that already have been done in the ACPICA. I'll take a look at this. Thanks and best regards -Lv
Re: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"
On Tuesday, March 26, 2013 02:34:25 PM Rafael J. Wysocki wrote:
> On Tuesday, March 19, 2013 11:41:01 AM Paul Bolle wrote:
> > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was
> > removed from that header in v3.8, with commit
> > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> > acmacros.h divergences."). That commit did not explain why that macro
> > was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed
> > too, as it is unused.
>
> Lv, can you please comment here?
Lv, I'm still waiting for your comment regarding the commit mentioned above.
Thanks,
Rafael
> > Signed-off-by: Paul Bolle
> > ---
> > Eyeball tested.
> >
> > drivers/acpi/Kconfig | 8
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> > index 92ed969..006b714 100644
> > --- a/drivers/acpi/Kconfig
> > +++ b/drivers/acpi/Kconfig
> > @@ -298,14 +298,6 @@ config ACPI_DEBUG
> > Documentation/kernel-parameters.txt to control the type and
> > amount of debug output.
> >
> > -config ACPI_DEBUG_FUNC_TRACE
> > - bool "Additionally enable ACPI function tracing"
> > - default n
> > - depends on ACPI_DEBUG
> > - help
> > - ACPI Debug Statements slow down ACPI processing. Function trace
> > - is about half of the penalty and is rarely useful.
> > -
> > config ACPI_PCI_SLOT
> > bool "PCI slot detection driver"
> > depends on SYSFS
> >
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI: remove config ACPI_DEBUG_FUNC_TRACE
On Tuesday, March 26, 2013 02:34:25 PM Rafael J. Wysocki wrote: On Tuesday, March 19, 2013 11:41:01 AM Paul Bolle wrote: Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was removed from that header in v3.8, with commit 86ff0e508f88eda6e479a897476026055831d2d8 (ACPICA: Fix unmerged acmacros.h divergences.). That commit did not explain why that macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed too, as it is unused. Lv, can you please comment here? Lv, I'm still waiting for your comment regarding the commit mentioned above. Thanks, Rafael Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Eyeball tested. drivers/acpi/Kconfig | 8 1 file changed, 8 deletions(-) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 92ed969..006b714 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -298,14 +298,6 @@ config ACPI_DEBUG Documentation/kernel-parameters.txt to control the type and amount of debug output. -config ACPI_DEBUG_FUNC_TRACE - bool Additionally enable ACPI function tracing - default n - depends on ACPI_DEBUG - help - ACPI Debug Statements slow down ACPI processing. Function trace - is about half of the penalty and is rarely useful. - config ACPI_PCI_SLOT bool PCI slot detection driver depends on SYSFS -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"
On Tuesday, March 19, 2013 11:41:01 AM Paul Bolle wrote:
> Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was
> removed from that header in v3.8, with commit
> 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> acmacros.h divergences."). That commit did not explain why that macro
> was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed
> too, as it is unused.
Lv, can you please comment here?
Rafael
> Signed-off-by: Paul Bolle
> ---
> Eyeball tested.
>
> drivers/acpi/Kconfig | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 92ed969..006b714 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -298,14 +298,6 @@ config ACPI_DEBUG
> Documentation/kernel-parameters.txt to control the type and
> amount of debug output.
>
> -config ACPI_DEBUG_FUNC_TRACE
> - bool "Additionally enable ACPI function tracing"
> - default n
> - depends on ACPI_DEBUG
> - help
> - ACPI Debug Statements slow down ACPI processing. Function trace
> - is about half of the penalty and is rarely useful.
> -
> config ACPI_PCI_SLOT
> bool "PCI slot detection driver"
> depends on SYSFS
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ACPI: remove config ACPI_DEBUG_FUNC_TRACE
On Tuesday, March 19, 2013 11:41:01 AM Paul Bolle wrote: Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was removed from that header in v3.8, with commit 86ff0e508f88eda6e479a897476026055831d2d8 (ACPICA: Fix unmerged acmacros.h divergences.). That commit did not explain why that macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed too, as it is unused. Lv, can you please comment here? Rafael Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Eyeball tested. drivers/acpi/Kconfig | 8 1 file changed, 8 deletions(-) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 92ed969..006b714 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -298,14 +298,6 @@ config ACPI_DEBUG Documentation/kernel-parameters.txt to control the type and amount of debug output. -config ACPI_DEBUG_FUNC_TRACE - bool Additionally enable ACPI function tracing - default n - depends on ACPI_DEBUG - help - ACPI Debug Statements slow down ACPI processing. Function trace - is about half of the penalty and is rarely useful. - config ACPI_PCI_SLOT bool PCI slot detection driver depends on SYSFS -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
