Re: [PATCH] HID: hyperv: Add the support of hibernation
On Sun, Sep 29, 2019 at 05:44:09PM +, Dexuan Cui wrote: From: Sasha Levin Dexuan, I've been silently ignoring your patches for the past few weeks for the same reason as Jiri has mentioned. I'll pick them all up once the 5.4 merge window closes in a few days. Thanks, Sasha! BTW, I'll post a v2 for this patch, as IMO I may be able to get rid of the mousevsc_pm_notify in this patch by disabling the channel callback in the suspend function. Okay, I'm ignoring this patch for now then. -- Thanks, Sasha
RE: [PATCH] HID: hyperv: Add the support of hibernation
> From: Sasha Levin
> Sent: Friday, September 27, 2019 5:05 AM
> To: Dexuan Cui
> Cc: Jiri Kosina ; KY Srinivasan ;
> Haiyang Zhang ; Stephen Hemminger
> ; benjamin.tissoi...@redhat.com;
> linux-hyp...@vger.kernel.org; linux-in...@vger.kernel.org;
> linux-kernel@vger.kernel.org; Michael Kelley
> Subject: Re: [PATCH] HID: hyperv: Add the support of hibernation
>
> On Fri, Sep 27, 2019 at 05:42:31AM +, Dexuan Cui wrote:
> >> From: Jiri Kosina
> >> Sent: Thursday, September 26, 2019 6:23 AM
> >> To: Dexuan Cui
> >>
> >> On Thu, 26 Sep 2019, Jiri Kosina wrote:
> >>
> >> > > > This patch is basically a pure Hyper-V specific change and it has a
> >> > > > build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus:
> >> > > > Implement
> >> > > > suspend/resume for VSC drivers for hibernation"), which is on Sasha
> >> Levin's
> >> > > > Hyper-V tree's hyperv-next branch [ ... snipped ...]
> >> > > >
> >> > > > I request this patch should go through Sasha's tree rather than the
> >> > > > input subsystem's tree.
> >> > > >
> >> > > > Hi Jiri, Benjamin, can you please Ack?
> >> > >
> >> > > Hi Jiri, Benjamin,
> >> > > Can you please take a look at the patch?
> >> >
> >> > Hi Dexuan,
> >> >
> >> > I am planning to process it once 5.4 merge window is over and thus
> >> > hid.git
> >> > is open again for 5.5 material.
> >>
> >> Ah, now I see you asked for this go through hyperv tree. For that, feel
> >> free to add
> >>Acked-by: Jiri Kosina
> >> Jiri Kosina
> >
> >Thanks for the Ack, Jiri!
> >
> >I have a bunch of patches, including this one, to support Linux VM's
> hibernation
> >when the VM runs on Hyper-V. I just feel it would be better for all of them
> >to
> >go through the Hyper-V tree. :-)
>
> Thank Dexuan, Jiri,
>
> Dexuan, I've been silently ignoring your patches for the past few weeks
> for the same reason as Jiri has mentioned. I'll pick them all up once
> the 5.4 merge window closes in a few days.
>
> Thanks,
> Sasha
Thanks, Sasha!
BTW, I'll post a v2 for this patch, as IMO I may be able to get rid of the
mousevsc_pm_notify in this patch by disabling the channel callback
in the suspend function.
Thanks,
-- Dexuan
Re: [PATCH] HID: hyperv: Add the support of hibernation
On Fri, Sep 27, 2019 at 05:42:31AM +, Dexuan Cui wrote:
From: Jiri Kosina
Sent: Thursday, September 26, 2019 6:23 AM
To: Dexuan Cui
On Thu, 26 Sep 2019, Jiri Kosina wrote:
> > > This patch is basically a pure Hyper-V specific change and it has a
> > > build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus:
> > > Implement
> > > suspend/resume for VSC drivers for hibernation"), which is on Sasha
Levin's
> > > Hyper-V tree's hyperv-next branch [ ... snipped ...]
> > >
> > > I request this patch should go through Sasha's tree rather than the
> > > input subsystem's tree.
> > >
> > > Hi Jiri, Benjamin, can you please Ack?
> >
> > Hi Jiri, Benjamin,
> > Can you please take a look at the patch?
>
> Hi Dexuan,
>
> I am planning to process it once 5.4 merge window is over and thus hid.git
> is open again for 5.5 material.
Ah, now I see you asked for this go through hyperv tree. For that, feel
free to add
Acked-by: Jiri Kosina
Jiri Kosina
Thanks for the Ack, Jiri!
I have a bunch of patches, including this one, to support Linux VM's hibernation
when the VM runs on Hyper-V. I just feel it would be better for all of them to
go through the Hyper-V tree. :-)
Thank Dexuan, Jiri,
Dexuan, I've been silently ignoring your patches for the past few weeks
for the same reason as Jiri has mentioned. I'll pick them all up once
the 5.4 merge window closes in a few days.
--
Thanks,
Sasha
RE: [PATCH] HID: hyperv: Add the support of hibernation
> From: Jiri Kosina
> Sent: Thursday, September 26, 2019 6:23 AM
> To: Dexuan Cui
>
> On Thu, 26 Sep 2019, Jiri Kosina wrote:
>
> > > > This patch is basically a pure Hyper-V specific change and it has a
> > > > build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus:
> > > > Implement
> > > > suspend/resume for VSC drivers for hibernation"), which is on Sasha
> Levin's
> > > > Hyper-V tree's hyperv-next branch [ ... snipped ...]
> > > >
> > > > I request this patch should go through Sasha's tree rather than the
> > > > input subsystem's tree.
> > > >
> > > > Hi Jiri, Benjamin, can you please Ack?
> > >
> > > Hi Jiri, Benjamin,
> > > Can you please take a look at the patch?
> >
> > Hi Dexuan,
> >
> > I am planning to process it once 5.4 merge window is over and thus hid.git
> > is open again for 5.5 material.
>
> Ah, now I see you asked for this go through hyperv tree. For that, feel
> free to add
> Acked-by: Jiri Kosina
> Jiri Kosina
Thanks for the Ack, Jiri!
I have a bunch of patches, including this one, to support Linux VM's hibernation
when the VM runs on Hyper-V. I just feel it would be better for all of them to
go through the Hyper-V tree. :-)
Thanks,
-- Dexuan
RE: [PATCH] HID: hyperv: Add the support of hibernation
On Thu, 26 Sep 2019, Jiri Kosina wrote:
> > > We need mousevsc_pm_notify() to make sure the pm_wakeup_hard_event()
> > > call does not prevent the system from entering hibernation: the
> > > hibernation is a relatively long process, which can be aborted by the
> > > call pm_wakeup_hard_event(), which is invoked upon mouse events.
> > >
> > > Signed-off-by: Dexuan Cui
> > > ---
> > >
> > > This patch is basically a pure Hyper-V specific change and it has a
> > > build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus:
> > > Implement
> > > suspend/resume for VSC drivers for hibernation"), which is on Sasha
> > > Levin's
> > > Hyper-V tree's hyperv-next branch [ ... snipped ...]
> > >
> > > I request this patch should go through Sasha's tree rather than the
> > > input subsystem's tree.
> > >
> > > Hi Jiri, Benjamin, can you please Ack?
> >
> > Hi Jiri, Benjamin,
> > Can you please take a look at the patch?
>
> Hi Dexuan,
>
> I am planning to process it once 5.4 merge window is over and thus hid.git
> is open again for 5.5 material.
Ah, now I see you asked for this go through hyperv tree. For that, feel
free to add
Acked-by: Jiri Kosina
Thanks,
--
Jiri Kosina
SUSE Labs
RE: [PATCH] HID: hyperv: Add the support of hibernation
On Wed, 25 Sep 2019, Dexuan Cui wrote:
> > We need mousevsc_pm_notify() to make sure the pm_wakeup_hard_event()
> > call does not prevent the system from entering hibernation: the
> > hibernation is a relatively long process, which can be aborted by the
> > call pm_wakeup_hard_event(), which is invoked upon mouse events.
> >
> > Signed-off-by: Dexuan Cui
> > ---
> >
> > This patch is basically a pure Hyper-V specific change and it has a
> > build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus:
> > Implement
> > suspend/resume for VSC drivers for hibernation"), which is on Sasha Levin's
> > Hyper-V tree's hyperv-next branch [ ... snipped ...]
> >
> > I request this patch should go through Sasha's tree rather than the
> > input subsystem's tree.
> >
> > Hi Jiri, Benjamin, can you please Ack?
>
> Hi Jiri, Benjamin,
> Can you please take a look at the patch?
Hi Dexuan,
I am planning to process it once 5.4 merge window is over and thus hid.git
is open again for 5.5 material.
Thanks,
--
Jiri Kosina
SUSE Labs
RE: [PATCH] HID: hyperv: Add the support of hibernation
> From: Dexuan Cui
> Sent: Wednesday, September 11, 2019 4:36 PM
>
> We need mousevsc_pm_notify() to make sure the pm_wakeup_hard_event()
> call
> does not prevent the system from entering hibernation: the hibernation
> is a relatively long process, which can be aborted by the call
> pm_wakeup_hard_event(), which is invoked upon mouse events.
>
> Signed-off-by: Dexuan Cui
> ---
>
> This patch is basically a pure Hyper-V specific change and it has a
> build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus:
> Implement
> suspend/resume for VSC drivers for hibernation"), which is on Sasha Levin's
> Hyper-V tree's hyperv-next branch [ ... snipped ...]
>
> I request this patch should go through Sasha's tree rather than the
> input subsystem's tree.
>
> Hi Jiri, Benjamin, can you please Ack?
Hi Jiri, Benjamin,
Can you please take a look at the patch?
Thanks,
-- Dexuan
