Re: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed
Quoting Anson Huang (2018-11-29 23:23:47) > Same as other i.MX6 SoCs, ensure unused MMDC channel's > handshake is bypassed, this is to make sure no request > signal will be generated when periphe_clk_sel is changed > or SRC warm reset is triggered. > > Signed-off-by: Anson Huang > --- Applied to clk-next
RE: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed
Quoting Anson Huang (2018-11-29 23:37:14) > Hi, Stephen > > Best Regards! > Anson Huang > > > -Original Message- > > From: Stephen Boyd [mailto:sb...@kernel.org] > > Sent: 2018年11月30日 15:25 > > To: ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; > > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > > mturque...@baylibre.com; s.ha...@pengutronix.de; shawn...@kernel.org; > > Anson Huang ; Fabio Estevam > > > > Cc: dl-linux-imx > > Subject: Re: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed > > > > Quoting Anson Huang (2018-11-29 23:23:47) > > > Same as other i.MX6 SoCs, ensure unused MMDC channel's handshake is > > > bypassed, this is to make sure no request signal will be generated > > > when periphe_clk_sel is changed or SRC warm reset is triggered. > > > > > > Signed-off-by: Anson Huang > > > > Does this need a fixes tag? > > Normally this bit is 1b'1 by reset, but during our development, it used to be > overwritten in u-boot and lead to some clock operation fail in Linux kernel, > that is why we ensure it > in clock driver early phase. IMO, it should be OK to not add a fix tag, since > it is just > to make sure the setting is correct and NOT depends on the hardware reset > value which > could be changed in u-boot. > > Hmm ok.
RE: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed
Quoting Anson Huang (2018-11-29 23:37:14) > Hi, Stephen > > Best Regards! > Anson Huang > > > -Original Message- > > From: Stephen Boyd [mailto:sb...@kernel.org] > > Sent: 2018年11月30日 15:25 > > To: ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; > > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > > mturque...@baylibre.com; s.ha...@pengutronix.de; shawn...@kernel.org; > > Anson Huang ; Fabio Estevam > > > > Cc: dl-linux-imx > > Subject: Re: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed > > > > Quoting Anson Huang (2018-11-29 23:23:47) > > > Same as other i.MX6 SoCs, ensure unused MMDC channel's handshake is > > > bypassed, this is to make sure no request signal will be generated > > > when periphe_clk_sel is changed or SRC warm reset is triggered. > > > > > > Signed-off-by: Anson Huang > > > > Does this need a fixes tag? > > Normally this bit is 1b'1 by reset, but during our development, it used to be > overwritten in u-boot and lead to some clock operation fail in Linux kernel, > that is why we ensure it > in clock driver early phase. IMO, it should be OK to not add a fix tag, since > it is just > to make sure the setting is correct and NOT depends on the hardware reset > value which > could be changed in u-boot. > > Hmm ok.
RE: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed
Hi, Stephen Best Regards! Anson Huang > -Original Message- > From: Stephen Boyd [mailto:sb...@kernel.org] > Sent: 2018年11月30日 15:25 > To: ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > mturque...@baylibre.com; s.ha...@pengutronix.de; shawn...@kernel.org; > Anson Huang ; Fabio Estevam > > Cc: dl-linux-imx > Subject: Re: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed > > Quoting Anson Huang (2018-11-29 23:23:47) > > Same as other i.MX6 SoCs, ensure unused MMDC channel's handshake is > > bypassed, this is to make sure no request signal will be generated > > when periphe_clk_sel is changed or SRC warm reset is triggered. > > > > Signed-off-by: Anson Huang > > Does this need a fixes tag? Normally this bit is 1b'1 by reset, but during our development, it used to be overwritten in u-boot and lead to some clock operation fail in Linux kernel, that is why we ensure it in clock driver early phase. IMO, it should be OK to not add a fix tag, since it is just to make sure the setting is correct and NOT depends on the hardware reset value which could be changed in u-boot. Anson.
RE: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed
Hi, Stephen Best Regards! Anson Huang > -Original Message- > From: Stephen Boyd [mailto:sb...@kernel.org] > Sent: 2018年11月30日 15:25 > To: ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > mturque...@baylibre.com; s.ha...@pengutronix.de; shawn...@kernel.org; > Anson Huang ; Fabio Estevam > > Cc: dl-linux-imx > Subject: Re: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed > > Quoting Anson Huang (2018-11-29 23:23:47) > > Same as other i.MX6 SoCs, ensure unused MMDC channel's handshake is > > bypassed, this is to make sure no request signal will be generated > > when periphe_clk_sel is changed or SRC warm reset is triggered. > > > > Signed-off-by: Anson Huang > > Does this need a fixes tag? Normally this bit is 1b'1 by reset, but during our development, it used to be overwritten in u-boot and lead to some clock operation fail in Linux kernel, that is why we ensure it in clock driver early phase. IMO, it should be OK to not add a fix tag, since it is just to make sure the setting is correct and NOT depends on the hardware reset value which could be changed in u-boot. Anson.
Re: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed
Quoting Anson Huang (2018-11-29 23:23:47) > Same as other i.MX6 SoCs, ensure unused MMDC channel's > handshake is bypassed, this is to make sure no request > signal will be generated when periphe_clk_sel is changed > or SRC warm reset is triggered. > > Signed-off-by: Anson Huang Does this need a fixes tag?
Re: [PATCH] clk: imx6sl: ensure MMDC CH0 handshake is bypassed
Quoting Anson Huang (2018-11-29 23:23:47) > Same as other i.MX6 SoCs, ensure unused MMDC channel's > handshake is bypassed, this is to make sure no request > signal will be generated when periphe_clk_sel is changed > or SRC warm reset is triggered. > > Signed-off-by: Anson Huang Does this need a fixes tag?
