RE: [PATCH] net: stmmac: Read user ID muliple times if needed.

2019-10-02 Thread Jose Abreu 
From: Hans Andersson 
Date: Oct/02/2019, 09:02:02 (UTC+00:00)

> We assert / de-assert the reset line, but the CPU is too fast and the IP is 
> still 
> in reset when we later try to read user ID / Synopsys ID. Another option would
> be to add a delay after we reset.

Then I think you should fix the reset driver to only return when the 
reset is fully done.

---
Thanks,
Jose Miguel Abreu

RE: [PATCH] net: stmmac: Read user ID muliple times if needed.

2019-10-02 Thread Jose Abreu 
From: Hans Andersson 
Date: Oct/02/2019, 08:07:21 (UTC+00:00)

> When we read user ID / Synopsys ID we might still be in reset,
> so read muliple times if needed.

We shouldn't even try to read it if IP is in reset ... 

---
Thanks,
Jose Miguel Abreu

RE: [PATCH] net: stmmac: Read user ID muliple times if needed.

2019-10-02 Thread Hans Andersson 
We assert / de-assert the reset line, but the CPU is too fast and the IP is 
still 
in reset when we later try to read user ID / Synopsys ID. Another option would
be to add a delay after we reset.

-Original Message-
From: Jose Abreu  
Sent: den 2 oktober 2019 09:52
To: Hans Andersson ; mcoquelin.st...@gmail.com
Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; da...@davemloft.net; 
net...@vger.kernel.org; linux-st...@st-md-mailman.stormreply.com; 
linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; Hans 
Andersson 
Subject: RE: [PATCH] net: stmmac: Read user ID muliple times if needed.

From: Hans Andersson 
Date: Oct/02/2019, 08:07:21 (UTC+00:00)

> When we read user ID / Synopsys ID we might still be in reset, so read 
> muliple times if needed.

We shouldn't even try to read it if IP is in reset ... 

---
Thanks,
Jose Miguel Abreu