RE: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()
>Sent: Saturday, August 27, 2016 8:07 PM >To: Tomi Valkeinen <tomi.valkei...@ti.com>; Tony Lindgren <t...@atomide.com>; >Sean Paul <seanp...@chromium.org>; Peter Chen <peter.c...@nxp.com>; >Andrey Utkin <andrey_ut...@fastmail.com> >Cc: David Airlie <airl...@linux.ie>; Peter Ujfalusi <peter.ujfal...@ti.com>; >Dave >Airlie <airl...@gmail.com>; Rob Clark <robdcl...@gmail.com>; Dr. H. Nikolaus >Schaller <h...@goldelico.com>; Andrew Bradford <bra...@gmail.com>; >ker...@pyra-handheld.com; Discussions about the Letux Kernel ker...@openphoenux.org>; dri-de...@lists.freedesktop.org; lkml ker...@vger.kernel.org>; linux-o...@vger.kernel.org >Subject: Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to >of_get_next_parent() > >> [8.842806] OF: ERROR: Bad of_node_put() on /encoder/ports/port@1/endpoint >> [8.843014] [] (omapdss_of_find_source_for_first_ep [omapdss]) > >I can confirm that reverting 2ab9f5879162 fixes this regression, tested on >omap5- >uevm. > It was my careless for introducing regression. The revert patch has already been at linux-next. Sorry for inconvenience. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=5a78ff7bf7e25191144b550961001bbf6c734da4 Peter
RE: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()
>Sent: Saturday, August 27, 2016 8:07 PM >To: Tomi Valkeinen ; Tony Lindgren ; >Sean Paul ; Peter Chen ; >Andrey Utkin >Cc: David Airlie ; Peter Ujfalusi ; >Dave >Airlie ; Rob Clark ; Dr. H. Nikolaus >Schaller ; Andrew Bradford ; >ker...@pyra-handheld.com; Discussions about the Letux Kernel ker...@openphoenux.org>; dri-de...@lists.freedesktop.org; lkml ker...@vger.kernel.org>; linux-o...@vger.kernel.org >Subject: Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to >of_get_next_parent() > >> [8.842806] OF: ERROR: Bad of_node_put() on /encoder/ports/port@1/endpoint >> [8.843014] [] (omapdss_of_find_source_for_first_ep [omapdss]) > >I can confirm that reverting 2ab9f5879162 fixes this regression, tested on >omap5- >uevm. > It was my careless for introducing regression. The revert patch has already been at linux-next. Sorry for inconvenience. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=5a78ff7bf7e25191144b550961001bbf6c734da4 Peter
Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()
> [8.842806] OF: ERROR: Bad of_node_put() on /encoder/ports/port@1/endpoint > [8.843014] [] (omapdss_of_find_source_for_first_ep [omapdss]) I can confirm that reverting 2ab9f5879162 fixes this regression, tested on omap5-uevm. Matthijs
Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()
> [8.842806] OF: ERROR: Bad of_node_put() on /encoder/ports/port@1/endpoint > [8.843014] [] (omapdss_of_find_source_for_first_ep [omapdss]) I can confirm that reverting 2ab9f5879162 fixes this regression, tested on omap5-uevm. Matthijs
Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()
To clarify, this patch effectively reverts commit 2ab9f5879162499e1c4e48613287e3f59e593c4f gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle except it leaves behind unnecessary verbiage that this commit introduced. And to be clear, that commit *should* indeed be reverted, although preferably in its entirety obviously. of_get_next_parent already drops a ref on its argument, so of_node_put was never "missing" here. Matthijs
Re: [PATCH] omapdrm: dss: drop unneeded of_node_put() on ref passed to of_get_next_parent()
To clarify, this patch effectively reverts commit 2ab9f5879162499e1c4e48613287e3f59e593c4f gpu: drm: omapdrm: dss-of: add missing of_node_put after calling of_parse_phandle except it leaves behind unnecessary verbiage that this commit introduced. And to be clear, that commit *should* indeed be reverted, although preferably in its entirety obviously. of_get_next_parent already drops a ref on its argument, so of_node_put was never "missing" here. Matthijs
