Re: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
On Mon, Sep 17, 2012 at 07:01:16AM +0200, Arun MURTHY wrote: > > On Fri, Sep 07, 2012 at 03:22:09PM +0200, Thierry Reding wrote: > > > On Mon, Sep 03, 2012 at 01:28:44PM +0200, Arun MURTHY wrote: > > > > > On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding > > > > > wrote: > > > > > > > > > > > This commit moves the driver to drivers/pwm and converts it to > > > > > > the new PWM framework. > > > > > > > > > > > > Signed-off-by: Thierry Reding > > > > > > --- > > > > > > Note: I'll take this through the PWM tree, but I'd like to have > > > > > > it acknowledged by a few people who know the hardware and can > > > > > > actually test whether this still works. > > > > > > > > > > Pls include Arun on these patches, he'll know best if it'll work or > > > > > not. > > > > > > > > > > I have one generic question: will this alter the layout of sysfs > > > > > so we need to change userspace? I had such issues before when > > > > > moving drivers to new busses... > > > > > > > > > > > > > Since this pwm framework is still a set of exported functions in a > > > > header file, the file architecture doesn't really matter. > > > > Using this driver, either leds-pwm and backlight-pwm is used to > > > > register and this is where actual registration happens(sysfs entry is > > created). > > > > > > Hi Arun, > > > > > > Have you been able to verify, then, that the driver still works after > > > this patch? Can I add your Acked-by as well? > > > > Hi Arun, > > > > any news on this? > > > > Thierry > > Hi Thierry, > Works with certain changes in platform data which I can manage > to push it later. > > Acked-by: Arun Murthy Thanks. I've pushed this patch to my for-next branch. Thierry pgpKiXjoPMhij.pgp Description: PGP signature
RE: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
> On Fri, Sep 07, 2012 at 03:22:09PM +0200, Thierry Reding wrote: > > On Mon, Sep 03, 2012 at 01:28:44PM +0200, Arun MURTHY wrote: > > > > On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding > > > > wrote: > > > > > > > > > This commit moves the driver to drivers/pwm and converts it to > > > > > the new PWM framework. > > > > > > > > > > Signed-off-by: Thierry Reding > > > > > --- > > > > > Note: I'll take this through the PWM tree, but I'd like to have > > > > > it acknowledged by a few people who know the hardware and can > > > > > actually test whether this still works. > > > > > > > > Pls include Arun on these patches, he'll know best if it'll work or not. > > > > > > > > I have one generic question: will this alter the layout of sysfs > > > > so we need to change userspace? I had such issues before when > > > > moving drivers to new busses... > > > > > > > > > > Since this pwm framework is still a set of exported functions in a > > > header file, the file architecture doesn't really matter. > > > Using this driver, either leds-pwm and backlight-pwm is used to > > > register and this is where actual registration happens(sysfs entry is > created). > > > > Hi Arun, > > > > Have you been able to verify, then, that the driver still works after > > this patch? Can I add your Acked-by as well? > > Hi Arun, > > any news on this? > > Thierry Hi Thierry, Works with certain changes in platform data which I can manage to push it later. Acked-by: Arun Murthy Thanks and Regards, Arun R Murthy -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
On Fri, Sep 07, 2012 at 03:22:09PM +0200, Thierry Reding wrote: > On Mon, Sep 03, 2012 at 01:28:44PM +0200, Arun MURTHY wrote: > > > On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding > > design.de> wrote: > > > > > > > This commit moves the driver to drivers/pwm and converts it to the new > > > > PWM framework. > > > > > > > > Signed-off-by: Thierry Reding > > > > --- > > > > Note: I'll take this through the PWM tree, but I'd like to have it > > > > acknowledged by a few people who know the hardware and can actually > > > > test whether this still works. > > > > > > Pls include Arun on these patches, he'll know best if it'll work or not. > > > > > > I have one generic question: will this alter the layout of sysfs so we > > > need to > > > change userspace? I had such issues before when moving drivers to new > > > busses... > > > > > > > Since this pwm framework is still a set of exported functions in a header > > file, > > the file architecture doesn't really matter. > > Using this driver, either leds-pwm and backlight-pwm is used to register and > > this is where actual registration happens(sysfs entry is created). > > Hi Arun, > > Have you been able to verify, then, that the driver still works after > this patch? Can I add your Acked-by as well? Hi Arun, any news on this? Thierry pgpPQCFYj2xA3.pgp Description: PGP signature
Re: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
On Mon, Sep 03, 2012 at 01:28:44PM +0200, Arun MURTHY wrote: > > On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding > design.de> wrote: > > > > > This commit moves the driver to drivers/pwm and converts it to the new > > > PWM framework. > > > > > > Signed-off-by: Thierry Reding > > > --- > > > Note: I'll take this through the PWM tree, but I'd like to have it > > > acknowledged by a few people who know the hardware and can actually > > > test whether this still works. > > > > Pls include Arun on these patches, he'll know best if it'll work or not. > > > > I have one generic question: will this alter the layout of sysfs so we need > > to > > change userspace? I had such issues before when moving drivers to new > > busses... > > > > Since this pwm framework is still a set of exported functions in a header > file, > the file architecture doesn't really matter. > Using this driver, either leds-pwm and backlight-pwm is used to register and > this is where actual registration happens(sysfs entry is created). Hi Arun, Have you been able to verify, then, that the driver still works after this patch? Can I add your Acked-by as well? Thierry pgpBLypLv4C1U.pgp Description: PGP signature
Re: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
On Mon, Sep 3, 2012 at 1:28 PM, Arun MURTHY wrote: >> On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding > design.de> wrote: >> >> > This commit moves the driver to drivers/pwm and converts it to the new >> > PWM framework. >> > >> > Signed-off-by: Thierry Reding >> > --- >> > Note: I'll take this through the PWM tree, but I'd like to have it >> > acknowledged by a few people who know the hardware and can actually >> > test whether this still works. >> >> Pls include Arun on these patches, he'll know best if it'll work or not. >> >> I have one generic question: will this alter the layout of sysfs so we need >> to >> change userspace? I had such issues before when moving drivers to new >> busses... >> > > Since this pwm framework is still a set of exported functions in a header > file, > the file architecture doesn't really matter. > Using this driver, either leds-pwm and backlight-pwm is used to register and > this is where actual registration happens(sysfs entry is created). OK sounds good to me, Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
> On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding design.de> wrote: > > > This commit moves the driver to drivers/pwm and converts it to the new > > PWM framework. > > > > Signed-off-by: Thierry Reding > > --- > > Note: I'll take this through the PWM tree, but I'd like to have it > > acknowledged by a few people who know the hardware and can actually > > test whether this still works. > > Pls include Arun on these patches, he'll know best if it'll work or not. > > I have one generic question: will this alter the layout of sysfs so we need to > change userspace? I had such issues before when moving drivers to new > busses... > Since this pwm framework is still a set of exported functions in a header file, the file architecture doesn't really matter. Using this driver, either leds-pwm and backlight-pwm is used to register and this is where actual registration happens(sysfs entry is created). Thanks and Regards, Arun R Murthy -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
On Sun, Sep 2, 2012 at 12:30 PM, Thierry Reding wrote: > This commit moves the driver to drivers/pwm and converts it to the new > PWM framework. > > Signed-off-by: Thierry Reding > --- > Note: I'll take this through the PWM tree, but I'd like to have it > acknowledged by a few people who know the hardware and can actually > test whether this still works. Pls include Arun on these patches, he'll know best if it'll work or not. I have one generic question: will this alter the layout of sysfs so we need to change userspace? I had such issues before when moving drivers to new busses... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
On Sun, Sep 02, 2012 at 06:55:11PM +, Arnd Bergmann wrote: > On Sunday 02 September 2012, Thierry Reding wrote: > > This commit moves the driver to drivers/pwm and converts it to the new > > PWM framework. > > > > Signed-off-by: Thierry Reding > > --- > > Note: I'll take this through the PWM tree, but I'd like to have it > > acknowledged by a few people who know the hardware and can actually > > test whether this still works. > > Did you create the patch using 'git format-patch -M'? It should > show the changes as a move plus changes rather than a file remove > and another file add. Yeah, I forgot that... again. Sorry for that. > The change to the common framework is of course very welcome, > > Acked-by: Arnd Bergmann Thierry pgpusuWiEUYDo.pgp Description: PGP signature
Re: [PATCH] pwm: Move AB8500 PWM driver to PWM framework
On Sunday 02 September 2012, Thierry Reding wrote: > This commit moves the driver to drivers/pwm and converts it to the new > PWM framework. > > Signed-off-by: Thierry Reding > --- > Note: I'll take this through the PWM tree, but I'd like to have it > acknowledged by a few people who know the hardware and can actually > test whether this still works. Did you create the patch using 'git format-patch -M'? It should show the changes as a move plus changes rather than a file remove and another file add. The change to the common framework is of course very welcome, Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
