Re: [PATCH] thermal: solve compilation errors in rcar_thermal
On Tue, Oct 30, 2012 at 08:21:09PM -0700, Kuninori Morimoto wrote:
>
> Hi Zhang, Andrew
>
> This patch is needed on latest linus/master branch.
> Please re-check this patch.
Rui, it'd be better to send Andrew a finalized patch with your
Acked-by or Signed-off-by (because you passed it on), after resolving
the below puzzle:
> And, similar patch was added on linux-next/master branch
> b5da4e6d5603633835a1da267e0e699eea66f317
> (Thermal: Pass zone parameters as argument to tzd_register)
> but it seems wrong (?)
Thanks,
Fengguang
> At Tue, 21 Aug 2012 22:01:36 +0530,
> Devendra Naga wrote:
> >
> > following were the errors reported
> >
> > drivers/thermal/rcar_thermal.c: In function ‘rcar_thermal_probe’:
> > drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of
> > ‘thermal_zone_device_register’ makes integer from pointer without a cast
> > [enabled by default]
> > include/linux/thermal.h:166:29: note: expected ‘int’ but argument is of
> > type ‘struct rcar_thermal_priv *’
> > drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to function
> > ‘thermal_zone_device_register’
> > include/linux/thermal.h:166:29: note: declared here
> > make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1
> > make: *** [drivers/thermal/rcar_thermal.o] Error 2
> >
> > with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
> >
> > Signed-off-by: Devendra Naga
> > ---
> > drivers/thermal/rcar_thermal.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> > index d445271..f7a1b57 100644
> > --- a/drivers/thermal/rcar_thermal.c
> > +++ b/drivers/thermal/rcar_thermal.c
> > @@ -210,7 +210,7 @@ static int rcar_thermal_probe(struct platform_device
> > *pdev)
> > goto error_free_priv;
> > }
> >
> > - zone = thermal_zone_device_register("rcar_thermal", 0, priv,
> > + zone = thermal_zone_device_register("rcar_thermal", 0, 0, priv,
> > _thermal_zone_ops, 0, 0);
> > if (IS_ERR(zone)) {
> > dev_err(>dev, "thermal zone device is NULL\n");
> > --
> > 1.7.9.5
> >
>
>
> Best regards
> ---
> Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] thermal: solve compilation errors in rcar_thermal
Hi, Andrew,
Can you take this patch?
It fixes a real build error, and IMO, we should merge it ASAP. Thanks.
> -Original Message-
> From: kuninori morimoto [mailto:kuninori.morimoto...@gmail.com] On
> Behalf Of Kuninori Morimoto
> Sent: Wednesday, October 31, 2012 4:46 PM
> To: Zhang, Rui
> Cc: Andrew Morton; linux-kernel@vger.kernel.org; Wu, Fengguang;
> Devendra Naga
> Subject: [PATCH] thermal: solve compilation errors in rcar_thermal
> Importance: High
>
> From: Devendra Naga
>
> following were the errors reported
>
> drivers/thermal/rcar_thermal.c: In function 'rcar_thermal_probe':
> drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of
> 'thermal_zone_device_register' makes integer from pointer without a
> cast [enabled by default]
> include/linux/thermal.h:166:29: note: expected 'int' but argument is of
> type 'struct rcar_thermal_priv *'
> drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to
> function 'thermal_zone_device_register'
> include/linux/thermal.h:166:29: note: declared here
> make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1
> make: *** [drivers/thermal/rcar_thermal.o] Error 2
>
> with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
>
> Signed-off-by: Devendra Naga
Acked-by: Zhang Rui
Thanks,
rui
> ---
> Hi Zhang
>
> This is original patch.
> Please check Author's name after "git am"
>
> drivers/thermal/rcar_thermal.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c
> b/drivers/thermal/rcar_thermal.c index d445271..f7a1b57 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -210,7 +210,7 @@ static int rcar_thermal_probe(struct
> platform_device *pdev)
> goto error_free_priv;
> }
>
> - zone = thermal_zone_device_register("rcar_thermal", 0, priv,
> + zone = thermal_zone_device_register("rcar_thermal", 0, 0, priv,
> _thermal_zone_ops, 0, 0);
> if (IS_ERR(zone)) {
> dev_err(>dev, "thermal zone device is NULL\n");
> --
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] thermal: solve compilation errors in rcar_thermal
Sorry, I can not see the original post of this patch.
Can you resend it so that I can apply it?
> -Original Message-
> From: kuninori morimoto [mailto:kuninori.morimoto...@gmail.com] On
> Behalf Of Kuninori Morimoto
> Sent: Wednesday, October 31, 2012 11:21 AM
> To: Andrew Morton; Zhang, Rui; linux-kernel@vger.kernel.org
> Cc: Wu, Fengguang
> Subject: Re: [PATCH] thermal: solve compilation errors in rcar_thermal
> Importance: High
>
>
> Hi Zhang, Andrew
>
> This patch is needed on latest linus/master branch.
> Please re-check this patch.
>
> And, similar patch was added on linux-next/master branch
> b5da4e6d5603633835a1da267e0e699eea66f317
> (Thermal: Pass zone parameters as argument to tzd_register) but it
> seems wrong (?)
>
> At Tue, 21 Aug 2012 22:01:36 +0530,
> Devendra Naga wrote:
> >
> > following were the errors reported
> >
> > drivers/thermal/rcar_thermal.c: In function 'rcar_thermal_probe':
> > drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of
> > 'thermal_zone_device_register' makes integer from pointer without a
> > cast [enabled by default]
> > include/linux/thermal.h:166:29: note: expected 'int' but argument is
> of type 'struct rcar_thermal_priv *'
> > drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to
> function 'thermal_zone_device_register'
> > include/linux/thermal.h:166:29: note: declared here
> > make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1
> > make: *** [drivers/thermal/rcar_thermal.o] Error 2
> >
> > with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
> >
> > Signed-off-by: Devendra Naga
> > ---
> > drivers/thermal/rcar_thermal.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/rcar_thermal.c
> > b/drivers/thermal/rcar_thermal.c index d445271..f7a1b57 100644
> > --- a/drivers/thermal/rcar_thermal.c
> > +++ b/drivers/thermal/rcar_thermal.c
> > @@ -210,7 +210,7 @@ static int rcar_thermal_probe(struct
> platform_device *pdev)
> > goto error_free_priv;
> > }
> >
> > - zone = thermal_zone_device_register("rcar_thermal", 0, priv,
> > + zone = thermal_zone_device_register("rcar_thermal", 0, 0, priv,
> > _thermal_zone_ops, 0, 0);
> > if (IS_ERR(zone)) {
> > dev_err(>dev, "thermal zone device is NULL\n");
> > --
> > 1.7.9.5
> >
>
>
> Best regards
> ---
> Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] thermal: solve compilation errors in rcar_thermal
Sorry, I can not see the original post of this patch.
Can you resend it so that I can apply it?
-Original Message-
From: kuninori morimoto [mailto:kuninori.morimoto...@gmail.com] On
Behalf Of Kuninori Morimoto
Sent: Wednesday, October 31, 2012 11:21 AM
To: Andrew Morton; Zhang, Rui; linux-kernel@vger.kernel.org
Cc: Wu, Fengguang
Subject: Re: [PATCH] thermal: solve compilation errors in rcar_thermal
Importance: High
Hi Zhang, Andrew
This patch is needed on latest linus/master branch.
Please re-check this patch.
And, similar patch was added on linux-next/master branch
b5da4e6d5603633835a1da267e0e699eea66f317
(Thermal: Pass zone parameters as argument to tzd_register) but it
seems wrong (?)
At Tue, 21 Aug 2012 22:01:36 +0530,
Devendra Naga wrote:
following were the errors reported
drivers/thermal/rcar_thermal.c: In function 'rcar_thermal_probe':
drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of
'thermal_zone_device_register' makes integer from pointer without a
cast [enabled by default]
include/linux/thermal.h:166:29: note: expected 'int' but argument is
of type 'struct rcar_thermal_priv *'
drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to
function 'thermal_zone_device_register'
include/linux/thermal.h:166:29: note: declared here
make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1
make: *** [drivers/thermal/rcar_thermal.o] Error 2
with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/thermal/rcar_thermal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rcar_thermal.c
b/drivers/thermal/rcar_thermal.c index d445271..f7a1b57 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -210,7 +210,7 @@ static int rcar_thermal_probe(struct
platform_device *pdev)
goto error_free_priv;
}
- zone = thermal_zone_device_register(rcar_thermal, 0, priv,
+ zone = thermal_zone_device_register(rcar_thermal, 0, 0, priv,
rcar_thermal_zone_ops, 0, 0);
if (IS_ERR(zone)) {
dev_err(pdev-dev, thermal zone device is NULL\n);
--
1.7.9.5
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] thermal: solve compilation errors in rcar_thermal
Hi, Andrew,
Can you take this patch?
It fixes a real build error, and IMO, we should merge it ASAP. Thanks.
-Original Message-
From: kuninori morimoto [mailto:kuninori.morimoto...@gmail.com] On
Behalf Of Kuninori Morimoto
Sent: Wednesday, October 31, 2012 4:46 PM
To: Zhang, Rui
Cc: Andrew Morton; linux-kernel@vger.kernel.org; Wu, Fengguang;
Devendra Naga
Subject: [PATCH] thermal: solve compilation errors in rcar_thermal
Importance: High
From: Devendra Naga develkernel412...@gmail.com
following were the errors reported
drivers/thermal/rcar_thermal.c: In function 'rcar_thermal_probe':
drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of
'thermal_zone_device_register' makes integer from pointer without a
cast [enabled by default]
include/linux/thermal.h:166:29: note: expected 'int' but argument is of
type 'struct rcar_thermal_priv *'
drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to
function 'thermal_zone_device_register'
include/linux/thermal.h:166:29: note: declared here
make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1
make: *** [drivers/thermal/rcar_thermal.o] Error 2
with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
Signed-off-by: Devendra Naga develkernel412...@gmail.com
Acked-by: Zhang Rui rui.zh...@intel.com
Thanks,
rui
---
Hi Zhang
This is original patch.
Please check Author's name after git am
drivers/thermal/rcar_thermal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rcar_thermal.c
b/drivers/thermal/rcar_thermal.c index d445271..f7a1b57 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -210,7 +210,7 @@ static int rcar_thermal_probe(struct
platform_device *pdev)
goto error_free_priv;
}
- zone = thermal_zone_device_register(rcar_thermal, 0, priv,
+ zone = thermal_zone_device_register(rcar_thermal, 0, 0, priv,
rcar_thermal_zone_ops, 0, 0);
if (IS_ERR(zone)) {
dev_err(pdev-dev, thermal zone device is NULL\n);
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] thermal: solve compilation errors in rcar_thermal
On Tue, Oct 30, 2012 at 08:21:09PM -0700, Kuninori Morimoto wrote:
Hi Zhang, Andrew
This patch is needed on latest linus/master branch.
Please re-check this patch.
Rui, it'd be better to send Andrew a finalized patch with your
Acked-by or Signed-off-by (because you passed it on), after resolving
the below puzzle:
And, similar patch was added on linux-next/master branch
b5da4e6d5603633835a1da267e0e699eea66f317
(Thermal: Pass zone parameters as argument to tzd_register)
but it seems wrong (?)
Thanks,
Fengguang
At Tue, 21 Aug 2012 22:01:36 +0530,
Devendra Naga wrote:
following were the errors reported
drivers/thermal/rcar_thermal.c: In function ‘rcar_thermal_probe’:
drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of
‘thermal_zone_device_register’ makes integer from pointer without a cast
[enabled by default]
include/linux/thermal.h:166:29: note: expected ‘int’ but argument is of
type ‘struct rcar_thermal_priv *’
drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to function
‘thermal_zone_device_register’
include/linux/thermal.h:166:29: note: declared here
make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1
make: *** [drivers/thermal/rcar_thermal.o] Error 2
with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/thermal/rcar_thermal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index d445271..f7a1b57 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -210,7 +210,7 @@ static int rcar_thermal_probe(struct platform_device
*pdev)
goto error_free_priv;
}
- zone = thermal_zone_device_register(rcar_thermal, 0, priv,
+ zone = thermal_zone_device_register(rcar_thermal, 0, 0, priv,
rcar_thermal_zone_ops, 0, 0);
if (IS_ERR(zone)) {
dev_err(pdev-dev, thermal zone device is NULL\n);
--
1.7.9.5
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] thermal: solve compilation errors in rcar_thermal
Hi Zhang, Andrew
This patch is needed on latest linus/master branch.
Please re-check this patch.
And, similar patch was added on linux-next/master branch
b5da4e6d5603633835a1da267e0e699eea66f317
(Thermal: Pass zone parameters as argument to tzd_register)
but it seems wrong (?)
At Tue, 21 Aug 2012 22:01:36 +0530,
Devendra Naga wrote:
>
> following were the errors reported
>
> drivers/thermal/rcar_thermal.c: In function ‘rcar_thermal_probe’:
> drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of
> ‘thermal_zone_device_register’ makes integer from pointer without a cast
> [enabled by default]
> include/linux/thermal.h:166:29: note: expected ‘int’ but argument is of type
> ‘struct rcar_thermal_priv *’
> drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to function
> ‘thermal_zone_device_register’
> include/linux/thermal.h:166:29: note: declared here
> make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1
> make: *** [drivers/thermal/rcar_thermal.o] Error 2
>
> with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
>
> Signed-off-by: Devendra Naga
> ---
> drivers/thermal/rcar_thermal.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index d445271..f7a1b57 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -210,7 +210,7 @@ static int rcar_thermal_probe(struct platform_device
> *pdev)
> goto error_free_priv;
> }
>
> - zone = thermal_zone_device_register("rcar_thermal", 0, priv,
> + zone = thermal_zone_device_register("rcar_thermal", 0, 0, priv,
> _thermal_zone_ops, 0, 0);
> if (IS_ERR(zone)) {
> dev_err(>dev, "thermal zone device is NULL\n");
> --
> 1.7.9.5
>
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] thermal: solve compilation errors in rcar_thermal
Hi Zhang, Andrew
This patch is needed on latest linus/master branch.
Please re-check this patch.
And, similar patch was added on linux-next/master branch
b5da4e6d5603633835a1da267e0e699eea66f317
(Thermal: Pass zone parameters as argument to tzd_register)
but it seems wrong (?)
At Tue, 21 Aug 2012 22:01:36 +0530,
Devendra Naga wrote:
following were the errors reported
drivers/thermal/rcar_thermal.c: In function ‘rcar_thermal_probe’:
drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of
‘thermal_zone_device_register’ makes integer from pointer without a cast
[enabled by default]
include/linux/thermal.h:166:29: note: expected ‘int’ but argument is of type
‘struct rcar_thermal_priv *’
drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to function
‘thermal_zone_device_register’
include/linux/thermal.h:166:29: note: declared here
make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1
make: *** [drivers/thermal/rcar_thermal.o] Error 2
with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/thermal/rcar_thermal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index d445271..f7a1b57 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -210,7 +210,7 @@ static int rcar_thermal_probe(struct platform_device
*pdev)
goto error_free_priv;
}
- zone = thermal_zone_device_register(rcar_thermal, 0, priv,
+ zone = thermal_zone_device_register(rcar_thermal, 0, 0, priv,
rcar_thermal_zone_ops, 0, 0);
if (IS_ERR(zone)) {
dev_err(pdev-dev, thermal zone device is NULL\n);
--
1.7.9.5
Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] thermal: solve compilation errors in rcar_thermal
Hi > following were the errors reported > > drivers/thermal/rcar_thermal.c: In function ‘rcar_thermal_probe’: > drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of > ‘thermal_zone_device_register’ makes integer from pointer without a cast > [enabled by default] > include/linux/thermal.h:166:29: note: expected ‘int’ but argument is of type > ‘struct rcar_thermal_priv *’ > drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to function > ‘thermal_zone_device_register’ > include/linux/thermal.h:166:29: note: declared here > make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1 > make: *** [drivers/thermal/rcar_thermal.o] Error 2 > > with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) > > Signed-off-by: Devendra Naga > --- Acked-by: Kuninori Morimoto Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] thermal: solve compilation errors in rcar_thermal
Hi following were the errors reported drivers/thermal/rcar_thermal.c: In function ‘rcar_thermal_probe’: drivers/thermal/rcar_thermal.c:214:10: warning: passing argument 3 of ‘thermal_zone_device_register’ makes integer from pointer without a cast [enabled by default] include/linux/thermal.h:166:29: note: expected ‘int’ but argument is of type ‘struct rcar_thermal_priv *’ drivers/thermal/rcar_thermal.c:214:10: error: too few arguments to function ‘thermal_zone_device_register’ include/linux/thermal.h:166:29: note: declared here make[1]: *** [drivers/thermal/rcar_thermal.o] Error 1 make: *** [drivers/thermal/rcar_thermal.o] Error 2 with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) Signed-off-by: Devendra Naga develkernel412...@gmail.com --- Acked-by: Kuninori Morimoto kuninori.morimoto...@renesas.com Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
