Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-18 Thread Greg KH
On Thu, Jan 17, 2008 at 03:15:23PM -0800, Kevin Lloyd wrote:
> > > Correct, the 0x0023 is the only newly added device that requires the
> new
> > > features.
> >
> > Does that mean things will not work for this device if it is added to
> > the device table, without the code updates?
> Adding the device will not break the driver (assuming you remove the
> tag).

Which "tag"?  The device id?

> > And is this device even public yet?
> 
> No, but we are trying to add native support for devices into kernels
> well before they are released in an effort give better native support
> to end-users.

Ok, that's great to do, and is what needs to be done, just can't add new
features during the "bug-fix-only" cycle of development :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-18 Thread Greg KH
On Thu, Jan 17, 2008 at 03:15:23PM -0800, Kevin Lloyd wrote:
   Correct, the 0x0023 is the only newly added device that requires the
 new
   features.
 
  Does that mean things will not work for this device if it is added to
  the device table, without the code updates?
 Adding the device will not break the driver (assuming you remove the
 tag).

Which tag?  The device id?

  And is this device even public yet?
 
 No, but we are trying to add native support for devices into kernels
 well before they are released in an effort give better native support
 to end-users.

Ok, that's great to do, and is what needs to be done, just can't add new
features during the bug-fix-only cycle of development :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-17 Thread Kevin Lloyd
> > Correct, the 0x0023 is the only newly added device that requires the
new
> > features.
>
> Does that mean things will not work for this device if it is added to
> the device table, without the code updates?
Adding the device will not break the driver (assuming you remove the
tag).

> And is this device even public yet?

No, but we are trying to add native support for devices into kernels
well 
before they are released in an effort give better native support to
end-users.

> > When do you expect the other changes will be propagated to the
kernel?
> > Would it be in a 2.6.24.x point release or will they have to wait
until
> > 2.6.25?
>
> They will have to wait until 2.6.25, they are too big to go into
2.6.24
> (we are in severe bug-fix mode only right now for .24).
Darn.

Thanks,
 -Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-17 Thread Greg KH
On Mon, Jan 14, 2008 at 09:21:32AM -0800, Kevin Lloyd wrote:
> > Hm, no, the intrusion into the driver is just too much this late in
> the
> > release cycle to allow this.
> >
> > Now I will be glad to only add the new device ids for the devices that
> > do not rely on the new changes right now, but that's it.
> >
> > So, right now I have a separate patch split out of your original one
> > that is below.  Should I modify it and not include some of these
> device
> > ids right now?  You mention 0023, is that the only one I should remove
> > from this patch?
> 
> Correct, the 0x0023 is the only newly added device that requires the new
> features.

Does that mean things will not work for this device if it is added to
the device table, without the code updates?

And is this device even public yet?

> When do you expect the other changes will be propagated to the kernel?
> Would it be in a 2.6.24.x point release or will they have to wait until
> 2.6.25?

They will have to wait until 2.6.25, they are too big to go into 2.6.24
(we are in severe bug-fix mode only right now for .24).

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-17 Thread Greg KH
On Mon, Jan 14, 2008 at 09:21:32AM -0800, Kevin Lloyd wrote:
  Hm, no, the intrusion into the driver is just too much this late in
 the
  release cycle to allow this.
 
  Now I will be glad to only add the new device ids for the devices that
  do not rely on the new changes right now, but that's it.
 
  So, right now I have a separate patch split out of your original one
  that is below.  Should I modify it and not include some of these
 device
  ids right now?  You mention 0023, is that the only one I should remove
  from this patch?
 
 Correct, the 0x0023 is the only newly added device that requires the new
 features.

Does that mean things will not work for this device if it is added to
the device table, without the code updates?

And is this device even public yet?

 When do you expect the other changes will be propagated to the kernel?
 Would it be in a 2.6.24.x point release or will they have to wait until
 2.6.25?

They will have to wait until 2.6.25, they are too big to go into 2.6.24
(we are in severe bug-fix mode only right now for .24).

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-17 Thread Kevin Lloyd
  Correct, the 0x0023 is the only newly added device that requires the
new
  features.

 Does that mean things will not work for this device if it is added to
 the device table, without the code updates?
Adding the device will not break the driver (assuming you remove the
tag).

 And is this device even public yet?

No, but we are trying to add native support for devices into kernels
well 
before they are released in an effort give better native support to
end-users.

  When do you expect the other changes will be propagated to the
kernel?
  Would it be in a 2.6.24.x point release or will they have to wait
until
  2.6.25?

 They will have to wait until 2.6.25, they are too big to go into
2.6.24
 (we are in severe bug-fix mode only right now for .24).
Darn.

Thanks,
 -Kevin

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-14 Thread Kevin Lloyd
> Hm, no, the intrusion into the driver is just too much this late in
the
> release cycle to allow this.
>
> Now I will be glad to only add the new device ids for the devices that
> do not rely on the new changes right now, but that's it.
>
> So, right now I have a separate patch split out of your original one
> that is below.  Should I modify it and not include some of these
device
> ids right now?  You mention 0023, is that the only one I should remove
> from this patch?

Correct, the 0x0023 is the only newly added device that requires the new
features.
When do you expect the other changes will be propagated to the kernel?
Would it be in a 2.6.24.x point release or will they have to wait until
2.6.25?

Thanks,
 -Kevin

-

From: Kevin Lloyd <[EMAIL PROTECTED]>
Subject: USB: sierra driver - add devices

From: Kevin Lloyd <[EMAIL PROTECTED]>

The following improvements were made:
 - Added new product support: MC5725, AC 880 U, MP 3G (UMTS & CDMA)

Signed-off-by: Kevin Lloyd <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>

---
 drivers/usb/serial/sierra.c |9 +
 1 file changed, 9 insertions(+)

--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -104,6 +104,7 @@ static struct usb_device_id id_table [] 
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595
*/
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E
*/
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle
595U */
+   { USB_DEVICE(0x1199, 0x0023) }, /* Sierra Wireless AirCard */
 
{ USB_DEVICE(0x1199, 0x6802) }, /* Sierra Wireless MC8755 */
{ USB_DEVICE(0x1199, 0x6804) }, /* Sierra Wireless MC8755 */
@@ -117,8 +118,12 @@ static struct usb_device_id id_table [] 
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881
*/
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880 E
*/
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881 E
*/
+   { USB_DEVICE(0x1199, 0x6855) }, /* Sierra Wireless AirCard 880 U
*/
{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U
*/
 
+   { USB_DEVICE(0x1199, 0x6468) }, /* Sierra Wireless MP3G - EVDO
*/
+   { USB_DEVICE(0x1199, 0x6469) }, /* Sierra Wireless MP3G -
UMTS/HSPA */
+
{ USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /*
Sierra Wireless AirCard 580 */
{ USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /*
Airprime/Sierra PC 5220 */
 
@@ -143,6 +148,7 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595
*/
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E
*/
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle
595U*/
+   { USB_DEVICE(0x1199, 0x0023) }, /* Sierra Wireless AirCard */
 
{ USB_DEVICE(0x1199, 0x6802) }, /* Sierra Wireless MC8755 */
{ USB_DEVICE(0x1199, 0x6804) }, /* Sierra Wireless MC8755 */
@@ -156,7 +162,10 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881
*/
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880E
*/
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881E
*/
+   { USB_DEVICE(0x1199, 0x6855) }, /* Sierra Wireless AirCard 880 U
*/
{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U
*/
+   { USB_DEVICE(0x1199, 0x6468) }, /* Sierra Wireless MP3G - EVDO
*/
+   { USB_DEVICE(0x1199, 0x6469) }, /* Sierra Wireless MP3G -
UMTS/HSPA */
{ }
 };
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-14 Thread Kevin Lloyd
 Hm, no, the intrusion into the driver is just too much this late in
the
 release cycle to allow this.

 Now I will be glad to only add the new device ids for the devices that
 do not rely on the new changes right now, but that's it.

 So, right now I have a separate patch split out of your original one
 that is below.  Should I modify it and not include some of these
device
 ids right now?  You mention 0023, is that the only one I should remove
 from this patch?

Correct, the 0x0023 is the only newly added device that requires the new
features.
When do you expect the other changes will be propagated to the kernel?
Would it be in a 2.6.24.x point release or will they have to wait until
2.6.25?

Thanks,
 -Kevin

-

From: Kevin Lloyd [EMAIL PROTECTED]
Subject: USB: sierra driver - add devices

From: Kevin Lloyd [EMAIL PROTECTED]

The following improvements were made:
 - Added new product support: MC5725, AC 880 U, MP 3G (UMTS  CDMA)

Signed-off-by: Kevin Lloyd [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]

---
 drivers/usb/serial/sierra.c |9 +
 1 file changed, 9 insertions(+)

--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -104,6 +104,7 @@ static struct usb_device_id id_table [] 
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595
*/
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E
*/
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle
595U */
+   { USB_DEVICE(0x1199, 0x0023) }, /* Sierra Wireless AirCard */
 
{ USB_DEVICE(0x1199, 0x6802) }, /* Sierra Wireless MC8755 */
{ USB_DEVICE(0x1199, 0x6804) }, /* Sierra Wireless MC8755 */
@@ -117,8 +118,12 @@ static struct usb_device_id id_table [] 
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881
*/
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880 E
*/
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881 E
*/
+   { USB_DEVICE(0x1199, 0x6855) }, /* Sierra Wireless AirCard 880 U
*/
{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U
*/
 
+   { USB_DEVICE(0x1199, 0x6468) }, /* Sierra Wireless MP3G - EVDO
*/
+   { USB_DEVICE(0x1199, 0x6469) }, /* Sierra Wireless MP3G -
UMTS/HSPA */
+
{ USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /*
Sierra Wireless AirCard 580 */
{ USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /*
Airprime/Sierra PC 5220 */
 
@@ -143,6 +148,7 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595
*/
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E
*/
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle
595U*/
+   { USB_DEVICE(0x1199, 0x0023) }, /* Sierra Wireless AirCard */
 
{ USB_DEVICE(0x1199, 0x6802) }, /* Sierra Wireless MC8755 */
{ USB_DEVICE(0x1199, 0x6804) }, /* Sierra Wireless MC8755 */
@@ -156,7 +162,10 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881
*/
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880E
*/
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881E
*/
+   { USB_DEVICE(0x1199, 0x6855) }, /* Sierra Wireless AirCard 880 U
*/
{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U
*/
+   { USB_DEVICE(0x1199, 0x6468) }, /* Sierra Wireless MP3G - EVDO
*/
+   { USB_DEVICE(0x1199, 0x6469) }, /* Sierra Wireless MP3G -
UMTS/HSPA */
{ }
 };
 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-11 Thread Greg KH
On Fri, Jan 11, 2008 at 09:24:36AM -0800, Kevin Lloyd wrote:
> > Those device ids are already in my tree, as it was my understanding
> that
> > you would not be sending me patches for them :)
> You're right, I normally wouldn't, but since someone else already had, I
> figured it would be alright.
> > I'll split this patch up into something that updates the device ids
> and
> > then does all of the other changes.  The device ids can go into 2.6.24
> > (and -stable if I miss the merge window), but the other changes should
> > wait until 2.6.25.
> >
> > Any objection to this?
> Actually some of the added functionality (calc_num_ports) is required
> for
> device 0x0023 and will be necessary for future devices (should someone 
> want to add the VID/PID of a new device it will likely require the added
> 
> support).
> 
> So my preference would be to please include the other changes in the 
> 2.6.24 release.

Hm, no, the intrusion into the driver is just too much this late in the
release cycle to allow this.

Now I will be glad to only add the new device ids for the devices that
do not rely on the new changes right now, but that's it.

So, right now I have a separate patch split out of your original one
that is below.  Should I modify it and not include some of these device
ids right now?  You mention 0023, is that the only one I should remove
from this patch?

thanks,

greg k-h

-

From: Kevin Lloyd <[EMAIL PROTECTED]>
Subject: USB: sierra driver - add devices

From: Kevin Lloyd <[EMAIL PROTECTED]>

The following improvements were made:
 - Added new product support: MC5725, AC 880 U, MP 3G (UMTS & CDMA)

Signed-off-by: Kevin Lloyd <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>

---
 drivers/usb/serial/sierra.c |9 +
 1 file changed, 9 insertions(+)

--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -104,6 +104,7 @@ static struct usb_device_id id_table [] 
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595 */
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E */
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle 595U */
+   { USB_DEVICE(0x1199, 0x0023) }, /* Sierra Wireless AirCard */
 
{ USB_DEVICE(0x1199, 0x6802) }, /* Sierra Wireless MC8755 */
{ USB_DEVICE(0x1199, 0x6804) }, /* Sierra Wireless MC8755 */
@@ -117,8 +118,12 @@ static struct usb_device_id id_table [] 
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880 E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881 E */
+   { USB_DEVICE(0x1199, 0x6855) }, /* Sierra Wireless AirCard 880 U */
{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */
 
+   { USB_DEVICE(0x1199, 0x6468) }, /* Sierra Wireless MP3G - EVDO */
+   { USB_DEVICE(0x1199, 0x6469) }, /* Sierra Wireless MP3G - UMTS/HSPA */
+
{ USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /* Sierra 
Wireless AirCard 580 */
{ USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /* 
Airprime/Sierra PC 5220 */
 
@@ -143,6 +148,7 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595 */
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E */
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle 595U*/
+   { USB_DEVICE(0x1199, 0x0023) }, /* Sierra Wireless AirCard */
 
{ USB_DEVICE(0x1199, 0x6802) }, /* Sierra Wireless MC8755 */
{ USB_DEVICE(0x1199, 0x6804) }, /* Sierra Wireless MC8755 */
@@ -156,7 +162,10 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881E */
+   { USB_DEVICE(0x1199, 0x6855) }, /* Sierra Wireless AirCard 880 U */
{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */
+   { USB_DEVICE(0x1199, 0x6468) }, /* Sierra Wireless MP3G - EVDO */
+   { USB_DEVICE(0x1199, 0x6469) }, /* Sierra Wireless MP3G - UMTS/HSPA */
{ }
 };
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-11 Thread Kevin Lloyd
> Those device ids are already in my tree, as it was my understanding
that
> you would not be sending me patches for them :)
You're right, I normally wouldn't, but since someone else already had, I
figured it would be alright.
> I'll split this patch up into something that updates the device ids
and
> then does all of the other changes.  The device ids can go into 2.6.24
> (and -stable if I miss the merge window), but the other changes should
> wait until 2.6.25.
>
> Any objection to this?
Actually some of the added functionality (calc_num_ports) is required
for
device 0x0023 and will be necessary for future devices (should someone 
want to add the VID/PID of a new device it will likely require the added

support).

So my preference would be to please include the other changes in the 
2.6.24 release.

Thanks,
 -Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-11 Thread Kevin Lloyd
 Those device ids are already in my tree, as it was my understanding
that
 you would not be sending me patches for them :)
You're right, I normally wouldn't, but since someone else already had, I
figured it would be alright.
 I'll split this patch up into something that updates the device ids
and
 then does all of the other changes.  The device ids can go into 2.6.24
 (and -stable if I miss the merge window), but the other changes should
 wait until 2.6.25.

 Any objection to this?
Actually some of the added functionality (calc_num_ports) is required
for
device 0x0023 and will be necessary for future devices (should someone 
want to add the VID/PID of a new device it will likely require the added

support).

So my preference would be to please include the other changes in the 
2.6.24 release.

Thanks,
 -Kevin
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-11 Thread Greg KH
On Fri, Jan 11, 2008 at 09:24:36AM -0800, Kevin Lloyd wrote:
  Those device ids are already in my tree, as it was my understanding
 that
  you would not be sending me patches for them :)
 You're right, I normally wouldn't, but since someone else already had, I
 figured it would be alright.
  I'll split this patch up into something that updates the device ids
 and
  then does all of the other changes.  The device ids can go into 2.6.24
  (and -stable if I miss the merge window), but the other changes should
  wait until 2.6.25.
 
  Any objection to this?
 Actually some of the added functionality (calc_num_ports) is required
 for
 device 0x0023 and will be necessary for future devices (should someone 
 want to add the VID/PID of a new device it will likely require the added
 
 support).
 
 So my preference would be to please include the other changes in the 
 2.6.24 release.

Hm, no, the intrusion into the driver is just too much this late in the
release cycle to allow this.

Now I will be glad to only add the new device ids for the devices that
do not rely on the new changes right now, but that's it.

So, right now I have a separate patch split out of your original one
that is below.  Should I modify it and not include some of these device
ids right now?  You mention 0023, is that the only one I should remove
from this patch?

thanks,

greg k-h

-

From: Kevin Lloyd [EMAIL PROTECTED]
Subject: USB: sierra driver - add devices

From: Kevin Lloyd [EMAIL PROTECTED]

The following improvements were made:
 - Added new product support: MC5725, AC 880 U, MP 3G (UMTS  CDMA)

Signed-off-by: Kevin Lloyd [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]

---
 drivers/usb/serial/sierra.c |9 +
 1 file changed, 9 insertions(+)

--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -104,6 +104,7 @@ static struct usb_device_id id_table [] 
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595 */
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E */
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle 595U */
+   { USB_DEVICE(0x1199, 0x0023) }, /* Sierra Wireless AirCard */
 
{ USB_DEVICE(0x1199, 0x6802) }, /* Sierra Wireless MC8755 */
{ USB_DEVICE(0x1199, 0x6804) }, /* Sierra Wireless MC8755 */
@@ -117,8 +118,12 @@ static struct usb_device_id id_table [] 
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880 E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881 E */
+   { USB_DEVICE(0x1199, 0x6855) }, /* Sierra Wireless AirCard 880 U */
{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881 U */
 
+   { USB_DEVICE(0x1199, 0x6468) }, /* Sierra Wireless MP3G - EVDO */
+   { USB_DEVICE(0x1199, 0x6469) }, /* Sierra Wireless MP3G - UMTS/HSPA */
+
{ USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /* Sierra 
Wireless AirCard 580 */
{ USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /* 
Airprime/Sierra PC 5220 */
 
@@ -143,6 +148,7 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x0019) }, /* Sierra Wireless AirCard 595 */
{ USB_DEVICE(0x1199, 0x0021) }, /* Sierra Wireless AirCard 597E */
{ USB_DEVICE(0x1199, 0x0120) }, /* Sierra Wireless USB Dongle 595U*/
+   { USB_DEVICE(0x1199, 0x0023) }, /* Sierra Wireless AirCard */
 
{ USB_DEVICE(0x1199, 0x6802) }, /* Sierra Wireless MC8755 */
{ USB_DEVICE(0x1199, 0x6804) }, /* Sierra Wireless MC8755 */
@@ -156,7 +162,10 @@ static struct usb_device_id id_table_3po
{ USB_DEVICE(0x1199, 0x6851) }, /* Sierra Wireless AirCard 881 */
{ USB_DEVICE(0x1199, 0x6852) }, /* Sierra Wireless AirCard 880E */
{ USB_DEVICE(0x1199, 0x6853) }, /* Sierra Wireless AirCard 881E */
+   { USB_DEVICE(0x1199, 0x6855) }, /* Sierra Wireless AirCard 880 U */
{ USB_DEVICE(0x1199, 0x6856) }, /* Sierra Wireless AirCard 881U */
+   { USB_DEVICE(0x1199, 0x6468) }, /* Sierra Wireless MP3G - EVDO */
+   { USB_DEVICE(0x1199, 0x6469) }, /* Sierra Wireless MP3G - UMTS/HSPA */
{ }
 };
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-10 Thread Greg KH
On Thu, Jan 10, 2008 at 11:11:04AM -0800, Kevin Lloyd wrote:
> From: Kevin Lloyd <[EMAIL PROTECTED]>
> 
> This patch is targeted for the 2.6.24-rc7 kernel.
> 
> The following improvements were made:
>  - Added new product support: MC5725, AC 880 U, MP 3G (UMTS & CDMA)
>  - Fixed control line issue where asserting DTR on ep5 would close ep2
>  - Added support for calc_num_ports (will help support future composite 
> devices)
> 
> This also covers the devices added by [EMAIL PROTECTED] and
> [EMAIL PROTECTED] since their patches were not committed to
> the 2.6.23-rc7 kernel.

Those device ids are already in my tree, as it was my understanding that
you would not be sending me patches for them :)

I'll split this patch up into something that updates the device ids and
then does all of the other changes.  The device ids can go into 2.6.24
(and -stable if I miss the merge window), but the other changes should
wait until 2.6.25.

Any objection to this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-10 Thread Greg KH
On Thu, Jan 10, 2008 at 11:11:04AM -0800, Kevin Lloyd wrote:
 From: Kevin Lloyd [EMAIL PROTECTED]
 
 This patch is targeted for the 2.6.24-rc7 kernel.
 
 The following improvements were made:
  - Added new product support: MC5725, AC 880 U, MP 3G (UMTS  CDMA)
  - Fixed control line issue where asserting DTR on ep5 would close ep2
  - Added support for calc_num_ports (will help support future composite 
 devices)
 
 This also covers the devices added by [EMAIL PROTECTED] and
 [EMAIL PROTECTED] since their patches were not committed to
 the 2.6.23-rc7 kernel.

Those device ids are already in my tree, as it was my understanding that
you would not be sending me patches for them :)

I'll split this patch up into something that updates the device ids and
then does all of the other changes.  The device ids can go into 2.6.24
(and -stable if I miss the merge window), but the other changes should
wait until 2.6.25.

Any objection to this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/