RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-23 Thread Ramneek Mehresh 


> -Original Message-
> From: Jun Li [mailto:jun...@nxp.com]
> Sent: Wednesday, December 23, 2015 10:02 PM
> To: Mehresh Ramneek-B31383 ; Felipe
> Balbi ; linux-kernel@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org
> Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> 
> 
> > -Original Message-
> > From: Ramneek Mehresh [mailto:ramneek.mehr...@freescale.com]
> > Sent: Wednesday, December 23, 2015 8:20 PM
> > To: Jun Li ; Felipe Balbi ; linux-
> > ker...@vger.kernel.org
> > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > u...@vger.kernel.org
> > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> >
> >
> >
> > > -Original Message-
> > > From: Jun Li [mailto:jun...@nxp.com]
> > > Sent: Wednesday, December 23, 2015 10:36 AM
> > > To: Felipe Balbi ; Mehresh Ramneek-B31383
> > > ; linux-kernel@vger.kernel.org
> > > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > > u...@vger.kernel.org
> > > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> > >
> > > Hi
> > >
> > > > -Original Message-
> > > > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> > > > ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> > > > Sent: Wednesday, December 23, 2015 2:21 AM
> > > > To: Ramneek Mehresh ; linux-
> > > > ker...@vger.kernel.org
> > > > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > > > u...@vger.kernel.org
> > > > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> > > >
> > > >
> > > > Hi,
> > > >
> > > > Ramneek Mehresh  writes:
> > > > >> -----Original Message-----
> > > > >> From: Felipe Balbi [mailto:ba...@ti.com]
> > > > >> Sent: Saturday, October 10, 2015 3:04 AM
> > > > >> To: Mehresh Ramneek-B31383
> ;
> > > linux-
> > > > >> ker...@vger.kernel.org
> > > > >> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;
> > > > >> linux- u...@vger.kernel.org; Mehresh Ramneek-B31383
> > > > >> 
> > > > >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> > > > >>
> > > > >> Felipe Balbi  writes:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > Ramneek Mehresh  writes:
> > > > >> >> Add support for otg for all freescale socs having internal
> > > > >> >> usb
> > phy.
> > > > >> >>
> > > > >> >> Ramneek Mehresh (7):
> > > > >> >>   usb:fsl:otg: Make fsl otg driver as tristate
> > > > >> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> > > > >> >>   usb:fsl:otg: Add support to add/remove usb host driver
> > > > >> >>   usb:fsl:otg: Signal host drv when host is otg
> > > > >> >>   usb:fsl:otg: Modify otg_event to start host drv
> > > > >> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> > > > >> >>   usb:fsl:otg: Add host-gadget drv sync delay
> > > > >> >
> > > > >> > Unless Alan's okay with the host side changes, I can't accept
> > > > >> > any of these. However, I must say some of the flags you add
> > > > >> > here already exist in some way, shape or form. For example,
> > > > >> > look at
> > > > is_b_host flag.
> > > > >>
> > > > >
> > > > > Could you please be more specific...which flag you think that I
> > > > >should remove/I'm re-defining. The flags I'm defining are:
> > > > >
> > > > > have_hcd : defined in fsl specific structure for fsl specific
> > > > > use-case
> > > > >
> > > > > had_hcd: defined in fsl specific structure for fsl specific
> > > > > use-case
> > > > >
> > > > > is_otg : defined in include/linux/usb.h
> > > > >
> > > > > Are you suggesting using otg_port or is_b_host instead of is_otg?
> > > > >
> > > > > As I understand, is_b_host is specifically to check if an otg B
> > &g

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-23 Thread Jun Li 


> -Original Message-
> From: Ramneek Mehresh [mailto:ramneek.mehr...@freescale.com]
> Sent: Wednesday, December 23, 2015 8:20 PM
> To: Jun Li ; Felipe Balbi ; linux-
> ker...@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org
> Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> 
> 
> > -Original Message-
> > From: Jun Li [mailto:jun...@nxp.com]
> > Sent: Wednesday, December 23, 2015 10:36 AM
> > To: Felipe Balbi ; Mehresh Ramneek-B31383
> > ; linux-kernel@vger.kernel.org
> > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > u...@vger.kernel.org
> > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> >
> > Hi
> >
> > > -Original Message-
> > > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> > > ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> > > Sent: Wednesday, December 23, 2015 2:21 AM
> > > To: Ramneek Mehresh ; linux-
> > > ker...@vger.kernel.org
> > > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > > u...@vger.kernel.org
> > > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> > >
> > >
> > > Hi,
> > >
> > > Ramneek Mehresh  writes:
> > > >> -Original Message-
> > > >> From: Felipe Balbi [mailto:ba...@ti.com]
> > > >> Sent: Saturday, October 10, 2015 3:04 AM
> > > >> To: Mehresh Ramneek-B31383 ;
> > linux-
> > > >> ker...@vger.kernel.org
> > > >> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > > >> u...@vger.kernel.org; Mehresh Ramneek-B31383
> > > >> 
> > > >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> > > >>
> > > >> Felipe Balbi  writes:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > Ramneek Mehresh  writes:
> > > >> >> Add support for otg for all freescale socs having internal usb
> phy.
> > > >> >>
> > > >> >> Ramneek Mehresh (7):
> > > >> >>   usb:fsl:otg: Make fsl otg driver as tristate
> > > >> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> > > >> >>   usb:fsl:otg: Add support to add/remove usb host driver
> > > >> >>   usb:fsl:otg: Signal host drv when host is otg
> > > >> >>   usb:fsl:otg: Modify otg_event to start host drv
> > > >> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> > > >> >>   usb:fsl:otg: Add host-gadget drv sync delay
> > > >> >
> > > >> > Unless Alan's okay with the host side changes, I can't accept
> > > >> > any of these. However, I must say some of the flags you add
> > > >> > here already exist in some way, shape or form. For example,
> > > >> > look at
> > > is_b_host flag.
> > > >>
> > > >
> > > > Could you please be more specific...which flag you think that I
> > > >should remove/I'm re-defining. The flags I'm defining are:
> > > >
> > > > have_hcd : defined in fsl specific structure for fsl specific
> > > > use-case
> > > >
> > > > had_hcd: defined in fsl specific structure for fsl specific
> > > > use-case
> > > >
> > > > is_otg : defined in include/linux/usb.h
> > > >
> > > > Are you suggesting using otg_port or is_b_host instead of is_otg?
> > > >
> > > > As I understand, is_b_host is specifically to check if an otg B
> > > > device is in host mode...correct?  I just need a flag to check if
> > > > a controller is capable of otg operations? That's why defined
> "is_otg"
> > > > flag. Please suggest.
> > >
> > > no, I don't know why I made that comment. You could use otg_port,
> > > but that wouldn't look very clean. Can you resend with Alan's ack,
> > > then I'll move this series into testing/next.
> > >
> > > --
> > > balbi
> >
> > Can you directly put the change_hcd_work in its phy driver(phy-fsl-
> usb.c)?
> > Then add/remove hcd will not through ehci_fsl_drv_suspend/resume, With
> > this, you can make it work without a new flag "is_otg".
> >
> change_hcd_work() changes host controller mode, and hence, should be in
> host controller driver. 

Reasonable, but most of OTG stuff not belong to phy actully,
I see phy-msm-usb.c directly do hcd add/remove for OTG. 

> To move this to phy driver (just to avoid usage of
> a single flag) won't be a good idea.

I just saw you simply still use the suspend/resume method, but the
change_hcd_work actually has nothing to do with it now, then add a
flag to return for it, also the flag in your usage is not to indicate
if the host capable/enabled otg, but something like
is_host_role_to_be_changed_for_otg(test and then clear).

Meanwhile you add another 2 flags in ehci_fsl(have_hcd, add_hcd) also for
OTG host add/remove, so I am thinking if all those can be simplified. 

> In this case, I'll also have to move some host controller specific flags
> to phy drv which won't be correct.

> 
> > Li Jun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-23 Thread Ramneek Mehresh 


> -Original Message-
> From: Jun Li [mailto:jun...@nxp.com]
> Sent: Wednesday, December 23, 2015 10:36 AM
> To: Felipe Balbi ; Mehresh Ramneek-B31383
> ; linux-kernel@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org
> Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> Hi
> 
> > -Original Message-
> > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> > ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> > Sent: Wednesday, December 23, 2015 2:21 AM
> > To: Ramneek Mehresh ; linux-
> > ker...@vger.kernel.org
> > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > u...@vger.kernel.org
> > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> >
> >
> > Hi,
> >
> > Ramneek Mehresh  writes:
> > >> -Original Message-
> > >> From: Felipe Balbi [mailto:ba...@ti.com]
> > >> Sent: Saturday, October 10, 2015 3:04 AM
> > >> To: Mehresh Ramneek-B31383 ;
> linux-
> > >> ker...@vger.kernel.org
> > >> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > >> u...@vger.kernel.org; Mehresh Ramneek-B31383
> > >> 
> > >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> > >>
> > >> Felipe Balbi  writes:
> > >>
> > >> > Hi,
> > >> >
> > >> > Ramneek Mehresh  writes:
> > >> >> Add support for otg for all freescale socs having internal usb phy.
> > >> >>
> > >> >> Ramneek Mehresh (7):
> > >> >>   usb:fsl:otg: Make fsl otg driver as tristate
> > >> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> > >> >>   usb:fsl:otg: Add support to add/remove usb host driver
> > >> >>   usb:fsl:otg: Signal host drv when host is otg
> > >> >>   usb:fsl:otg: Modify otg_event to start host drv
> > >> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> > >> >>   usb:fsl:otg: Add host-gadget drv sync delay
> > >> >
> > >> > Unless Alan's okay with the host side changes, I can't accept any
> > >> > of these. However, I must say some of the flags you add here
> > >> > already exist in some way, shape or form. For example, look at
> > is_b_host flag.
> > >>
> > >
> > > Could you please be more specific...which flag you think that I
> > >should remove/I'm re-defining. The flags I'm defining are:
> > >
> > > have_hcd : defined in fsl specific structure for fsl specific
> > > use-case
> > >
> > > had_hcd: defined in fsl specific structure for fsl specific use-case
> > >
> > > is_otg : defined in include/linux/usb.h
> > >
> > > Are you suggesting using otg_port or is_b_host instead of is_otg?
> > >
> > > As I understand, is_b_host is specifically to check if an otg B
> > > device is in host mode...correct?  I just need a flag to check if a
> > > controller is capable of otg operations? That's why defined "is_otg"
> > > flag. Please suggest.
> >
> > no, I don't know why I made that comment. You could use otg_port, but
> > that wouldn't look very clean. Can you resend with Alan's ack, then
> > I'll move this series into testing/next.
> >
> > --
> > balbi
> 
> Can you directly put the change_hcd_work in its phy driver(phy-fsl-usb.c)?
> Then add/remove hcd will not through ehci_fsl_drv_suspend/resume, With
> this, you can make it work without a new flag "is_otg".
> 
change_hcd_work() changes host controller mode, and hence, should be in host 
controller
driver. To move this to phy driver (just to avoid usage of a single flag) won't 
be a good idea.
In this case, I'll also have to move some host controller specific flags to phy 
drv which won't be correct.

> Li Jun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-23 Thread Jun Li 


> -Original Message-
> From: Ramneek Mehresh [mailto:ramneek.mehr...@freescale.com]
> Sent: Wednesday, December 23, 2015 8:20 PM
> To: Jun Li <jun...@nxp.com>; Felipe Balbi <ba...@ti.com>; linux-
> ker...@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org
> Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> 
> 
> > -Original Message-
> > From: Jun Li [mailto:jun...@nxp.com]
> > Sent: Wednesday, December 23, 2015 10:36 AM
> > To: Felipe Balbi <ba...@ti.com>; Mehresh Ramneek-B31383
> > <ramneek.mehr...@freescale.com>; linux-kernel@vger.kernel.org
> > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > u...@vger.kernel.org
> > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> >
> > Hi
> >
> > > -Original Message-
> > > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> > > ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> > > Sent: Wednesday, December 23, 2015 2:21 AM
> > > To: Ramneek Mehresh <ramneek.mehr...@freescale.com>; linux-
> > > ker...@vger.kernel.org
> > > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > > u...@vger.kernel.org
> > > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> > >
> > >
> > > Hi,
> > >
> > > Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
> > > >> -Original Message-
> > > >> From: Felipe Balbi [mailto:ba...@ti.com]
> > > >> Sent: Saturday, October 10, 2015 3:04 AM
> > > >> To: Mehresh Ramneek-B31383 <ramneek.mehr...@freescale.com>;
> > linux-
> > > >> ker...@vger.kernel.org
> > > >> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > > >> u...@vger.kernel.org; Mehresh Ramneek-B31383
> > > >> <ramneek.mehr...@freescale.com>
> > > >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> > > >>
> > > >> Felipe Balbi <ba...@ti.com> writes:
> > > >>
> > > >> > Hi,
> > > >> >
> > > >> > Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
> > > >> >> Add support for otg for all freescale socs having internal usb
> phy.
> > > >> >>
> > > >> >> Ramneek Mehresh (7):
> > > >> >>   usb:fsl:otg: Make fsl otg driver as tristate
> > > >> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> > > >> >>   usb:fsl:otg: Add support to add/remove usb host driver
> > > >> >>   usb:fsl:otg: Signal host drv when host is otg
> > > >> >>   usb:fsl:otg: Modify otg_event to start host drv
> > > >> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> > > >> >>   usb:fsl:otg: Add host-gadget drv sync delay
> > > >> >
> > > >> > Unless Alan's okay with the host side changes, I can't accept
> > > >> > any of these. However, I must say some of the flags you add
> > > >> > here already exist in some way, shape or form. For example,
> > > >> > look at
> > > is_b_host flag.
> > > >>
> > > >
> > > > Could you please be more specific...which flag you think that I
> > > >should remove/I'm re-defining. The flags I'm defining are:
> > > >
> > > > have_hcd : defined in fsl specific structure for fsl specific
> > > > use-case
> > > >
> > > > had_hcd: defined in fsl specific structure for fsl specific
> > > > use-case
> > > >
> > > > is_otg : defined in include/linux/usb.h
> > > >
> > > > Are you suggesting using otg_port or is_b_host instead of is_otg?
> > > >
> > > > As I understand, is_b_host is specifically to check if an otg B
> > > > device is in host mode...correct?  I just need a flag to check if
> > > > a controller is capable of otg operations? That's why defined
> "is_otg"
> > > > flag. Please suggest.
> > >
> > > no, I don't know why I made that comment. You could use otg_port,
> > > but that wouldn't look very clean. Can you resend with Alan's ack,
> > > then I'll move this series into testing/next.
> > >
> > > --
> > > balbi
> >
> > Can you di

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-23 Thread Ramneek Mehresh 


> -Original Message-
> From: Jun Li [mailto:jun...@nxp.com]
> Sent: Wednesday, December 23, 2015 10:02 PM
> To: Mehresh Ramneek-B31383 <ramneek.mehr...@freescale.com>; Felipe
> Balbi <ba...@ti.com>; linux-kernel@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org
> Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> 
> 
> > -Original Message-
> > From: Ramneek Mehresh [mailto:ramneek.mehr...@freescale.com]
> > Sent: Wednesday, December 23, 2015 8:20 PM
> > To: Jun Li <jun...@nxp.com>; Felipe Balbi <ba...@ti.com>; linux-
> > ker...@vger.kernel.org
> > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > u...@vger.kernel.org
> > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> >
> >
> >
> > > -Original Message-
> > > From: Jun Li [mailto:jun...@nxp.com]
> > > Sent: Wednesday, December 23, 2015 10:36 AM
> > > To: Felipe Balbi <ba...@ti.com>; Mehresh Ramneek-B31383
> > > <ramneek.mehr...@freescale.com>; linux-kernel@vger.kernel.org
> > > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > > u...@vger.kernel.org
> > > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> > >
> > > Hi
> > >
> > > > -Original Message-
> > > > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> > > > ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> > > > Sent: Wednesday, December 23, 2015 2:21 AM
> > > > To: Ramneek Mehresh <ramneek.mehr...@freescale.com>; linux-
> > > > ker...@vger.kernel.org
> > > > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > > > u...@vger.kernel.org
> > > > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> > > >
> > > >
> > > > Hi,
> > > >
> > > > Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
> > > > >> -Original Message-
> > > > >> From: Felipe Balbi [mailto:ba...@ti.com]
> > > > >> Sent: Saturday, October 10, 2015 3:04 AM
> > > > >> To: Mehresh Ramneek-B31383
> <ramneek.mehr...@freescale.com>;
> > > linux-
> > > > >> ker...@vger.kernel.org
> > > > >> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;
> > > > >> linux- u...@vger.kernel.org; Mehresh Ramneek-B31383
> > > > >> <ramneek.mehr...@freescale.com>
> > > > >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> > > > >>
> > > > >> Felipe Balbi <ba...@ti.com> writes:
> > > > >>
> > > > >> > Hi,
> > > > >> >
> > > > >> > Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
> > > > >> >> Add support for otg for all freescale socs having internal
> > > > >> >> usb
> > phy.
> > > > >> >>
> > > > >> >> Ramneek Mehresh (7):
> > > > >> >>   usb:fsl:otg: Make fsl otg driver as tristate
> > > > >> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> > > > >> >>   usb:fsl:otg: Add support to add/remove usb host driver
> > > > >> >>   usb:fsl:otg: Signal host drv when host is otg
> > > > >> >>   usb:fsl:otg: Modify otg_event to start host drv
> > > > >> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> > > > >> >>   usb:fsl:otg: Add host-gadget drv sync delay
> > > > >> >
> > > > >> > Unless Alan's okay with the host side changes, I can't accept
> > > > >> > any of these. However, I must say some of the flags you add
> > > > >> > here already exist in some way, shape or form. For example,
> > > > >> > look at
> > > > is_b_host flag.
> > > > >>
> > > > >
> > > > > Could you please be more specific...which flag you think that I
> > > > >should remove/I'm re-defining. The flags I'm defining are:
> > > > >
> > > > > have_hcd : defined in fsl specific structure for fsl specific
> > > > > use-case
> > > > >
> > > > > had_hcd: defined in fsl specific structure for fsl specific
>

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-23 Thread Ramneek Mehresh 


> -Original Message-
> From: Jun Li [mailto:jun...@nxp.com]
> Sent: Wednesday, December 23, 2015 10:36 AM
> To: Felipe Balbi <ba...@ti.com>; Mehresh Ramneek-B31383
> <ramneek.mehr...@freescale.com>; linux-kernel@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org
> Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> Hi
> 
> > -Original Message-
> > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> > ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> > Sent: Wednesday, December 23, 2015 2:21 AM
> > To: Ramneek Mehresh <ramneek.mehr...@freescale.com>; linux-
> > ker...@vger.kernel.org
> > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > u...@vger.kernel.org
> > Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> >
> >
> > Hi,
> >
> > Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
> > >> -Original Message-
> > >> From: Felipe Balbi [mailto:ba...@ti.com]
> > >> Sent: Saturday, October 10, 2015 3:04 AM
> > >> To: Mehresh Ramneek-B31383 <ramneek.mehr...@freescale.com>;
> linux-
> > >> ker...@vger.kernel.org
> > >> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> > >> u...@vger.kernel.org; Mehresh Ramneek-B31383
> > >> <ramneek.mehr...@freescale.com>
> > >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> > >>
> > >> Felipe Balbi <ba...@ti.com> writes:
> > >>
> > >> > Hi,
> > >> >
> > >> > Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
> > >> >> Add support for otg for all freescale socs having internal usb phy.
> > >> >>
> > >> >> Ramneek Mehresh (7):
> > >> >>   usb:fsl:otg: Make fsl otg driver as tristate
> > >> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> > >> >>   usb:fsl:otg: Add support to add/remove usb host driver
> > >> >>   usb:fsl:otg: Signal host drv when host is otg
> > >> >>   usb:fsl:otg: Modify otg_event to start host drv
> > >> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> > >> >>   usb:fsl:otg: Add host-gadget drv sync delay
> > >> >
> > >> > Unless Alan's okay with the host side changes, I can't accept any
> > >> > of these. However, I must say some of the flags you add here
> > >> > already exist in some way, shape or form. For example, look at
> > is_b_host flag.
> > >>
> > >
> > > Could you please be more specific...which flag you think that I
> > >should remove/I'm re-defining. The flags I'm defining are:
> > >
> > > have_hcd : defined in fsl specific structure for fsl specific
> > > use-case
> > >
> > > had_hcd: defined in fsl specific structure for fsl specific use-case
> > >
> > > is_otg : defined in include/linux/usb.h
> > >
> > > Are you suggesting using otg_port or is_b_host instead of is_otg?
> > >
> > > As I understand, is_b_host is specifically to check if an otg B
> > > device is in host mode...correct?  I just need a flag to check if a
> > > controller is capable of otg operations? That's why defined "is_otg"
> > > flag. Please suggest.
> >
> > no, I don't know why I made that comment. You could use otg_port, but
> > that wouldn't look very clean. Can you resend with Alan's ack, then
> > I'll move this series into testing/next.
> >
> > --
> > balbi
> 
> Can you directly put the change_hcd_work in its phy driver(phy-fsl-usb.c)?
> Then add/remove hcd will not through ehci_fsl_drv_suspend/resume, With
> this, you can make it work without a new flag "is_otg".
> 
change_hcd_work() changes host controller mode, and hence, should be in host 
controller
driver. To move this to phy driver (just to avoid usage of a single flag) won't 
be a good idea.
In this case, I'll also have to move some host controller specific flags to phy 
drv which won't be correct.

> Li Jun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-22 Thread Jun Li 
Hi

> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> Sent: Wednesday, December 23, 2015 2:21 AM
> To: Ramneek Mehresh ; linux-
> ker...@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org
> Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> 
> Hi,
> 
> Ramneek Mehresh  writes:
> >> -Original Message-
> >> From: Felipe Balbi [mailto:ba...@ti.com]
> >> Sent: Saturday, October 10, 2015 3:04 AM
> >> To: Mehresh Ramneek-B31383 ; linux-
> >> ker...@vger.kernel.org
> >> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> >> u...@vger.kernel.org; Mehresh Ramneek-B31383
> >> 
> >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> >>
> >> Felipe Balbi  writes:
> >>
> >> > Hi,
> >> >
> >> > Ramneek Mehresh  writes:
> >> >> Add support for otg for all freescale socs having internal usb phy.
> >> >>
> >> >> Ramneek Mehresh (7):
> >> >>   usb:fsl:otg: Make fsl otg driver as tristate
> >> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> >> >>   usb:fsl:otg: Add support to add/remove usb host driver
> >> >>   usb:fsl:otg: Signal host drv when host is otg
> >> >>   usb:fsl:otg: Modify otg_event to start host drv
> >> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> >> >>   usb:fsl:otg: Add host-gadget drv sync delay
> >> >
> >> > Unless Alan's okay with the host side changes, I can't accept any
> >> > of these. However, I must say some of the flags you add here
> >> > already exist in some way, shape or form. For example, look at
> is_b_host flag.
> >>
> >
> > Could you please be more specific...which flag you think that I should
> >remove/I'm re-defining. The flags I'm defining are:
> >
> > have_hcd : defined in fsl specific structure for fsl specific use-case
> >
> > had_hcd: defined in fsl specific structure for fsl specific use-case
> >
> > is_otg : defined in include/linux/usb.h
> >
> > Are you suggesting using otg_port or is_b_host instead of is_otg?
> >
> > As I understand, is_b_host is specifically to check if an otg B device
> > is in host mode...correct?  I just need a flag to check if a
> > controller is capable of otg operations? That's why defined "is_otg"
> > flag. Please suggest.
> 
> no, I don't know why I made that comment. You could use otg_port, but that
> wouldn't look very clean. Can you resend with Alan's ack, then I'll move
> this series into testing/next.
> 
> --
> balbi

Can you directly put the change_hcd_work in its phy driver(phy-fsl-usb.c)?
Then add/remove hcd will not through ehci_fsl_drv_suspend/resume,
With this, you can make it work without a new flag "is_otg".

Li Jun 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-22 Thread Felipe Balbi 

Hi,

Ramneek Mehresh  writes:
>> -Original Message-
>> From: Felipe Balbi [mailto:ba...@ti.com]
>> Sent: Saturday, October 10, 2015 3:04 AM
>> To: Mehresh Ramneek-B31383 ; linux-
>> ker...@vger.kernel.org
>> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
>> u...@vger.kernel.org; Mehresh Ramneek-B31383
>> 
>> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
>> 
>> Felipe Balbi  writes:
>> 
>> > Hi,
>> >
>> > Ramneek Mehresh  writes:
>> >> Add support for otg for all freescale socs having internal usb phy.
>> >>
>> >> Ramneek Mehresh (7):
>> >>   usb:fsl:otg: Make fsl otg driver as tristate
>> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>> >>   usb:fsl:otg: Add support to add/remove usb host driver
>> >>   usb:fsl:otg: Signal host drv when host is otg
>> >>   usb:fsl:otg: Modify otg_event to start host drv
>> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>> >>   usb:fsl:otg: Add host-gadget drv sync delay
>> >
>> > Unless Alan's okay with the host side changes, I can't accept any of
>> > these. However, I must say some of the flags you add here already
>> > exist in some way, shape or form. For example, look at is_b_host flag.
>>
>
> Could you please be more specific...which flag you think that I should
>remove/I'm re-defining. The flags I'm defining are:
>
> have_hcd : defined in fsl specific structure for fsl specific use-case
>
> had_hcd: defined in fsl specific structure for fsl specific use-case
>
> is_otg : defined in include/linux/usb.h
>
> Are you suggesting using otg_port or is_b_host instead of is_otg?
>
> As I understand, is_b_host is specifically to check if an otg B device
> is in host mode...correct?  I just need a flag to check if a
> controller is capable of otg operations? That's why defined "is_otg"
> flag. Please suggest.

no, I don't know why I made that comment. You could use otg_port, but
that wouldn't look very clean. Can you resend with Alan's ack, then I'll
move this series into testing/next.

-- 
balbi


signature.asc
Description: PGP signature

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-22 Thread Felipe Balbi 

Hi,

Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
>> -Original Message-
>> From: Felipe Balbi [mailto:ba...@ti.com]
>> Sent: Saturday, October 10, 2015 3:04 AM
>> To: Mehresh Ramneek-B31383 <ramneek.mehr...@freescale.com>; linux-
>> ker...@vger.kernel.org
>> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
>> u...@vger.kernel.org; Mehresh Ramneek-B31383
>> <ramneek.mehr...@freescale.com>
>> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
>> 
>> Felipe Balbi <ba...@ti.com> writes:
>> 
>> > Hi,
>> >
>> > Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
>> >> Add support for otg for all freescale socs having internal usb phy.
>> >>
>> >> Ramneek Mehresh (7):
>> >>   usb:fsl:otg: Make fsl otg driver as tristate
>> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>> >>   usb:fsl:otg: Add support to add/remove usb host driver
>> >>   usb:fsl:otg: Signal host drv when host is otg
>> >>   usb:fsl:otg: Modify otg_event to start host drv
>> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>> >>   usb:fsl:otg: Add host-gadget drv sync delay
>> >
>> > Unless Alan's okay with the host side changes, I can't accept any of
>> > these. However, I must say some of the flags you add here already
>> > exist in some way, shape or form. For example, look at is_b_host flag.
>>
>
> Could you please be more specific...which flag you think that I should
>remove/I'm re-defining. The flags I'm defining are:
>
> have_hcd : defined in fsl specific structure for fsl specific use-case
>
> had_hcd: defined in fsl specific structure for fsl specific use-case
>
> is_otg : defined in include/linux/usb.h
>
> Are you suggesting using otg_port or is_b_host instead of is_otg?
>
> As I understand, is_b_host is specifically to check if an otg B device
> is in host mode...correct?  I just need a flag to check if a
> controller is capable of otg operations? That's why defined "is_otg"
> flag. Please suggest.

no, I don't know why I made that comment. You could use otg_port, but
that wouldn't look very clean. Can you resend with Alan's ack, then I'll
move this series into testing/next.

-- 
balbi


signature.asc
Description: PGP signature

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-22 Thread Jun Li 
Hi

> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Felipe Balbi
> Sent: Wednesday, December 23, 2015 2:21 AM
> To: Ramneek Mehresh <ramneek.mehr...@freescale.com>; linux-
> ker...@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org
> Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> 
> Hi,
> 
> Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
> >> -Original Message-
> >> From: Felipe Balbi [mailto:ba...@ti.com]
> >> Sent: Saturday, October 10, 2015 3:04 AM
> >> To: Mehresh Ramneek-B31383 <ramneek.mehr...@freescale.com>; linux-
> >> ker...@vger.kernel.org
> >> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> >> u...@vger.kernel.org; Mehresh Ramneek-B31383
> >> <ramneek.mehr...@freescale.com>
> >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> >>
> >> Felipe Balbi <ba...@ti.com> writes:
> >>
> >> > Hi,
> >> >
> >> > Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
> >> >> Add support for otg for all freescale socs having internal usb phy.
> >> >>
> >> >> Ramneek Mehresh (7):
> >> >>   usb:fsl:otg: Make fsl otg driver as tristate
> >> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> >> >>   usb:fsl:otg: Add support to add/remove usb host driver
> >> >>   usb:fsl:otg: Signal host drv when host is otg
> >> >>   usb:fsl:otg: Modify otg_event to start host drv
> >> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> >> >>   usb:fsl:otg: Add host-gadget drv sync delay
> >> >
> >> > Unless Alan's okay with the host side changes, I can't accept any
> >> > of these. However, I must say some of the flags you add here
> >> > already exist in some way, shape or form. For example, look at
> is_b_host flag.
> >>
> >
> > Could you please be more specific...which flag you think that I should
> >remove/I'm re-defining. The flags I'm defining are:
> >
> > have_hcd : defined in fsl specific structure for fsl specific use-case
> >
> > had_hcd: defined in fsl specific structure for fsl specific use-case
> >
> > is_otg : defined in include/linux/usb.h
> >
> > Are you suggesting using otg_port or is_b_host instead of is_otg?
> >
> > As I understand, is_b_host is specifically to check if an otg B device
> > is in host mode...correct?  I just need a flag to check if a
> > controller is capable of otg operations? That's why defined "is_otg"
> > flag. Please suggest.
> 
> no, I don't know why I made that comment. You could use otg_port, but that
> wouldn't look very clean. Can you resend with Alan's ack, then I'll move
> this series into testing/next.
> 
> --
> balbi

Can you directly put the change_hcd_work in its phy driver(phy-fsl-usb.c)?
Then add/remove hcd will not through ehci_fsl_drv_suspend/resume,
With this, you can make it work without a new flag "is_otg".

Li Jun 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-19 Thread Ramneek Mehresh 


> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Saturday, October 10, 2015 3:04 AM
> To: Mehresh Ramneek-B31383 ; linux-
> ker...@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org; Mehresh Ramneek-B31383
> 
> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> Felipe Balbi  writes:
> 
> > Hi,
> >
> > Ramneek Mehresh  writes:
> >> Add support for otg for all freescale socs having internal usb phy.
> >>
> >> Ramneek Mehresh (7):
> >>   usb:fsl:otg: Make fsl otg driver as tristate
> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> >>   usb:fsl:otg: Add support to add/remove usb host driver
> >>   usb:fsl:otg: Signal host drv when host is otg
> >>   usb:fsl:otg: Modify otg_event to start host drv
> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> >>   usb:fsl:otg: Add host-gadget drv sync delay
> >
> > Unless Alan's okay with the host side changes, I can't accept any of
> > these. However, I must say some of the flags you add here already
> > exist in some way, shape or form. For example, look at is_b_host flag.
> 
Could you please be more specific...which flag you think that I should 
remove/I'm
re-defining. The flags I'm defining are:
have_hcd : defined in fsl specific structure for fsl specific use-case
had_hcd: defined in fsl specific structure for fsl specific use-case
is_otg : defined in include/linux/usb.h
Are you suggesting using otg_port or is_b_host instead of is_otg?
As I understand, is_b_host is specifically to check if an otg B device is in 
host mode...correct?
I just need a flag to check if a controller is capable of otg operations? 
That's why defined
"is_otg" flag. Please suggest.

> Just saw Alan's reply, still, please have a look at these other flags which
> already exist in usbcore today.
> 
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-19 Thread Ramneek Mehresh 


> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Saturday, October 10, 2015 3:04 AM
> To: Mehresh Ramneek-B31383 <ramneek.mehr...@freescale.com>; linux-
> ker...@vger.kernel.org
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
> u...@vger.kernel.org; Mehresh Ramneek-B31383
> <ramneek.mehr...@freescale.com>
> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs
> 
> Felipe Balbi <ba...@ti.com> writes:
> 
> > Hi,
> >
> > Ramneek Mehresh <ramneek.mehr...@freescale.com> writes:
> >> Add support for otg for all freescale socs having internal usb phy.
> >>
> >> Ramneek Mehresh (7):
> >>   usb:fsl:otg: Make fsl otg driver as tristate
> >>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> >>   usb:fsl:otg: Add support to add/remove usb host driver
> >>   usb:fsl:otg: Signal host drv when host is otg
> >>   usb:fsl:otg: Modify otg_event to start host drv
> >>   usb:fsl:otg: Combine host/gadget start/resume for ID change
> >>   usb:fsl:otg: Add host-gadget drv sync delay
> >
> > Unless Alan's okay with the host side changes, I can't accept any of
> > these. However, I must say some of the flags you add here already
> > exist in some way, shape or form. For example, look at is_b_host flag.
> 
Could you please be more specific...which flag you think that I should 
remove/I'm
re-defining. The flags I'm defining are:
have_hcd : defined in fsl specific structure for fsl specific use-case
had_hcd: defined in fsl specific structure for fsl specific use-case
is_otg : defined in include/linux/usb.h
Are you suggesting using otg_port or is_b_host instead of is_otg?
As I understand, is_b_host is specifically to check if an otg B device is in 
host mode...correct?
I just need a flag to check if a controller is capable of otg operations? 
That's why defined
"is_otg" flag. Please suggest.

> Just saw Alan's reply, still, please have a look at these other flags which
> already exist in usbcore today.
> 
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-09 Thread Felipe Balbi 
Felipe Balbi  writes:

> Hi,
>
> Ramneek Mehresh  writes:
>> Add support for otg for all freescale socs having internal
>> usb phy.
>>
>> Ramneek Mehresh (7):
>>   usb:fsl:otg: Make fsl otg driver as tristate
>>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>>   usb:fsl:otg: Add support to add/remove usb host driver
>>   usb:fsl:otg: Signal host drv when host is otg
>>   usb:fsl:otg: Modify otg_event to start host drv
>>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>>   usb:fsl:otg: Add host-gadget drv sync delay
>
> Unless Alan's okay with the host side changes, I can't accept any of
> these. However, I must say some of the flags you add here already exist
> in some way, shape or form. For example, look at is_b_host flag.

Just saw Alan's reply, still, please have a look at these other flags
which already exist in usbcore today.

-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-09 Thread Felipe Balbi 

Hi,

Ramneek Mehresh  writes:
> Add support for otg for all freescale socs having internal
> usb phy.
>
> Ramneek Mehresh (7):
>   usb:fsl:otg: Make fsl otg driver as tristate
>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>   usb:fsl:otg: Add support to add/remove usb host driver
>   usb:fsl:otg: Signal host drv when host is otg
>   usb:fsl:otg: Modify otg_event to start host drv
>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>   usb:fsl:otg: Add host-gadget drv sync delay

Unless Alan's okay with the host side changes, I can't accept any of
these. However, I must say some of the flags you add here already exist
in some way, shape or form. For example, look at is_b_host flag.

-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-09 Thread Felipe Balbi 

Hi,

Ramneek Mehresh  writes:
> Add support for otg for all freescale socs having internal
> usb phy.
>
> Ramneek Mehresh (7):
>   usb:fsl:otg: Make fsl otg driver as tristate
>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>   usb:fsl:otg: Add support to add/remove usb host driver
>   usb:fsl:otg: Signal host drv when host is otg
>   usb:fsl:otg: Modify otg_event to start host drv
>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>   usb:fsl:otg: Add host-gadget drv sync delay

Unless Alan's okay with the host side changes, I can't accept any of
these. However, I must say some of the flags you add here already exist
in some way, shape or form. For example, look at is_b_host flag.

-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-09 Thread Felipe Balbi 
Felipe Balbi  writes:

> Hi,
>
> Ramneek Mehresh  writes:
>> Add support for otg for all freescale socs having internal
>> usb phy.
>>
>> Ramneek Mehresh (7):
>>   usb:fsl:otg: Make fsl otg driver as tristate
>>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>>   usb:fsl:otg: Add support to add/remove usb host driver
>>   usb:fsl:otg: Signal host drv when host is otg
>>   usb:fsl:otg: Modify otg_event to start host drv
>>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>>   usb:fsl:otg: Add host-gadget drv sync delay
>
> Unless Alan's okay with the host side changes, I can't accept any of
> these. However, I must say some of the flags you add here already exist
> in some way, shape or form. For example, look at is_b_host flag.

Just saw Alan's reply, still, please have a look at these other flags
which already exist in usbcore today.

-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-06 Thread Alan Stern 
On Mon, 5 Oct 2015, Felipe Balbi wrote:

> Ramneek Mehresh  writes:
> 
> > Add support for otg for all freescale socs having internal
> > usb phy.
> >
> > Ramneek Mehresh (7):
> >   usb:fsl:otg: Make fsl otg driver as tristate
> >   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> >   usb:fsl:otg: Add support to add/remove usb host driver
> >   usb:fsl:otg: Signal host drv when host is otg
> >   usb:fsl:otg: Modify otg_event to start host drv
> >   usb:fsl:otg: Combine host/gadget start/resume for ID change
> >   usb:fsl:otg: Add host-gadget drv sync delay
> >
> >  drivers/usb/host/ehci-fsl.c   | 73 
> > +++
> >  drivers/usb/host/ehci-fsl.h   | 16 ++
> 
> Alan, how do you want to handle these patches ? Do I get your Acked-by
> or do we split everything up ?

Patch 3/7 is the only one touching the ehci-fsl files.  Its changes 
look okay to me.

Acked-by: Alan Stern 

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-06 Thread Alan Stern 
On Mon, 5 Oct 2015, Felipe Balbi wrote:

> Ramneek Mehresh  writes:
> 
> > Add support for otg for all freescale socs having internal
> > usb phy.
> >
> > Ramneek Mehresh (7):
> >   usb:fsl:otg: Make fsl otg driver as tristate
> >   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> >   usb:fsl:otg: Add support to add/remove usb host driver
> >   usb:fsl:otg: Signal host drv when host is otg
> >   usb:fsl:otg: Modify otg_event to start host drv
> >   usb:fsl:otg: Combine host/gadget start/resume for ID change
> >   usb:fsl:otg: Add host-gadget drv sync delay
> >
> >  drivers/usb/host/ehci-fsl.c   | 73 
> > +++
> >  drivers/usb/host/ehci-fsl.h   | 16 ++
> 
> Alan, how do you want to handle these patches ? Do I get your Acked-by
> or do we split everything up ?

Patch 3/7 is the only one touching the ehci-fsl files.  Its changes 
look okay to me.

Acked-by: Alan Stern 

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-05 Thread Fabio Estevam 
On Thu, Aug 27, 2015 at 1:43 PM, Ramneek Mehresh
 wrote:
> Add support for otg for all freescale socs having internal
> usb phy.
>
> Ramneek Mehresh (7):
>   usb:fsl:otg: Make fsl otg driver as tristate
>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>   usb:fsl:otg: Add support to add/remove usb host driver
>   usb:fsl:otg: Signal host drv when host is otg
>   usb:fsl:otg: Modify otg_event to start host drv
>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>   usb:fsl:otg: Add host-gadget drv sync delay
>
>  drivers/usb/host/ehci-fsl.c   | 73 
> +++
>  drivers/usb/host/ehci-fsl.h   | 16 ++
>  drivers/usb/phy/Kconfig   |  2 +-
>  drivers/usb/phy/phy-fsl-usb.c | 58 +-
>  drivers/usb/phy/phy-fsl-usb.h |  7 +
>  include/linux/usb.h   |  1 +
>  6 files changed, 122 insertions(+), 35 deletions(-)

Isn't this all Chipidea IP? If so, why don't you use the existing
chipidea driver instead?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-05 Thread Alan Stern 
On Mon, 5 Oct 2015, Felipe Balbi wrote:

> Ramneek Mehresh  writes:
> 
> > Add support for otg for all freescale socs having internal
> > usb phy.
> >
> > Ramneek Mehresh (7):
> >   usb:fsl:otg: Make fsl otg driver as tristate
> >   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> >   usb:fsl:otg: Add support to add/remove usb host driver
> >   usb:fsl:otg: Signal host drv when host is otg
> >   usb:fsl:otg: Modify otg_event to start host drv
> >   usb:fsl:otg: Combine host/gadget start/resume for ID change
> >   usb:fsl:otg: Add host-gadget drv sync delay
> >
> >  drivers/usb/host/ehci-fsl.c   | 73 
> > +++
> >  drivers/usb/host/ehci-fsl.h   | 16 ++
> 
> Alan, how do you want to handle these patches ? Do I get your Acked-by
> or do we split everything up ?

I'll send an Acked-by after looking carefully at the parts that affect 
ehci-fsl.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-05 Thread Felipe Balbi 
Ramneek Mehresh  writes:

> Add support for otg for all freescale socs having internal
> usb phy.
>
> Ramneek Mehresh (7):
>   usb:fsl:otg: Make fsl otg driver as tristate
>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>   usb:fsl:otg: Add support to add/remove usb host driver
>   usb:fsl:otg: Signal host drv when host is otg
>   usb:fsl:otg: Modify otg_event to start host drv
>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>   usb:fsl:otg: Add host-gadget drv sync delay
>
>  drivers/usb/host/ehci-fsl.c   | 73 
> +++
>  drivers/usb/host/ehci-fsl.h   | 16 ++

Alan, how do you want to handle these patches ? Do I get your Acked-by
or do we split everything up ?

-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-05 Thread Alan Stern 
On Mon, 5 Oct 2015, Felipe Balbi wrote:

> Ramneek Mehresh  writes:
> 
> > Add support for otg for all freescale socs having internal
> > usb phy.
> >
> > Ramneek Mehresh (7):
> >   usb:fsl:otg: Make fsl otg driver as tristate
> >   usb:fsl:otg: Add controller version based ULPI and UTMI phy
> >   usb:fsl:otg: Add support to add/remove usb host driver
> >   usb:fsl:otg: Signal host drv when host is otg
> >   usb:fsl:otg: Modify otg_event to start host drv
> >   usb:fsl:otg: Combine host/gadget start/resume for ID change
> >   usb:fsl:otg: Add host-gadget drv sync delay
> >
> >  drivers/usb/host/ehci-fsl.c   | 73 
> > +++
> >  drivers/usb/host/ehci-fsl.h   | 16 ++
> 
> Alan, how do you want to handle these patches ? Do I get your Acked-by
> or do we split everything up ?

I'll send an Acked-by after looking carefully at the parts that affect 
ehci-fsl.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-05 Thread Felipe Balbi 
Ramneek Mehresh  writes:

> Add support for otg for all freescale socs having internal
> usb phy.
>
> Ramneek Mehresh (7):
>   usb:fsl:otg: Make fsl otg driver as tristate
>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>   usb:fsl:otg: Add support to add/remove usb host driver
>   usb:fsl:otg: Signal host drv when host is otg
>   usb:fsl:otg: Modify otg_event to start host drv
>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>   usb:fsl:otg: Add host-gadget drv sync delay
>
>  drivers/usb/host/ehci-fsl.c   | 73 
> +++
>  drivers/usb/host/ehci-fsl.h   | 16 ++

Alan, how do you want to handle these patches ? Do I get your Acked-by
or do we split everything up ?

-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-10-05 Thread Fabio Estevam 
On Thu, Aug 27, 2015 at 1:43 PM, Ramneek Mehresh
 wrote:
> Add support for otg for all freescale socs having internal
> usb phy.
>
> Ramneek Mehresh (7):
>   usb:fsl:otg: Make fsl otg driver as tristate
>   usb:fsl:otg: Add controller version based ULPI and UTMI phy
>   usb:fsl:otg: Add support to add/remove usb host driver
>   usb:fsl:otg: Signal host drv when host is otg
>   usb:fsl:otg: Modify otg_event to start host drv
>   usb:fsl:otg: Combine host/gadget start/resume for ID change
>   usb:fsl:otg: Add host-gadget drv sync delay
>
>  drivers/usb/host/ehci-fsl.c   | 73 
> +++
>  drivers/usb/host/ehci-fsl.h   | 16 ++
>  drivers/usb/phy/Kconfig   |  2 +-
>  drivers/usb/phy/phy-fsl-usb.c | 58 +-
>  drivers/usb/phy/phy-fsl-usb.h |  7 +
>  include/linux/usb.h   |  1 +
>  6 files changed, 122 insertions(+), 35 deletions(-)

Isn't this all Chipidea IP? If so, why don't you use the existing
chipidea driver instead?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/