RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

[Laurentiu Tudor]

Hi Greg,

> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Saturday, June 03, 2017 11:41 AM
> 
> On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tu...@nxp.com wrote:
> > From: Laurentiu Tudor 
> >
> > Several macros didn't had macro params enclosed in parens. Fix them to
> > avoid precedence issues.
> >
> > Found with checkpatch.pl who was issuing this
> > message:
> >   "Macro argument 'id' may be better as '(id)'
> >to avoid precedence issues"
> 
> Why are you line-wrapping at such a small number?  Please use 72 columns like
> git asks you to...

I'll rewrap the commit message in the next spin.

---
Thanks & Best Regards, Laurentiu

RE: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

[Laurentiu Tudor]

Hi Greg,

> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Saturday, June 03, 2017 11:41 AM
> 
> On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tu...@nxp.com wrote:
> > From: Laurentiu Tudor 
> >
> > Several macros didn't had macro params enclosed in parens. Fix them to
> > avoid precedence issues.
> >
> > Found with checkpatch.pl who was issuing this
> > message:
> >   "Macro argument 'id' may be better as '(id)'
> >to avoid precedence issues"
> 
> Why are you line-wrapping at such a small number?  Please use 72 columns like
> git asks you to...

I'll rewrap the commit message in the next spin.

---
Thanks & Best Regards, Laurentiu

Re: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

[Greg KH]

On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tu...@nxp.com wrote:
> From: Laurentiu Tudor 
> 
> Several macros didn't had macro params enclosed
> in parens. Fix them to avoid precedence issues.
> 
> Found with checkpatch.pl who was issuing this
> message:
>   "Macro argument 'id' may be better as '(id)'
>to avoid precedence issues"

Why are you line-wrapping at such a small number?  Please use 72 columns
like git asks you to...

thanks,

greg k-h

Re: [PATCH 01/10] staging: fsl-mc: enclose macro params in parens

[Greg KH]

On Wed, May 31, 2017 at 01:58:43PM +0300, laurentiu.tu...@nxp.com wrote:
> From: Laurentiu Tudor 
> 
> Several macros didn't had macro params enclosed
> in parens. Fix them to avoid precedence issues.
> 
> Found with checkpatch.pl who was issuing this
> message:
>   "Macro argument 'id' may be better as '(id)'
>to avoid precedence issues"

Why are you line-wrapping at such a small number?  Please use 72 columns
like git asks you to...

thanks,

greg k-h