RE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for EHCI drv
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Friday, May 08, 2015 7:56 PM > To: Mehresh Ramneek-B31383 > Cc: linux-kernel@vger.kernel.org; ba...@ti.com; linux-...@vger.kernel.org; > gre...@linuxfoundation.org > Subject: RE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for > EHCI drv > > On Fri, 8 May 2015, Ramneek Mehresh wrote: > > > > On Thu, 7 May 2015, Ramneek Mehresh wrote: > > > > > > > Make use of ehci_driver_overrides structure for ehci-fsl driver > > > > > > > > Signed-off-by: Ramneek Mehresh > > > > > > > You need to change a lot more than this. See commit a76dd463c58e > (USB: > > > EHCI: make ehci-orion a separate driver) as an example of what is > > > needed. In the end, ehci-fsl.ko should be a new driver module, not > > > compiled into ehci- hcd.ko. > > > > > I can definitely make this change, but this patch set is about OTG > > functionality fix for all FSL QorIQ socs. Changes you are asking are > > for FSL Host driver. For that I can float separate patch/patch set. > > Hence, I would request you to please accept the Patch series in conext > > of OTG functionality fix > > Accept which patch series? You have posted several different versions (and > you failed to put the version numbers in the email Subject: > lines, so I can't tell which patches belong to which version!). > > I am not going to accept something that does a partial job of converting ehci- > fsl into a separate module. Either do the entire conversion first, as a > separate patch that is prerequisite to the OTG fix, or else fix the OTG stuff > in > a way that doesn't require ehci-fsl to be a separate module. > Ok, then let me first fix USB host driver as per expectation... I'll then re-send OTG patch set over that...I don't want to intermingle these two separate functionalities. Thanks. > Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for EHCI drv
On Fri, 8 May 2015, Ramneek Mehresh wrote: > > On Thu, 7 May 2015, Ramneek Mehresh wrote: > > > > > Make use of ehci_driver_overrides structure for ehci-fsl driver > > > > > > Signed-off-by: Ramneek Mehresh > > > > You need to change a lot more than this. See commit a76dd463c58e (USB: > > EHCI: make ehci-orion a separate driver) as an example of what is needed. > > In > > the end, ehci-fsl.ko should be a new driver module, not compiled into ehci- > > hcd.ko. > > > I can definitely make this change, but this patch set is about OTG > functionality > fix for all FSL QorIQ socs. Changes you are asking are for FSL Host driver. > For that > I can float separate patch/patch set. Hence, I would request you to please > accept the > Patch series in conext of OTG functionality fix Accept which patch series? You have posted several different versions (and you failed to put the version numbers in the email Subject: lines, so I can't tell which patches belong to which version!). I am not going to accept something that does a partial job of converting ehci-fsl into a separate module. Either do the entire conversion first, as a separate patch that is prerequisite to the OTG fix, or else fix the OTG stuff in a way that doesn't require ehci-fsl to be a separate module. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for EHCI drv
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Thursday, May 07, 2015 8:16 PM > To: Mehresh Ramneek-B31383 > Cc: linux-kernel@vger.kernel.org; ba...@ti.com; linux-...@vger.kernel.org; > gre...@linuxfoundation.org > Subject: Re: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for > EHCI drv > > On Thu, 7 May 2015, Ramneek Mehresh wrote: > > > Make use of ehci_driver_overrides structure for ehci-fsl driver > > > > Signed-off-by: Ramneek Mehresh > > You need to change a lot more than this. See commit a76dd463c58e (USB: > EHCI: make ehci-orion a separate driver) as an example of what is needed. In > the end, ehci-fsl.ko should be a new driver module, not compiled into ehci- > hcd.ko. > I can definitely make this change, but this patch set is about OTG functionality fix for all FSL QorIQ socs. Changes you are asking are for FSL Host driver. For that I can float separate patch/patch set. Hence, I would request you to please accept the Patch series in conext of OTG functionality fix > > + ehci_init_driver(driver, &ehci_fsl_overrides); > > + driver->product_desc = "Freescale On-Chip EHCI Host Controller"; > > + driver->start = ehci_run; > > + driver->start_port_reset = ehci_start_port_reset; > > Why do you want to override driver->start? The default value for this field > is > already set to ehci_run. > Will correct this > Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for EHCI drv
On Thu, 7 May 2015, Ramneek Mehresh wrote: > Make use of ehci_driver_overrides structure for ehci-fsl > driver > > Signed-off-by: Ramneek Mehresh You need to change a lot more than this. See commit a76dd463c58e (USB: EHCI: make ehci-orion a separate driver) as an example of what is needed. In the end, ehci-fsl.ko should be a new driver module, not compiled into ehci-hcd.ko. > + ehci_init_driver(driver, &ehci_fsl_overrides); > + driver->product_desc = "Freescale On-Chip EHCI Host Controller"; > + driver->start = ehci_run; > + driver->start_port_reset = ehci_start_port_reset; Why do you want to override driver->start? The default value for this field is already set to ehci_run. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
