Re: [PATCH 02/26] pstore: add flags
On Tue, Oct 23, 2012 at 7:57 PM, Luck, Tony wrote: >> I wonder if the default should be to not show headers, and to add this >> flag to the backends that want the pstore-added header. I think the >> more common case going forward will to be without headers since >> backends should arguably storing metadata themselves. > > Perhaps just add the headings when pstore breaks a dump into > pieces because of a back-end size limitation. I.e. if there is only > one piece, then no headings. If there are two or more, include > a heading to aid with putting the pieces together later. > But how do you determine the kmsg data size without doing a kmsg_dump_get_buffer beforehand? Thanks, Dragos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 02/26] pstore: add flags
On Tue, Oct 23, 2012 at 7:57 PM, Luck, Tony tony.l...@intel.com wrote: I wonder if the default should be to not show headers, and to add this flag to the backends that want the pstore-added header. I think the more common case going forward will to be without headers since backends should arguably storing metadata themselves. Perhaps just add the headings when pstore breaks a dump into pieces because of a back-end size limitation. I.e. if there is only one piece, then no headings. If there are two or more, include a heading to aid with putting the pieces together later. But how do you determine the kmsg data size without doing a kmsg_dump_get_buffer beforehand? Thanks, Dragos -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 02/26] pstore: add flags
> I wonder if the default should be to not show headers, and to add this > flag to the backends that want the pstore-added header. I think the > more common case going forward will to be without headers since > backends should arguably storing metadata themselves. Perhaps just add the headings when pstore breaks a dump into pieces because of a back-end size limitation. I.e. if there is only one piece, then no headings. If there are two or more, include a heading to aid with putting the pieces together later. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 02/26] pstore: add flags
On Tue, Oct 23, 2012 at 6:48 AM, Irina Tirdea wrote: > From: Adrian Hunter > > Let the back end tweak pstore behaviour. Flags added are: > > PSTORE_NO_HEADINGS > > Omit pstore heading lines from dumped data I wonder if the default should be to not show headers, and to add this flag to the backends that want the pstore-added header. I think the more common case going forward will to be without headers since backends should arguably storing metadata themselves. Thoughts? > PSTORE_MAX_KMSG_BYTES > > Default kmsg_bytes to ULONG_MAX > > Signed-off-by: Adrian Hunter > Signed-off-by: Irina Tirdea Either way, this patch looks logically fine to me. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 02/26] pstore: add flags
On Tue, Oct 23, 2012 at 6:48 AM, Irina Tirdea irina.tir...@intel.com wrote: From: Adrian Hunter adrian.hun...@intel.com Let the back end tweak pstore behaviour. Flags added are: PSTORE_NO_HEADINGS Omit pstore heading lines from dumped data I wonder if the default should be to not show headers, and to add this flag to the backends that want the pstore-added header. I think the more common case going forward will to be without headers since backends should arguably storing metadata themselves. Thoughts? PSTORE_MAX_KMSG_BYTES Default kmsg_bytes to ULONG_MAX Signed-off-by: Adrian Hunter adrian.hun...@intel.com Signed-off-by: Irina Tirdea irina.tir...@intel.com Either way, this patch looks logically fine to me. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 02/26] pstore: add flags
I wonder if the default should be to not show headers, and to add this flag to the backends that want the pstore-added header. I think the more common case going forward will to be without headers since backends should arguably storing metadata themselves. Perhaps just add the headings when pstore breaks a dump into pieces because of a back-end size limitation. I.e. if there is only one piece, then no headings. If there are two or more, include a heading to aid with putting the pieces together later. -Tony -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
