RE: [PATCH 04/21] net: thunderx: Set queue count based on number of CPUs

2016-08-11 Thread Yuval Mintz
> 81xx has only 4 CPUs, so it doesn't make sense to initialize entire Qset i.e 8
> queues by default. Made changes to queue initialization to init queues equal 
> to
> number of CPUs or
> 8 queues whichever is lesser. Also this will be applicable to VMs with VNIC VF
> attached and having less VCPUs
...
> - qcount = MAX_CMP_QUEUES_PER_QS;
> + qcount = min_t(int, MAX_CMP_QUEUES_PER_QS, num_online_cpus());

We have netif_get_num_default_rss_queues() which does this.


RE: [PATCH 04/21] net: thunderx: Set queue count based on number of CPUs

2016-08-11 Thread Yuval Mintz
> 81xx has only 4 CPUs, so it doesn't make sense to initialize entire Qset i.e 8
> queues by default. Made changes to queue initialization to init queues equal 
> to
> number of CPUs or
> 8 queues whichever is lesser. Also this will be applicable to VMs with VNIC VF
> attached and having less VCPUs
...
> - qcount = MAX_CMP_QUEUES_PER_QS;
> + qcount = min_t(int, MAX_CMP_QUEUES_PER_QS, num_online_cpus());

We have netif_get_num_default_rss_queues() which does this.


Re: [PATCH 04/21] net: thunderx: Set queue count based on number of CPUs

2016-08-11 Thread Sunil Kovvuri
> We have netif_get_num_default_rss_queues() which does this.
Thanks for pointing out the generic API.
Will make changes and resubmit.


Re: [PATCH 04/21] net: thunderx: Set queue count based on number of CPUs

2016-08-11 Thread Sunil Kovvuri
> We have netif_get_num_default_rss_queues() which does this.
Thanks for pointing out the generic API.
Will make changes and resubmit.