> -Original Message-
> From: Aisheng Dong
> Sent: Friday, March 19, 2021 12:57
> To: Clark Wang ; shawn...@kernel.org;
> s.ha...@pengutronix.de
> Cc: ker...@pengutronix.de; feste...@gmail.com; dl-linux-imx i...@nxp.com>; sumit.sem...@linaro.org; christian.koe...@amd.com;
> linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> ker...@vger.kernel.org
> Subject: RE: [PATCH 05/11] i2c: imx-lpi2c: add debug message when i2c
> peripheral clk doesn't work
>
> > From: Clark Wang
> > Sent: Wednesday, March 17, 2021 2:54 PM
> >
> > add debug message when i2c peripheral clk rate is 0, then directly
> > return -EINVAL.
> >
> > Signed-off-by: Gao Pan
> > Reviewed-by: Andy Duan
>
> Drop old review when patch is changed
>
> > ---
> > drivers/i2c/busses/i2c-imx-lpi2c.c | 7 ++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c
> > b/drivers/i2c/busses/i2c-imx-lpi2c.c
> > index e718bb6b2387..8f9dd3dd2951 100644
> > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> > @@ -209,7 +209,12 @@ static int lpi2c_imx_config(struct
> > lpi2c_imx_struct
> > *lpi2c_imx)
> >
> > lpi2c_imx_set_mode(lpi2c_imx);
> >
> > - clk_rate = clk_get_rate(lpi2c_imx->clk);
>
> I guess the kernel can't compile right before this patch because lpi2c_imx-
> >clk was Removed In former patch You need double check not break bisect
Oh, sorry, I miss this clk definition here.
I will fix this in V2.
>
> > + clk_rate = clk_get_rate(lpi2c_imx->clk_per);
> > + if (!clk_rate) {
> > + dev_dbg(_imx->adapter.dev, "clk_per rate is 0\n");
>
> s/dev_dbg/dev_err
Will change to dev_err.
Thanks.
Best Regards,
Clark Wang
>
> > + return -EINVAL;
> > + }
> > +
> > if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
> > filt = 0;
> > else
> > --
> > 2.25.1
smime.p7s
Description: S/MIME cryptographic signature
