Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

2020-05-17 Thread Shawn Guo 
On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.d...@nxp.com wrote:
> From: Fugang Duan 
> 
> Add "fsl,imx6sx-fec" compatible string for fec node, then
> i.MX8MP EVK ethernet function can work now.
> 
> Signed-off-by: Fugang Duan 

Applied, thanks.

RE: [EXT] Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

2020-05-13 Thread Andy Duan 
From: Shawn Guo  Sent: Wednesday, May 13, 2020 4:50 PM
> On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.d...@nxp.com wrote:
> > From: Fugang Duan 
> >
> > Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK
> > ethernet function can work now.
> >
> > Signed-off-by: Fugang Duan 
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 9b1616e59d58..b5df957c5063 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -615,7 +615,7 @@
> >   };
> >
> >   fec: ethernet@30be {
> > - compatible = "fsl,imx8mp-fec",
> "fsl,imx8mq-fec";
> > + compatible = "fsl,imx8mp-fec",
> > + "fsl,imx8mq-fec", "fsl,imx6sx-fec";
> 
> In this case, "fsl,imx8mq-fec" can be dropped?
> 
> Shawn
Please don't drop the compatible string, there have little difference for 8mq
that support eee feature, the feature will be upstreamed.

Thanks.
> 
> >   reg = <0x30be 0x1>;
> >   interrupts =  IRQ_TYPE_LEVEL_HIGH>,
> > > IRQ_TYPE_LEVEL_HIGH>,
> > --
> > 2.17.1
> >

Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

2020-05-13 Thread Shawn Guo 
On Wed, Apr 29, 2020 at 06:04:14PM +0800, fugang.d...@nxp.com wrote:
> From: Fugang Duan 
> 
> Add "fsl,imx6sx-fec" compatible string for fec node, then
> i.MX8MP EVK ethernet function can work now.
> 
> Signed-off-by: Fugang Duan 
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi 
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
>   };
>  
>   fec: ethernet@30be {
> - compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> + compatible = "fsl,imx8mp-fec", 
> "fsl,imx8mq-fec", "fsl,imx6sx-fec";

In this case, "fsl,imx8mq-fec" can be dropped?

Shawn

>   reg = <0x30be 0x1>;
>   interrupts = ,
>,
> -- 
> 2.17.1
>

RE: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

2020-04-29 Thread Aisheng Dong 
> From: Andy Duan 
> Sent: Wednesday, April 29, 2020 6:04 PM
> 
> Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK ethernet
> function can work now.
> 
> Signed-off-by: Fugang Duan 

Reviewed-by: Dong Aisheng 

Regards
Aisheng

> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
>   };
> 
>   fec: ethernet@30be {
> - compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> + compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec",
> "fsl,imx6sx-fec";
>   reg = <0x30be 0x1>;
>   interrupts = ,
>,
> --
> 2.17.1