RE: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Tuesday, May 26, 2015 8:39 PM > To: Jie, Yang > Cc: broo...@kernel.org; alsa-de...@alsa-project.org; linux- > ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced > memory footprint > > At Tue, 26 May 2015 12:32:43 +, > Jie, Yang wrote: > > > > > -Original Message- > > > From: Takashi Iwai [mailto:ti...@suse.de] > > > Sent: Tuesday, May 26, 2015 7:05 PM > > > To: Jie, Yang > > > Cc: broo...@kernel.org; alsa-de...@alsa-project.org; linux- > > > ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > > Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced > > > memory footprint > > > > > > At Tue, 26 May 2015 19:04:24 +0800, > > > Jie Yang wrote: > > > > > > > > For some embedded devices, we need reduce code size and data > > > > footprint as much as possible, e.g. disabling procfs, hw/sw params > > > > refinement, mmap, dpcm, dapm, compressed API... > > > > > > > > Here add root config menu for those configuration, and disable > > > > procfs once reduced memory footprint is selected. > > > > > > > > Signed-off-by: Jie Yang > > > > --- > > > > sound/Kconfig | 16 > > > > 1 file changed, 16 insertions(+) > > > > > > > > diff --git a/sound/Kconfig b/sound/Kconfig index 5a240e0..6760dfa > > > > 100644 > > > > --- a/sound/Kconfig > > > > +++ b/sound/Kconfig > > > > @@ -68,6 +68,22 @@ menuconfig SND > > > > > > > > if SND > > > > > > > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > > > > + bool "Reduced Memory Footprint Support" > > > > + default n > > > > + help > > > > + Say 'Y' to enable Reduced Memory Footprint Support, which may > > > > + reduce code size and data footprint as much as possible. > > > > > > I'd like to move this into sound/core. > > > Also, the kconfig name appears a bit too lengthy to me. > > > > > > > +config SND_PROC_FS > > > > + bool "Sound Proc FS Support" > > > > + depends on PROC_FS && !SND_REDUCED_MEMORY_FOOTPRINT > > > > > > This should be > > > bool "Sound Proc FS Support" > > > if !SND_REDUCED_MEMORY_FOOTPRINT > > > depends on PROC_FS > > > > > > In this way, this prompt would appear only when > > > SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts. > > > > Takashi, I tested and found same for these two way, the prompt will > > appear only when PROC_FS=y and SND_REDUCED_MEMORY_FOOTPRINT > is *not* > > set. BTW, seems here we should use without '!'? > > > > bool "Sound Proc FS Support" if > SND_REDUCED_MEMORY_FOOTPRINT > > Yes. It was my typo. An expression 'type "prompt" if xxx' means that the > prompt appears only if xxx is true. Got it, thanks. Will update and resend the patch soon. ~Keyon > > > Takashi > > > depends on PROC_FS > > > > ~Keyon > > > > > > > > > thanks, > > > > > > Takashi > > > > > > > + default y > > > > + help > > > > + Say 'N' to disable Sound proc FS, which may reduce code size > > > > about > > > > + 9KB on x86_64 platform. > > > > + If unsure say Y. > > > > + > > > > source "sound/core/Kconfig" > > > > > > > > source "sound/drivers/Kconfig" > > > > -- > > > > 1.9.1 > > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Tuesday, May 26, 2015 7:05 PM > To: Jie, Yang > Cc: broo...@kernel.org; alsa-de...@alsa-project.org; linux- > ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced > memory footprint > > At Tue, 26 May 2015 19:04:24 +0800, > Jie Yang wrote: > > > > For some embedded devices, we need reduce code size and data footprint > > as much as possible, e.g. disabling procfs, hw/sw params refinement, > > mmap, dpcm, dapm, compressed API... > > > > Here add root config menu for those configuration, and disable procfs > > once reduced memory footprint is selected. > > > > Signed-off-by: Jie Yang > > --- > > sound/Kconfig | 16 > > 1 file changed, 16 insertions(+) > > > > diff --git a/sound/Kconfig b/sound/Kconfig index 5a240e0..6760dfa > > 100644 > > --- a/sound/Kconfig > > +++ b/sound/Kconfig > > @@ -68,6 +68,22 @@ menuconfig SND > > > > if SND > > > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > > + bool "Reduced Memory Footprint Support" > > + default n > > + help > > + Say 'Y' to enable Reduced Memory Footprint Support, which may > > + reduce code size and data footprint as much as possible. > > I'd like to move this into sound/core. > Also, the kconfig name appears a bit too lengthy to me. > > > +config SND_PROC_FS > > + bool "Sound Proc FS Support" > > + depends on PROC_FS && !SND_REDUCED_MEMORY_FOOTPRINT > > This should be > bool "Sound Proc FS Support" > if !SND_REDUCED_MEMORY_FOOTPRINT > depends on PROC_FS > > In this way, this prompt would appear only when > SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts. Takashi, I tested and found same for these two way, the prompt will appear only when PROC_FS=y and SND_REDUCED_MEMORY_FOOTPRINT is *not* set. BTW, seems here we should use without '!'? bool "Sound Proc FS Support" if SND_REDUCED_MEMORY_FOOTPRINT depends on PROC_FS ~Keyon > > > thanks, > > Takashi > > > + default y > > + help > > + Say 'N' to disable Sound proc FS, which may reduce code size about > > + 9KB on x86_64 platform. > > + If unsure say Y. > > + > > source "sound/core/Kconfig" > > > > source "sound/drivers/Kconfig" > > -- > > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint
At Tue, 26 May 2015 12:32:43 +, Jie, Yang wrote: > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Tuesday, May 26, 2015 7:05 PM > > To: Jie, Yang > > Cc: broo...@kernel.org; alsa-de...@alsa-project.org; linux- > > ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced > > memory footprint > > > > At Tue, 26 May 2015 19:04:24 +0800, > > Jie Yang wrote: > > > > > > For some embedded devices, we need reduce code size and data footprint > > > as much as possible, e.g. disabling procfs, hw/sw params refinement, > > > mmap, dpcm, dapm, compressed API... > > > > > > Here add root config menu for those configuration, and disable procfs > > > once reduced memory footprint is selected. > > > > > > Signed-off-by: Jie Yang > > > --- > > > sound/Kconfig | 16 > > > 1 file changed, 16 insertions(+) > > > > > > diff --git a/sound/Kconfig b/sound/Kconfig index 5a240e0..6760dfa > > > 100644 > > > --- a/sound/Kconfig > > > +++ b/sound/Kconfig > > > @@ -68,6 +68,22 @@ menuconfig SND > > > > > > if SND > > > > > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > > > + bool "Reduced Memory Footprint Support" > > > + default n > > > + help > > > + Say 'Y' to enable Reduced Memory Footprint Support, which may > > > + reduce code size and data footprint as much as possible. > > > > I'd like to move this into sound/core. > > Also, the kconfig name appears a bit too lengthy to me. > > > > > +config SND_PROC_FS > > > + bool "Sound Proc FS Support" > > > + depends on PROC_FS && !SND_REDUCED_MEMORY_FOOTPRINT > > > > This should be > > bool "Sound Proc FS Support" > > if !SND_REDUCED_MEMORY_FOOTPRINT > > depends on PROC_FS > > > > In this way, this prompt would appear only when > > SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts. > > Takashi, I tested and found same for these two way, the prompt will > appear only when PROC_FS=y and SND_REDUCED_MEMORY_FOOTPRINT > is *not* set. BTW, seems here we should use without '!'? > > bool "Sound Proc FS Support" if SND_REDUCED_MEMORY_FOOTPRINT Yes. It was my typo. An expression 'type "prompt" if xxx' means that the prompt appears only if xxx is true. Takashi > depends on PROC_FS > > ~Keyon > > > > > > thanks, > > > > Takashi > > > > > + default y > > > + help > > > + Say 'N' to disable Sound proc FS, which may reduce code size about > > > + 9KB on x86_64 platform. > > > + If unsure say Y. > > > + > > > source "sound/core/Kconfig" > > > > > > source "sound/drivers/Kconfig" > > > -- > > > 1.9.1 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint
At Tue, 26 May 2015 19:04:24 +0800, Jie Yang wrote: > > For some embedded devices, we need reduce code size and data > footprint as much as possible, e.g. disabling procfs, hw/sw > params refinement, mmap, dpcm, dapm, compressed API... > > Here add root config menu for those configuration, and > disable procfs once reduced memory footprint is selected. > > Signed-off-by: Jie Yang > --- > sound/Kconfig | 16 > 1 file changed, 16 insertions(+) > > diff --git a/sound/Kconfig b/sound/Kconfig > index 5a240e0..6760dfa 100644 > --- a/sound/Kconfig > +++ b/sound/Kconfig > @@ -68,6 +68,22 @@ menuconfig SND > > if SND > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > + bool "Reduced Memory Footprint Support" > + default n > + help > + Say 'Y' to enable Reduced Memory Footprint Support, which may > + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. > +config SND_PROC_FS > + bool "Sound Proc FS Support" > + depends on PROC_FS && !SND_REDUCED_MEMORY_FOOTPRINT This should be bool "Sound Proc FS Support" if !SND_REDUCED_MEMORY_FOOTPRINT depends on PROC_FS In this way, this prompt would appear only when SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts. thanks, Takashi > + default y > + help > + Say 'N' to disable Sound proc FS, which may reduce code size about > + 9KB on x86_64 platform. > + If unsure say Y. > + > source "sound/core/Kconfig" > > source "sound/drivers/Kconfig" > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint
At Tue, 26 May 2015 19:04:24 +0800, Jie Yang wrote: For some embedded devices, we need reduce code size and data footprint as much as possible, e.g. disabling procfs, hw/sw params refinement, mmap, dpcm, dapm, compressed API... Here add root config menu for those configuration, and disable procfs once reduced memory footprint is selected. Signed-off-by: Jie Yang yang@intel.com --- sound/Kconfig | 16 1 file changed, 16 insertions(+) diff --git a/sound/Kconfig b/sound/Kconfig index 5a240e0..6760dfa 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -68,6 +68,22 @@ menuconfig SND if SND +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. +config SND_PROC_FS + bool Sound Proc FS Support + depends on PROC_FS !SND_REDUCED_MEMORY_FOOTPRINT This should be bool Sound Proc FS Support if !SND_REDUCED_MEMORY_FOOTPRINT depends on PROC_FS In this way, this prompt would appear only when SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts. thanks, Takashi + default y + help + Say 'N' to disable Sound proc FS, which may reduce code size about + 9KB on x86_64 platform. + If unsure say Y. + source sound/core/Kconfig source sound/drivers/Kconfig -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint
-Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Tuesday, May 26, 2015 7:05 PM To: Jie, Yang Cc: broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint At Tue, 26 May 2015 19:04:24 +0800, Jie Yang wrote: For some embedded devices, we need reduce code size and data footprint as much as possible, e.g. disabling procfs, hw/sw params refinement, mmap, dpcm, dapm, compressed API... Here add root config menu for those configuration, and disable procfs once reduced memory footprint is selected. Signed-off-by: Jie Yang yang@intel.com --- sound/Kconfig | 16 1 file changed, 16 insertions(+) diff --git a/sound/Kconfig b/sound/Kconfig index 5a240e0..6760dfa 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -68,6 +68,22 @@ menuconfig SND if SND +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. +config SND_PROC_FS + bool Sound Proc FS Support + depends on PROC_FS !SND_REDUCED_MEMORY_FOOTPRINT This should be bool Sound Proc FS Support if !SND_REDUCED_MEMORY_FOOTPRINT depends on PROC_FS In this way, this prompt would appear only when SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts. Takashi, I tested and found same for these two way, the prompt will appear only when PROC_FS=y and SND_REDUCED_MEMORY_FOOTPRINT is *not* set. BTW, seems here we should use without '!'? bool Sound Proc FS Support if SND_REDUCED_MEMORY_FOOTPRINT depends on PROC_FS ~Keyon thanks, Takashi + default y + help + Say 'N' to disable Sound proc FS, which may reduce code size about + 9KB on x86_64 platform. + If unsure say Y. + source sound/core/Kconfig source sound/drivers/Kconfig -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint
-Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Tuesday, May 26, 2015 8:39 PM To: Jie, Yang Cc: broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint At Tue, 26 May 2015 12:32:43 +, Jie, Yang wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Tuesday, May 26, 2015 7:05 PM To: Jie, Yang Cc: broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint At Tue, 26 May 2015 19:04:24 +0800, Jie Yang wrote: For some embedded devices, we need reduce code size and data footprint as much as possible, e.g. disabling procfs, hw/sw params refinement, mmap, dpcm, dapm, compressed API... Here add root config menu for those configuration, and disable procfs once reduced memory footprint is selected. Signed-off-by: Jie Yang yang@intel.com --- sound/Kconfig | 16 1 file changed, 16 insertions(+) diff --git a/sound/Kconfig b/sound/Kconfig index 5a240e0..6760dfa 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -68,6 +68,22 @@ menuconfig SND if SND +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. +config SND_PROC_FS + bool Sound Proc FS Support + depends on PROC_FS !SND_REDUCED_MEMORY_FOOTPRINT This should be bool Sound Proc FS Support if !SND_REDUCED_MEMORY_FOOTPRINT depends on PROC_FS In this way, this prompt would appear only when SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts. Takashi, I tested and found same for these two way, the prompt will appear only when PROC_FS=y and SND_REDUCED_MEMORY_FOOTPRINT is *not* set. BTW, seems here we should use without '!'? bool Sound Proc FS Support if SND_REDUCED_MEMORY_FOOTPRINT Yes. It was my typo. An expression 'type prompt if xxx' means that the prompt appears only if xxx is true. Got it, thanks. Will update and resend the patch soon. ~Keyon Takashi depends on PROC_FS ~Keyon thanks, Takashi + default y + help + Say 'N' to disable Sound proc FS, which may reduce code size about + 9KB on x86_64 platform. + If unsure say Y. + source sound/core/Kconfig source sound/drivers/Kconfig -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint
At Tue, 26 May 2015 12:32:43 +, Jie, Yang wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Tuesday, May 26, 2015 7:05 PM To: Jie, Yang Cc: broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH 1/2] ALSA: Kconfig: add config menu for reduced memory footprint At Tue, 26 May 2015 19:04:24 +0800, Jie Yang wrote: For some embedded devices, we need reduce code size and data footprint as much as possible, e.g. disabling procfs, hw/sw params refinement, mmap, dpcm, dapm, compressed API... Here add root config menu for those configuration, and disable procfs once reduced memory footprint is selected. Signed-off-by: Jie Yang yang@intel.com --- sound/Kconfig | 16 1 file changed, 16 insertions(+) diff --git a/sound/Kconfig b/sound/Kconfig index 5a240e0..6760dfa 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -68,6 +68,22 @@ menuconfig SND if SND +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. +config SND_PROC_FS + bool Sound Proc FS Support + depends on PROC_FS !SND_REDUCED_MEMORY_FOOTPRINT This should be bool Sound Proc FS Support if !SND_REDUCED_MEMORY_FOOTPRINT depends on PROC_FS In this way, this prompt would appear only when SND_REDUCED_MEMORY_FOOTPRINT is set, i.e. only for experts. Takashi, I tested and found same for these two way, the prompt will appear only when PROC_FS=y and SND_REDUCED_MEMORY_FOOTPRINT is *not* set. BTW, seems here we should use without '!'? bool Sound Proc FS Support if SND_REDUCED_MEMORY_FOOTPRINT Yes. It was my typo. An expression 'type prompt if xxx' means that the prompt appears only if xxx is true. Takashi depends on PROC_FS ~Keyon thanks, Takashi + default y + help + Say 'N' to disable Sound proc FS, which may reduce code size about + 9KB on x86_64 platform. + If unsure say Y. + source sound/core/Kconfig source sound/drivers/Kconfig -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
