Re: [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category

2016-07-26 Thread Chanwoo Choi 
Hi Myungjoo,

On 2016년 07월 27일 13:27, MyungJoo Ham wrote:
>> This patch adds the new extcon type to group the each connecotr
>> into following five category. This type would be used to handle
>> the connectors as a group unit instead of a connector unit.
>> - EXTCON_TYPE_USB  : USB connector
>> - EXTCON_TYPE_CHG  : Charger connector
>> - EXTCON_TYPE_JACK : Jack connector
> 
> "Jack" seems to be an internal jargon that many people won't recognize.
> It's, in fact, 3.5-pi, isn't it?

You're right. But, the ALSA framework already used the 'jack' word
for headphone/headset/microphone for a long time. (sound/soc/soc-jack.c)
So, To prevent the confusion, I use the 'jack' word.

> 
> Anyway, this is already being used as an enum with drivers,
> I'd suggest to add a comment in extcon.h stating that 
> "Jack connector" is usually the 3.5-pi earbud connector.

Additionally,  jack means the the LINE_IN/OUT, VIDEO_IN/OUT,
SPDIF_IN/OUT in the extcon.

> 
> Anyway, I like the direction of this patch.

Thanks.

> 
> 
> Signed-off-by: MyungJoo Ham 

Regards,
Chanwoo Choi

> 
> Cheers,
> MyungJoo
> 
>> --- a/include/linux/extcon.h
>> +++ b/include/linux/extcon.h
>> @@ -29,6 +29,15 @@
>>  #include 
>>  
>>  /*
>> + * Define the type of supported external connectors
>> + */
>> +#define EXTCON_TYPE_USB BIT(0)  /* USB connector */
>> +#define EXTCON_TYPE_CHG BIT(1)  /* Charger connector */
>> +#define EXTCON_TYPE_JACKBIT(2)  /* Jack connector */
> +/* Usually, this is a 3.5-pi earbud conector 
> */
>> +#define EXTCON_TYPE_DISPBIT(3)  /* Display connector */
>> +#define EXTCON_TYPE_MISCBIT(4)  /* Miscellaneous connector */
>> +
>> +/*
>>   * Define the unique id of supported external connectors
>>   */
>>  #define EXTCON_NONE 0
>> -- 
>> 1.9.1
>>

Re: [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category

2016-07-26 Thread Chanwoo Choi 
Hi Myungjoo,

On 2016년 07월 27일 13:27, MyungJoo Ham wrote:
>> This patch adds the new extcon type to group the each connecotr
>> into following five category. This type would be used to handle
>> the connectors as a group unit instead of a connector unit.
>> - EXTCON_TYPE_USB  : USB connector
>> - EXTCON_TYPE_CHG  : Charger connector
>> - EXTCON_TYPE_JACK : Jack connector
> 
> "Jack" seems to be an internal jargon that many people won't recognize.
> It's, in fact, 3.5-pi, isn't it?

You're right. But, the ALSA framework already used the 'jack' word
for headphone/headset/microphone for a long time. (sound/soc/soc-jack.c)
So, To prevent the confusion, I use the 'jack' word.

> 
> Anyway, this is already being used as an enum with drivers,
> I'd suggest to add a comment in extcon.h stating that 
> "Jack connector" is usually the 3.5-pi earbud connector.

Additionally,  jack means the the LINE_IN/OUT, VIDEO_IN/OUT,
SPDIF_IN/OUT in the extcon.

> 
> Anyway, I like the direction of this patch.

Thanks.

> 
> 
> Signed-off-by: MyungJoo Ham 

Regards,
Chanwoo Choi

> 
> Cheers,
> MyungJoo
> 
>> --- a/include/linux/extcon.h
>> +++ b/include/linux/extcon.h
>> @@ -29,6 +29,15 @@
>>  #include 
>>  
>>  /*
>> + * Define the type of supported external connectors
>> + */
>> +#define EXTCON_TYPE_USB BIT(0)  /* USB connector */
>> +#define EXTCON_TYPE_CHG BIT(1)  /* Charger connector */
>> +#define EXTCON_TYPE_JACKBIT(2)  /* Jack connector */
> +/* Usually, this is a 3.5-pi earbud conector 
> */
>> +#define EXTCON_TYPE_DISPBIT(3)  /* Display connector */
>> +#define EXTCON_TYPE_MISCBIT(4)  /* Miscellaneous connector */
>> +
>> +/*
>>   * Define the unique id of supported external connectors
>>   */
>>  #define EXTCON_NONE 0
>> -- 
>> 1.9.1
>>

RE: [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category

2016-07-26 Thread MyungJoo Ham 
> This patch adds the new extcon type to group the each connecotr
> into following five category. This type would be used to handle
> the connectors as a group unit instead of a connector unit.
> - EXTCON_TYPE_USB  : USB connector
> - EXTCON_TYPE_CHG  : Charger connector
> - EXTCON_TYPE_JACK : Jack connector

"Jack" seems to be an internal jargon that many people won't recognize.
It's, in fact, 3.5-pi, isn't it?

Anyway, this is already being used as an enum with drivers,
I'd suggest to add a comment in extcon.h stating that 
"Jack connector" is usually the 3.5-pi earbud connector.

Anyway, I like the direction of this patch.


Signed-off-by: MyungJoo Ham 

Cheers,
MyungJoo

> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -29,6 +29,15 @@
>  #include 
>  
>  /*
> + * Define the type of supported external connectors
> + */
> +#define EXTCON_TYPE_USB  BIT(0)  /* USB connector */
> +#define EXTCON_TYPE_CHG  BIT(1)  /* Charger connector */
> +#define EXTCON_TYPE_JACK BIT(2)  /* Jack connector */
+/* Usually, this is a 3.5-pi earbud conector */
> +#define EXTCON_TYPE_DISP BIT(3)  /* Display connector */
> +#define EXTCON_TYPE_MISC BIT(4)  /* Miscellaneous connector */
> +
> +/*
>   * Define the unique id of supported external connectors
>   */
>  #define EXTCON_NONE  0
> -- 
> 1.9.1
>

RE: [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category

2016-07-26 Thread MyungJoo Ham 
> This patch adds the new extcon type to group the each connecotr
> into following five category. This type would be used to handle
> the connectors as a group unit instead of a connector unit.
> - EXTCON_TYPE_USB  : USB connector
> - EXTCON_TYPE_CHG  : Charger connector
> - EXTCON_TYPE_JACK : Jack connector

"Jack" seems to be an internal jargon that many people won't recognize.
It's, in fact, 3.5-pi, isn't it?

Anyway, this is already being used as an enum with drivers,
I'd suggest to add a comment in extcon.h stating that 
"Jack connector" is usually the 3.5-pi earbud connector.

Anyway, I like the direction of this patch.


Signed-off-by: MyungJoo Ham 

Cheers,
MyungJoo

> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -29,6 +29,15 @@
>  #include 
>  
>  /*
> + * Define the type of supported external connectors
> + */
> +#define EXTCON_TYPE_USB  BIT(0)  /* USB connector */
> +#define EXTCON_TYPE_CHG  BIT(1)  /* Charger connector */
> +#define EXTCON_TYPE_JACK BIT(2)  /* Jack connector */
+/* Usually, this is a 3.5-pi earbud conector */
> +#define EXTCON_TYPE_DISP BIT(3)  /* Display connector */
> +#define EXTCON_TYPE_MISC BIT(4)  /* Miscellaneous connector */
> +
> +/*
>   * Define the unique id of supported external connectors
>   */
>  #define EXTCON_NONE  0
> -- 
> 1.9.1
>