RE: [PATCH 15/21] mwifiex: slight optimization of addr compare

2013-12-23 Thread Bing Zhao 
Hi Ding,

> diff --git a/drivers/net/wireless/mwifiex/11n_rxreorder.c
> b/drivers/net/wireless/mwifiex/11n_rxreorder.c
> index ada809f..a180298 100644
> --- a/drivers/net/wireless/mwifiex/11n_rxreorder.c
> +++ b/drivers/net/wireless/mwifiex/11n_rxreorder.c
> @@ -164,7 +164,7 @@ mwifiex_11n_get_rx_reorder_tbl(struct mwifiex_private 
> *priv, int tid, u8 *ta)
> 
>   spin_lock_irqsave(>rx_reorder_tbl_lock, flags);
>   list_for_each_entry(tbl, >rx_reorder_tbl_ptr, list) {
> - if (!memcmp(tbl->ta, ta, ETH_ALEN) && tbl->tid == tid) {
> + if (ether_addr_equal_unaligned(tbl->ta, ta) && tbl->tid == tid) 
> {

checkpatch.pl found several warnings in this patch.
WARNING: line over 80 characters

Could you please fix these warnings by splitting the function arguments into 
multiple lines?

Thanks,
Bing

RE: [PATCH 15/21] mwifiex: slight optimization of addr compare

2013-12-23 Thread Bing Zhao 
Hi Ding,

 diff --git a/drivers/net/wireless/mwifiex/11n_rxreorder.c
 b/drivers/net/wireless/mwifiex/11n_rxreorder.c
 index ada809f..a180298 100644
 --- a/drivers/net/wireless/mwifiex/11n_rxreorder.c
 +++ b/drivers/net/wireless/mwifiex/11n_rxreorder.c
 @@ -164,7 +164,7 @@ mwifiex_11n_get_rx_reorder_tbl(struct mwifiex_private 
 *priv, int tid, u8 *ta)
 
   spin_lock_irqsave(priv-rx_reorder_tbl_lock, flags);
   list_for_each_entry(tbl, priv-rx_reorder_tbl_ptr, list) {
 - if (!memcmp(tbl-ta, ta, ETH_ALEN)  tbl-tid == tid) {
 + if (ether_addr_equal_unaligned(tbl-ta, ta)  tbl-tid == tid) 
 {

checkpatch.pl found several warnings in this patch.
WARNING: line over 80 characters

Could you please fix these warnings by splitting the function arguments into 
multiple lines?

Thanks,
Bing