RE: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug

[Steve Wise]

> Subject: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug
> 
> Using the normal mechanism, not an indirected one, is clearer.
> 
> Miscellanea:
> 
> o Coalesce formats
> o Realign arguments
> 
> Signed-off-by: Joe Perches 
> ---
>  drivers/infiniband/hw/cxgb3/cxio_dbg.c  |  35 ++---
>  drivers/infiniband/hw/cxgb3/cxio_hal.c  | 174 
>  drivers/infiniband/hw/cxgb3/cxio_hal.h  |   2 -
>  drivers/infiniband/hw/cxgb3/cxio_resource.c |  20 +--
>  drivers/infiniband/hw/cxgb3/iwch.c  |   6 +-
>  drivers/infiniband/hw/cxgb3/iwch_cm.c   | 203
++--
>  drivers/infiniband/hw/cxgb3/iwch_cm.h   |  18 +--
>  drivers/infiniband/hw/cxgb3/iwch_cq.c   |  14 +-
>  drivers/infiniband/hw/cxgb3/iwch_ev.c   |  15 +-
>  drivers/infiniband/hw/cxgb3/iwch_mem.c  |   2 +-
>  drivers/infiniband/hw/cxgb3/iwch_provider.c | 101 +++---
>  drivers/infiniband/hw/cxgb3/iwch_provider.h |   9 +-
>  drivers/infiniband/hw/cxgb3/iwch_qp.c   |  60 
>  13 files changed, 329 insertions(+), 330 deletions(-)
> 

Looks good (and thanks).

Reviewed-by: Steve Wise 

RE: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug

[Steve Wise]

> Subject: [PATCH 2/4] cxgb3: Convert PDBG to pr_debug
> 
> Using the normal mechanism, not an indirected one, is clearer.
> 
> Miscellanea:
> 
> o Coalesce formats
> o Realign arguments
> 
> Signed-off-by: Joe Perches 
> ---
>  drivers/infiniband/hw/cxgb3/cxio_dbg.c  |  35 ++---
>  drivers/infiniband/hw/cxgb3/cxio_hal.c  | 174 
>  drivers/infiniband/hw/cxgb3/cxio_hal.h  |   2 -
>  drivers/infiniband/hw/cxgb3/cxio_resource.c |  20 +--
>  drivers/infiniband/hw/cxgb3/iwch.c  |   6 +-
>  drivers/infiniband/hw/cxgb3/iwch_cm.c   | 203
++--
>  drivers/infiniband/hw/cxgb3/iwch_cm.h   |  18 +--
>  drivers/infiniband/hw/cxgb3/iwch_cq.c   |  14 +-
>  drivers/infiniband/hw/cxgb3/iwch_ev.c   |  15 +-
>  drivers/infiniband/hw/cxgb3/iwch_mem.c  |   2 +-
>  drivers/infiniband/hw/cxgb3/iwch_provider.c | 101 +++---
>  drivers/infiniband/hw/cxgb3/iwch_provider.h |   9 +-
>  drivers/infiniband/hw/cxgb3/iwch_qp.c   |  60 
>  13 files changed, 329 insertions(+), 330 deletions(-)
> 

Looks good (and thanks).

Reviewed-by: Steve Wise