Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Yang Shi]

On 1/5/18 7:17 AM, David Miller wrote:

From: "Yang Shi" 
Date: Fri, 05 Jan 2018 06:46:48 +0800


Any more comment on this change?


These patches were not really submitted properly.

If you post a series, the series goes to one destination and
one tree.

If they are supposed to go to multiple trees, submit them
individually rather than as a series.  With clear indications
in the Subject lines which tree should be taking the patch.


Thanks for the comment. I will resend the net patches in a separate 
series to you.


Yang



Thank you.

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Yang Shi]

On 1/5/18 7:17 AM, David Miller wrote:

From: "Yang Shi" 
Date: Fri, 05 Jan 2018 06:46:48 +0800


Any more comment on this change?


These patches were not really submitted properly.

If you post a series, the series goes to one destination and
one tree.

If they are supposed to go to multiple trees, submit them
individually rather than as a series.  With clear indications
in the Subject lines which tree should be taking the patch.


Thanks for the comment. I will resend the net patches in a separate 
series to you.


Yang



Thank you.

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[David Miller]

From: "Yang Shi" 
Date: Fri, 05 Jan 2018 06:46:48 +0800

> Any more comment on this change?

These patches were not really submitted properly.

If you post a series, the series goes to one destination and
one tree.

If they are supposed to go to multiple trees, submit them
individually rather than as a series.  With clear indications
in the Subject lines which tree should be taking the patch.

Thank you.

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[David Miller]

From: "Yang Shi" 
Date: Fri, 05 Jan 2018 06:46:48 +0800

> Any more comment on this change?

These patches were not really submitted properly.

If you post a series, the series goes to one destination and
one tree.

If they are supposed to go to multiple trees, submit them
individually rather than as a series.  With clear indications
in the Subject lines which tree should be taking the patch.

Thank you.

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Yang Shi]

Hi David,

Any more comment on this change?

Thanks,
Yang


On 12/7/17 5:40 PM, Ying Xue wrote:

On 11/18/2017 07:02 AM, Yang Shi wrote:

Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by TIPC at all.

So, remove the unused hardirq.h.

Signed-off-by: Yang Shi 
Cc: Jon Maloy 
Cc: Ying Xue 
Cc: "David S. Miller" 


Tested-by: Ying Xue 
Acked-by: Ying Xue 


---
  net/tipc/core.h | 1 -
  1 file changed, 1 deletion(-)

diff --git a/net/tipc/core.h b/net/tipc/core.h
index 5cc5398..099e072 100644
--- a/net/tipc/core.h
+++ b/net/tipc/core.h
@@ -49,7 +49,6 @@
  #include 
  #include 
  #include 
-#include 
  #include 
  #include 
  #include 

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Yang Shi]

Hi David,

Any more comment on this change?

Thanks,
Yang


On 12/7/17 5:40 PM, Ying Xue wrote:

On 11/18/2017 07:02 AM, Yang Shi wrote:

Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by TIPC at all.

So, remove the unused hardirq.h.

Signed-off-by: Yang Shi 
Cc: Jon Maloy 
Cc: Ying Xue 
Cc: "David S. Miller" 


Tested-by: Ying Xue 
Acked-by: Ying Xue 


---
  net/tipc/core.h | 1 -
  1 file changed, 1 deletion(-)

diff --git a/net/tipc/core.h b/net/tipc/core.h
index 5cc5398..099e072 100644
--- a/net/tipc/core.h
+++ b/net/tipc/core.h
@@ -49,7 +49,6 @@
  #include 
  #include 
  #include 
-#include 
  #include 
  #include 
  #include 

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Ying Xue]

On 11/18/2017 07:02 AM, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by TIPC at all.
> 
> So, remove the unused hardirq.h.
> 
> Signed-off-by: Yang Shi 
> Cc: Jon Maloy 
> Cc: Ying Xue 
> Cc: "David S. Miller" 

Tested-by: Ying Xue 
Acked-by: Ying Xue 

> ---
>  net/tipc/core.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/tipc/core.h b/net/tipc/core.h
> index 5cc5398..099e072 100644
> --- a/net/tipc/core.h
> +++ b/net/tipc/core.h
> @@ -49,7 +49,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
> 

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Ying Xue]

On 11/18/2017 07:02 AM, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by TIPC at all.
> 
> So, remove the unused hardirq.h.
> 
> Signed-off-by: Yang Shi 
> Cc: Jon Maloy 
> Cc: Ying Xue 
> Cc: "David S. Miller" 

Tested-by: Ying Xue 
Acked-by: Ying Xue 

> ---
>  net/tipc/core.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/tipc/core.h b/net/tipc/core.h
> index 5cc5398..099e072 100644
> --- a/net/tipc/core.h
> +++ b/net/tipc/core.h
> @@ -49,7 +49,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
> 

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Yang Shi]

On 12/7/17 11:20 AM, Jon Maloy wrote:




-Original Message-
From: netdev-ow...@vger.kernel.org [mailto:netdev-
ow...@vger.kernel.org] On Behalf Of Yang Shi
Sent: Thursday, December 07, 2017 14:16
To: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org; linux-fsde...@vger.kernel.org; linux-
cry...@vger.kernel.org; net...@vger.kernel.org; Jon Maloy
<jon.ma...@ericsson.com>; Ying Xue <ying@windriver.com>; David S.
Miller <da...@davemloft.net>
Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

Hi folks,

Any comment on this one?


If it compiles it is ok with me. Don't know why it was put there in the first 
place.


Yes, it does compile.

Yang



///jon



Thanks,
Yang


On 11/17/17 3:02 PM, Yang Shi wrote:

Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by TIPC at all.

So, remove the unused hardirq.h.

Signed-off-by: Yang Shi <yan...@alibaba-inc.com>
Cc: Jon Maloy <jon.ma...@ericsson.com>
Cc: Ying Xue <ying@windriver.com>
Cc: "David S. Miller" <da...@davemloft.net>
---
   net/tipc/core.h | 1 -
   1 file changed, 1 deletion(-)

diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072
100644
--- a/net/tipc/core.h
+++ b/net/tipc/core.h
@@ -49,7 +49,6 @@
   #include 
   #include 
   #include 
-#include 
   #include 
   #include 
   #include 

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Yang Shi]

On 12/7/17 11:20 AM, Jon Maloy wrote:




-Original Message-
From: netdev-ow...@vger.kernel.org [mailto:netdev-
ow...@vger.kernel.org] On Behalf Of Yang Shi
Sent: Thursday, December 07, 2017 14:16
To: linux-kernel@vger.kernel.org
Cc: linux...@kvack.org; linux-fsde...@vger.kernel.org; linux-
cry...@vger.kernel.org; net...@vger.kernel.org; Jon Maloy
; Ying Xue ; David S.
Miller 
Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

Hi folks,

Any comment on this one?


If it compiles it is ok with me. Don't know why it was put there in the first 
place.


Yes, it does compile.

Yang



///jon



Thanks,
Yang


On 11/17/17 3:02 PM, Yang Shi wrote:

Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by TIPC at all.

So, remove the unused hardirq.h.

Signed-off-by: Yang Shi 
Cc: Jon Maloy 
Cc: Ying Xue 
Cc: "David S. Miller" 
---
   net/tipc/core.h | 1 -
   1 file changed, 1 deletion(-)

diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072
100644
--- a/net/tipc/core.h
+++ b/net/tipc/core.h
@@ -49,7 +49,6 @@
   #include 
   #include 
   #include 
-#include 
   #include 
   #include 
   #include 

RE: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Jon Maloy]

> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Yang Shi
> Sent: Thursday, December 07, 2017 14:16
> To: linux-kernel@vger.kernel.org
> Cc: linux...@kvack.org; linux-fsde...@vger.kernel.org; linux-
> cry...@vger.kernel.org; net...@vger.kernel.org; Jon Maloy
> <jon.ma...@ericsson.com>; Ying Xue <ying@windriver.com>; David S.
> Miller <da...@davemloft.net>
> Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h
> 
> Hi folks,
> 
> Any comment on this one?

If it compiles it is ok with me. Don't know why it was put there in the first 
place.

///jon

> 
> Thanks,
> Yang
> 
> 
> On 11/17/17 3:02 PM, Yang Shi wrote:
> > Preempt counter APIs have been split out, currently, hardirq.h just
> > includes irq_enter/exit APIs which are not used by TIPC at all.
> >
> > So, remove the unused hardirq.h.
> >
> > Signed-off-by: Yang Shi <yan...@alibaba-inc.com>
> > Cc: Jon Maloy <jon.ma...@ericsson.com>
> > Cc: Ying Xue <ying@windriver.com>
> > Cc: "David S. Miller" <da...@davemloft.net>
> > ---
> >   net/tipc/core.h | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072
> > 100644
> > --- a/net/tipc/core.h
> > +++ b/net/tipc/core.h
> > @@ -49,7 +49,6 @@
> >   #include 
> >   #include 
> >   #include 
> > -#include 
> >   #include 
> >   #include 
> >   #include 
> >

RE: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Jon Maloy]

> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Yang Shi
> Sent: Thursday, December 07, 2017 14:16
> To: linux-kernel@vger.kernel.org
> Cc: linux...@kvack.org; linux-fsde...@vger.kernel.org; linux-
> cry...@vger.kernel.org; net...@vger.kernel.org; Jon Maloy
> ; Ying Xue ; David S.
> Miller 
> Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h
> 
> Hi folks,
> 
> Any comment on this one?

If it compiles it is ok with me. Don't know why it was put there in the first 
place.

///jon

> 
> Thanks,
> Yang
> 
> 
> On 11/17/17 3:02 PM, Yang Shi wrote:
> > Preempt counter APIs have been split out, currently, hardirq.h just
> > includes irq_enter/exit APIs which are not used by TIPC at all.
> >
> > So, remove the unused hardirq.h.
> >
> > Signed-off-by: Yang Shi 
> > Cc: Jon Maloy 
> > Cc: Ying Xue 
> > Cc: "David S. Miller" 
> > ---
> >   net/tipc/core.h | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072
> > 100644
> > --- a/net/tipc/core.h
> > +++ b/net/tipc/core.h
> > @@ -49,7 +49,6 @@
> >   #include 
> >   #include 
> >   #include 
> > -#include 
> >   #include 
> >   #include 
> >   #include 
> >

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Yang Shi]

Hi folks,

Any comment on this one?

Thanks,
Yang


On 11/17/17 3:02 PM, Yang Shi wrote:

Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by TIPC at all.

So, remove the unused hardirq.h.

Signed-off-by: Yang Shi 
Cc: Jon Maloy 
Cc: Ying Xue 
Cc: "David S. Miller" 
---
  net/tipc/core.h | 1 -
  1 file changed, 1 deletion(-)

diff --git a/net/tipc/core.h b/net/tipc/core.h
index 5cc5398..099e072 100644
--- a/net/tipc/core.h
+++ b/net/tipc/core.h
@@ -49,7 +49,6 @@
  #include 
  #include 
  #include 
-#include 
  #include 
  #include 
  #include 

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Yang Shi]

Hi folks,

Any comment on this one?

Thanks,
Yang


On 11/17/17 3:02 PM, Yang Shi wrote:

Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by TIPC at all.

So, remove the unused hardirq.h.

Signed-off-by: Yang Shi 
Cc: Jon Maloy 
Cc: Ying Xue 
Cc: "David S. Miller" 
---
  net/tipc/core.h | 1 -
  1 file changed, 1 deletion(-)

diff --git a/net/tipc/core.h b/net/tipc/core.h
index 5cc5398..099e072 100644
--- a/net/tipc/core.h
+++ b/net/tipc/core.h
@@ -49,7 +49,6 @@
  #include 
  #include 
  #include 
-#include 
  #include 
  #include 
  #include