Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Hi! > >>Why is it global struct? It seems to be flexible configurable over > >>devicetree. > >>So I would assume it should be able to handle more then one button. Please > >>remove global variables, make it allocatable per OF node. > > > >There is ONLY one button available for SC key, but yes, I think I can make > >the structure > >private and get all necessary data from the structure using container_of. > > And we will never need more then 640 kB RAM ;) > https://en.wikiquote.org/wiki/Talk:Bill_Gates Right question is "is it worth complicating kernel now (and making it slower/bigger) for future flexibility?". And I believe answer is "no", but it is not a big deal either way. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
On 03.09.19 09:35, Anson Huang wrote:
Hi, Oleksij
On 03.09.19 08:48, Anson Huang wrote:
Hi, Oleksij
On 03.09.19 16:03, Anson Huang wrote:
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
inside, the system controller is in charge of controlling power,
clock and power key etc..
Adds i.MX system controller power key driver support, Linux kernel
has to communicate with system controller via MU (message unit) IPC
to get power key's status.
Signed-off-by: Anson Huang
---
Changes since V1:
- remove "wakeup-source" property operation, scu power key uses
generic scu irq,
no need to have this property for device wakeup operation.
---
drivers/input/keyboard/Kconfig | 7 ++
drivers/input/keyboard/Makefile| 1 +
drivers/input/keyboard/imx_sc_pwrkey.c | 169
+
3 files changed, 177 insertions(+)
create mode 100644 drivers/input/keyboard/imx_sc_pwrkey.c
diff --git a/drivers/input/keyboard/Kconfig
b/drivers/input/keyboard/Kconfig index 2e6d288..3aaeb9c 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -469,6 +469,13 @@ config KEYBOARD_IMX
To compile this driver as a module, choose M here: the
module will be called imx_keypad.
+config KEYBOARD_IMX_SC_PWRKEY
+ tristate "IMX SCU Power Key Driver"
+ depends on IMX_SCU
+ help
+ This is the system controller powerkey driver for NXP i.MX SoCs with
+ system controller inside.
The KEY is configurable over devicetree, why is it called PWRKEY? It
looks for me as generic SCU key handler.
We always use it as power key, NOT a generic key, as it has HW
function designed for power key purpose.
gpio-key driver is mostly used for power or reboot key. And it is still called
gpio-key driver. If it is used for power key only, why is it configurable? I can
configure it as KEY_ENTER or some thing different. This driver has not
KEY_POWER specific any thing.
Understood, I am making the V3 with all "power" removed, just using the "key".
config KEYBOARD_NEWTON
tristate "Newton keyboard"
select SERIO
diff --git a/drivers/input/keyboard/Makefile
b/drivers/input/keyboard/Makefile index 9510325..9ea5585 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -29,6 +29,7 @@ obj-$(CONFIG_KEYBOARD_HIL)+=
hil_kbd.o
obj-$(CONFIG_KEYBOARD_HIL_OLD) += hilkbd.o
obj-$(CONFIG_KEYBOARD_IPAQ_MICRO) += ipaq-micro-keys.o
obj-$(CONFIG_KEYBOARD_IMX) += imx_keypad.o
+obj-$(CONFIG_KEYBOARD_IMX_SC_PWRKEY) += imx_sc_pwrkey.o
obj-$(CONFIG_KEYBOARD_HP6XX)+= jornada680_kbd.o
obj-$(CONFIG_KEYBOARD_HP7XX)+= jornada720_kbd.o
obj-$(CONFIG_KEYBOARD_LKKBD)+= lkkbd.o
diff --git a/drivers/input/keyboard/imx_sc_pwrkey.c
b/drivers/input/keyboard/imx_sc_pwrkey.c
new file mode 100644
index 000..53aa9a4
--- /dev/null
+++ b/drivers/input/keyboard/imx_sc_pwrkey.c
@@ -0,0 +1,169 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2019 NXP.
+ */
+
+#include
+#include
+#include #include
+#include #include #include
+ #include #include
+ #include #include
+ #include
+
+#define DEBOUNCE_TIME 100
+#define REPEAT_INTERVAL60
+
+#define SC_IRQ_BUTTON 1
+#define SC_IRQ_GROUP_WAKE 3
+#define IMX_SC_MISC_FUNC_GET_BUTTON_STATUS 18
+
+struct imx_pwrkey_drv_data {
+ int keycode;
+ bool keystate; /* 1: pressed, 0: release */
+ bool delay_check;
+ struct delayed_work check_work;
+ struct input_dev *input;
+};
+
+struct imx_sc_msg_pwrkey {
+ struct imx_sc_rpc_msg hdr;
+ u8 state;
+};
+static struct imx_pwrkey_drv_data *pdata;
Why is it global struct? It seems to be flexible configurable over devicetree.
So I would assume it should be able to handle more then one button.
Please remove global variables, make it allocatable per OF node.
There is ONLY one button available for SC key, but yes, I think I can
make the structure private and get all necessary data from the structure
using container_of.
And we will never need more then 640 kB RAM ;)
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wi
kiquote.org%2Fwiki%2FTalk%3ABill_Gatesdata=02%7C01%7Canson.hu
ang%40nxp.com%7C4d4d7458087747e0d8f008d7304057e9%7C686ea1d3bc2
b4c6fa92cd99c5c301635%7C0%7C0%7C637030925236150243sdata=w
%2FGXBaHfnBdLwjTxjbzWSPeIw3ExL%2Fs9IMOgF1onL6A%3Dreserved
=0
Please use different name "pdata" is usually used as platform data.
Please, use "priv".
OK.
+static struct imx_sc_ipc *pwrkey_ipc_handle;
same as before, no global variables.
Will move it into private platform data structure.
+
+static int imx_sc_pwrkey_notify(struct notifier_block *nb,
+ unsigned long event, void *group) {
+ if ((event & SC_IRQ_BUTTON) && (*(u8 *)group ==
RE: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Hi, Oleksij
> On 03.09.19 08:48, Anson Huang wrote:
> > Hi, Oleksij
> >
> >> On 03.09.19 16:03, Anson Huang wrote:
> >>> i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> >>> inside, the system controller is in charge of controlling power,
> >>> clock and power key etc..
> >>>
> >>> Adds i.MX system controller power key driver support, Linux kernel
> >>> has to communicate with system controller via MU (message unit) IPC
> >>> to get power key's status.
> >>>
> >>> Signed-off-by: Anson Huang
> >>> ---
> >>> Changes since V1:
> >>> - remove "wakeup-source" property operation, scu power key uses
> >> generic scu irq,
> >>> no need to have this property for device wakeup operation.
> >>> ---
> >>>drivers/input/keyboard/Kconfig | 7 ++
> >>>drivers/input/keyboard/Makefile| 1 +
> >>>drivers/input/keyboard/imx_sc_pwrkey.c | 169
> >> +
> >>>3 files changed, 177 insertions(+)
> >>>create mode 100644 drivers/input/keyboard/imx_sc_pwrkey.c
> >>>
> >>> diff --git a/drivers/input/keyboard/Kconfig
> >>> b/drivers/input/keyboard/Kconfig index 2e6d288..3aaeb9c 100644
> >>> --- a/drivers/input/keyboard/Kconfig
> >>> +++ b/drivers/input/keyboard/Kconfig
> >>> @@ -469,6 +469,13 @@ config KEYBOARD_IMX
> >>> To compile this driver as a module, choose M here: the
> >>> module will be called imx_keypad.
> >>>
> >>> +config KEYBOARD_IMX_SC_PWRKEY
> >>> + tristate "IMX SCU Power Key Driver"
> >>> + depends on IMX_SCU
> >>> + help
> >>> + This is the system controller powerkey driver for NXP i.MX SoCs with
> >>> + system controller inside.
> >>
> >> The KEY is configurable over devicetree, why is it called PWRKEY? It
> >> looks for me as generic SCU key handler.
> >
> > We always use it as power key, NOT a generic key, as it has HW
> > function designed for power key purpose.
>
> gpio-key driver is mostly used for power or reboot key. And it is still called
> gpio-key driver. If it is used for power key only, why is it configurable? I
> can
> configure it as KEY_ENTER or some thing different. This driver has not
> KEY_POWER specific any thing.
Understood, I am making the V3 with all "power" removed, just using the "key".
>
> >
> >>
> >>>config KEYBOARD_NEWTON
> >>> tristate "Newton keyboard"
> >>> select SERIO
> >>> diff --git a/drivers/input/keyboard/Makefile
> >>> b/drivers/input/keyboard/Makefile index 9510325..9ea5585 100644
> >>> --- a/drivers/input/keyboard/Makefile
> >>> +++ b/drivers/input/keyboard/Makefile
> >>> @@ -29,6 +29,7 @@ obj-$(CONFIG_KEYBOARD_HIL) +=
> hil_kbd.o
> >>>obj-$(CONFIG_KEYBOARD_HIL_OLD) += hilkbd.o
> >>>obj-$(CONFIG_KEYBOARD_IPAQ_MICRO) += ipaq-micro-keys.o
> >>>obj-$(CONFIG_KEYBOARD_IMX) += imx_keypad.o
> >>> +obj-$(CONFIG_KEYBOARD_IMX_SC_PWRKEY) += imx_sc_pwrkey.o
> >>>obj-$(CONFIG_KEYBOARD_HP6XX) += jornada680_kbd.o
> >>>obj-$(CONFIG_KEYBOARD_HP7XX) += jornada720_kbd.o
> >>>obj-$(CONFIG_KEYBOARD_LKKBD) += lkkbd.o
> >>> diff --git a/drivers/input/keyboard/imx_sc_pwrkey.c
> >>> b/drivers/input/keyboard/imx_sc_pwrkey.c
> >>> new file mode 100644
> >>> index 000..53aa9a4
> >>> --- /dev/null
> >>> +++ b/drivers/input/keyboard/imx_sc_pwrkey.c
> >>> @@ -0,0 +1,169 @@
> >>> +// SPDX-License-Identifier: GPL-2.0
> >>> +/*
> >>> + * Copyright 2019 NXP.
> >>> + */
> >>> +
> >>> +#include
> >>> +#include
> >>> +#include #include
> >>> +#include #include #include
> >>> + #include #include
> >>> + #include #include
> >>> + #include
> >>> +
> >>> +#define DEBOUNCE_TIME100
> >>> +#define REPEAT_INTERVAL 60
> >>> +
> >>> +#define SC_IRQ_BUTTON1
> >>> +#define SC_IRQ_GROUP_WAKE3
> >>> +#define IMX_SC_MISC_FUNC_GET_BUTTON_STATUS 18
> >>> +
> >>> +struct imx_pwrkey_drv_data {
> >>> + int keycode;
> >>> + bool keystate; /* 1: pressed, 0: release */
> >>> + bool delay_check;
> >>> + struct delayed_work check_work;
> >>> + struct input_dev *input;
> >>> +};
> >>> +
> >>> +struct imx_sc_msg_pwrkey {
> >>> + struct imx_sc_rpc_msg hdr;
> >>> + u8 state;
> >>> +};
> >>> +static struct imx_pwrkey_drv_data *pdata;
> >>
> >> Why is it global struct? It seems to be flexible configurable over
> >> devicetree.
> >> So I would assume it should be able to handle more then one button.
> >> Please remove global variables, make it allocatable per OF node.
> >
> > There is ONLY one button available for SC key, but yes, I think I can
> > make the structure private and get all necessary data from the structure
> using container_of.
>
> And we will never need more then 640 kB RAM ;)
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wi
> kiquote.org%2Fwiki%2FTalk%3ABill_Gatesdata=02%7C01%7Canson.hu
> ang%40nxp.com%7C4d4d7458087747e0d8f008d7304057e9%7C686ea1d3bc2
> b4c6fa92cd99c5c301635%7C0%7C0%7C637030925236150243sdata=w
>
Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
On 03.09.19 08:48, Anson Huang wrote:
Hi, Oleksij
On 03.09.19 16:03, Anson Huang wrote:
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
inside, the system controller is in charge of controlling power, clock
and power key etc..
Adds i.MX system controller power key driver support, Linux kernel has
to communicate with system controller via MU (message unit) IPC to get
power key's status.
Signed-off-by: Anson Huang
---
Changes since V1:
- remove "wakeup-source" property operation, scu power key uses
generic scu irq,
no need to have this property for device wakeup operation.
---
drivers/input/keyboard/Kconfig | 7 ++
drivers/input/keyboard/Makefile| 1 +
drivers/input/keyboard/imx_sc_pwrkey.c | 169
+
3 files changed, 177 insertions(+)
create mode 100644 drivers/input/keyboard/imx_sc_pwrkey.c
diff --git a/drivers/input/keyboard/Kconfig
b/drivers/input/keyboard/Kconfig index 2e6d288..3aaeb9c 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -469,6 +469,13 @@ config KEYBOARD_IMX
To compile this driver as a module, choose M here: the
module will be called imx_keypad.
+config KEYBOARD_IMX_SC_PWRKEY
+ tristate "IMX SCU Power Key Driver"
+ depends on IMX_SCU
+ help
+ This is the system controller powerkey driver for NXP i.MX SoCs with
+ system controller inside.
The KEY is configurable over devicetree, why is it called PWRKEY? It looks for
me as generic SCU key handler.
We always use it as power key, NOT a generic key, as it has HW function designed
for power key purpose.
gpio-key driver is mostly used for power or reboot key. And it is still called gpio-key
driver. If it is used for power key only, why is it configurable? I can configure it as
KEY_ENTER or some thing different. This driver has not KEY_POWER specific any thing.
config KEYBOARD_NEWTON
tristate "Newton keyboard"
select SERIO
diff --git a/drivers/input/keyboard/Makefile
b/drivers/input/keyboard/Makefile index 9510325..9ea5585 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -29,6 +29,7 @@ obj-$(CONFIG_KEYBOARD_HIL)+= hil_kbd.o
obj-$(CONFIG_KEYBOARD_HIL_OLD) += hilkbd.o
obj-$(CONFIG_KEYBOARD_IPAQ_MICRO)+= ipaq-micro-keys.o
obj-$(CONFIG_KEYBOARD_IMX) += imx_keypad.o
+obj-$(CONFIG_KEYBOARD_IMX_SC_PWRKEY) += imx_sc_pwrkey.o
obj-$(CONFIG_KEYBOARD_HP6XX) += jornada680_kbd.o
obj-$(CONFIG_KEYBOARD_HP7XX) += jornada720_kbd.o
obj-$(CONFIG_KEYBOARD_LKKBD) += lkkbd.o
diff --git a/drivers/input/keyboard/imx_sc_pwrkey.c
b/drivers/input/keyboard/imx_sc_pwrkey.c
new file mode 100644
index 000..53aa9a4
--- /dev/null
+++ b/drivers/input/keyboard/imx_sc_pwrkey.c
@@ -0,0 +1,169 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2019 NXP.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#define DEBOUNCE_TIME 100
+#define REPEAT_INTERVAL60
+
+#define SC_IRQ_BUTTON 1
+#define SC_IRQ_GROUP_WAKE 3
+#define IMX_SC_MISC_FUNC_GET_BUTTON_STATUS 18
+
+struct imx_pwrkey_drv_data {
+ int keycode;
+ bool keystate; /* 1: pressed, 0: release */
+ bool delay_check;
+ struct delayed_work check_work;
+ struct input_dev *input;
+};
+
+struct imx_sc_msg_pwrkey {
+ struct imx_sc_rpc_msg hdr;
+ u8 state;
+};
+static struct imx_pwrkey_drv_data *pdata;
Why is it global struct? It seems to be flexible configurable over devicetree.
So I would assume it should be able to handle more then one button. Please
remove global variables, make it allocatable per OF node.
There is ONLY one button available for SC key, but yes, I think I can make the
structure
private and get all necessary data from the structure using container_of.
And we will never need more then 640 kB RAM ;)
https://en.wikiquote.org/wiki/Talk:Bill_Gates
Please use different name "pdata" is usually used as platform data. Please,
use "priv".
OK.
+static struct imx_sc_ipc *pwrkey_ipc_handle;
same as before, no global variables.
Will move it into private platform data structure.
+
+static int imx_sc_pwrkey_notify(struct notifier_block *nb,
+ unsigned long event, void *group) {
+ if ((event & SC_IRQ_BUTTON) && (*(u8 *)group ==
SC_IRQ_GROUP_WAKE)
+ && !pdata->delay_check) {
+ pdata->delay_check = 1;
+ schedule_delayed_work(>check_work,
+ msecs_to_jiffies(REPEAT_INTERVAL));
+ }
+
+ return 0;
+}
+
+static void imx_sc_check_for_events(struct work_struct *work) {
+ struct input_dev *input = pdata->input;
+ struct imx_sc_msg_pwrkey msg;
+ struct imx_sc_rpc_msg
RE: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Hi, Oleksij
> On 03.09.19 16:03, Anson Huang wrote:
> > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> > inside, the system controller is in charge of controlling power, clock
> > and power key etc..
> >
> > Adds i.MX system controller power key driver support, Linux kernel has
> > to communicate with system controller via MU (message unit) IPC to get
> > power key's status.
> >
> > Signed-off-by: Anson Huang
> > ---
> > Changes since V1:
> > - remove "wakeup-source" property operation, scu power key uses
> generic scu irq,
> > no need to have this property for device wakeup operation.
> > ---
> > drivers/input/keyboard/Kconfig | 7 ++
> > drivers/input/keyboard/Makefile| 1 +
> > drivers/input/keyboard/imx_sc_pwrkey.c | 169
> +
> > 3 files changed, 177 insertions(+)
> > create mode 100644 drivers/input/keyboard/imx_sc_pwrkey.c
> >
> > diff --git a/drivers/input/keyboard/Kconfig
> > b/drivers/input/keyboard/Kconfig index 2e6d288..3aaeb9c 100644
> > --- a/drivers/input/keyboard/Kconfig
> > +++ b/drivers/input/keyboard/Kconfig
> > @@ -469,6 +469,13 @@ config KEYBOARD_IMX
> > To compile this driver as a module, choose M here: the
> > module will be called imx_keypad.
> >
> > +config KEYBOARD_IMX_SC_PWRKEY
> > + tristate "IMX SCU Power Key Driver"
> > + depends on IMX_SCU
> > + help
> > + This is the system controller powerkey driver for NXP i.MX SoCs with
> > + system controller inside.
>
> The KEY is configurable over devicetree, why is it called PWRKEY? It looks for
> me as generic SCU key handler.
We always use it as power key, NOT a generic key, as it has HW function designed
for power key purpose.
>
> > config KEYBOARD_NEWTON
> > tristate "Newton keyboard"
> > select SERIO
> > diff --git a/drivers/input/keyboard/Makefile
> > b/drivers/input/keyboard/Makefile index 9510325..9ea5585 100644
> > --- a/drivers/input/keyboard/Makefile
> > +++ b/drivers/input/keyboard/Makefile
> > @@ -29,6 +29,7 @@ obj-$(CONFIG_KEYBOARD_HIL)+= hil_kbd.o
> > obj-$(CONFIG_KEYBOARD_HIL_OLD)+= hilkbd.o
> > obj-$(CONFIG_KEYBOARD_IPAQ_MICRO) += ipaq-micro-keys.o
> > obj-$(CONFIG_KEYBOARD_IMX)+= imx_keypad.o
> > +obj-$(CONFIG_KEYBOARD_IMX_SC_PWRKEY) += imx_sc_pwrkey.o
> > obj-$(CONFIG_KEYBOARD_HP6XX) += jornada680_kbd.o
> > obj-$(CONFIG_KEYBOARD_HP7XX) += jornada720_kbd.o
> > obj-$(CONFIG_KEYBOARD_LKKBD) += lkkbd.o
> > diff --git a/drivers/input/keyboard/imx_sc_pwrkey.c
> > b/drivers/input/keyboard/imx_sc_pwrkey.c
> > new file mode 100644
> > index 000..53aa9a4
> > --- /dev/null
> > +++ b/drivers/input/keyboard/imx_sc_pwrkey.c
> > @@ -0,0 +1,169 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright 2019 NXP.
> > + */
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +
> > +#define DEBOUNCE_TIME 100
> > +#define REPEAT_INTERVAL60
> > +
> > +#define SC_IRQ_BUTTON 1
> > +#define SC_IRQ_GROUP_WAKE 3
> > +#define IMX_SC_MISC_FUNC_GET_BUTTON_STATUS 18
> > +
> > +struct imx_pwrkey_drv_data {
> > + int keycode;
> > + bool keystate; /* 1: pressed, 0: release */
> > + bool delay_check;
> > + struct delayed_work check_work;
> > + struct input_dev *input;
> > +};
> > +
> > +struct imx_sc_msg_pwrkey {
> > + struct imx_sc_rpc_msg hdr;
> > + u8 state;
> > +};
> > +static struct imx_pwrkey_drv_data *pdata;
>
> Why is it global struct? It seems to be flexible configurable over devicetree.
> So I would assume it should be able to handle more then one button. Please
> remove global variables, make it allocatable per OF node.
There is ONLY one button available for SC key, but yes, I think I can make the
structure
private and get all necessary data from the structure using container_of.
>
> Please use different name "pdata" is usually used as platform data. Please,
> use "priv".
OK.
>
> > +static struct imx_sc_ipc *pwrkey_ipc_handle;
>
> same as before, no global variables.
Will move it into private platform data structure.
>
> > +
> > +static int imx_sc_pwrkey_notify(struct notifier_block *nb,
> > + unsigned long event, void *group) {
> > + if ((event & SC_IRQ_BUTTON) && (*(u8 *)group ==
> SC_IRQ_GROUP_WAKE)
> > + && !pdata->delay_check) {
> > + pdata->delay_check = 1;
> > + schedule_delayed_work(>check_work,
> > + msecs_to_jiffies(REPEAT_INTERVAL));
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static void imx_sc_check_for_events(struct work_struct *work) {
> > + struct input_dev *input = pdata->input;
> > + struct imx_sc_msg_pwrkey msg;
> > + struct imx_sc_rpc_msg *hdr =
> > + bool state;
> > +
> > + hdr->ver =
Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Hi,
On 03.09.19 16:03, Anson Huang wrote:
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
inside, the system controller is in charge of controlling power,
clock and power key etc..
Adds i.MX system controller power key driver support, Linux kernel
has to communicate with system controller via MU (message unit) IPC
to get power key's status.
Signed-off-by: Anson Huang
---
Changes since V1:
- remove "wakeup-source" property operation, scu power key uses generic
scu irq,
no need to have this property for device wakeup operation.
---
drivers/input/keyboard/Kconfig | 7 ++
drivers/input/keyboard/Makefile| 1 +
drivers/input/keyboard/imx_sc_pwrkey.c | 169 +
3 files changed, 177 insertions(+)
create mode 100644 drivers/input/keyboard/imx_sc_pwrkey.c
diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 2e6d288..3aaeb9c 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -469,6 +469,13 @@ config KEYBOARD_IMX
To compile this driver as a module, choose M here: the
module will be called imx_keypad.
+config KEYBOARD_IMX_SC_PWRKEY
+ tristate "IMX SCU Power Key Driver"
+ depends on IMX_SCU
+ help
+ This is the system controller powerkey driver for NXP i.MX SoCs with
+ system controller inside.
The KEY is configurable over devicetree, why is it called PWRKEY? It looks for me as
generic SCU key handler.
config KEYBOARD_NEWTON
tristate "Newton keyboard"
select SERIO
diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile
index 9510325..9ea5585 100644
--- a/drivers/input/keyboard/Makefile
+++ b/drivers/input/keyboard/Makefile
@@ -29,6 +29,7 @@ obj-$(CONFIG_KEYBOARD_HIL)+= hil_kbd.o
obj-$(CONFIG_KEYBOARD_HIL_OLD)+= hilkbd.o
obj-$(CONFIG_KEYBOARD_IPAQ_MICRO) += ipaq-micro-keys.o
obj-$(CONFIG_KEYBOARD_IMX)+= imx_keypad.o
+obj-$(CONFIG_KEYBOARD_IMX_SC_PWRKEY) += imx_sc_pwrkey.o
obj-$(CONFIG_KEYBOARD_HP6XX) += jornada680_kbd.o
obj-$(CONFIG_KEYBOARD_HP7XX) += jornada720_kbd.o
obj-$(CONFIG_KEYBOARD_LKKBD) += lkkbd.o
diff --git a/drivers/input/keyboard/imx_sc_pwrkey.c
b/drivers/input/keyboard/imx_sc_pwrkey.c
new file mode 100644
index 000..53aa9a4
--- /dev/null
+++ b/drivers/input/keyboard/imx_sc_pwrkey.c
@@ -0,0 +1,169 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2019 NXP.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#define DEBOUNCE_TIME 100
+#define REPEAT_INTERVAL60
+
+#define SC_IRQ_BUTTON 1
+#define SC_IRQ_GROUP_WAKE 3
+#define IMX_SC_MISC_FUNC_GET_BUTTON_STATUS 18
+
+struct imx_pwrkey_drv_data {
+ int keycode;
+ bool keystate; /* 1: pressed, 0: release */
+ bool delay_check;
+ struct delayed_work check_work;
+ struct input_dev *input;
+};
+
+struct imx_sc_msg_pwrkey {
+ struct imx_sc_rpc_msg hdr;
+ u8 state;
+};
+static struct imx_pwrkey_drv_data *pdata;
Why is it global struct? It seems to be flexible configurable over devicetree. So I would
assume it should be able to handle more then one button. Please remove global variables,
make it allocatable per OF node.
Please use different name "pdata" is usually used as platform data. Please, use
"priv".
+static struct imx_sc_ipc *pwrkey_ipc_handle;
same as before, no global variables.
+
+static int imx_sc_pwrkey_notify(struct notifier_block *nb,
+ unsigned long event, void *group)
+{
+ if ((event & SC_IRQ_BUTTON) && (*(u8 *)group == SC_IRQ_GROUP_WAKE)
+ && !pdata->delay_check) {
+ pdata->delay_check = 1;
+ schedule_delayed_work(>check_work,
+ msecs_to_jiffies(REPEAT_INTERVAL));
+ }
+
+ return 0;
+}
+
+static void imx_sc_check_for_events(struct work_struct *work)
+{
+ struct input_dev *input = pdata->input;
+ struct imx_sc_msg_pwrkey msg;
+ struct imx_sc_rpc_msg *hdr =
+ bool state;
+
+ hdr->ver = IMX_SC_RPC_VERSION;
+ hdr->svc = IMX_SC_RPC_SVC_MISC;
+ hdr->func = IMX_SC_MISC_FUNC_GET_BUTTON_STATUS;
+ hdr->size = 1;
+
+ /*
+* Current SCU firmware does NOT have return value for
+* this API, that means it is always successful.
+*/
It is not true for the kernel part:
https://elixir.bootlin.com/linux/latest/source/drivers/firmware/imx/imx-scu.c#L157
imx_scu_call_rpc() may fail in different ways and provide proper error value.
Please use it.
+ imx_scu_call_rpc(pwrkey_ipc_handle, , true); > + state =
msg.state;
the conversation u8 to bool should be done here.
+
+ if (!state && !pdata->keystate)
+ state =
Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
On Mon, Sep 2, 2019 at 8:11 PM Anson Huang wrote:
>
> Hi, Fabio
>
> > On Mon, Sep 2, 2019 at 11:05 PM Anson Huang
> > wrote:
> >
> > > + ret = input_register_device(input);
> > > + if (ret < 0) {
> > > + dev_err(>dev, "failed to register input device\n");
> > > + return ret;
> > > + }
> > > +
> > > + pdata->input = input;
> > > + platform_set_drvdata(pdev, pdata);
> > > +
> > > + ret = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE,
> > SC_IRQ_BUTTON, true);
> > > + if (ret) {
> > > + dev_warn(>dev, "enable scu group irq failed\n");
> > > + return ret;
> >
> > Better do a 'goto input_unregister' here instead and call
> > input_unregister_device().
>
> Agreed, will fix in V3 later.
Not needed actually as input device is managed by devm.
Thanks.
--
Dmitry
RE: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Hi, Fabio
> On Mon, Sep 2, 2019 at 11:05 PM Anson Huang
> wrote:
>
> > + ret = input_register_device(input);
> > + if (ret < 0) {
> > + dev_err(>dev, "failed to register input device\n");
> > + return ret;
> > + }
> > +
> > + pdata->input = input;
> > + platform_set_drvdata(pdev, pdata);
> > +
> > + ret = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE,
> SC_IRQ_BUTTON, true);
> > + if (ret) {
> > + dev_warn(>dev, "enable scu group irq failed\n");
> > + return ret;
>
> Better do a 'goto input_unregister' here instead and call
> input_unregister_device().
Agreed, will fix in V3 later.
Thanks,
Anson.
Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Hi Anson,
On Mon, Sep 2, 2019 at 11:05 PM Anson Huang wrote:
> + ret = input_register_device(input);
> + if (ret < 0) {
> + dev_err(>dev, "failed to register input device\n");
> + return ret;
> + }
> +
> + pdata->input = input;
> + platform_set_drvdata(pdev, pdata);
> +
> + ret = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE, SC_IRQ_BUTTON,
> true);
> + if (ret) {
> + dev_warn(>dev, "enable scu group irq failed\n");
> + return ret;
Better do a 'goto input_unregister' here instead and call
input_unregister_device().
