Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Thu, 2015-09-10 at 20:59 -0500, Zhao Qiang-B45475 wrote: > On Mon, 2015-09-11 at 06:09 -0500, Wood Scott-B07421 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Friday, September 11, 2015 6:09 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li > > Yang-Leo-R58472; pau...@samba.org > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > > muram > > > > On Wed, 2015-09-09 at 21:34 -0500, Zhao Qiang-B45475 wrote: > > > On Mon, 2015-09-10 at 12:39 -0500, Wood Scott-B07421 wrote: > > > > > > > -Original Message- > > > > From: Wood Scott-B07421 > > > > Sent: Thursday, September 10, 2015 12:39 AM > > > > To: Zhao Qiang-B45475 > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; > > > > Li Yang-Leo-R58472; pau...@samba.org > > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to > > > > manage muram > > > > > > > > On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > > > > > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > > > > > -Original Message- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, September 02, 2015 8:34 AM > > > > > > To: Zhao Qiang-B45475 > > > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > > > > > lau...@codeaurora.org; Xie Xiaobo-R63061; > > > > > > b...@kernel.crashing.org; Li Yang-Leo-R58472; pau...@samba.org > > > > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions > > > > > > to manage muram > > > > > > > > > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > > > > > > > > > @@ -187,12 +190,25 @@ static inline int > > > > > > > qe_alive_during_sleep(void) } > > > > > > > > > > > > > > /* we actually use cpm_muram implementation, define this for > > > > > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > > > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > > > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free > > > > > > > -#define qe_muram_addr cpm_muram_addr -#define qe_muram_offset > > > > > > > cpm_muram_offset > > > > > > > +#define cpm_muram_init qe_muram_init #define cpm_muram_alloc > > > > > > > +qe_muram_alloc #define cpm_muram_alloc_fixed > > > > > > > +qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free > > > > > > > +#define cpm_muram_addr qe_muram_addr #define cpm_muram_offset > > > > > > > +qe_muram_offset > > > > > > > > > > > > Why? This is unnecessary churn. > > > > > > > > > > > This is necessary. QE is on both ARM and PowerPC, its code is > > > > > under public code. > > > > > But CPM is only on PowerPC and its code is under PowerPC. > > > > > So when build ARM, QE will not find cpm_muram_* function. > > > > > > > > If you move the cpm_muram functions to drivers/soc, then ARM will > > > > find them. > > > > There is no need to rename them. > > > > > > Yes, moving cpm_muram can handle this issue. However, cpm is not > > > necessary To move to public code, and a churn is simpler than moving > > cpm_muram. > > > Please consider my suggestion, Thank you! > > > > What do you mean by "public code"? You're already moving cpm_muram. I'm > > just asking that you not rename it while you do so. If it absolutely > > must be renamed, do it in a different patch from the one that moves the > > code, though I don't see why the rename is helpful. > > "Public code" is "driver/soc" here. I moved the qe_muram into driver/soc, > not cpm_muram, They are the same thing. > And the functions are named qe_muram_*, Only after you renamed them. Before that they were just #defined aliases. > and removed cpm_muram_*, let cpm_muram > Use the same functions code with qe_muram, and define cpm_muram_* > qe_muram_*. > > Previously, cpm/qe-muram functions are named cpm_muram_* because CPM is the > predecessor > Of QE, Yes, and just because marketing decided they wanted to change the name when they came out with a new version doesn't mean we need to rename infrastructure that is common between them. E.g. we still classify PPC QorIQ chips as "mpc85xx". Again, if you really want to do the rename, at least do it in a separate patch from moving the code, so that git will detect the code movement and we can see if anything else changed during the move. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Mon, 2015-09-11 at 06:09 -0500, Wood Scott-B07421 wrote:
> -Original Message-
> From: Wood Scott-B07421
> Sent: Friday, September 11, 2015 6:09 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> Yang-Leo-R58472; pau...@samba.org
> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> muram
>
> On Wed, 2015-09-09 at 21:34 -0500, Zhao Qiang-B45475 wrote:
> > On Mon, 2015-09-10 at 12:39 -0500, Wood Scott-B07421 wrote:
> >
> > > -Original Message-
> > > From: Wood Scott-B07421
> > > Sent: Thursday, September 10, 2015 12:39 AM
> > > To: Zhao Qiang-B45475
> > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org;
> > > Li Yang-Leo-R58472; pau...@samba.org
> > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to
> > > manage muram
> > >
> > > On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote:
> > > > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote:
> > > > > -Original Message-
> > > > > From: Wood Scott-B07421
> > > > > Sent: Wednesday, September 02, 2015 8:34 AM
> > > > > To: Zhao Qiang-B45475
> > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> > > > > lau...@codeaurora.org; Xie Xiaobo-R63061;
> > > > > b...@kernel.crashing.org; Li Yang-Leo-R58472; pau...@samba.org
> > > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions
> > > > > to manage muram
> > > > >
> > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> > > > >
> > > > > > @@ -187,12 +190,25 @@ static inline int
> > > > > > qe_alive_during_sleep(void) }
> > > > > >
> > > > > > /* we actually use cpm_muram implementation, define this for
> > > > > > convenience */ -#define qe_muram_init cpm_muram_init -#define
> > > > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed
> > > > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free
> > > > > > -#define qe_muram_addr cpm_muram_addr -#define qe_muram_offset
> > > > > > cpm_muram_offset
> > > > > > +#define cpm_muram_init qe_muram_init #define cpm_muram_alloc
> > > > > > +qe_muram_alloc #define cpm_muram_alloc_fixed
> > > > > > +qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free
> > > > > > +#define cpm_muram_addr qe_muram_addr #define cpm_muram_offset
> > > > > > +qe_muram_offset
> > > > >
> > > > > Why? This is unnecessary churn.
> > > > >
> > > > This is necessary. QE is on both ARM and PowerPC, its code is
> > > > under public code.
> > > > But CPM is only on PowerPC and its code is under PowerPC.
> > > > So when build ARM, QE will not find cpm_muram_* function.
> > >
> > > If you move the cpm_muram functions to drivers/soc, then ARM will
> > > find them.
> > > There is no need to rename them.
> >
> > Yes, moving cpm_muram can handle this issue. However, cpm is not
> > necessary To move to public code, and a churn is simpler than moving
> cpm_muram.
> > Please consider my suggestion, Thank you!
>
> What do you mean by "public code"? You're already moving cpm_muram. I'm
> just asking that you not rename it while you do so. If it absolutely
> must be renamed, do it in a different patch from the one that moves the
> code, though I don't see why the rename is helpful.
"Public code" is "driver/soc" here. I moved the qe_muram into driver/soc, not
cpm_muram,
And the functions are named qe_muram_*, and removed cpm_muram_*, let cpm_muram
Use the same functions code with qe_muram, and define cpm_muram_* qe_muram_*.
Previously, cpm/qe-muram functions are named cpm_muram_* because CPM is the
predecessor
Of QE, and "define qe_muram_* cpm_muram_*". Now, because QE support both ARM
and PowerPC,
move qe to driver/soc, and move the cpm/qe-muram functions to drver/soc too. So
name the
functions qe_muram_*, and "define cpm_muram_* qe_muram_*"
>
> -Scott
>
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Wed, 2015-09-09 at 21:34 -0500, Zhao Qiang-B45475 wrote: > On Mon, 2015-09-10 at 12:39 -0500, Wood Scott-B07421 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Thursday, September 10, 2015 12:39 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li > > Yang-Leo-R58472; pau...@samba.org > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > > muram > > > > On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > > > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > > > -Original Message- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 02, 2015 8:34 AM > > > > To: Zhao Qiang-B45475 > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; > > > > Li Yang-Leo-R58472; pau...@samba.org > > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to > > > > manage muram > > > > > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > > > > > @@ -187,12 +190,25 @@ static inline int > > > > > qe_alive_during_sleep(void) } > > > > > > > > > > /* we actually use cpm_muram implementation, define this for > > > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free > > > > > -#define qe_muram_addr cpm_muram_addr -#define qe_muram_offset > > > > > cpm_muram_offset > > > > > +#define cpm_muram_init qe_muram_init #define cpm_muram_alloc > > > > > +qe_muram_alloc #define cpm_muram_alloc_fixed qe_muram_alloc_fixed > > > > > +#define cpm_muram_free qe_muram_free #define cpm_muram_addr > > > > > +qe_muram_addr #define cpm_muram_offset qe_muram_offset > > > > > > > > Why? This is unnecessary churn. > > > > > > > This is necessary. QE is on both ARM and PowerPC, its code is under > > > public code. > > > But CPM is only on PowerPC and its code is under PowerPC. > > > So when build ARM, QE will not find cpm_muram_* function. > > > > If you move the cpm_muram functions to drivers/soc, then ARM will find > > them. > > There is no need to rename them. > > Yes, moving cpm_muram can handle this issue. However, cpm is not necessary > To move to public code, and a churn is simpler than moving cpm_muram. > Please consider my suggestion, Thank you! What do you mean by "public code"? You're already moving cpm_muram. I'm just asking that you not rename it while you do so. If it absolutely must be renamed, do it in a different patch from the one that moves the code, though I don't see why the rename is helpful. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Mon, 2015-09-11 at 06:09 -0500, Wood Scott-B07421 wrote:
> -Original Message-
> From: Wood Scott-B07421
> Sent: Friday, September 11, 2015 6:09 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> Yang-Leo-R58472; pau...@samba.org
> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> muram
>
> On Wed, 2015-09-09 at 21:34 -0500, Zhao Qiang-B45475 wrote:
> > On Mon, 2015-09-10 at 12:39 -0500, Wood Scott-B07421 wrote:
> >
> > > -Original Message-
> > > From: Wood Scott-B07421
> > > Sent: Thursday, September 10, 2015 12:39 AM
> > > To: Zhao Qiang-B45475
> > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org;
> > > Li Yang-Leo-R58472; pau...@samba.org
> > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to
> > > manage muram
> > >
> > > On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote:
> > > > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote:
> > > > > -Original Message-
> > > > > From: Wood Scott-B07421
> > > > > Sent: Wednesday, September 02, 2015 8:34 AM
> > > > > To: Zhao Qiang-B45475
> > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> > > > > lau...@codeaurora.org; Xie Xiaobo-R63061;
> > > > > b...@kernel.crashing.org; Li Yang-Leo-R58472; pau...@samba.org
> > > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions
> > > > > to manage muram
> > > > >
> > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> > > > >
> > > > > > @@ -187,12 +190,25 @@ static inline int
> > > > > > qe_alive_during_sleep(void) }
> > > > > >
> > > > > > /* we actually use cpm_muram implementation, define this for
> > > > > > convenience */ -#define qe_muram_init cpm_muram_init -#define
> > > > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed
> > > > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free
> > > > > > -#define qe_muram_addr cpm_muram_addr -#define qe_muram_offset
> > > > > > cpm_muram_offset
> > > > > > +#define cpm_muram_init qe_muram_init #define cpm_muram_alloc
> > > > > > +qe_muram_alloc #define cpm_muram_alloc_fixed
> > > > > > +qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free
> > > > > > +#define cpm_muram_addr qe_muram_addr #define cpm_muram_offset
> > > > > > +qe_muram_offset
> > > > >
> > > > > Why? This is unnecessary churn.
> > > > >
> > > > This is necessary. QE is on both ARM and PowerPC, its code is
> > > > under public code.
> > > > But CPM is only on PowerPC and its code is under PowerPC.
> > > > So when build ARM, QE will not find cpm_muram_* function.
> > >
> > > If you move the cpm_muram functions to drivers/soc, then ARM will
> > > find them.
> > > There is no need to rename them.
> >
> > Yes, moving cpm_muram can handle this issue. However, cpm is not
> > necessary To move to public code, and a churn is simpler than moving
> cpm_muram.
> > Please consider my suggestion, Thank you!
>
> What do you mean by "public code"? You're already moving cpm_muram. I'm
> just asking that you not rename it while you do so. If it absolutely
> must be renamed, do it in a different patch from the one that moves the
> code, though I don't see why the rename is helpful.
"Public code" is "driver/soc" here. I moved the qe_muram into driver/soc, not
cpm_muram,
And the functions are named qe_muram_*, and removed cpm_muram_*, let cpm_muram
Use the same functions code with qe_muram, and define cpm_muram_* qe_muram_*.
Previously, cpm/qe-muram functions are named cpm_muram_* because CPM is the
predecessor
Of QE, and "define qe_muram_* cpm_muram_*". Now, because QE support both ARM
and PowerPC,
move qe to driver/soc, and move the cpm/qe-muram functions to drver/soc too. So
name the
functions qe_muram_*, and "define cpm_muram_* qe_muram_*"
>
> -Scott
>
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Wed, 2015-09-09 at 21:34 -0500, Zhao Qiang-B45475 wrote: > On Mon, 2015-09-10 at 12:39 -0500, Wood Scott-B07421 wrote: > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Thursday, September 10, 2015 12:39 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li > > Yang-Leo-R58472; pau...@samba.org > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > > muram > > > > On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > > > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > > > -Original Message- > > > > From: Wood Scott-B07421 > > > > Sent: Wednesday, September 02, 2015 8:34 AM > > > > To: Zhao Qiang-B45475 > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; > > > > Li Yang-Leo-R58472; pau...@samba.org > > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to > > > > manage muram > > > > > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > > > > > @@ -187,12 +190,25 @@ static inline int > > > > > qe_alive_during_sleep(void) } > > > > > > > > > > /* we actually use cpm_muram implementation, define this for > > > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free > > > > > -#define qe_muram_addr cpm_muram_addr -#define qe_muram_offset > > > > > cpm_muram_offset > > > > > +#define cpm_muram_init qe_muram_init #define cpm_muram_alloc > > > > > +qe_muram_alloc #define cpm_muram_alloc_fixed qe_muram_alloc_fixed > > > > > +#define cpm_muram_free qe_muram_free #define cpm_muram_addr > > > > > +qe_muram_addr #define cpm_muram_offset qe_muram_offset > > > > > > > > Why? This is unnecessary churn. > > > > > > > This is necessary. QE is on both ARM and PowerPC, its code is under > > > public code. > > > But CPM is only on PowerPC and its code is under PowerPC. > > > So when build ARM, QE will not find cpm_muram_* function. > > > > If you move the cpm_muram functions to drivers/soc, then ARM will find > > them. > > There is no need to rename them. > > Yes, moving cpm_muram can handle this issue. However, cpm is not necessary > To move to public code, and a churn is simpler than moving cpm_muram. > Please consider my suggestion, Thank you! What do you mean by "public code"? You're already moving cpm_muram. I'm just asking that you not rename it while you do so. If it absolutely must be renamed, do it in a different patch from the one that moves the code, though I don't see why the rename is helpful. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Thu, 2015-09-10 at 20:59 -0500, Zhao Qiang-B45475 wrote: > On Mon, 2015-09-11 at 06:09 -0500, Wood Scott-B07421 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Friday, September 11, 2015 6:09 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li > > Yang-Leo-R58472; pau...@samba.org > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > > muram > > > > On Wed, 2015-09-09 at 21:34 -0500, Zhao Qiang-B45475 wrote: > > > On Mon, 2015-09-10 at 12:39 -0500, Wood Scott-B07421 wrote: > > > > > > > -Original Message- > > > > From: Wood Scott-B07421 > > > > Sent: Thursday, September 10, 2015 12:39 AM > > > > To: Zhao Qiang-B45475 > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; > > > > Li Yang-Leo-R58472; pau...@samba.org > > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to > > > > manage muram > > > > > > > > On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > > > > > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > > > > > -Original Message- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Wednesday, September 02, 2015 8:34 AM > > > > > > To: Zhao Qiang-B45475 > > > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > > > > > lau...@codeaurora.org; Xie Xiaobo-R63061; > > > > > > b...@kernel.crashing.org; Li Yang-Leo-R58472; pau...@samba.org > > > > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions > > > > > > to manage muram > > > > > > > > > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > > > > > > > > > @@ -187,12 +190,25 @@ static inline int > > > > > > > qe_alive_during_sleep(void) } > > > > > > > > > > > > > > /* we actually use cpm_muram implementation, define this for > > > > > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > > > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > > > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free > > > > > > > -#define qe_muram_addr cpm_muram_addr -#define qe_muram_offset > > > > > > > cpm_muram_offset > > > > > > > +#define cpm_muram_init qe_muram_init #define cpm_muram_alloc > > > > > > > +qe_muram_alloc #define cpm_muram_alloc_fixed > > > > > > > +qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free > > > > > > > +#define cpm_muram_addr qe_muram_addr #define cpm_muram_offset > > > > > > > +qe_muram_offset > > > > > > > > > > > > Why? This is unnecessary churn. > > > > > > > > > > > This is necessary. QE is on both ARM and PowerPC, its code is > > > > > under public code. > > > > > But CPM is only on PowerPC and its code is under PowerPC. > > > > > So when build ARM, QE will not find cpm_muram_* function. > > > > > > > > If you move the cpm_muram functions to drivers/soc, then ARM will > > > > find them. > > > > There is no need to rename them. > > > > > > Yes, moving cpm_muram can handle this issue. However, cpm is not > > > necessary To move to public code, and a churn is simpler than moving > > cpm_muram. > > > Please consider my suggestion, Thank you! > > > > What do you mean by "public code"? You're already moving cpm_muram. I'm > > just asking that you not rename it while you do so. If it absolutely > > must be renamed, do it in a different patch from the one that moves the > > code, though I don't see why the rename is helpful. > > "Public code" is "driver/soc" here. I moved the qe_muram into driver/soc, > not cpm_muram, They are the same thing. > And the functions are named qe_muram_*, Only after you renamed them. Before that they were just #defined aliases. > and removed cpm_muram_*, let cpm_muram > Use the same functions code with qe_muram, and define cpm_muram_* > qe_muram_*. > > Previously, cpm/qe-muram functions are named cpm_muram_* because CPM is the > predecessor > Of QE, Yes, and just because marketing decided they wanted to change the name when they came out with a new version doesn't mean we need to rename infrastructure that is common between them. E.g. we still classify PPC QorIQ chips as "mpc85xx". Again, if you really want to do the rename, at least do it in a separate patch from moving the code, so that git will detect the code movement and we can see if anything else changed during the move. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Mon, 2015-09-10 at 12:39 -0500, Wood Scott-B07421 wrote: > -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, September 10, 2015 12:39 AM > To: Zhao Qiang-B45475 > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li > Yang-Leo-R58472; pau...@samba.org > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > muram > > On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > > -Original Message- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 02, 2015 8:34 AM > > > To: Zhao Qiang-B45475 > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; > > > Li Yang-Leo-R58472; pau...@samba.org > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to > > > manage muram > > > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > > > @@ -187,12 +190,25 @@ static inline int > > > > qe_alive_during_sleep(void) } > > > > > > > > /* we actually use cpm_muram implementation, define this for > > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free > > > > -#define qe_muram_addr cpm_muram_addr -#define qe_muram_offset > > > > cpm_muram_offset > > > > +#define cpm_muram_init qe_muram_init #define cpm_muram_alloc > > > > +qe_muram_alloc #define cpm_muram_alloc_fixed qe_muram_alloc_fixed > > > > +#define cpm_muram_free qe_muram_free #define cpm_muram_addr > > > > +qe_muram_addr #define cpm_muram_offset qe_muram_offset > > > > > > Why? This is unnecessary churn. > > > > > This is necessary. QE is on both ARM and PowerPC, its code is under > > public code. > > But CPM is only on PowerPC and its code is under PowerPC. > > So when build ARM, QE will not find cpm_muram_* function. > > If you move the cpm_muram functions to drivers/soc, then ARM will find > them. > There is no need to rename them. Yes, moving cpm_muram can handle this issue. However, cpm is not necessary To move to public code, and a churn is simpler than moving cpm_muram. Please consider my suggestion, Thank you! > > -Scott
Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 02, 2015 8:34 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li > > Yang-Leo-R58472; pau...@samba.org > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > > muram > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > @@ -187,12 +190,25 @@ static inline int qe_alive_during_sleep(void) } > > > > > > /* we actually use cpm_muram implementation, define this for > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free -#define > > > qe_muram_addr cpm_muram_addr -#define qe_muram_offset cpm_muram_offset > > > +#define cpm_muram_init qe_muram_init > > > +#define cpm_muram_alloc qe_muram_alloc #define cpm_muram_alloc_fixed > > > +qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free #define > > > +cpm_muram_addr qe_muram_addr #define cpm_muram_offset qe_muram_offset > > > > Why? This is unnecessary churn. > > > This is necessary. QE is on both ARM and PowerPC, its code is under public > code. > But CPM is only on PowerPC and its code is under PowerPC. > So when build ARM, QE will not find cpm_muram_* function. If you move the cpm_muram functions to drivers/soc, then ARM will find them. There is no need to rename them. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Mon, 2015-09-10 at 12:39 -0500, Wood Scott-B07421 wrote: > -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, September 10, 2015 12:39 AM > To: Zhao Qiang-B45475 > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li > Yang-Leo-R58472; pau...@samba.org > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > muram > > On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > > -Original Message- > > > From: Wood Scott-B07421 > > > Sent: Wednesday, September 02, 2015 8:34 AM > > > To: Zhao Qiang-B45475 > > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; > > > Li Yang-Leo-R58472; pau...@samba.org > > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to > > > manage muram > > > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > > > @@ -187,12 +190,25 @@ static inline int > > > > qe_alive_during_sleep(void) } > > > > > > > > /* we actually use cpm_muram implementation, define this for > > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free > > > > -#define qe_muram_addr cpm_muram_addr -#define qe_muram_offset > > > > cpm_muram_offset > > > > +#define cpm_muram_init qe_muram_init #define cpm_muram_alloc > > > > +qe_muram_alloc #define cpm_muram_alloc_fixed qe_muram_alloc_fixed > > > > +#define cpm_muram_free qe_muram_free #define cpm_muram_addr > > > > +qe_muram_addr #define cpm_muram_offset qe_muram_offset > > > > > > Why? This is unnecessary churn. > > > > > This is necessary. QE is on both ARM and PowerPC, its code is under > > public code. > > But CPM is only on PowerPC and its code is under PowerPC. > > So when build ARM, QE will not find cpm_muram_* function. > > If you move the cpm_muram functions to drivers/soc, then ARM will find > them. > There is no need to rename them. Yes, moving cpm_muram can handle this issue. However, cpm is not necessary To move to public code, and a churn is simpler than moving cpm_muram. Please consider my suggestion, Thank you! > > -Scott
Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Sun, 2015-09-06 at 01:37 -0500, Zhao Qiang-B45475 wrote: > On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote: > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, September 02, 2015 8:34 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li > > Yang-Leo-R58472; pau...@samba.org > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage > > muram > > > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote: > > > > > @@ -187,12 +190,25 @@ static inline int qe_alive_during_sleep(void) } > > > > > > /* we actually use cpm_muram implementation, define this for > > > convenience */ -#define qe_muram_init cpm_muram_init -#define > > > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed > > > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free -#define > > > qe_muram_addr cpm_muram_addr -#define qe_muram_offset cpm_muram_offset > > > +#define cpm_muram_init qe_muram_init > > > +#define cpm_muram_alloc qe_muram_alloc #define cpm_muram_alloc_fixed > > > +qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free #define > > > +cpm_muram_addr qe_muram_addr #define cpm_muram_offset qe_muram_offset > > > > Why? This is unnecessary churn. > > > This is necessary. QE is on both ARM and PowerPC, its code is under public > code. > But CPM is only on PowerPC and its code is under PowerPC. > So when build ARM, QE will not find cpm_muram_* function. If you move the cpm_muram functions to drivers/soc, then ARM will find them. There is no need to rename them. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote:
> -Original Message-
> From: Wood Scott-B07421
> Sent: Wednesday, September 02, 2015 8:34 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> Yang-Leo-R58472; pau...@samba.org
> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> muram
>
> On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
>
> > @@ -187,12 +190,25 @@ static inline int qe_alive_during_sleep(void) }
> >
> > /* we actually use cpm_muram implementation, define this for
> > convenience */ -#define qe_muram_init cpm_muram_init -#define
> > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed
> > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free -#define
> > qe_muram_addr cpm_muram_addr -#define qe_muram_offset cpm_muram_offset
> > +#define cpm_muram_init qe_muram_init
> > +#define cpm_muram_alloc qe_muram_alloc #define cpm_muram_alloc_fixed
> > +qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free #define
> > +cpm_muram_addr qe_muram_addr #define cpm_muram_offset qe_muram_offset
>
> Why? This is unnecessary churn.
>
This is necessary. QE is on both ARM and PowerPC, its code is under public code.
But CPM is only on PowerPC and its code is under PowerPC.
So when build ARM, QE will not find cpm_muram_* function.
>
>
> >
> > -int cpm_muram_init(void)
> > -{
> > - struct device_node *np;
> > - struct resource r;
> > - u32 zero[OF_MAX_ADDR_CELLS] = {};
> > - resource_size_t max = 0;
> > - int i = 0;
> > - int ret = 0;
> > -
> > - if (muram_pbase)
> > - return 0;
> > -
> > - spin_lock_init(_muram_lock);
> > - /* initialize the info header */
> > - rh_init(_muram_info, 1,
> > - sizeof(cpm_boot_muram_rh_block) /
> > - sizeof(cpm_boot_muram_rh_block[0]),
> > - cpm_boot_muram_rh_block);
> > -
> > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data");
> > - if (!np) {
> > - /* try legacy bindings */
> > - np = of_find_node_by_name(NULL, "data-only");
> > - if (!np) {
> > - printk(KERN_ERR "Cannot find CPM muram data
> node");
> > - ret = -ENODEV;
> > - goto out;
> > - }
> > - }
> > -
> > - muram_pbase = of_translate_address(np, zero);
> > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > - printk(KERN_ERR "Cannot translate zero through CPM muram
> node");
> > - ret = -ENODEV;
> > - goto out;
> > - }
> >
> -Scott
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Mon, 2015-09-2 at 8:34 +0800, Wood Scott-B07421 wrote:
> -Original Message-
> From: Wood Scott-B07421
> Sent: Wednesday, September 02, 2015 8:34 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> Yang-Leo-R58472; pau...@samba.org
> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> muram
>
> On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
>
> > @@ -187,12 +190,25 @@ static inline int qe_alive_during_sleep(void) }
> >
> > /* we actually use cpm_muram implementation, define this for
> > convenience */ -#define qe_muram_init cpm_muram_init -#define
> > qe_muram_alloc cpm_muram_alloc -#define qe_muram_alloc_fixed
> > cpm_muram_alloc_fixed -#define qe_muram_free cpm_muram_free -#define
> > qe_muram_addr cpm_muram_addr -#define qe_muram_offset cpm_muram_offset
> > +#define cpm_muram_init qe_muram_init
> > +#define cpm_muram_alloc qe_muram_alloc #define cpm_muram_alloc_fixed
> > +qe_muram_alloc_fixed #define cpm_muram_free qe_muram_free #define
> > +cpm_muram_addr qe_muram_addr #define cpm_muram_offset qe_muram_offset
>
> Why? This is unnecessary churn.
>
This is necessary. QE is on both ARM and PowerPC, its code is under public code.
But CPM is only on PowerPC and its code is under PowerPC.
So when build ARM, QE will not find cpm_muram_* function.
>
>
> >
> > -int cpm_muram_init(void)
> > -{
> > - struct device_node *np;
> > - struct resource r;
> > - u32 zero[OF_MAX_ADDR_CELLS] = {};
> > - resource_size_t max = 0;
> > - int i = 0;
> > - int ret = 0;
> > -
> > - if (muram_pbase)
> > - return 0;
> > -
> > - spin_lock_init(_muram_lock);
> > - /* initialize the info header */
> > - rh_init(_muram_info, 1,
> > - sizeof(cpm_boot_muram_rh_block) /
> > - sizeof(cpm_boot_muram_rh_block[0]),
> > - cpm_boot_muram_rh_block);
> > -
> > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data");
> > - if (!np) {
> > - /* try legacy bindings */
> > - np = of_find_node_by_name(NULL, "data-only");
> > - if (!np) {
> > - printk(KERN_ERR "Cannot find CPM muram data
> node");
> > - ret = -ENODEV;
> > - goto out;
> > - }
> > - }
> > -
> > - muram_pbase = of_translate_address(np, zero);
> > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > - printk(KERN_ERR "Cannot translate zero through CPM muram
> node");
> > - ret = -ENODEV;
> > - goto out;
> > - }
> >
> -Scott
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Wed, 2015-09-02 at 10:31AM, Wood Scott-B07421 wrote:
> -Original Message-
> From: Wood Scott-B07421
> Sent: Wednesday, September 02, 2015 10:31 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> Yang-Leo-R58472; pau...@samba.org
> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> muram
>
> On Tue, 2015-09-01 at 21:22 -0500, Zhao Qiang-B45475 wrote:
> > On Wed, 2015-09-02 at 8:34AM +0800, Wood Scott-B07421 wrote:
> > > -Original Message-
> > > From: Wood Scott-B07421
> > > Sent: Wednesday, September 02, 2015 8:34 AM
> > > To: Zhao Qiang-B45475
> > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org;
> > > Li Yang-Leo-R58472; pau...@samba.org
> > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to
> > > manage muram
> > >
> > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> > >
> > > > -int cpm_muram_init(void)
> > > > -{
> > > > - struct device_node *np;
> > > > - struct resource r;
> > > > - u32 zero[OF_MAX_ADDR_CELLS] = {};
> > > > - resource_size_t max = 0;
> > > > - int i = 0;
> > > > - int ret = 0;
> > > > -
> > > > - if (muram_pbase)
> > > > - return 0;
> > > > -
> > > > - spin_lock_init(_muram_lock);
> > > > - /* initialize the info header */
> > > > - rh_init(_muram_info, 1,
> > > > - sizeof(cpm_boot_muram_rh_block) /
> > > > - sizeof(cpm_boot_muram_rh_block[0]),
> > > > - cpm_boot_muram_rh_block);
> > > > -
> > > > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-
> data");
> > > > - if (!np) {
> > > > - /* try legacy bindings */
> > > > - np = of_find_node_by_name(NULL, "data-only");
> > > > - if (!np) {
> > > > - printk(KERN_ERR "Cannot find CPM muram data
> > > node");
> > > > - ret = -ENODEV;
> > > > - goto out;
> > > > - }
> > > > - }
> > > > -
> > > > - muram_pbase = of_translate_address(np, zero);
> > > > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > > > - printk(KERN_ERR "Cannot translate zero through CPM
> muram
> > > node");
> > > > - ret = -ENODEV;
> > > > - goto out;
> > > > - }
> > >
> > > Did you pass -M -C to git format-patch?
> >
> >
> > Yes!
>
> Then maybe it's the qe/cpm rename churn, or similar, that prevented it
> from being identified as a move?
Maybe
>
> -Scott
-Zhao
Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Tue, 2015-09-01 at 21:22 -0500, Zhao Qiang-B45475 wrote:
> On Wed, 2015-09-02 at 8:34AM +0800, Wood Scott-B07421 wrote:
> > -Original Message-
> > From: Wood Scott-B07421
> > Sent: Wednesday, September 02, 2015 8:34 AM
> > To: Zhao Qiang-B45475
> > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> > Yang-Leo-R58472; pau...@samba.org
> > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> > muram
> >
> > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> >
> > > -int cpm_muram_init(void)
> > > -{
> > > - struct device_node *np;
> > > - struct resource r;
> > > - u32 zero[OF_MAX_ADDR_CELLS] = {};
> > > - resource_size_t max = 0;
> > > - int i = 0;
> > > - int ret = 0;
> > > -
> > > - if (muram_pbase)
> > > - return 0;
> > > -
> > > - spin_lock_init(_muram_lock);
> > > - /* initialize the info header */
> > > - rh_init(_muram_info, 1,
> > > - sizeof(cpm_boot_muram_rh_block) /
> > > - sizeof(cpm_boot_muram_rh_block[0]),
> > > - cpm_boot_muram_rh_block);
> > > -
> > > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data");
> > > - if (!np) {
> > > - /* try legacy bindings */
> > > - np = of_find_node_by_name(NULL, "data-only");
> > > - if (!np) {
> > > - printk(KERN_ERR "Cannot find CPM muram data
> > node");
> > > - ret = -ENODEV;
> > > - goto out;
> > > - }
> > > - }
> > > -
> > > - muram_pbase = of_translate_address(np, zero);
> > > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > > - printk(KERN_ERR "Cannot translate zero through CPM muram
> > node");
> > > - ret = -ENODEV;
> > > - goto out;
> > > - }
> >
> > Did you pass -M -C to git format-patch?
>
>
> Yes!
Then maybe it's the qe/cpm rename churn, or similar, that prevented it from
being identified as a move?
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Wed, 2015-09-02 at 8:34AM +0800, Wood Scott-B07421 wrote:
> -Original Message-
> From: Wood Scott-B07421
> Sent: Wednesday, September 02, 2015 8:34 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> Yang-Leo-R58472; pau...@samba.org
> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> muram
>
> On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
>
> > -int cpm_muram_init(void)
> > -{
> > - struct device_node *np;
> > - struct resource r;
> > - u32 zero[OF_MAX_ADDR_CELLS] = {};
> > - resource_size_t max = 0;
> > - int i = 0;
> > - int ret = 0;
> > -
> > - if (muram_pbase)
> > - return 0;
> > -
> > - spin_lock_init(_muram_lock);
> > - /* initialize the info header */
> > - rh_init(_muram_info, 1,
> > - sizeof(cpm_boot_muram_rh_block) /
> > - sizeof(cpm_boot_muram_rh_block[0]),
> > - cpm_boot_muram_rh_block);
> > -
> > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data");
> > - if (!np) {
> > - /* try legacy bindings */
> > - np = of_find_node_by_name(NULL, "data-only");
> > - if (!np) {
> > - printk(KERN_ERR "Cannot find CPM muram data
> node");
> > - ret = -ENODEV;
> > - goto out;
> > - }
> > - }
> > -
> > - muram_pbase = of_translate_address(np, zero);
> > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > - printk(KERN_ERR "Cannot translate zero through CPM muram
> node");
> > - ret = -ENODEV;
> > - goto out;
> > - }
>
> Did you pass -M -C to git format-patch?
Yes!
>
> -Scott
-Zhao
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> @@ -187,12 +190,25 @@ static inline int qe_alive_during_sleep(void)
> }
>
> /* we actually use cpm_muram implementation, define this for convenience */
> -#define qe_muram_init cpm_muram_init
> -#define qe_muram_alloc cpm_muram_alloc
> -#define qe_muram_alloc_fixed cpm_muram_alloc_fixed
> -#define qe_muram_free cpm_muram_free
> -#define qe_muram_addr cpm_muram_addr
> -#define qe_muram_offset cpm_muram_offset
> +#define cpm_muram_init qe_muram_init
> +#define cpm_muram_alloc qe_muram_alloc
> +#define cpm_muram_alloc_fixed qe_muram_alloc_fixed
> +#define cpm_muram_free qe_muram_free
> +#define cpm_muram_addr qe_muram_addr
> +#define cpm_muram_offset qe_muram_offset
Why? This is unnecessary churn.
> @@ -266,6 +282,27 @@ struct qe_bd {
> #define BD_STATUS_MASK 0x
> #define BD_LENGTH_MASK 0x
>
> +/* Buffer descriptor control/status used by serial
> + */
> +
> +#define BD_SC_READY (0x8000)/* Transmit is ready */
> +#define BD_SC_WRAP (0x2000)/* Last buffer descriptor */
> +#define BD_SC_INTRPT (0x1000)/* Interrupt on change */
> +#define BD_SC_LAST (0x0800)/* Last buffer in frame */
> +#define BD_SC_TC (0x0400)/* Transmit CRC */
> +#define BD_SC_CM (0x0200)/* Continuous mode */
> +#define BD_SC_ID (0x0100)/* Rec'd too many idles */
> +#define BD_SC_P (0x0100)/* xmt preamble */
> +#define BD_SC_BR (0x0020)/* Break received */
> +#define BD_SC_FR (0x0010)/* Framing error */
> +#define BD_SC_PR (0x0008)/* Parity error */
> +#define BD_SC_NAK(0x0004)/* NAK - did not respond */
> +#define BD_SC_OV (0x0002)/* Overrun */
> +#define BD_SC_UN (0x0002)/* Underrun */
> +#define BD_SC_CD (0x0001)/* */
> +#define BD_SC_CL (0x0001)/* Collision */
> +
Why is this being copied rather than moved?
>
> -int cpm_muram_init(void)
> -{
> - struct device_node *np;
> - struct resource r;
> - u32 zero[OF_MAX_ADDR_CELLS] = {};
> - resource_size_t max = 0;
> - int i = 0;
> - int ret = 0;
> -
> - if (muram_pbase)
> - return 0;
> -
> - spin_lock_init(_muram_lock);
> - /* initialize the info header */
> - rh_init(_muram_info, 1,
> - sizeof(cpm_boot_muram_rh_block) /
> - sizeof(cpm_boot_muram_rh_block[0]),
> - cpm_boot_muram_rh_block);
> -
> - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data");
> - if (!np) {
> - /* try legacy bindings */
> - np = of_find_node_by_name(NULL, "data-only");
> - if (!np) {
> - printk(KERN_ERR "Cannot find CPM muram data node");
> - ret = -ENODEV;
> - goto out;
> - }
> - }
> -
> - muram_pbase = of_translate_address(np, zero);
> - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> - printk(KERN_ERR "Cannot translate zero through CPM muram node");
> - ret = -ENODEV;
> - goto out;
> - }
Did you pass -M -C to git format-patch?
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> @@ -187,12 +190,25 @@ static inline int qe_alive_during_sleep(void)
> }
>
> /* we actually use cpm_muram implementation, define this for convenience */
> -#define qe_muram_init cpm_muram_init
> -#define qe_muram_alloc cpm_muram_alloc
> -#define qe_muram_alloc_fixed cpm_muram_alloc_fixed
> -#define qe_muram_free cpm_muram_free
> -#define qe_muram_addr cpm_muram_addr
> -#define qe_muram_offset cpm_muram_offset
> +#define cpm_muram_init qe_muram_init
> +#define cpm_muram_alloc qe_muram_alloc
> +#define cpm_muram_alloc_fixed qe_muram_alloc_fixed
> +#define cpm_muram_free qe_muram_free
> +#define cpm_muram_addr qe_muram_addr
> +#define cpm_muram_offset qe_muram_offset
Why? This is unnecessary churn.
> @@ -266,6 +282,27 @@ struct qe_bd {
> #define BD_STATUS_MASK 0x
> #define BD_LENGTH_MASK 0x
>
> +/* Buffer descriptor control/status used by serial
> + */
> +
> +#define BD_SC_READY (0x8000)/* Transmit is ready */
> +#define BD_SC_WRAP (0x2000)/* Last buffer descriptor */
> +#define BD_SC_INTRPT (0x1000)/* Interrupt on change */
> +#define BD_SC_LAST (0x0800)/* Last buffer in frame */
> +#define BD_SC_TC (0x0400)/* Transmit CRC */
> +#define BD_SC_CM (0x0200)/* Continuous mode */
> +#define BD_SC_ID (0x0100)/* Rec'd too many idles */
> +#define BD_SC_P (0x0100)/* xmt preamble */
> +#define BD_SC_BR (0x0020)/* Break received */
> +#define BD_SC_FR (0x0010)/* Framing error */
> +#define BD_SC_PR (0x0008)/* Parity error */
> +#define BD_SC_NAK(0x0004)/* NAK - did not respond */
> +#define BD_SC_OV (0x0002)/* Overrun */
> +#define BD_SC_UN (0x0002)/* Underrun */
> +#define BD_SC_CD (0x0001)/* */
> +#define BD_SC_CL (0x0001)/* Collision */
> +
Why is this being copied rather than moved?
>
> -int cpm_muram_init(void)
> -{
> - struct device_node *np;
> - struct resource r;
> - u32 zero[OF_MAX_ADDR_CELLS] = {};
> - resource_size_t max = 0;
> - int i = 0;
> - int ret = 0;
> -
> - if (muram_pbase)
> - return 0;
> -
> - spin_lock_init(_muram_lock);
> - /* initialize the info header */
> - rh_init(_muram_info, 1,
> - sizeof(cpm_boot_muram_rh_block) /
> - sizeof(cpm_boot_muram_rh_block[0]),
> - cpm_boot_muram_rh_block);
> -
> - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data");
> - if (!np) {
> - /* try legacy bindings */
> - np = of_find_node_by_name(NULL, "data-only");
> - if (!np) {
> - printk(KERN_ERR "Cannot find CPM muram data node");
> - ret = -ENODEV;
> - goto out;
> - }
> - }
> -
> - muram_pbase = of_translate_address(np, zero);
> - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> - printk(KERN_ERR "Cannot translate zero through CPM muram node");
> - ret = -ENODEV;
> - goto out;
> - }
Did you pass -M -C to git format-patch?
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Wed, 2015-09-02 at 10:31AM, Wood Scott-B07421 wrote:
> -Original Message-
> From: Wood Scott-B07421
> Sent: Wednesday, September 02, 2015 10:31 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> Yang-Leo-R58472; pau...@samba.org
> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> muram
>
> On Tue, 2015-09-01 at 21:22 -0500, Zhao Qiang-B45475 wrote:
> > On Wed, 2015-09-02 at 8:34AM +0800, Wood Scott-B07421 wrote:
> > > -Original Message-
> > > From: Wood Scott-B07421
> > > Sent: Wednesday, September 02, 2015 8:34 AM
> > > To: Zhao Qiang-B45475
> > > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> > > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org;
> > > Li Yang-Leo-R58472; pau...@samba.org
> > > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to
> > > manage muram
> > >
> > > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> > >
> > > > -int cpm_muram_init(void)
> > > > -{
> > > > - struct device_node *np;
> > > > - struct resource r;
> > > > - u32 zero[OF_MAX_ADDR_CELLS] = {};
> > > > - resource_size_t max = 0;
> > > > - int i = 0;
> > > > - int ret = 0;
> > > > -
> > > > - if (muram_pbase)
> > > > - return 0;
> > > > -
> > > > - spin_lock_init(_muram_lock);
> > > > - /* initialize the info header */
> > > > - rh_init(_muram_info, 1,
> > > > - sizeof(cpm_boot_muram_rh_block) /
> > > > - sizeof(cpm_boot_muram_rh_block[0]),
> > > > - cpm_boot_muram_rh_block);
> > > > -
> > > > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-
> data");
> > > > - if (!np) {
> > > > - /* try legacy bindings */
> > > > - np = of_find_node_by_name(NULL, "data-only");
> > > > - if (!np) {
> > > > - printk(KERN_ERR "Cannot find CPM muram data
> > > node");
> > > > - ret = -ENODEV;
> > > > - goto out;
> > > > - }
> > > > - }
> > > > -
> > > > - muram_pbase = of_translate_address(np, zero);
> > > > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > > > - printk(KERN_ERR "Cannot translate zero through CPM
> muram
> > > node");
> > > > - ret = -ENODEV;
> > > > - goto out;
> > > > - }
> > >
> > > Did you pass -M -C to git format-patch?
> >
> >
> > Yes!
>
> Then maybe it's the qe/cpm rename churn, or similar, that prevented it
> from being identified as a move?
Maybe
>
> -Scott
-Zhao
RE: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Wed, 2015-09-02 at 8:34AM +0800, Wood Scott-B07421 wrote:
> -Original Message-
> From: Wood Scott-B07421
> Sent: Wednesday, September 02, 2015 8:34 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> Yang-Leo-R58472; pau...@samba.org
> Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> muram
>
> On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
>
> > -int cpm_muram_init(void)
> > -{
> > - struct device_node *np;
> > - struct resource r;
> > - u32 zero[OF_MAX_ADDR_CELLS] = {};
> > - resource_size_t max = 0;
> > - int i = 0;
> > - int ret = 0;
> > -
> > - if (muram_pbase)
> > - return 0;
> > -
> > - spin_lock_init(_muram_lock);
> > - /* initialize the info header */
> > - rh_init(_muram_info, 1,
> > - sizeof(cpm_boot_muram_rh_block) /
> > - sizeof(cpm_boot_muram_rh_block[0]),
> > - cpm_boot_muram_rh_block);
> > -
> > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data");
> > - if (!np) {
> > - /* try legacy bindings */
> > - np = of_find_node_by_name(NULL, "data-only");
> > - if (!np) {
> > - printk(KERN_ERR "Cannot find CPM muram data
> node");
> > - ret = -ENODEV;
> > - goto out;
> > - }
> > - }
> > -
> > - muram_pbase = of_translate_address(np, zero);
> > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > - printk(KERN_ERR "Cannot translate zero through CPM muram
> node");
> > - ret = -ENODEV;
> > - goto out;
> > - }
>
> Did you pass -M -C to git format-patch?
Yes!
>
> -Scott
-Zhao
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage muram
On Tue, 2015-09-01 at 21:22 -0500, Zhao Qiang-B45475 wrote:
> On Wed, 2015-09-02 at 8:34AM +0800, Wood Scott-B07421 wrote:
> > -Original Message-
> > From: Wood Scott-B07421
> > Sent: Wednesday, September 02, 2015 8:34 AM
> > To: Zhao Qiang-B45475
> > Cc: linux-kernel@vger.kernel.org; linuxppc-...@lists.ozlabs.org;
> > lau...@codeaurora.org; Xie Xiaobo-R63061; b...@kernel.crashing.org; Li
> > Yang-Leo-R58472; pau...@samba.org
> > Subject: Re: [PATCH V7 2/3] qe_common: add qe_muram_ functions to manage
> > muram
> >
> > On Mon, 2015-08-31 at 16:58 +0800, Zhao Qiang wrote:
> >
> > > -int cpm_muram_init(void)
> > > -{
> > > - struct device_node *np;
> > > - struct resource r;
> > > - u32 zero[OF_MAX_ADDR_CELLS] = {};
> > > - resource_size_t max = 0;
> > > - int i = 0;
> > > - int ret = 0;
> > > -
> > > - if (muram_pbase)
> > > - return 0;
> > > -
> > > - spin_lock_init(_muram_lock);
> > > - /* initialize the info header */
> > > - rh_init(_muram_info, 1,
> > > - sizeof(cpm_boot_muram_rh_block) /
> > > - sizeof(cpm_boot_muram_rh_block[0]),
> > > - cpm_boot_muram_rh_block);
> > > -
> > > - np = of_find_compatible_node(NULL, NULL, "fsl,cpm-muram-data");
> > > - if (!np) {
> > > - /* try legacy bindings */
> > > - np = of_find_node_by_name(NULL, "data-only");
> > > - if (!np) {
> > > - printk(KERN_ERR "Cannot find CPM muram data
> > node");
> > > - ret = -ENODEV;
> > > - goto out;
> > > - }
> > > - }
> > > -
> > > - muram_pbase = of_translate_address(np, zero);
> > > - if (muram_pbase == (phys_addr_t)OF_BAD_ADDR) {
> > > - printk(KERN_ERR "Cannot translate zero through CPM muram
> > node");
> > > - ret = -ENODEV;
> > > - goto out;
> > > - }
> >
> > Did you pass -M -C to git format-patch?
>
>
> Yes!
Then maybe it's the qe/cpm rename churn, or similar, that prevented it from
being identified as a move?
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
