RE: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns_remove

2021-01-13 Thread Peter Chen 
 
> >
> > Issue occurs for USB/CDNS3/CDNSP kernel configuration:
> > CONFIG_USB=m
> > CONFIG_USB_CDNS_SUPPORT=y
> > CONFIG_USB_CDNS3=m
> > CONFIG_USB_CDNS3_PCI_WRAP=m
> > CONFIG_USB_CDNSP_PCI=y
> >
> > Reported-by: Randy Dunlap 
> > Signed-off-by: Pawel Laszczak 
> 
> After removing the v1 patch and applying this one, my build errors are gone.
> Thanks.
> 
> Acked-by: Randy Dunlap 
> 

Force updated, thanks.

Peter

> > ---
> > changelog:
> > v2
> > - added missing condition
> >
> >  drivers/usb/cdns3/Makefile | 8 
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile
> > index 3f9b7fa8a594..61edb2f89276 100644
> > --- a/drivers/usb/cdns3/Makefile
> > +++ b/drivers/usb/cdns3/Makefile
> > @@ -26,7 +26,15 @@ obj-$(CONFIG_USB_CDNS3_TI)   +=
> cdns3-ti.o
> >  obj-$(CONFIG_USB_CDNS3_IMX)+= cdns3-imx.o
> >
> >  cdnsp-udc-pci-y:= cdnsp-pci.o
> > +
> > +ifdef CONFIG_USB_CDNSP_PCI
> > +ifeq ($(CONFIG_USB),m)
> > +obj-m  += cdnsp-udc-pci.o
> > +else
> >  obj-$(CONFIG_USB_CDNSP_PCI)+= cdnsp-udc-pci.o
> > +endif
> > +endif
> > +
> >  cdnsp-udc-pci-$(CONFIG_USB_CDNSP_GADGET)   += cdnsp-ring.o
> cdnsp-gadget.o \
> >cdnsp-mem.o cdnsp-ep0.o
> >
> >
> 
> 
> --
> ~Randy
> You can't do anything without having to do something else first.
> -- Belefant's Law

Re: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns_remove

2021-01-13 Thread Randy Dunlap 
On 1/13/21 6:14 AM, Pawel Laszczak wrote:
> Patch fixes the following errors:
> ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_remove':
> cdnsp-pci.c:(.text+0x80): undefined reference to `cdns_remove'
> ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_probe':
> cdnsp-pci.c:(.text+0x34c): undefined reference to `cdns_init'
> 
> Issue occurs for USB/CDNS3/CDNSP kernel configuration:
> CONFIG_USB=m
> CONFIG_USB_CDNS_SUPPORT=y
> CONFIG_USB_CDNS3=m
> CONFIG_USB_CDNS3_PCI_WRAP=m
> CONFIG_USB_CDNSP_PCI=y
> 
> Reported-by: Randy Dunlap 
> Signed-off-by: Pawel Laszczak 

After removing the v1 patch and applying this one, my build errors are gone.
Thanks.

Acked-by: Randy Dunlap 

> ---
> changelog:
> v2
> - added missing condition
> 
>  drivers/usb/cdns3/Makefile | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile
> index 3f9b7fa8a594..61edb2f89276 100644
> --- a/drivers/usb/cdns3/Makefile
> +++ b/drivers/usb/cdns3/Makefile
> @@ -26,7 +26,15 @@ obj-$(CONFIG_USB_CDNS3_TI) += cdns3-ti.o
>  obj-$(CONFIG_USB_CDNS3_IMX)  += cdns3-imx.o
>  
>  cdnsp-udc-pci-y  := cdnsp-pci.o
> +
> +ifdef CONFIG_USB_CDNSP_PCI
> +ifeq ($(CONFIG_USB),m)
> +obj-m+= cdnsp-udc-pci.o
> +else
>  obj-$(CONFIG_USB_CDNSP_PCI)  += cdnsp-udc-pci.o
> +endif
> +endif
> +
>  cdnsp-udc-pci-$(CONFIG_USB_CDNSP_GADGET) += cdnsp-ring.o cdnsp-gadget.o \
>  cdnsp-mem.o cdnsp-ep0.o
>  
> 


-- 
~Randy
You can't do anything without having to do something else first.
-- Belefant's Law

RE: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns_remove

2021-01-13 Thread Pawel Laszczak 
Hi Peter,

Can you replace the previous version with this one. 
The v1 still has problem with undefined reference when CONFIG_PCI or 
CONFIG_ACPI are disabled.

V2 fixes this issue. 

Thanks,
Regards,
Pawel Laszczak


>From: Pawel Laszczak 
>Sent: Wednesday, January 13, 2021 3:14 PM
>To: peter.c...@nxp.com
>Cc: rdun...@infradead.org; a-govindr...@ti.com; gre...@linuxfoundation.org; 
>linux-...@vger.kernel.org; linux-
>ker...@vger.kernel.org; Rahul Kumar ; 
>ge...@linux-m68k.org; Pawel Laszczak 
>Subject: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns_remove
>
>Patch fixes the following errors:
>ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_remove':
>cdnsp-pci.c:(.text+0x80): undefined reference to `cdns_remove'
>ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_probe':
>cdnsp-pci.c:(.text+0x34c): undefined reference to `cdns_init'
>
>Issue occurs for USB/CDNS3/CDNSP kernel configuration:
>CONFIG_USB=m
>CONFIG_USB_CDNS_SUPPORT=y
>CONFIG_USB_CDNS3=m
>CONFIG_USB_CDNS3_PCI_WRAP=m
>CONFIG_USB_CDNSP_PCI=y
>
>Reported-by: Randy Dunlap 
>Signed-off-by: Pawel Laszczak 
>---
>changelog:
>v2
>- added missing condition
>
> drivers/usb/cdns3/Makefile | 8 
> 1 file changed, 8 insertions(+)
>
>diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile
>index 3f9b7fa8a594..61edb2f89276 100644
>--- a/drivers/usb/cdns3/Makefile
>+++ b/drivers/usb/cdns3/Makefile
>@@ -26,7 +26,15 @@ obj-$(CONFIG_USB_CDNS3_TI)  += cdns3-ti.o
> obj-$(CONFIG_USB_CDNS3_IMX)   += cdns3-imx.o
>
> cdnsp-udc-pci-y   := cdnsp-pci.o
>+
>+ifdef CONFIG_USB_CDNSP_PCI
>+ifeq ($(CONFIG_USB),m)
>+obj-m += cdnsp-udc-pci.o
>+else
> obj-$(CONFIG_USB_CDNSP_PCI)   += cdnsp-udc-pci.o
>+endif
>+endif
>+
> cdnsp-udc-pci-$(CONFIG_USB_CDNSP_GADGET)  += cdnsp-ring.o cdnsp-gadget.o \
>  cdnsp-mem.o cdnsp-ep0.o
>
>--
>2.17.1