Re: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11
On Fri, 14 Aug 2015, Kukjin Kim wrote: > Krzysztof Kozlowski wrote: > > > > Document a new Device Tree property 'samsung,s2mps11-acokb-ground' > > indicating that ACOKB pin of S2MPS11 PMIC is connected to the ground so > > the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the > > power. > > > > Signed-off-by: Krzysztof Kozlowski > > Reviewed-by: Javier Martinez Canillas > > Acked-by: Lee Jones > > > > --- > > > > Changes since v1: > > 1. Split bindings documentation to separate patch (suggested by Lee). > > 2. Add Javier's reviewed-by and Lee's acked-by. > > --- > > Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt > > b/Documentation/devicetree/bindings/mfd/s2mps11.txt > > index 57a045016fca..90eaef393325 100644 > > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > > @@ -15,6 +15,10 @@ Optional properties: > > - interrupt-parent: Specifies the phandle of the interrupt controller to > > which > >the interrupts from s2mps11 are delivered to. > > - interrupts: Interrupt specifiers for interrupt sources. > > +- samsung,s2mps11-acokb-ground: Indicates that ACOKB pin of S2MPS11 PMIC is > > + connected to the ground so the PMIC must manually set PWRHOLD bit in > > CTRL1 > > + register to turn off the power. Usually the ACOKB is pulled up to VBATT > > so > > + when PWRHOLD pin goes low, the rising ACOKB will trigger power off. > > > > Optional nodes: > > - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered > > 32.768 > > Applied 1/3 and 3/3. Any chance you applied these on their own branch (which can be tagged)? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11
On Fri, 14 Aug 2015, Kukjin Kim wrote: > Krzysztof Kozlowski wrote: > > > > Document a new Device Tree property 'samsung,s2mps11-acokb-ground' > > indicating that ACOKB pin of S2MPS11 PMIC is connected to the ground so > > the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the > > power. > > > > Signed-off-by: Krzysztof Kozlowski> > Reviewed-by: Javier Martinez Canillas > > Acked-by: Lee Jones > > > > --- > > > > Changes since v1: > > 1. Split bindings documentation to separate patch (suggested by Lee). > > 2. Add Javier's reviewed-by and Lee's acked-by. > > --- > > Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt > > b/Documentation/devicetree/bindings/mfd/s2mps11.txt > > index 57a045016fca..90eaef393325 100644 > > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > > @@ -15,6 +15,10 @@ Optional properties: > > - interrupt-parent: Specifies the phandle of the interrupt controller to > > which > >the interrupts from s2mps11 are delivered to. > > - interrupts: Interrupt specifiers for interrupt sources. > > +- samsung,s2mps11-acokb-ground: Indicates that ACOKB pin of S2MPS11 PMIC is > > + connected to the ground so the PMIC must manually set PWRHOLD bit in > > CTRL1 > > + register to turn off the power. Usually the ACOKB is pulled up to VBATT > > so > > + when PWRHOLD pin goes low, the rising ACOKB will trigger power off. > > > > Optional nodes: > > - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered > > 32.768 > > Applied 1/3 and 3/3. Any chance you applied these on their own branch (which can be tagged)? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11
Krzysztof Kozlowski wrote: > > Document a new Device Tree property 'samsung,s2mps11-acokb-ground' > indicating that ACOKB pin of S2MPS11 PMIC is connected to the ground so > the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the > power. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Javier Martinez Canillas > Acked-by: Lee Jones > > --- > > Changes since v1: > 1. Split bindings documentation to separate patch (suggested by Lee). > 2. Add Javier's reviewed-by and Lee's acked-by. > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt > b/Documentation/devicetree/bindings/mfd/s2mps11.txt > index 57a045016fca..90eaef393325 100644 > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > @@ -15,6 +15,10 @@ Optional properties: > - interrupt-parent: Specifies the phandle of the interrupt controller to > which >the interrupts from s2mps11 are delivered to. > - interrupts: Interrupt specifiers for interrupt sources. > +- samsung,s2mps11-acokb-ground: Indicates that ACOKB pin of S2MPS11 PMIC is > + connected to the ground so the PMIC must manually set PWRHOLD bit in CTRL1 > + register to turn off the power. Usually the ACOKB is pulled up to VBATT so > + when PWRHOLD pin goes low, the rising ACOKB will trigger power off. > > Optional nodes: > - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered > 32.768 > -- > 2.1.4 Applied 1/3 and 3/3. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 1/3] mfd: documentation: dt: Document grounded ACOKB pin on S2MPS11
Krzysztof Kozlowski wrote: Document a new Device Tree property 'samsung,s2mps11-acokb-ground' indicating that ACOKB pin of S2MPS11 PMIC is connected to the ground so the PMIC must manually set PWRHOLD bit in CTRL1 register to turn off the power. Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com Reviewed-by: Javier Martinez Canillas jav...@osg.samsung.com Acked-by: Lee Jones lee.jo...@linaro.org --- Changes since v1: 1. Split bindings documentation to separate patch (suggested by Lee). 2. Add Javier's reviewed-by and Lee's acked-by. --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt index 57a045016fca..90eaef393325 100644 --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt @@ -15,6 +15,10 @@ Optional properties: - interrupt-parent: Specifies the phandle of the interrupt controller to which the interrupts from s2mps11 are delivered to. - interrupts: Interrupt specifiers for interrupt sources. +- samsung,s2mps11-acokb-ground: Indicates that ACOKB pin of S2MPS11 PMIC is + connected to the ground so the PMIC must manually set PWRHOLD bit in CTRL1 + register to turn off the power. Usually the ACOKB is pulled up to VBATT so + when PWRHOLD pin goes low, the rising ACOKB will trigger power off. Optional nodes: - clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 -- 2.1.4 Applied 1/3 and 3/3. Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/