RE: [PATCH v3 0/7] spi: add support for octo mode
Hi Vignesh, > -Original Message- > From: Vignesh R [mailto:vigne...@ti.com] > Sent: Tuesday, November 13, 2018 1:30 PM > To: Yogesh Narayan Gaur ; linux- > m...@lists.infradead.org; boris.brezil...@bootlin.com; broo...@kernel.org; > marek.va...@gmail.com; linux-...@vger.kernel.org; > devicet...@vger.kernel.org > Cc: r...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; linux- > arm-ker...@lists.infradead.org; computersforpe...@gmail.com; > frieder.schre...@exceet.de; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3 0/7] spi: add support for octo mode > > Hi Yogesh > > On 23/10/18 3:07 PM, Yogesh Narayan Gaur wrote: > > Add support for octo mode IO data transfer. > > Micron flash, mt35xu512aba, supports octal mode data transfer and NXP > > FlexSPI controller supports 8 data lines for data transfer (Rx/Tx). > > > > Patch series > > * Add support for octo mode flags and parsing of same in spi driver. > > * Add parsing logic for spi-mem framework and m25p80.c device file. > > * Add opcodes for octo I/O commands in spi-nor framework, Read and Write > proto for (1-1-8/1-8-8) mode. > > Opcodes are added as per octal data IO commands required for > mt35xu512aba [1] flash. > > * Add mode bit required for octo mode in nxp-fspi driver [2]. > > * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2]. > > > > You may have to rebase this series to avoid conflicts with recent spi.h > changes. Done, have send the next version with rebase on top of v4.20-rc2 [1] and resolving conflict with spi.h changes. > Also, I suggest merging patches in [1] with this series if you plan to post > another > version so that all bits are at one place. Patches for addition of the flash property has already been accepted. -- Regards Yogesh Gaur. [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=77394 > > Regards > Vignesh > [...]
RE: [PATCH v3 0/7] spi: add support for octo mode
Hi Vignesh, > -Original Message- > From: Vignesh R [mailto:vigne...@ti.com] > Sent: Tuesday, November 13, 2018 1:30 PM > To: Yogesh Narayan Gaur ; linux- > m...@lists.infradead.org; boris.brezil...@bootlin.com; broo...@kernel.org; > marek.va...@gmail.com; linux-...@vger.kernel.org; > devicet...@vger.kernel.org > Cc: r...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; linux- > arm-ker...@lists.infradead.org; computersforpe...@gmail.com; > frieder.schre...@exceet.de; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3 0/7] spi: add support for octo mode > > Hi Yogesh > > On 23/10/18 3:07 PM, Yogesh Narayan Gaur wrote: > > Add support for octo mode IO data transfer. > > Micron flash, mt35xu512aba, supports octal mode data transfer and NXP > > FlexSPI controller supports 8 data lines for data transfer (Rx/Tx). > > > > Patch series > > * Add support for octo mode flags and parsing of same in spi driver. > > * Add parsing logic for spi-mem framework and m25p80.c device file. > > * Add opcodes for octo I/O commands in spi-nor framework, Read and Write > proto for (1-1-8/1-8-8) mode. > > Opcodes are added as per octal data IO commands required for > mt35xu512aba [1] flash. > > * Add mode bit required for octo mode in nxp-fspi driver [2]. > > * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2]. > > > > You may have to rebase this series to avoid conflicts with recent spi.h > changes. Done, have send the next version with rebase on top of v4.20-rc2 [1] and resolving conflict with spi.h changes. > Also, I suggest merging patches in [1] with this series if you plan to post > another > version so that all bits are at one place. Patches for addition of the flash property has already been accepted. -- Regards Yogesh Gaur. [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=77394 > > Regards > Vignesh > [...]
Re: [PATCH v3 0/7] spi: add support for octo mode
Hi Yogesh On 23/10/18 3:07 PM, Yogesh Narayan Gaur wrote: > Add support for octo mode IO data transfer. > Micron flash, mt35xu512aba, supports octal mode data transfer and > NXP FlexSPI controller supports 8 data lines for data transfer (Rx/Tx). > > Patch series > * Add support for octo mode flags and parsing of same in spi driver. > * Add parsing logic for spi-mem framework and m25p80.c device file. > * Add opcodes for octo I/O commands in spi-nor framework, Read and Write > proto for (1-1-8/1-8-8) mode. > Opcodes are added as per octal data IO commands required for mt35xu512aba > [1] flash. > * Add mode bit required for octo mode in nxp-fspi driver [2]. > * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2]. > You may have to rebase this series to avoid conflicts with recent spi.h changes. Also, I suggest merging patches in [1] with this series if you plan to post another version so that all bits are at one place. Regards Vignesh > Cherry pick below 2 patches (from: > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git): > c639f871febe6667d9afce28108c634e5636c735 spi: spi-mem: Fix inverted logic > in op sanity check > db122eb8a749a1eff038f9a282c620ab16c4be1d spi: spi-mem: Add extra sanity > checks on the op param > > Tested on LX2160ARDB target with nxp-fspi driver, below are > Read performance number of 1-1-1 and 1-1-8 read protocol. > > root@lxxx:~# cat /proc/mtd > dev:size erasesize name > mtd0: 0400 1000 "spi0.0" > mtd1: 0400 1000 "spi0.1" > root@lxxx:~# time mtd_debug read /dev/mtd0 0x0 0x100 0read > Copied 16777216 bytes from address 0x in flash to 0read > > real0m2.792s > user0m0.000s > sys 0m2.790s > root@lxxx:~# time mtd_debug read /dev/mtd1 0x0 0x100 0read > Copied 16777216 bytes from address 0x in flash to 0read > > real0m0.441s > user0m0.000s > sys 0m0.440s > root@ls1012ardb:~# > > Flash device MTD0 configured in 1-1-1 protocol. > Flash device MTD1 configured in 1-1-8 protocol. > > [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=70384 > [2] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=72181 > > Yogesh Gaur (7): > spi: add support for octo mode I/O data transfer > spi: spi-mem: add support for octo mode I/O data transfer > mtd: spi-nor: add opcodes for octo Read/Write commands > mtd: spi-nor: add octo read flag for flash mt35xu512aba > mtd: m25p80: add support of octo mode I/O transfer > spi: nxp-fspi: add octo mode flag bit for octal support > arm64: dts: lx2160a: update fspi node > > Changes for v3: > - Add octo mode support in spi_setup(). > - Rename all patches with 'octal' string modified as 'octo'. > Changes for v2: > - Incorporated review comments of Boris and Vignesh. > > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 > drivers/mtd/devices/m25p80.c | 9 - > drivers/mtd/spi-nor/spi-nor.c | 15 ++- > drivers/spi/spi-mem.c | 9 - > drivers/spi/spi-nxp-fspi.c| 4 ++-- > drivers/spi/spi.c | 12 ++-- > include/linux/mtd/spi-nor.h | 8 > include/linux/spi/spi.h | 2 ++ > 8 files changed, 56 insertions(+), 7 deletions(-) > -- Regards Vignesh
Re: [PATCH v3 0/7] spi: add support for octo mode
Hi Yogesh On 23/10/18 3:07 PM, Yogesh Narayan Gaur wrote: > Add support for octo mode IO data transfer. > Micron flash, mt35xu512aba, supports octal mode data transfer and > NXP FlexSPI controller supports 8 data lines for data transfer (Rx/Tx). > > Patch series > * Add support for octo mode flags and parsing of same in spi driver. > * Add parsing logic for spi-mem framework and m25p80.c device file. > * Add opcodes for octo I/O commands in spi-nor framework, Read and Write > proto for (1-1-8/1-8-8) mode. > Opcodes are added as per octal data IO commands required for mt35xu512aba > [1] flash. > * Add mode bit required for octo mode in nxp-fspi driver [2]. > * Define binding property 'spi-rx/tx-bus-width' for LX2160ARDB target [2]. > You may have to rebase this series to avoid conflicts with recent spi.h changes. Also, I suggest merging patches in [1] with this series if you plan to post another version so that all bits are at one place. Regards Vignesh > Cherry pick below 2 patches (from: > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git): > c639f871febe6667d9afce28108c634e5636c735 spi: spi-mem: Fix inverted logic > in op sanity check > db122eb8a749a1eff038f9a282c620ab16c4be1d spi: spi-mem: Add extra sanity > checks on the op param > > Tested on LX2160ARDB target with nxp-fspi driver, below are > Read performance number of 1-1-1 and 1-1-8 read protocol. > > root@lxxx:~# cat /proc/mtd > dev:size erasesize name > mtd0: 0400 1000 "spi0.0" > mtd1: 0400 1000 "spi0.1" > root@lxxx:~# time mtd_debug read /dev/mtd0 0x0 0x100 0read > Copied 16777216 bytes from address 0x in flash to 0read > > real0m2.792s > user0m0.000s > sys 0m2.790s > root@lxxx:~# time mtd_debug read /dev/mtd1 0x0 0x100 0read > Copied 16777216 bytes from address 0x in flash to 0read > > real0m0.441s > user0m0.000s > sys 0m0.440s > root@ls1012ardb:~# > > Flash device MTD0 configured in 1-1-1 protocol. > Flash device MTD1 configured in 1-1-8 protocol. > > [1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=70384 > [2] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=72181 > > Yogesh Gaur (7): > spi: add support for octo mode I/O data transfer > spi: spi-mem: add support for octo mode I/O data transfer > mtd: spi-nor: add opcodes for octo Read/Write commands > mtd: spi-nor: add octo read flag for flash mt35xu512aba > mtd: m25p80: add support of octo mode I/O transfer > spi: nxp-fspi: add octo mode flag bit for octal support > arm64: dts: lx2160a: update fspi node > > Changes for v3: > - Add octo mode support in spi_setup(). > - Rename all patches with 'octal' string modified as 'octo'. > Changes for v2: > - Incorporated review comments of Boris and Vignesh. > > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 > drivers/mtd/devices/m25p80.c | 9 - > drivers/mtd/spi-nor/spi-nor.c | 15 ++- > drivers/spi/spi-mem.c | 9 - > drivers/spi/spi-nxp-fspi.c| 4 ++-- > drivers/spi/spi.c | 12 ++-- > include/linux/mtd/spi-nor.h | 8 > include/linux/spi/spi.h | 2 ++ > 8 files changed, 56 insertions(+), 7 deletions(-) > -- Regards Vignesh
