RE: [PATCH v3 net-next] net: stmmac: Add support for MDIO interrupts

2019-09-06 Thread Jose Abreu
From: Andrew Lunn 
Date: Sep/06/2019, 15:24:46 (UTC+00:00)

> On Fri, Sep 06, 2019 at 01:31:14PM +, Jose Abreu wrote:
> > From: Voon Weifeng 
> > Date: Sep/05/2019, 13:05:30 (UTC+00:00)
> > 
> > > DW EQoS v5.xx controllers added capability for interrupt generation
> > > when MDIO interface is done (GMII Busy bit is cleared).
> > > This patch adds support for this interrupt on supported HW to avoid
> > > polling on GMII Busy bit.
> > 
> > Better leave the enabling of this optional because the support for it is 
> > also optional depending on the IP HW configuration.
> 
> Hi Jose
> 
> If there a register which indicates if this feature is part of the IP?

Yes. That would be SMASEL which is Bit 5 of register MAC_HW_Feature0.

---
Thanks,
Jose Miguel Abreu


Re: [PATCH v3 net-next] net: stmmac: Add support for MDIO interrupts

2019-09-06 Thread Andrew Lunn
On Fri, Sep 06, 2019 at 01:31:14PM +, Jose Abreu wrote:
> From: Voon Weifeng 
> Date: Sep/05/2019, 13:05:30 (UTC+00:00)
> 
> > DW EQoS v5.xx controllers added capability for interrupt generation
> > when MDIO interface is done (GMII Busy bit is cleared).
> > This patch adds support for this interrupt on supported HW to avoid
> > polling on GMII Busy bit.
> 
> Better leave the enabling of this optional because the support for it is 
> also optional depending on the IP HW configuration.

Hi Jose

If there a register which indicates if this feature is part of the IP?

   Andrew


RE: [PATCH v3 net-next] net: stmmac: Add support for MDIO interrupts

2019-09-06 Thread Jose Abreu
From: Voon Weifeng 
Date: Sep/05/2019, 13:05:30 (UTC+00:00)

> DW EQoS v5.xx controllers added capability for interrupt generation
> when MDIO interface is done (GMII Busy bit is cleared).
> This patch adds support for this interrupt on supported HW to avoid
> polling on GMII Busy bit.

Better leave the enabling of this optional because the support for it is 
also optional depending on the IP HW configuration.

---
Thanks,
Jose Miguel Abreu