RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Ping!!

> -Original Message-
> From: Nava kishore Manne
> Sent: Monday, July 25, 2016 3:57 PM
> To: 'gre...@linuxfoundation.org' <gre...@linuxfoundation.org>
> Cc: 'Rob Herring' <r...@kernel.org>; 'pawel.m...@arm.com'
> <pawel.m...@arm.com>; 'mark.rutl...@arm.com'
> <mark.rutl...@arm.com>; 'ijc+devicet...@hellion.org.uk'
> <ijc+devicet...@hellion.org.uk>; 'ga...@codeaurora.org'
> <ga...@codeaurora.org>; Michal Simek <mich...@xilinx.com>; Soren
> Brinkmann <sor...@xilinx.com>; 'ba...@ti.com' <ba...@ti.com>; Hyun
> Kwon <hy...@xilinx.com>; Radhey Shyam Pandey <radh...@xilinx.com>;
> 'devicet...@vger.kernel.org' <devicet...@vger.kernel.org>; 'linux-arm-
> ker...@lists.infradead.org' <linux-arm-ker...@lists.infradead.org>; 'linux-
> ker...@vger.kernel.org' <linux-kernel@vger.kernel.org>
> Subject: RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> 
> Ping!!
> 
> > -Original Message-
> > From: Nava kishore Manne
> > Sent: Wednesday, July 13, 2016 1:00 PM
> > To: 'gre...@linuxfoundation.org' <gre...@linuxfoundation.org>
> > Cc: Rob Herring <r...@kernel.org>; pawel.m...@arm.com;
> > mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk;
> > ga...@codeaurora.org; Michal Simek <mich...@xilinx.com>; Soren
> > Brinkmann <sor...@xilinx.com>; ba...@ti.com; Hyun Kwon
> > <hy...@xilinx.com>; Radhey Shyam Pandey <radh...@xilinx.com>;
> > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> > linux- ker...@vger.kernel.org
> > Subject: RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> >
> > Hi Greg,
> >
> > > > Ping!!
> > >
> > > 
> > >
> > > >
> > > > This email and any attachments are intended for the sole use of
> > > > the named
> > > recipient(s) and contain(s) confidential information that may be
> > > proprietary, privileged or copyrighted under applicable law. If you
> > > are not the intended recipient, do not read, copy, or forward this
> > > email message or any attachments. Delete this email message and any
> > attachments immediately.
> > >
> > > You do realize that with an email footer like this, you prevent any
> > > of us from responding to you, sorry.  I shouldn't even be writing this...
> >
> > Sorry something fishy happened with my email-client I have fixed it
> > now next time onwards will take care before giving replies...
> >
> > Regards,
> > Navakishore.
> > >
> >
> >
> > > greg k-h

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Ping!!

> -Original Message-
> From: Nava kishore Manne
> Sent: Monday, July 25, 2016 3:57 PM
> To: 'gre...@linuxfoundation.org' 
> Cc: 'Rob Herring' ; 'pawel.m...@arm.com'
> ; 'mark.rutl...@arm.com'
> ; 'ijc+devicet...@hellion.org.uk'
> ; 'ga...@codeaurora.org'
> ; Michal Simek ; Soren
> Brinkmann ; 'ba...@ti.com' ; Hyun
> Kwon ; Radhey Shyam Pandey ;
> 'devicet...@vger.kernel.org' ; 'linux-arm-
> ker...@lists.infradead.org' ; 'linux-
> ker...@vger.kernel.org' 
> Subject: RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> 
> Ping!!
> 
> > -Original Message-
> > From: Nava kishore Manne
> > Sent: Wednesday, July 13, 2016 1:00 PM
> > To: 'gre...@linuxfoundation.org' 
> > Cc: Rob Herring ; pawel.m...@arm.com;
> > mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk;
> > ga...@codeaurora.org; Michal Simek ; Soren
> > Brinkmann ; ba...@ti.com; Hyun Kwon
> > ; Radhey Shyam Pandey ;
> > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> > linux- ker...@vger.kernel.org
> > Subject: RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> >
> > Hi Greg,
> >
> > > > Ping!!
> > >
> > > 
> > >
> > > >
> > > > This email and any attachments are intended for the sole use of
> > > > the named
> > > recipient(s) and contain(s) confidential information that may be
> > > proprietary, privileged or copyrighted under applicable law. If you
> > > are not the intended recipient, do not read, copy, or forward this
> > > email message or any attachments. Delete this email message and any
> > attachments immediately.
> > >
> > > You do realize that with an email footer like this, you prevent any
> > > of us from responding to you, sorry.  I shouldn't even be writing this...
> >
> > Sorry something fishy happened with my email-client I have fixed it
> > now next time onwards will take care before giving replies...
> >
> > Regards,
> > Navakishore.
> > >
> >
> >
> > > greg k-h

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[gre...@linuxfoundation.org]

On Thu, Sep 01, 2016 at 06:01:35AM +, Nava kishore Manne wrote:
> Ping!!

ping what?

I don't see a patch here, and nothing is in my to-review queue about
this.

Perhaps send it again?

confused,

greg k-h

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[gre...@linuxfoundation.org]

On Thu, Sep 01, 2016 at 06:01:35AM +, Nava kishore Manne wrote:
> Ping!!

ping what?

I don't see a patch here, and nothing is in my to-review queue about
this.

Perhaps send it again?

confused,

greg k-h

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Ping!!

> -Original Message-
> From: Nava kishore Manne
> Sent: Wednesday, July 13, 2016 1:00 PM
> To: 'gre...@linuxfoundation.org' <gre...@linuxfoundation.org>
> Cc: Rob Herring <r...@kernel.org>; pawel.m...@arm.com;
> mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk;
> ga...@codeaurora.org; Michal Simek <mich...@xilinx.com>; Soren
> Brinkmann <sor...@xilinx.com>; ba...@ti.com; Hyun Kwon
> <hy...@xilinx.com>; Radhey Shyam Pandey <radh...@xilinx.com>;
> devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> ker...@vger.kernel.org
> Subject: RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> 
> Hi Greg,
> 
> > > Ping!!
> >
> > 
> >
> > >
> > > This email and any attachments are intended for the sole use of the
> > > named
> > recipient(s) and contain(s) confidential information that may be
> > proprietary, privileged or copyrighted under applicable law. If you
> > are not the intended recipient, do not read, copy, or forward this
> > email message or any attachments. Delete this email message and any
> attachments immediately.
> >
> > You do realize that with an email footer like this, you prevent any of
> > us from responding to you, sorry.  I shouldn't even be writing this...
> 
> Sorry something fishy happened with my email-client I have fixed it now next
> time onwards will take care before giving replies...
> 
> Regards,
> Navakishore.
> >
> 
> 
> > greg k-h

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Ping!!

> -Original Message-
> From: Nava kishore Manne
> Sent: Wednesday, July 13, 2016 1:00 PM
> To: 'gre...@linuxfoundation.org' 
> Cc: Rob Herring ; pawel.m...@arm.com;
> mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk;
> ga...@codeaurora.org; Michal Simek ; Soren
> Brinkmann ; ba...@ti.com; Hyun Kwon
> ; Radhey Shyam Pandey ;
> devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> ker...@vger.kernel.org
> Subject: RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> 
> Hi Greg,
> 
> > > Ping!!
> >
> > 
> >
> > >
> > > This email and any attachments are intended for the sole use of the
> > > named
> > recipient(s) and contain(s) confidential information that may be
> > proprietary, privileged or copyrighted under applicable law. If you
> > are not the intended recipient, do not read, copy, or forward this
> > email message or any attachments. Delete this email message and any
> attachments immediately.
> >
> > You do realize that with an email footer like this, you prevent any of
> > us from responding to you, sorry.  I shouldn't even be writing this...
> 
> Sorry something fishy happened with my email-client I have fixed it now next
> time onwards will take care before giving replies...
> 
> Regards,
> Navakishore.
> >
> 
> 
> > greg k-h

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Hi Greg,

> > Ping!!
> 
> 
> 
> >
> > This email and any attachments are intended for the sole use of the named
> recipient(s) and contain(s) confidential information that may be proprietary,
> privileged or copyrighted under applicable law. If you are not the intended
> recipient, do not read, copy, or forward this email message or any
> attachments. Delete this email message and any attachments immediately.
> 
> You do realize that with an email footer like this, you prevent any of us from
> responding to you, sorry.  I shouldn't even be writing this...

Sorry something fishy happened with my email-client
I have fixed it now next time onwards will take care before giving replies...

Regards,
Navakishore.
> 


> greg k-h

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Hi Greg,

> > Ping!!
> 
> 
> 
> >
> > This email and any attachments are intended for the sole use of the named
> recipient(s) and contain(s) confidential information that may be proprietary,
> privileged or copyrighted under applicable law. If you are not the intended
> recipient, do not read, copy, or forward this email message or any
> attachments. Delete this email message and any attachments immediately.
> 
> You do realize that with an email footer like this, you prevent any of us from
> responding to you, sorry.  I shouldn't even be writing this...

Sorry something fishy happened with my email-client
I have fixed it now next time onwards will take care before giving replies...

Regards,
Navakishore.
> 


> greg k-h

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[gre...@linuxfoundation.org]

On Mon, Jul 11, 2016 at 10:07:31AM +, Nava kishore Manne wrote:
> Ping!!



> 
> This email and any attachments are intended for the sole use of the named 
> recipient(s) and contain(s) confidential information that may be proprietary, 
> privileged or copyrighted under applicable law. If you are not the intended 
> recipient, do not read, copy, or forward this email message or any 
> attachments. Delete this email message and any attachments immediately.

You do realize that with an email footer like this, you prevent any of
us from responding to you, sorry.  I shouldn't even be writing this...

greg k-h

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[gre...@linuxfoundation.org]

On Mon, Jul 11, 2016 at 10:07:31AM +, Nava kishore Manne wrote:
> Ping!!



> 
> This email and any attachments are intended for the sole use of the named 
> recipient(s) and contain(s) confidential information that may be proprietary, 
> privileged or copyrighted under applicable law. If you are not the intended 
> recipient, do not read, copy, or forward this email message or any 
> attachments. Delete this email message and any attachments immediately.

You do realize that with an email footer like this, you prevent any of
us from responding to you, sorry.  I shouldn't even be writing this...

greg k-h

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Ping!!

> -Original Message-
> From: Nava kishore Manne
> Sent: Monday, June 27, 2016 6:18 PM
> To: 'Rob Herring' <r...@kernel.org>
> Cc: pawel.m...@arm.com; mark.rutl...@arm.com;
> ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; Michal Simek
> <mich...@xilinx.com>; Soren Brinkmann <sor...@xilinx.com>;
> ba...@ti.com; gre...@linuxfoundation.org; Hyun Kwon
> <hy...@xilinx.com>; Radhey Shyam Pandey <radh...@xilinx.com>;
> devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> ker...@vger.kernel.org
> Subject: RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
>
> Ping!!
>
> > -Original Message-
> > From: Rob Herring [mailto:r...@kernel.org]
> > Sent: Friday, June 03, 2016 4:28 AM
> > To: Nava kishore Manne <na...@xilinx.com>
> > Cc: pawel.m...@arm.com; mark.rutl...@arm.com;
> > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; Michal Simek
> > <mich...@xilinx.com>; Soren Brinkmann <sor...@xilinx.com>;
> > ba...@ti.com; gre...@linuxfoundation.org; Hyun Kwon
> > <hy...@xilinx.com>; Nava kishore Manne <na...@xilinx.com>; Radhey
> > Shyam Pandey <radh...@xilinx.com>; devicet...@vger.kernel.org; linux-
> > arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> >
> > On Mon, May 30, 2016 at 10:16:38PM +0530, Nava kishore Manne wrote:
> > > This patch updates the driver to support 64-bit DMA addressing.
> > >
> > > Signed-off-by: Nava kishore Manne <na...@xilinx.com>
> > > ---
> > > Changes for v4:
> > >   -Used boolen property insted of addrwith property in the DT
> > >as suggested by Arnd Bergmann.
> > >   -Adopt the DT relevant changes into the driver.
> > >
> > > Changes for v3:
> > > -Added new compatable string for 5.00 IP version as 
> > > suggested by
> > >  Arnd Bergmann.
> > > -Used write_fn() insted of lo_hi_writeq() as suggested by
> > >  Arnd Bergmann.
> > >
> > > Changes for v2:
> > > -Added dma-ranges property in device tree as
> > > suggested by Arnd
> > Bergmann.
> > > -Modified the driver code based on the xlnx,addrwidth.
> > >
> > >  .../devicetree/bindings/usb/udc-xilinx.txt |  5 ++-
> >
> > Acked-by: Rob Herring <r...@kernel.org>
> >
> > >  drivers/usb/gadget/udc/udc-xilinx.c| 52
> > +-
> > >  2 files changed, 54 insertions(+), 3 deletions(-)


This email and any attachments are intended for the sole use of the named 
recipient(s) and contain(s) confidential information that may be proprietary, 
privileged or copyrighted under applicable law. If you are not the intended 
recipient, do not read, copy, or forward this email message or any attachments. 
Delete this email message and any attachments immediately.

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Ping!!

> -Original Message-
> From: Nava kishore Manne
> Sent: Monday, June 27, 2016 6:18 PM
> To: 'Rob Herring' 
> Cc: pawel.m...@arm.com; mark.rutl...@arm.com;
> ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; Michal Simek
> ; Soren Brinkmann ;
> ba...@ti.com; gre...@linuxfoundation.org; Hyun Kwon
> ; Radhey Shyam Pandey ;
> devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> ker...@vger.kernel.org
> Subject: RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
>
> Ping!!
>
> > -Original Message-
> > From: Rob Herring [mailto:r...@kernel.org]
> > Sent: Friday, June 03, 2016 4:28 AM
> > To: Nava kishore Manne 
> > Cc: pawel.m...@arm.com; mark.rutl...@arm.com;
> > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; Michal Simek
> > ; Soren Brinkmann ;
> > ba...@ti.com; gre...@linuxfoundation.org; Hyun Kwon
> > ; Nava kishore Manne ; Radhey
> > Shyam Pandey ; devicet...@vger.kernel.org; linux-
> > arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> >
> > On Mon, May 30, 2016 at 10:16:38PM +0530, Nava kishore Manne wrote:
> > > This patch updates the driver to support 64-bit DMA addressing.
> > >
> > > Signed-off-by: Nava kishore Manne 
> > > ---
> > > Changes for v4:
> > >   -Used boolen property insted of addrwith property in the DT
> > >as suggested by Arnd Bergmann.
> > >   -Adopt the DT relevant changes into the driver.
> > >
> > > Changes for v3:
> > > -Added new compatable string for 5.00 IP version as 
> > > suggested by
> > >  Arnd Bergmann.
> > > -Used write_fn() insted of lo_hi_writeq() as suggested by
> > >  Arnd Bergmann.
> > >
> > > Changes for v2:
> > > -Added dma-ranges property in device tree as
> > > suggested by Arnd
> > Bergmann.
> > > -Modified the driver code based on the xlnx,addrwidth.
> > >
> > >  .../devicetree/bindings/usb/udc-xilinx.txt |  5 ++-
> >
> > Acked-by: Rob Herring 
> >
> > >  drivers/usb/gadget/udc/udc-xilinx.c| 52
> > +-
> > >  2 files changed, 54 insertions(+), 3 deletions(-)


This email and any attachments are intended for the sole use of the named 
recipient(s) and contain(s) confidential information that may be proprietary, 
privileged or copyrighted under applicable law. If you are not the intended 
recipient, do not read, copy, or forward this email message or any attachments. 
Delete this email message and any attachments immediately.

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Ping!!

> -Original Message-
> From: Rob Herring [mailto:r...@kernel.org]
> Sent: Friday, June 03, 2016 4:28 AM
> To: Nava kishore Manne <na...@xilinx.com>
> Cc: pawel.m...@arm.com; mark.rutl...@arm.com;
> ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; Michal Simek
> <mich...@xilinx.com>; Soren Brinkmann <sor...@xilinx.com>;
> ba...@ti.com; gre...@linuxfoundation.org; Hyun Kwon
> <hy...@xilinx.com>; Nava kishore Manne <na...@xilinx.com>; Radhey
> Shyam Pandey <radh...@xilinx.com>; devicet...@vger.kernel.org; linux-
> arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> 
> On Mon, May 30, 2016 at 10:16:38PM +0530, Nava kishore Manne wrote:
> > This patch updates the driver to support 64-bit DMA addressing.
> >
> > Signed-off-by: Nava kishore Manne <na...@xilinx.com>
> > ---
> > Changes for v4:
> > -Used boolen property insted of addrwith property in the DT
> >  as suggested by Arnd Bergmann.
> > -Adopt the DT relevant changes into the driver.
> >
> > Changes for v3:
> > -Added new compatable string for 5.00 IP version as 
> > suggested by
> >  Arnd Bergmann.
> > -Used write_fn() insted of lo_hi_writeq() as suggested by
> >  Arnd Bergmann.
> >
> > Changes for v2:
> > -Added dma-ranges property in device tree as suggested by 
> > Arnd
> Bergmann.
> > -Modified the driver code based on the xlnx,addrwidth.
> >
> >  .../devicetree/bindings/usb/udc-xilinx.txt |  5 ++-
> 
> Acked-by: Rob Herring <r...@kernel.org>
> 
> >  drivers/usb/gadget/udc/udc-xilinx.c| 52
> +-
> >  2 files changed, 54 insertions(+), 3 deletions(-)

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Ping!!

> -Original Message-
> From: Rob Herring [mailto:r...@kernel.org]
> Sent: Friday, June 03, 2016 4:28 AM
> To: Nava kishore Manne 
> Cc: pawel.m...@arm.com; mark.rutl...@arm.com;
> ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; Michal Simek
> ; Soren Brinkmann ;
> ba...@ti.com; gre...@linuxfoundation.org; Hyun Kwon
> ; Nava kishore Manne ; Radhey
> Shyam Pandey ; devicet...@vger.kernel.org; linux-
> arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.
> 
> On Mon, May 30, 2016 at 10:16:38PM +0530, Nava kishore Manne wrote:
> > This patch updates the driver to support 64-bit DMA addressing.
> >
> > Signed-off-by: Nava kishore Manne 
> > ---
> > Changes for v4:
> > -Used boolen property insted of addrwith property in the DT
> >  as suggested by Arnd Bergmann.
> > -Adopt the DT relevant changes into the driver.
> >
> > Changes for v3:
> > -Added new compatable string for 5.00 IP version as 
> > suggested by
> >  Arnd Bergmann.
> > -Used write_fn() insted of lo_hi_writeq() as suggested by
> >  Arnd Bergmann.
> >
> > Changes for v2:
> > -Added dma-ranges property in device tree as suggested by 
> > Arnd
> Bergmann.
> > -Modified the driver code based on the xlnx,addrwidth.
> >
> >  .../devicetree/bindings/usb/udc-xilinx.txt |  5 ++-
> 
> Acked-by: Rob Herring 
> 
> >  drivers/usb/gadget/udc/udc-xilinx.c| 52
> +-
> >  2 files changed, 54 insertions(+), 3 deletions(-)

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Shubhrajyoti Datta]

On Tue, May 31, 2016 at 10:45 AM, Nava kishore Manne
 wrote:
> Hi Shubhrajyoti,
>
>
> Thanks for the review...
>
>> >  /**
>> > + * xudc_write64 - write 64bit value to device registers
>> > + * @ep: pointer to the usb device endpoint structure.
>> > + * @offset: register offset
>> > + * @val: data to be written
>> > + **/
>> > +static void xudc_write64(struct xusb_ep *ep, u32 offset, u64 val) {
>> > +   struct xusb_udc *udc = ep->udc;
>> > +
>> > +   udc->write_fn(udc->addr, offset, lower_32_bits(val));
>> > +   udc->write_fn(udc->addr, offset+0x04, upper_32_bits(val));
>>
>> can we move this to a single 64 bit write?
>
> Initially I sent the patches with writeq() ,lo_hi_writeq()  later we decided 
> to replace with write_fun().
> The reason for this is lo_hi_writeq() always assumes a little-endian 
> register, so it's broken if anyone builds this device with big-endian 
> registers.
> So replaced the 64bit calls with write_fun() as suggested by Arnd Bergmann. 
> Hope it clears your query.
> Please refer to the below thread
>
> http://lkml.iu.edu/hypermail/linux/kernel/1604.2/02046.html

missed that discurssion.

thanks
>
>
> Regards,
> Navakishore.
>

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Shubhrajyoti Datta]

On Tue, May 31, 2016 at 10:45 AM, Nava kishore Manne
 wrote:
> Hi Shubhrajyoti,
>
>
> Thanks for the review...
>
>> >  /**
>> > + * xudc_write64 - write 64bit value to device registers
>> > + * @ep: pointer to the usb device endpoint structure.
>> > + * @offset: register offset
>> > + * @val: data to be written
>> > + **/
>> > +static void xudc_write64(struct xusb_ep *ep, u32 offset, u64 val) {
>> > +   struct xusb_udc *udc = ep->udc;
>> > +
>> > +   udc->write_fn(udc->addr, offset, lower_32_bits(val));
>> > +   udc->write_fn(udc->addr, offset+0x04, upper_32_bits(val));
>>
>> can we move this to a single 64 bit write?
>
> Initially I sent the patches with writeq() ,lo_hi_writeq()  later we decided 
> to replace with write_fun().
> The reason for this is lo_hi_writeq() always assumes a little-endian 
> register, so it's broken if anyone builds this device with big-endian 
> registers.
> So replaced the 64bit calls with write_fun() as suggested by Arnd Bergmann. 
> Hope it clears your query.
> Please refer to the below thread
>
> http://lkml.iu.edu/hypermail/linux/kernel/1604.2/02046.html

missed that discurssion.

thanks
>
>
> Regards,
> Navakishore.
>

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Rob Herring]

On Mon, May 30, 2016 at 10:16:38PM +0530, Nava kishore Manne wrote:
> This patch updates the driver to support 64-bit DMA addressing.
> 
> Signed-off-by: Nava kishore Manne 
> ---
> Changes for v4:
>   -Used boolen property insted of addrwith property in the DT
>as suggested by Arnd Bergmann.
>   -Adopt the DT relevant changes into the driver.
> 
> Changes for v3:
> -Added new compatable string for 5.00 IP version as suggested 
> by
>  Arnd Bergmann.
> -Used write_fn() insted of lo_hi_writeq() as suggested by
>  Arnd Bergmann.
> 
> Changes for v2:
> -Added dma-ranges property in device tree as suggested by 
> Arnd Bergmann.
> -Modified the driver code based on the xlnx,addrwidth.
> 
>  .../devicetree/bindings/usb/udc-xilinx.txt |  5 ++-

Acked-by: Rob Herring 

>  drivers/usb/gadget/udc/udc-xilinx.c| 52 
> +-
>  2 files changed, 54 insertions(+), 3 deletions(-)

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Rob Herring]

On Mon, May 30, 2016 at 10:16:38PM +0530, Nava kishore Manne wrote:
> This patch updates the driver to support 64-bit DMA addressing.
> 
> Signed-off-by: Nava kishore Manne 
> ---
> Changes for v4:
>   -Used boolen property insted of addrwith property in the DT
>as suggested by Arnd Bergmann.
>   -Adopt the DT relevant changes into the driver.
> 
> Changes for v3:
> -Added new compatable string for 5.00 IP version as suggested 
> by
>  Arnd Bergmann.
> -Used write_fn() insted of lo_hi_writeq() as suggested by
>  Arnd Bergmann.
> 
> Changes for v2:
> -Added dma-ranges property in device tree as suggested by 
> Arnd Bergmann.
> -Modified the driver code based on the xlnx,addrwidth.
> 
>  .../devicetree/bindings/usb/udc-xilinx.txt |  5 ++-

Acked-by: Rob Herring 

>  drivers/usb/gadget/udc/udc-xilinx.c| 52 
> +-
>  2 files changed, 54 insertions(+), 3 deletions(-)

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Hi Shubhrajyoti,


Thanks for the review...

> >  /**
> > + * xudc_write64 - write 64bit value to device registers
> > + * @ep: pointer to the usb device endpoint structure.
> > + * @offset: register offset
> > + * @val: data to be written
> > + **/
> > +static void xudc_write64(struct xusb_ep *ep, u32 offset, u64 val) {
> > +   struct xusb_udc *udc = ep->udc;
> > +
> > +   udc->write_fn(udc->addr, offset, lower_32_bits(val));
> > +   udc->write_fn(udc->addr, offset+0x04, upper_32_bits(val));
> 
> can we move this to a single 64 bit write?

Initially I sent the patches with writeq() ,lo_hi_writeq()  later we decided to 
replace with write_fun().
The reason for this is lo_hi_writeq() always assumes a little-endian register, 
so it's broken if anyone builds this device with big-endian registers.
So replaced the 64bit calls with write_fun() as suggested by Arnd Bergmann. 
Hope it clears your query.
Please refer to the below thread

http://lkml.iu.edu/hypermail/linux/kernel/1604.2/02046.html 


Regards,
Navakishore.

RE: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Nava kishore Manne]

Hi Shubhrajyoti,


Thanks for the review...

> >  /**
> > + * xudc_write64 - write 64bit value to device registers
> > + * @ep: pointer to the usb device endpoint structure.
> > + * @offset: register offset
> > + * @val: data to be written
> > + **/
> > +static void xudc_write64(struct xusb_ep *ep, u32 offset, u64 val) {
> > +   struct xusb_udc *udc = ep->udc;
> > +
> > +   udc->write_fn(udc->addr, offset, lower_32_bits(val));
> > +   udc->write_fn(udc->addr, offset+0x04, upper_32_bits(val));
> 
> can we move this to a single 64 bit write?

Initially I sent the patches with writeq() ,lo_hi_writeq()  later we decided to 
replace with write_fun().
The reason for this is lo_hi_writeq() always assumes a little-endian register, 
so it's broken if anyone builds this device with big-endian registers.
So replaced the 64bit calls with write_fun() as suggested by Arnd Bergmann. 
Hope it clears your query.
Please refer to the below thread

http://lkml.iu.edu/hypermail/linux/kernel/1604.2/02046.html 


Regards,
Navakishore.

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Shubhrajyoti Datta]

On Mon, May 30, 2016 at 10:16 PM, Nava kishore Manne
 wrote:
> This patch updates the driver to support 64-bit DMA addressing.
>
> Signed-off-by: Nava kishore Manne 
> ---
> Changes for v4:
> -Used boolen property insted of addrwith property in the DT
>  as suggested by Arnd Bergmann.
> -Adopt the DT relevant changes into the driver.
>
> Changes for v3:
> -Added new compatable string for 5.00 IP version as suggested 
> by
>  Arnd Bergmann.
> -Used write_fn() insted of lo_hi_writeq() as suggested by
>  Arnd Bergmann.
>
> Changes for v2:
> -Added dma-ranges property in device tree as suggested by 
> Arnd Bergmann.
> -Modified the driver code based on the xlnx,addrwidth.
>
>  .../devicetree/bindings/usb/udc-xilinx.txt |  5 ++-
>  drivers/usb/gadget/udc/udc-xilinx.c| 52 
> +-
>  2 files changed, 54 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt 
> b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> index 47b4e39..d08d972 100644
> --- a/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> @@ -1,12 +1,14 @@
>  Xilinx USB2 device controller
>
>  Required properties:
> -- compatible   : Should be "xlnx,usb2-device-4.00.a"
> +- compatible   : Should be "xlnx,usb2-device-4.00.a" or
> + "xlnx,usb2-device-5.00"
>  - reg  : Physical base address and size of the USB2
>   device registers map.
>  - interrupts   : Should contain single irq line of USB2 device
>   controller
>  - xlnx,has-builtin-dma : if DMA is included
> +- xlnx,has-64bit-dma   : if DMA is included 64-bit addressing support.
>
>  Example:
> axi-usb2-device@42e0 {
> @@ -14,5 +16,6 @@ Example:
>  interrupts = <0x0 0x39 0x1>;
>  reg = <0x42e0 0x1>;
>  xlnx,has-builtin-dma;
> +   xlnx,has-64bit-dma;
>  };
>
> diff --git a/drivers/usb/gadget/udc/udc-xilinx.c 
> b/drivers/usb/gadget/udc/udc-xilinx.c
> index 1cbb0ac..6fb80c6 100644
> --- a/drivers/usb/gadget/udc/udc-xilinx.c
> +++ b/drivers/usb/gadget/udc/udc-xilinx.c
> @@ -47,6 +47,15 @@
>  #define XUSB_DMA_LENGTH_OFFSET 0x0210  /* DMA Length Register */
>  #define XUSB_DMA_STATUS_OFFSET 0x0214  /* DMA Status Register */
>
> +/* DMA source Address Reg for LSB */
> +#define XUSB_DMA_DSAR_ADDR_OFFSET_LSB   0x0308
> +/* DMA source Address Reg for MSB */
> +#define XUSB_DMA_DSAR_ADDR_OFFSET_MSB   0x030C
> +/* DMA destination Addr Reg LSB */
> +#define XUSB_DMA_DDAR_ADDR_OFFSET_LSB   0x0310
> +/* DMA destination Addr Reg MSB */
> +#define XUSB_DMA_DDAR_ADDR_OFFSET_MSB   0x0314
> +
>  /* Endpoint Configuration Space offsets */
>  #define XUSB_EP_CFGSTATUS_OFFSET   0x00/* Endpoint Config Status  */
>  #define XUSB_EP_BUF0COUNT_OFFSET   0x08/* Buffer 0 Count */
> @@ -169,6 +178,7 @@ struct xusb_ep {
>   * @setup: usb_ctrlrequest structure for control requests
>   * @req: pointer to dummy request for get status command
>   * @dev: pointer to device structure in gadget
> + * @is_extend_dma: flag indiacting whether the dma is 64-bit support or not.
>   * @usb_state: device in suspended state or not
>   * @remote_wkp: remote wakeup enabled by host
>   * @setupseqtx: tx status
> @@ -186,6 +196,7 @@ struct xusb_udc {
> struct usb_ctrlrequest setup;
> struct xusb_req *req;
> struct device *dev;
> +   bool is_extend_dma;
> u32 usb_state;
> u32 remote_wkp;
> u32 setupseqtx;
> @@ -215,6 +226,20 @@ static const struct usb_endpoint_descriptor 
> config_bulk_out_desc = {
>  };
>
>  /**
> + * xudc_write64 - write 64bit value to device registers
> + * @ep: pointer to the usb device endpoint structure.
> + * @offset: register offset
> + * @val: data to be written
> + **/
> +static void xudc_write64(struct xusb_ep *ep, u32 offset, u64 val)
> +{
> +   struct xusb_udc *udc = ep->udc;
> +
> +   udc->write_fn(udc->addr, offset, lower_32_bits(val));
> +   udc->write_fn(udc->addr, offset+0x04, upper_32_bits(val));

can we move this to a single 64 bit write?
> +}
> +
> +/**

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

[Shubhrajyoti Datta]

On Mon, May 30, 2016 at 10:16 PM, Nava kishore Manne
 wrote:
> This patch updates the driver to support 64-bit DMA addressing.
>
> Signed-off-by: Nava kishore Manne 
> ---
> Changes for v4:
> -Used boolen property insted of addrwith property in the DT
>  as suggested by Arnd Bergmann.
> -Adopt the DT relevant changes into the driver.
>
> Changes for v3:
> -Added new compatable string for 5.00 IP version as suggested 
> by
>  Arnd Bergmann.
> -Used write_fn() insted of lo_hi_writeq() as suggested by
>  Arnd Bergmann.
>
> Changes for v2:
> -Added dma-ranges property in device tree as suggested by 
> Arnd Bergmann.
> -Modified the driver code based on the xlnx,addrwidth.
>
>  .../devicetree/bindings/usb/udc-xilinx.txt |  5 ++-
>  drivers/usb/gadget/udc/udc-xilinx.c| 52 
> +-
>  2 files changed, 54 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt 
> b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> index 47b4e39..d08d972 100644
> --- a/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> @@ -1,12 +1,14 @@
>  Xilinx USB2 device controller
>
>  Required properties:
> -- compatible   : Should be "xlnx,usb2-device-4.00.a"
> +- compatible   : Should be "xlnx,usb2-device-4.00.a" or
> + "xlnx,usb2-device-5.00"
>  - reg  : Physical base address and size of the USB2
>   device registers map.
>  - interrupts   : Should contain single irq line of USB2 device
>   controller
>  - xlnx,has-builtin-dma : if DMA is included
> +- xlnx,has-64bit-dma   : if DMA is included 64-bit addressing support.
>
>  Example:
> axi-usb2-device@42e0 {
> @@ -14,5 +16,6 @@ Example:
>  interrupts = <0x0 0x39 0x1>;
>  reg = <0x42e0 0x1>;
>  xlnx,has-builtin-dma;
> +   xlnx,has-64bit-dma;
>  };
>
> diff --git a/drivers/usb/gadget/udc/udc-xilinx.c 
> b/drivers/usb/gadget/udc/udc-xilinx.c
> index 1cbb0ac..6fb80c6 100644
> --- a/drivers/usb/gadget/udc/udc-xilinx.c
> +++ b/drivers/usb/gadget/udc/udc-xilinx.c
> @@ -47,6 +47,15 @@
>  #define XUSB_DMA_LENGTH_OFFSET 0x0210  /* DMA Length Register */
>  #define XUSB_DMA_STATUS_OFFSET 0x0214  /* DMA Status Register */
>
> +/* DMA source Address Reg for LSB */
> +#define XUSB_DMA_DSAR_ADDR_OFFSET_LSB   0x0308
> +/* DMA source Address Reg for MSB */
> +#define XUSB_DMA_DSAR_ADDR_OFFSET_MSB   0x030C
> +/* DMA destination Addr Reg LSB */
> +#define XUSB_DMA_DDAR_ADDR_OFFSET_LSB   0x0310
> +/* DMA destination Addr Reg MSB */
> +#define XUSB_DMA_DDAR_ADDR_OFFSET_MSB   0x0314
> +
>  /* Endpoint Configuration Space offsets */
>  #define XUSB_EP_CFGSTATUS_OFFSET   0x00/* Endpoint Config Status  */
>  #define XUSB_EP_BUF0COUNT_OFFSET   0x08/* Buffer 0 Count */
> @@ -169,6 +178,7 @@ struct xusb_ep {
>   * @setup: usb_ctrlrequest structure for control requests
>   * @req: pointer to dummy request for get status command
>   * @dev: pointer to device structure in gadget
> + * @is_extend_dma: flag indiacting whether the dma is 64-bit support or not.
>   * @usb_state: device in suspended state or not
>   * @remote_wkp: remote wakeup enabled by host
>   * @setupseqtx: tx status
> @@ -186,6 +196,7 @@ struct xusb_udc {
> struct usb_ctrlrequest setup;
> struct xusb_req *req;
> struct device *dev;
> +   bool is_extend_dma;
> u32 usb_state;
> u32 remote_wkp;
> u32 setupseqtx;
> @@ -215,6 +226,20 @@ static const struct usb_endpoint_descriptor 
> config_bulk_out_desc = {
>  };
>
>  /**
> + * xudc_write64 - write 64bit value to device registers
> + * @ep: pointer to the usb device endpoint structure.
> + * @offset: register offset
> + * @val: data to be written
> + **/
> +static void xudc_write64(struct xusb_ep *ep, u32 offset, u64 val)
> +{
> +   struct xusb_udc *udc = ep->udc;
> +
> +   udc->write_fn(udc->addr, offset, lower_32_bits(val));
> +   udc->write_fn(udc->addr, offset+0x04, upper_32_bits(val));

can we move this to a single 64 bit write?
> +}
> +
> +/**