RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

2016-09-24 Thread Winkler, Tomas 
> 
> 
> >
> > Signed-off-by: Tomas Winkler 
> > Signed-off-by: Alexander Usyskin 
> Tested-by: Avri Altman 
> 
> - mmc -  full functionality. One issue found that was fixed on V6: patch V6 
> 2/9.
> - ufs - read & read counter only.  Testing is still wip.
> 
> 
> > +static int rpmb_request_verify(struct rpmb_dev *rdev, struct rpmb_data
> > +*rpmbd) {
> 
> Seems excessive - Isn't the standard should be enforced by the device?

Yes the device is responsible to detect the issues in the protocol. The 
rpmb_request_verify is called only for the managed interface (rpmb_cmd_req) the 
raw interface (rpm_cmd_seq) is going through.  Second,  we only check more or 
less if we can accommodate the request/response into the arguments.  If there 
is a specific issue  you see in this check, please let me know.

Thanks
Tomas

RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

2016-09-24 Thread Winkler, Tomas 
> 
> 
> >
> > Signed-off-by: Tomas Winkler 
> > Signed-off-by: Alexander Usyskin 
> Tested-by: Avri Altman 
> 
> - mmc -  full functionality. One issue found that was fixed on V6: patch V6 
> 2/9.
> - ufs - read & read counter only.  Testing is still wip.
> 
> 
> > +static int rpmb_request_verify(struct rpmb_dev *rdev, struct rpmb_data
> > +*rpmbd) {
> 
> Seems excessive - Isn't the standard should be enforced by the device?

Yes the device is responsible to detect the issues in the protocol. The 
rpmb_request_verify is called only for the managed interface (rpmb_cmd_req) the 
raw interface (rpm_cmd_seq) is going through.  Second,  we only check more or 
less if we can accommodate the request/response into the arguments.  If there 
is a specific issue  you see in this check, please let me know.

Thanks
Tomas

RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

2016-09-23 Thread Avri Altman 

> 
> Signed-off-by: Tomas Winkler 
> Signed-off-by: Alexander Usyskin 
Tested-by: Avri Altman 

- mmc -  full functionality. One issue found that was fixed on V6: patch V6 2/9.
- ufs - read & read counter only.  Testing is still wip.


> +static int rpmb_request_verify(struct rpmb_dev *rdev, struct rpmb_data
> +*rpmbd) {

Seems excessive - Isn't the standard should be enforced by the device?

Cheers,
Avri

RE: [PATCH v6 1/9] rpmb: add Replay Protected Memory Block (RPMB) subsystem

2016-09-23 Thread Avri Altman 

> 
> Signed-off-by: Tomas Winkler 
> Signed-off-by: Alexander Usyskin 
Tested-by: Avri Altman 

- mmc -  full functionality. One issue found that was fixed on V6: patch V6 2/9.
- ufs - read & read counter only.  Testing is still wip.


> +static int rpmb_request_verify(struct rpmb_dev *rdev, struct rpmb_data
> +*rpmbd) {

Seems excessive - Isn't the standard should be enforced by the device?

Cheers,
Avri