RE: [RFC PATCH 1/1] mwifiex: Remove stop_net_dev_queue operation when uap handling packets forwarding.

2013-06-03 Thread Bing Zhao 
Hi Huawei,

Thanks for the patch.

> Under uap mode mwifiex may stop all net tx queues on forwarding packets. This 
> may stop some tx queues
> and they never have chance to be waked up... There is also no need to check 
> tx_pending and stop
> queues here. Because local host has such kind of check when transmitting 
> packets and it's not proper
> to have forwarding affect local transmitting.
> 
> Signed-off-by: Huawei Yang 

Reviewed-by: Avinash Patil 
Acked-by: Bing Zhao 

Thanks,
Bing

> ---
>  drivers/net/wireless/mwifiex/uap_txrx.c |4 
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/mwifiex/uap_txrx.c 
> b/drivers/net/wireless/mwifiex/uap_txrx.c
> index a018e42..11df2b2 100644
> --- a/drivers/net/wireless/mwifiex/uap_txrx.c
> +++ b/drivers/net/wireless/mwifiex/uap_txrx.c
> @@ -95,10 +95,6 @@ static void mwifiex_uap_queue_bridged_pkt(struct 
> mwifiex_private *priv,
>   atomic_inc(>tx_pending);
>   atomic_inc(>pending_bridged_pkts);
> 
> - if ((atomic_read(>tx_pending) >= MAX_TX_PENDING)) {
> - mwifiex_set_trans_start(priv->netdev);
> - mwifiex_stop_net_dev_queue(priv->netdev, priv->adapter);
> - }
>   return;
>  }
> 
> --
> 1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [RFC PATCH 1/1] mwifiex: Remove stop_net_dev_queue operation when uap handling packets forwarding.

2013-06-03 Thread Bing Zhao 
Hi Huawei,

Thanks for the patch.

 Under uap mode mwifiex may stop all net tx queues on forwarding packets. This 
 may stop some tx queues
 and they never have chance to be waked up... There is also no need to check 
 tx_pending and stop
 queues here. Because local host has such kind of check when transmitting 
 packets and it's not proper
 to have forwarding affect local transmitting.
 
 Signed-off-by: Huawei Yang harvey.huawei.y...@gmail.com

Reviewed-by: Avinash Patil pat...@marvell.com
Acked-by: Bing Zhao bz...@marvell.com

Thanks,
Bing

 ---
  drivers/net/wireless/mwifiex/uap_txrx.c |4 
  1 file changed, 4 deletions(-)
 
 diff --git a/drivers/net/wireless/mwifiex/uap_txrx.c 
 b/drivers/net/wireless/mwifiex/uap_txrx.c
 index a018e42..11df2b2 100644
 --- a/drivers/net/wireless/mwifiex/uap_txrx.c
 +++ b/drivers/net/wireless/mwifiex/uap_txrx.c
 @@ -95,10 +95,6 @@ static void mwifiex_uap_queue_bridged_pkt(struct 
 mwifiex_private *priv,
   atomic_inc(adapter-tx_pending);
   atomic_inc(adapter-pending_bridged_pkts);
 
 - if ((atomic_read(adapter-tx_pending) = MAX_TX_PENDING)) {
 - mwifiex_set_trans_start(priv-netdev);
 - mwifiex_stop_net_dev_queue(priv-netdev, priv-adapter);
 - }
   return;
  }
 
 --
 1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/