RE: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.
> Subject: Re: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments > of simple card. > > > Hi Xiubo > > > > > /* > > > > -* soc_bind_dai_link() will check cpu name > > > > -* after of_node matching if dai_link has cpu_dai_name. > > > > -* but, it will never match if name was created by > fmt_single_name() > > > > -* remove cpu_dai_name to escape name matching. > > > > -* see > > > > +* In soc_bind_dai_link() will check cpu name after > > > > +* of_node matching if dai_link has cpu_dai_name. > > > > +* but, it will never match if name was created by > > > > +* fmt_single_name() remove cpu_dai_name to escape > > > > +* name matching. Please see: > > > > * fmt_single_name() > > > > * fmt_multiple_name() > > > > */ > > > > > > The patch done by Kuninori, setting the cpu_dai_name to NULL in all > > > cases, does not work. This sequence should be replaced where is was > > > previously. > > > > > > > If so, it should be another issue here, should we send another patch for > > It ? > > I posted patch yesterday, and Jean tested it > > Subject: [PATCH][RFC] ASoC: simple-card: fixup cpu_dai_name clear case > Date: Tue, 02 Sep 2014 20:05:32 +0900 > Nice. I think I just missed it. Thanks, BRs Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.
Hi Xiubo > > > /* > > > - * soc_bind_dai_link() will check cpu name > > > - * after of_node matching if dai_link has cpu_dai_name. > > > - * but, it will never match if name was created by fmt_single_name() > > > - * remove cpu_dai_name to escape name matching. > > > - * see > > > + * In soc_bind_dai_link() will check cpu name after > > > + * of_node matching if dai_link has cpu_dai_name. > > > + * but, it will never match if name was created by > > > + * fmt_single_name() remove cpu_dai_name to escape > > > + * name matching. Please see: > > >* fmt_single_name() > > >* fmt_multiple_name() > > >*/ > > > > The patch done by Kuninori, setting the cpu_dai_name to NULL in all > > cases, does not work. This sequence should be replaced where is was > > previously. > > > > If so, it should be another issue here, should we send another patch for > It ? I posted patch yesterday, and Jean tested it Subject: [PATCH][RFC] ASoC: simple-card: fixup cpu_dai_name clear case Date: Tue, 02 Sep 2014 20:05:32 +0900 Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.
Hi Xiubo /* - * soc_bind_dai_link() will check cpu name - * after of_node matching if dai_link has cpu_dai_name. - * but, it will never match if name was created by fmt_single_name() - * remove cpu_dai_name to escape name matching. - * see + * In soc_bind_dai_link() will check cpu name after + * of_node matching if dai_link has cpu_dai_name. + * but, it will never match if name was created by + * fmt_single_name() remove cpu_dai_name to escape + * name matching. Please see: * fmt_single_name() * fmt_multiple_name() */ The patch done by Kuninori, setting the cpu_dai_name to NULL in all cases, does not work. This sequence should be replaced where is was previously. If so, it should be another issue here, should we send another patch for It ? I posted patch yesterday, and Jean tested it Subject: [PATCH][RFC] ASoC: simple-card: fixup cpu_dai_name clear case Date: Tue, 02 Sep 2014 20:05:32 +0900 Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.
Subject: Re: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card. Hi Xiubo /* -* soc_bind_dai_link() will check cpu name -* after of_node matching if dai_link has cpu_dai_name. -* but, it will never match if name was created by fmt_single_name() -* remove cpu_dai_name to escape name matching. -* see +* In soc_bind_dai_link() will check cpu name after +* of_node matching if dai_link has cpu_dai_name. +* but, it will never match if name was created by +* fmt_single_name() remove cpu_dai_name to escape +* name matching. Please see: * fmt_single_name() * fmt_multiple_name() */ The patch done by Kuninori, setting the cpu_dai_name to NULL in all cases, does not work. This sequence should be replaced where is was previously. If so, it should be another issue here, should we send another patch for It ? I posted patch yesterday, and Jean tested it Subject: [PATCH][RFC] ASoC: simple-card: fixup cpu_dai_name clear case Date: Tue, 02 Sep 2014 20:05:32 +0900 Nice. I think I just missed it. Thanks, BRs Xiubo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
