Re: [patch] bfa: use strncpy() instead of memcpy()

[Martin K. Petersen]

> "Dan" == Dan Carpenter  writes:

Dan> BFA_MFG_NAME is "QLogic" which is only 7 bytes, but we are copying
Dan> 8 bytes.  It's harmless because the badding byte is likely zero but
Dan> it makes static checkers complain.

Applied to 4.6/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [patch] bfa: use strncpy() instead of memcpy()

[Martin K. Petersen]

> "Dan" == Dan Carpenter  writes:

Dan> BFA_MFG_NAME is "QLogic" which is only 7 bytes, but we are copying
Dan> 8 bytes.  It's harmless because the badding byte is likely zero but
Dan> it makes static checkers complain.

Applied to 4.6/scsi-queue.

-- 
Martin K. Petersen  Oracle Linux Engineering

RE: [patch] bfa: use strncpy() instead of memcpy()

[Anil Gurumurthy]

Acked-by: Anil Gurumurthy 

-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com] 
Sent: 30 January 2016 20:06
To: Anil Gurumurthy 
Cc: Sudarsana Kalluru ; James E.J. Bottomley 
; Martin K. Petersen ; 
linux-scsi ; linux-kernel 
; kernel-janit...@vger.kernel.org
Subject: [patch] bfa: use strncpy() instead of memcpy()

BFA_MFG_NAME is "QLogic" which is only 7 bytes, but we are copying 8 bytes.  
It's harmless because the badding byte is likely zero but it makes static 
checkers complain.

Signed-off-by: Dan Carpenter 
---
Technically the memset() is not needed because strncpy() will pad the rest of 
the buffer with zeros but I was worried that people would be paranoid.

diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index 
251e2ff..a1ada4a 100644
--- a/drivers/scsi/bfa/bfa_ioc.c
+++ b/drivers/scsi/bfa/bfa_ioc.c
@@ -2803,7 +2803,7 @@ void
 bfa_ioc_get_adapter_manufacturer(struct bfa_ioc_s *ioc, char *manufacturer)  {
memset((void *)manufacturer, 0, BFA_ADAPTER_MFG_NAME_LEN);
-   memcpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN);
+   strncpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN);
 }
 
 void

RE: [patch] bfa: use strncpy() instead of memcpy()

[Anil Gurumurthy]

Acked-by: Anil Gurumurthy 

-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com] 
Sent: 30 January 2016 20:06
To: Anil Gurumurthy 
Cc: Sudarsana Kalluru ; James E.J. Bottomley 
; Martin K. Petersen ; 
linux-scsi ; linux-kernel 
; kernel-janit...@vger.kernel.org
Subject: [patch] bfa: use strncpy() instead of memcpy()

BFA_MFG_NAME is "QLogic" which is only 7 bytes, but we are copying 8 bytes.  
It's harmless because the badding byte is likely zero but it makes static 
checkers complain.

Signed-off-by: Dan Carpenter 
---
Technically the memset() is not needed because strncpy() will pad the rest of 
the buffer with zeros but I was worried that people would be paranoid.

diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index 
251e2ff..a1ada4a 100644
--- a/drivers/scsi/bfa/bfa_ioc.c
+++ b/drivers/scsi/bfa/bfa_ioc.c
@@ -2803,7 +2803,7 @@ void
 bfa_ioc_get_adapter_manufacturer(struct bfa_ioc_s *ioc, char *manufacturer)  {
memset((void *)manufacturer, 0, BFA_ADAPTER_MFG_NAME_LEN);
-   memcpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN);
+   strncpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN);
 }
 
 void